[PATCH] virStorageBackendLogicalCheckPool: Properly mark empty logical pools as active

2023-08-08 Thread Peter Krempa
The '/dev' filesystem convenience directory for a LVM volume group is not created when the volume group is empty. The logic in 'virStorageBackendLogicalCheckPool' which is used to see whether a pool is active was first checking presence of the directory, which failed for an empty VG. Since the se

Re: [libvirt PATCH v2 24/24] qemu_snapshot: allow snapshot revert for external snapshots

2023-08-08 Thread Peter Krempa
On Tue, Jun 27, 2023 at 17:07:27 +0200, Pavel Hrdina wrote: > Now that the support to revert external snapshots is implemented we can > drop this check. > > Signed-off-by: Pavel Hrdina > --- > src/qemu/qemu_snapshot.c | 6 -- > 1 file changed, 6 deletions(-) Reviewed-by: Peter Krempa

Re: [libvirt PATCH v2 23/24] qemu_snapshot: add checks for external snapshot deletion

2023-08-08 Thread Peter Krempa
On Tue, Jun 27, 2023 at 17:07:26 +0200, Pavel Hrdina wrote: > With the introduction of external snapshot revert support we need to > error out in some cases when trying to delete some snapshots. > > If users reverts to non-leaf snapshots and would try to delete it after > the revert is done it wou

Re: [libvirt PATCH v2 21/24] qemu_snapshot: update backing store after deleting external snapshot

2023-08-08 Thread Peter Krempa
On Tue, Jun 27, 2023 at 17:07:24 +0200, Pavel Hrdina wrote: > With introduction of external snapshot revert we will have to update > backing store of qcow images not actively used be QEMU manually. > The need for this patch comes from the fact that we stop and start QEMU > process therefore after r

Re: [libvirt PATCH 5/5] qemu: Implement support for vDPA block devices

2023-08-08 Thread Stefano Garzarella
On Mon, Aug 07, 2023 at 03:41:21PM +0200, Peter Krempa wrote: On Thu, Aug 03, 2023 at 09:48:01 +0200, Stefano Garzarella wrote: On Wed, Aug 2, 2023 at 10:33 PM Jonathon Jongsma wrote: > On 7/24/23 8:05 AM, Peter Krempa wrote: [...] > > > > I've also noticed that using 'qcow2' format for the d

Re: [PATCH] conf: fix error message

2023-08-08 Thread Martin Kletzander
On Mon, Aug 07, 2023 at 04:37:34PM +0300, Anastasia Belova wrote: From: Анастасия Белова In case of invalid placement its value should be passed as a parameter of virReportError instead of mode. Fixes: 93e82727ec ("numatune: Encapsulate numatune configuration in order to unify results") Signe