On Thu, Sep 28, 2023 at 03:32:15PM +0200, Andrea Bolognani wrote:
> Commit 56edf2fefe30 removed the last use.
>
> Signed-off-by: Andrea Bolognani
> ---
> libvirt.spec.in | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com
When starting a guest via libvirt (`virsh create --console`), early
console output was missed because the guest was started first and then
the console was attached. This patch changes this to the following
sequence:
1. create a paused transient guest
2. attach the console
3. resume the guest
Revi
When starting a guest via libvirt (`virsh start --console`), early
console output was missed because the guest was started first and then
the console was attached. This patch changes this to the following
sequence:
1. create a paused guest
2. attach the console
3. resume the guest
Reviewed-by: Bo
Currently, early console output may be lost, e.g. if starting a guest with
`virsh start --console` guest, which can make debugging of early failures very
difficult
(like zipl messages or disabled wait conditions happening early). This is
because QEMU may emit serial console output before the libvir
This patch adds the command line flag `--resume` to the `virsh console`
command. This resumes a paused guest after connecting to the console.
This might be handy since it's a "common" pattern to start a guest
paused, connect to the console, and then resume it so as not to miss any
console messages.
Commit 56edf2fefe30 removed the last use.
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 1 -
1 file changed, 1 deletion(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 57cf46a16d..f3d21ccc8f 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -128,7 +128,6 @@
%define with
On Wed, Sep 27, 2023 at 06:19:32PM +0200, Andrea Bolognani wrote:
> Currently we only set this for the main sockets, which means
> that
>
> $ systemctl stop virtqemud.socket
>
> will make the socket disappear from the filesystem while
>
> $ systemctl stop virtqemud-ro.socket
>
> won't. Get
On Thu, Sep 28, 2023 at 06:52:35AM -0500, Andrea Bolognani wrote:
> On Thu, Sep 28, 2023 at 04:30:03AM -0500, Andrea Bolognani wrote:
> > On Thu, Sep 28, 2023 at 09:24:11AM +0100, Daniel P. Berrangé wrote:
> > > On Wed, Sep 27, 2023 at 06:19:07PM +0200, Andrea Bolognani wrote:
> > > > +++ b/scripts
virBitmapFormat returns the string that should be freed.
All strings in three ADD_BITMAP calls in qemuDomainGetGuestVcpusParams
are contained in tmp. So memory leak is possible here without VIR_FREE.
Fixes: 3e7db8d3e8 ("Remove backslash alignment attempts")
Signed-off-by: Anastasia Belova
---
s
On Thu, Sep 28, 2023 at 04:30:03AM -0500, Andrea Bolognani wrote:
> On Thu, Sep 28, 2023 at 09:24:11AM +0100, Daniel P. Berrangé wrote:
> > On Wed, Sep 27, 2023 at 06:19:07PM +0200, Andrea Bolognani wrote:
> > > +++ b/scripts/merge-systemd-units.py
> > > @@ -0,0 +1,91 @@
> > > +#!/usr/bin/env pytho
On Wed, Sep 27, 2023 at 06:19:11PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> src/nwfilter/meson.build | 4
> src/nwfilter/virtnwfilterd.service.in | 25 -
> 2 files changed, 29 deletions(-)
> delete mode 100644 src/nwfilte
On Wed, Sep 27, 2023 at 06:19:08PM +0200, Andrea Bolognani wrote:
> All services are still listing their input files explicitly, so
> no changes to the output files will occur yet.
>
> Signed-off-by: Andrea Bolognani
> ---
> src/meson.build | 10 +-
> 1 file changed, 5 insertions(+), 5 d
On Wed, Sep 27, 2023 at 06:19:27PM +0200, Andrea Bolognani wrote:
> Only the main socket is actually necessary for the service to be
> usable.
>
> In the past, we've had security issues that could be exploited via
> access to the read-only socket, so a security-minded administrator
> might conside
On Wed, Sep 27, 2023 at 06:19:31PM +0200, Andrea Bolognani wrote:
> This results in all sockets for a service being enabled when a
> single one of them is.
>
> The -tcp and -tls sockets are intentionally excluded, because
> enabling them should require explicit action on the
> administrator's part
On Wed, Sep 27, 2023 at 06:19:33PM +0200, Andrea Bolognani wrote:
> Hypervisors are referred to by their user-facing name rather
> than the name of their libvirt driver, the monolithic daemon is
> explicitly referred to as legacy, and a consistent format is
> used throughout.
>
> Signed-off-by: An
On Wed, Sep 27, 2023 at 06:19:15PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> src/vbox/meson.build| 5 +
> src/vbox/virtvboxd.service.extra.in | 2 ++
> src/vbox/virtvboxd.service.in | 26 --
> 3 files changed, 3 in
On Thu, Sep 28, 2023 at 05:38:45AM -0500, Andrea Bolognani wrote:
> On Thu, Sep 28, 2023 at 11:16:53AM +0100, Daniel P. Berrangé wrote:
> > On Wed, Sep 27, 2023 at 06:19:09PM +0200, Andrea Bolognani wrote:
> > > Signed-off-by: Andrea Bolognani
> > > ---
> > > src/node_device/meson.build
On Wed, Sep 27, 2023 at 06:19:17PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> src/ch/meson.build | 5 +---
> src/ch/virtchd.service.extra.in | 22 +
> src/ch/virtchd.service.in | 44 -
> 3 files chan
On Wed, Sep 27, 2023 at 06:19:14PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> src/storage/meson.build | 5 +
> src/storage/virtstoraged.service.extra.in | 3 +++
> src/storage/virtstoraged.service.in | 27 ---
> 3 fil
On Wed, Sep 27, 2023 at 06:19:10PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> src/interface/meson.build | 4
> src/interface/virtinterfaced.service.in | 25 -
> 2 files changed, 29 deletions(-)
> delete mode 100644 src/int
On Wed, Sep 27, 2023 at 06:19:16PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> src/vz/meson.build | 5 +
> src/vz/virtvzd.service.extra.in | 2 ++
> src/vz/virtvzd.service.in | 26 --
> 3 files changed, 3 insertions(+),
On Wed, Sep 27, 2023 at 06:19:20PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> src/qemu/meson.build| 5 +--
> src/qemu/virtqemud.service.extra.in | 28 +
> src/qemu/virtqemud.service.in | 48 -
> 3 fil
On Thu, Sep 28, 2023 at 11:16:53AM +0100, Daniel P. Berrangé wrote:
> On Wed, Sep 27, 2023 at 06:19:09PM +0200, Andrea Bolognani wrote:
> > Signed-off-by: Andrea Bolognani
> > ---
> > src/node_device/meson.build | 4
> > src/node_device/virtnodedevd.service.in | 25 -
On Wed, Sep 27, 2023 at 06:19:22PM +0200, Andrea Bolognani wrote:
> Now that the migration to common templates has been completed,
> we no longer need these.
>
> Signed-off-by: Andrea Bolognani
> ---
> src/meson.build | 4
> 1 file changed, 4 deletions(-)
Reviewed-by: Daniel P. Berrangé
On Wed, Sep 27, 2023 at 06:19:12PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> src/secret/meson.build| 4
> src/secret/virtsecretd.service.in | 25 -
> 2 files changed, 29 deletions(-)
> delete mode 100644 src/secret/virtsecr
On Wed, Sep 27, 2023 at 06:19:09PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> src/node_device/meson.build | 4
> src/node_device/virtnodedevd.service.in | 25 -
> 2 files changed, 29 deletions(-)
> delete mode 100644 src/no
On Wed, Sep 27, 2023 at 06:19:03PM +0200, Andrea Bolognani wrote:
> They're similar to the existing socket_in/socket_out variables
> and will make future changes nicer.
>
> Signed-off-by: Andrea Bolognani
> ---
> src/meson.build | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
Rev
On Wed, Sep 27, 2023 at 06:19:19PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> src/lxc/meson.build | 5 +---
> src/lxc/virtlxcd.service.extra.in | 22
> src/lxc/virtlxcd.service.in | 44 ---
> 3 files c
On Wed, Sep 27, 2023 at 06:19:21PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> src/remote/meson.build | 6 --
> src/remote/virtproxyd.service.in | 25 -
> 2 files changed, 31 deletions(-)
> delete mode 100644 src/remote/virtprox
On Wed, Sep 27, 2023 at 06:19:13PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> src/network/meson.build | 5 +
> src/network/virtnetworkd.service.extra.in | 2 ++
> src/network/virtnetworkd.service.in | 26 ---
> 3 file
On Wed, Sep 27, 2023 at 06:19:18PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> src/libxl/meson.build | 7 ++-
> src/libxl/virtxend.service.extra.in | 12 +++
> src/libxl/virtxend.service.in | 32 -
> src/lib
On Wed, Sep 27, 2023 at 06:19:05PM +0200, Andrea Bolognani wrote:
> These will be useful during the upcoming migration to common
> templates for systemd units and will be dropped as soon as all
> services have been converted.
>
> Signed-off-by: Andrea Bolognani
> ---
> src/meson.build | 4
>
On Wed, Sep 27, 2023 at 06:19:04PM +0200, Andrea Bolognani wrote:
> It is currently considered required, but we're soon going to
> provide a default that will be suitable for most services.
>
> Since all services currently provide a value explicitly, we
> can implement a default without breaking a
On Thu, Sep 28, 2023 at 09:24:11AM +0100, Daniel P. Berrangé wrote:
> On Wed, Sep 27, 2023 at 06:19:07PM +0200, Andrea Bolognani wrote:
> > +++ b/scripts/merge-systemd-units.py
> > @@ -0,0 +1,91 @@
> > +#!/usr/bin/env python3
>
> Stick a license header of SPDX tag on this.
Done (patch below).
> A
On Wed, Sep 27, 2023 at 06:19:06PM +0200, Andrea Bolognani wrote:
> We're about to change the defaults and start migrating to common
> templates: in order to be able to switch units over one at a
> time, make the input files that are currently used explicit
> rather than implicit.
>
> Signed-off-b
On Wed, Sep 27, 2023 at 06:19:07PM +0200, Andrea Bolognani wrote:
> We already use templating to generate sockets, which are all
> based off libvirtd's. Push the idea further, and extend it to
> cover services as well.
>
> This is more challenging, as the various modular daemons each have
> their
On Wed, Sep 27, 2023 at 06:19:23PM +0200, Andrea Bolognani wrote:
> It's no longer used anywhere.
>
> Signed-off-by: Andrea Bolognani
> ---
> src/meson.build | 2 --
> src/remote/libvirtd-admin.socket.in | 1 -
> src/remote/libvirtd-ro.socket.in| 1 -
> src/remote/libvirt
On Wed, Sep 27, 2023 at 06:19:26PM +0200, Andrea Bolognani wrote:
> This is the strongest relationship that can be declared between
> two units, and causes the service to be terminated immediately
> if its main socket disappears. This is the behavior we want.
>
> Note that we don't do the same for
On Wed, Sep 27, 2023 at 06:19:24PM +0200, Andrea Bolognani wrote:
> Up until now the files have been used as template for most
> services, but now that those have been converted to common
> templates we can drop parametrization and make it clear that
> these files are for libvirtd only.
>
> Signed
On Wed, Sep 27, 2023 at 06:19:02PM +0200, Andrea Bolognani wrote:
> The idea behind these is to prevent running both modular daemons
> and monolithic daemon at the same time. We will implement a more
> effective solution for that shortly.
>
> Signed-off-by: Andrea Bolognani
> ---
> src/remote/me
On Wed, Sep 27, 2023 at 07:46:22PM +0200, Andrea Bolognani wrote:
> The actual versioning policy[1] is a bit more nuanced, and in
> particular there are scenarios in which the monthly release
> is intentionally skipped, but overall it's not inaccurate to
> claim that the release cadence of the Go b
41 matches
Mail list logo
