Re: [PATCH v2] Unlock the storage pool objects after looking it up

ping On Fri, May 8, 2020 at 12:23 AM Yi Li wrote: > > Use g_new0 to allocate and remove NULL checks from callers > and the lock will release properly > > Signed-off-by: Yi Li > --- > src/conf/virstorageobj.c | 14 -- > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a

Re: [PATCH] Unlock the storage pool objects after looking it up

On 5/7/20, Peter Krempa wrote: > On Thu, May 07, 2020 at 18:48:55 +0800, Yi Li wrote: >> The lock should be released. >> >> Signed-off-by: Yi Li >> --- >> src/conf/virstorageobj.c | 6 -- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/src/conf/virstorageobj.c b/src/con

Re: [libvirt] [PATCH v3 1/3] Storage: Use rc hold intermediate function return values.

On Tue, Dec 24, 2019 at 3:32 AM Cole Robinson wrote: > > On 12/22/19 8:15 PM, Yi Li wrote: > > most libvirt code uses 'int rc' to hold intermediate > > function return values. consistent with the rest of libvirt. > > > > Signed-off-by: Yi Li > > --- > > src/storage/storage_backend_rbd.c | 202 >

[libvirt] [PATCH] storage: Don't get src in each loop since src is not changed

The src of pool is not changed in each loop, so don't VIR_FREE(src) and get when next iteration. Signed-off-by: Yi Li --- src/storage/storage_backend_fs.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs