On Wed, Sep 24, 2014 at 05:50:50AM -0400, Laine Stump wrote:
> These patches set up an event handler for qemu's NIC_RX_FILTER_CHANGED
> event, which is sent whenever a guest makes a change to a network
> device's unicast/multicast filter, vlan table, or MAC address.
Not 'whenever', if first event
On Wed, Sep 24, 2014 at 05:50:54AM -0400, Laine Stump wrote:
> This function can be called at any time to get the current status of a
> guest's network device rx-filter. In particular it is useful to call
> after libvirt recieves a NIC_RX_FILTER_CHANGED event - this event only
> tells you that some
On Wed, Sep 24, 2014 at 05:50:53AM -0400, Laine Stump wrote:
> This same structure will be used to retrieve RX filter info for
> interfaces on the host via netlink messages, and RX filter info for
> interfaces on the guest via the qemu "query-rx-filter" command.
> ---
> src/libvirt_private.syms |
All the options are defined in qemu-options.hx. If we can't find a
matched option definition by group name of option table, then the
group name doesn't match with defined option name, it's not allowed
from 2.0
Signed-off-by: Amos Kong
---
qemu-options.h | 12
uti
already.
I have updated the release note of 2.0
http://wiki.qemu.org/ChangeLog/2.0#ABI_breaking
Signed-off-by: Amos Kong
Reviewed-by: Eric Blake
---
hw/acpi/core.c| 8
hw/nvram/fw_cfg.c | 4 ++--
include/qemu/option.h | 2 +-
vl.c | 14 +++---
4
Signed-off-by: Amos Kong
---
vl.c | 4
1 file changed, 4 insertions(+)
diff --git a/vl.c b/vl.c
index 2355227..596ecfa 100644
--- a/vl.c
+++ b/vl.c
@@ -449,6 +449,7 @@ static QemuOptsList qemu_object_opts = {
},
};
+#ifdef CONFIG_TPM
static QemuOptsList qemu_tpmdev_opts
This patchset changes group names of option tables to match with option name,
this breakes ABI, release note was updated.
V4: fix tpmdev, add name matching test (markus)
V5: adjust patch order (paolo)
Amos Kong (3):
only add qemu_tpmdev_opts when CONFIG_TPM is defined
update names in option
On Thu, Mar 27, 2014 at 01:28:37PM +0100, Paolo Bonzini wrote:
> Il 27/03/2014 03:38, Amos Kong ha scritto:
> >This patchset changes group names of option tables to match with option name,
> >this breakes ABI, release note was updated.
> >
> >Amos Kong (3):
> >
On Thu, Mar 27, 2014 at 02:57:00PM +0800, Amos Kong wrote:
> This patchset fixed some issues of query-command-line-options:
> * some new options that haven't argument can't be queried. (eg: -enable-fips)
> * some legacy options that have argument can't be queried. (eg:
This patch added a new field to expose implicit parameter name,
we make it optional for compatibility.
Suggested-by: Eric Blake
Signed-off-by: Amos Kong
---
qapi-schema.json | 6 +-
util/qemu-config.c | 24 +++-
2 files changed, 20 insertions(+), 10 deletions
heir actual command-line
spelling rather than an alternate name associated with the
option table in use by the command.
Signed-off-by: Amos Kong
---
qapi-schema.json | 10 --
qemu-options.h | 12
util/qemu-config.c | 30 --
vl.c |
Signed-off-by: Amos Kong
Reviewed-by: Eric Blake
---
util/qemu-config.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/util/qemu-config.c b/util/qemu-config.c
index f610101..508adbc 100644
--- a/util/qemu-config.c
+++ b/util/qemu-config.c
@@ -39,7 +39,7
add implied-name (eric, markus)
Thanks for your review!
Amos Kong (3):
qmp: rename query_option_descs() to get_param_info()
query-command-line-options: expose implicit parameter name
query-command-line-options: query all the options in qemu-options.hx
qapi-schema.json | 16 +
On Thu, Mar 20, 2014 at 10:12:43PM +0800, Amos Kong wrote:
> On Tue, Mar 11, 2014 at 10:04:56AM +0100, Markus Armbruster wrote:
> > Eric Blake writes:
> >
> > > On 03/07/2014 02:54 AM, Markus Armbruster wrote:
> > >> Eric Blake writes:
> > >>
On Wed, Mar 26, 2014 at 02:15:18PM +0100, Markus Armbruster wrote:
> Amos Kong writes:
>
> > On Fri, Mar 07, 2014 at 10:54:09AM +0100, Markus Armbruster wrote:
> >> Eric Blake writes:
> >>
> >> > On 03/05/2014 07:36 PM, Amos Kong wrote:
> >&
On Thu, Mar 27, 2014 at 10:16:44AM +0800, Amos Kong wrote:
> On Wed, Mar 26, 2014 at 05:12:08PM +0100, Markus Armbruster wrote:
> > Eric Blake writes:
...
> > > Reviewed-by: Eric Blake
> >
> > I'm not thrilled about the ABI break, but avoiding it would prob
Signed-off-by: Amos Kong
---
vl.c | 4
1 file changed, 4 insertions(+)
diff --git a/vl.c b/vl.c
index 2355227..596ecfa 100644
--- a/vl.c
+++ b/vl.c
@@ -449,6 +449,7 @@ static QemuOptsList qemu_object_opts = {
},
};
+#ifdef CONFIG_TPM
static QemuOptsList qemu_tpmdev_opts
All the options are defined in qemu-options.hx. If we can't find a
matched option definition by group name of option table, then the
group name doesn't match with defined option name, it's not allowed
from 2.0
Signed-off-by: Amos Kong
---
qemu-options.h | 12
uti
already.
I have updated the release note of 2.0
http://wiki.qemu.org/ChangeLog/2.0#ABI_breaking
Signed-off-by: Amos Kong
Reviewed-by: Eric Blake
---
hw/acpi/core.c| 8
hw/nvram/fw_cfg.c | 4 ++--
include/qemu/option.h | 2 +-
vl.c | 14 +++---
4
This patchset changes group names of option tables to match with option name,
this breakes ABI, release note was updated.
Amos Kong (3):
only add qemu_tpmdev_opts when CONFIG_TPM is defined
abort QEMU if group name in option table doesn't match with defined
option name
update nam
On Wed, Mar 26, 2014 at 05:12:08PM +0100, Markus Armbruster wrote:
> Eric Blake writes:
>
> > On 03/20/2014 07:07 AM, Amos Kong wrote:
> >> We want to establish a mapping between option name and option table,
> >> then we can search related option table by opti
On Tue, Mar 11, 2014 at 06:46:10PM -0600, Eric Blake wrote:
> On 03/06/2014 11:09 PM, Amos Kong wrote:
> > vm_config_groups[] only contains part of the options which have
> > parameters, and all options which have no parameter aren't added
> > to vm_config_groups[].
On Thu, Mar 20, 2014 at 10:03:12PM +0800, Amos Kong wrote:
> On Fri, Mar 07, 2014 at 10:54:09AM +0100, Markus Armbruster wrote:
> > Eric Blake writes:
> >
> > > On 03/05/2014 07:36 PM, Amos Kong wrote:
> > >> vm_config_groups[] only contains part of the opt
On Tue, Mar 11, 2014 at 10:04:56AM +0100, Markus Armbruster wrote:
> Eric Blake writes:
>
> > On 03/07/2014 02:54 AM, Markus Armbruster wrote:
> >> Eric Blake writes:
> >>
> >>> On 03/05/2014 07:36 PM, Amos Kong wrote:
> >>>> vm_con
On Fri, Mar 07, 2014 at 10:54:09AM +0100, Markus Armbruster wrote:
> Eric Blake writes:
>
> > On 03/05/2014 07:36 PM, Amos Kong wrote:
> >> vm_config_groups[] only contains part of the options which have
> >> argument, and all options which have no argument aren&#x
already.
I have updated the release note of 2.0
http://wiki.qemu.org/ChangeLog/2.0#ABI_breaking
Signed-off-by: Amos Kong
---
V2: fix name in acpi option table
V3: mention ABI break in commitlog (Markus)
---
hw/acpi/core.c| 8
hw/nvram/fw_cfg.c | 4 ++--
include/qemu/option.h
Signed-off-by: Amos Kong
Reviewed-by: Eric Blake
---
util/qemu-config.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/util/qemu-config.c b/util/qemu-config.c
index f610101..d2facfd 100644
--- a/util/qemu-config.c
+++ b/util/qemu-config.c
@@ -39,7 +39,7
On Thu, Mar 06, 2014 at 02:23:15PM -0700, Eric Blake wrote:
> On 03/05/2014 07:36 PM, Amos Kong wrote:
> > vm_config_groups[] only contains part of the options which have
> > argument, and all options which have no argument aren't added
> > to vm_config_groups[]. Current
81830416684&w=2
V2: remove duplicate option tables, update schema (eric)
V3: fix typo in commitlog and export qemu_options talbe (eric)
V4: avoid the duplicate static table (eric)
V5: rename new field, other fix (markus)
Thanks for your review!
Amos Kong (2):
qmp: rename query_option_descs(
heir actual command-line
spelling rather than an alternate name associated with the
option table in use by the command.
Signed-off-by: Amos Kong
---
qapi-schema.json | 9 +++--
qemu-options.h | 12
util/qemu-config.c | 43 ---
vl.c
Signed-off-by: Amos Kong
Reviewed-by: Eric Blake
---
util/qemu-config.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/util/qemu-config.c b/util/qemu-config.c
index f610101..d2facfd 100644
--- a/util/qemu-config.c
+++ b/util/qemu-config.c
@@ -39,7 +39,7
e
spelling rather than an alternate name associated with the
option table in use by the command.
Signed-off-by: Amos Kong
---
qapi-schema.json | 8 ++--
qemu-options.h | 10 ++
util/qemu-config.c | 44 ++--
vl.c | 15 ---
81830416684&w=2
V2: remove duplicate option tables, update schema (eric)
V3: fix typo in commitlog and export qemu_options talbe (eric)
V4: avoid the duplicate static table (eric)
Amos Kong (2):
qmp: rename query_option_descs() to get_param_infolist()
query-command-line-options: query
On Wed, Mar 05, 2014 at 11:50:22AM -0700, Eric Blake wrote:
> On 03/05/2014 08:58 AM, Eric Blake wrote:
> > On 03/04/2014 11:40 PM, Amos Kong wrote:
> >
> >>> but the docs imply that I should now see:
> >>>
> >>> {"parameters": [],
On Tue, Mar 04, 2014 at 03:03:08PM -0700, Eric Blake wrote:
Hi Eric,
> On 03/03/2014 10:51 PM, Amos Kong wrote:
> > vm_config_groups[] only contains part of the options which have
> > argument, and all options which have no argument aren't added to
> > vm_config_group
Signed-off-by: Amos Kong
---
util/qemu-config.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/util/qemu-config.c b/util/qemu-config.c
index 9298f55..d624d92 100644
--- a/util/qemu-config.c
+++ b/util/qemu-config.c
@@ -39,7 +39,7 @@ QemuOptsList *qemu_find_opts(const
81830416684&w=2
V2: remove duplicate option tables, update schema
V3: fix typo in commitlog and export qemu_options talbe
Amos Kong (2):
qmp: rename query_option_descs() to get_param_infolist()
query-command-line-options: query all the options in qemu-options.hx
qapi-schema.json | 8 +
me options that have argument have a NULL desc list, some
options don't have argument, and "parameters" is mandatory
in the past. So we add a new field "arguments" to present
if the option takes unspecified arguments.
Signed-off-by: Amos Kong
---
qapi-schema.json
On Mon, Mar 03, 2014 at 05:37:57PM -0700, Eric Blake wrote:
> > ---
> > qapi-schema.json | 8 ++--
> > util/qemu-config.c | 52
> > ++--
> > 2 files changed, 52 insertions(+), 8 deletions(-)
> >
> > diff --git a/qapi-schema.json b/qapi-sche
684&w=2
V2: remove duplicate option tables, update schema
Amos Kong (2):
qmp: rename query_option_descs() to get_param_infolist()
query-command-line-options: query all the options in qemu-options.hx
qapi-schema.json | 8 ++--
Signed-off-by: Amos Kong
---
util/qemu-config.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/util/qemu-config.c b/util/qemu-config.c
index 9298f55..d624d92 100644
--- a/util/qemu-config.c
+++ b/util/qemu-config.c
@@ -39,7 +39,7 @@ QemuOptsList *qemu_find_opts(const
ent have a NULL desc list, some
options don't have argument, and "parameters" is mandatory
in the past. So we add a new field "arguments" to present
if the option takes unspecified arguments.
Signed-off-by: Amos Kong
---
qapi-schema.json
On Wed, Feb 12, 2014 at 02:00:51PM -0700, Eric Blake wrote:
> On 01/27/2014 08:53 PM, Amos Kong wrote:
> > Some legacy options that have arguments weren't added to
> > vm_config_groups[], so query-command-line-options returns a
> > NULL parameters infolist. This patch
On Tue, Feb 11, 2014 at 01:19:16PM +0100, Markus Armbruster wrote:
> [Note cc: Eric]
Hi Markus,
> Amos Kong writes:
>
> > Some legacy options that have arguments weren't added to
> > vm_config_groups[], so query-command-line-options returns a
> > NULL parame
On Tue, Feb 11, 2014 at 01:03:05PM +0100, Markus Armbruster wrote:
> Amos Kong writes:
>
> > vm_config_groups[] contain the options which have parameter, but some
> > legcy options haven't been added to vm_config_groups[].
> >
> > All the options can be found
On Mon, Jan 27, 2014 at 06:46:31PM +0800, Fam Zheng wrote:
> On Mon, 01/27 10:38, Paolo Bonzini wrote:
> > Il 27/01/2014 09:17, Amos Kong ha scritto:
> > >CC Libvirt-list
> > >
> > >Original discussion:
> > > http://marc.info/?l=qemu-devel&m=1390
VNC server on display\\n\"",
"parameters": [
],
"option": "vnc"
},
Signed-off-by: Amos Kong
---
qapi-schema.json | 5 -
util/qemu-config.c | 3 +++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/qapi-schema.json b/qapi
This patch introduced a new maroc, it will be used to dump the help
messages of all the options.
Signed-off-by: Amos Kong
---
qemu-options-wrapper.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/qemu-options-wrapper.h b/qemu-options-wrapper.h
index c36a9ee..bb0ac87 100644
--- a
n has arguments.
This patch also try to visit all the options in option_names[], then
we won't lost the legacy options that weren't added to vm_config_groups[].
The options have no arguments will also be returned (eg: -enable-fips)
Signed-off-by: Amos Kong
---
util/qem
We will use the marocs to generate two tables, which contain
the option name and argument information.
Signed-off-by: Amos Kong
---
qemu-options-wrapper.h | 18 ++
1 file changed, 18 insertions(+)
diff --git a/qemu-options-wrapper.h b/qemu-options-wrapper.h
index 13bfea0
This patchset fixed some issues of query-command-line-options:
* some new options haven't arguments can't be queried. (eg: -enable-fips)
* some legcy options have arguments can't be queried. (eg: -vnc display)
More discussion:
http://marc.info/?l=qemu-devel&m=13908183041
Signed-off-by: Amos Kong
---
util/qemu-config.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/util/qemu-config.c b/util/qemu-config.c
index 9298f55..d624d92 100644
--- a/util/qemu-config.c
+++ b/util/qemu-config.c
@@ -39,7 +39,7 @@ QemuOptsList *qemu_find_opts(const
Hi QEMU/Libvirt list,
When I worked on query-command-line-options, I first used some marcos [1] to
generate two config & option tables. This will cover all the options,
but it returns a string, it's difficult for libvirt to parse and use
it.
| {"execute": "query-config", "arguments" : {"name": "b
On Mon, Jan 27, 2014 at 10:38:24AM +0100, Paolo Bonzini wrote:
> Il 27/01/2014 09:17, Amos Kong ha scritto:
> >CC Libvirt-list
> >
> >Original discussion:
> > http://marc.info/?l=qemu-devel&m=139048842504757&w=2
> > [Qemu-devel] [PATCH v4 0/5] QMP full
On Mon, Jan 27, 2014 at 04:17:56PM +0800, Amos Kong wrote:
> CC Libvirt-list
>
> Original discussion:
> http://marc.info/?l=qemu-devel&m=139048842504757&w=2
> [Qemu-devel] [PATCH v4 0/5] QMP full introspection
>
> On Fri, Jan 24, 2014 at 06:48:31PM +0800, Fam Z
CC Libvirt-list
Original discussion:
http://marc.info/?l=qemu-devel&m=139048842504757&w=2
[Qemu-devel] [PATCH v4 0/5] QMP full introspection
On Fri, Jan 24, 2014 at 06:48:31PM +0800, Fam Zheng wrote:
> On Thu, 01/23 22:46, Amos Kong wrote:
> > This patch introduces a new m
Hi QEMU/Libvirt list,
When I worked on query-command-line-options, I first used some marcos [1] to
generate two config & option tables. This will cover all the options,
but it returns a string, it's difficult for libvirt to parse and use
it.
Finally I got a suggestion to read info from new inter
bootloader that
> merely
> instructs the system to reboot, and placing *that* disk in the boot order just
> after the PXE device), so the BZ was closed as CANTFIX.
We have a reboot-timeout boot parameter to reboot guest if not found
bootable device.
| commit ac05f3492421caeb05809ffa02c6
On Tue, Nov 26, 2013 at 07:32:37AM -0700, Eric Blake wrote:
> [adding libvirt]
>
> On 11/26/2013 06:58 AM, Paolo Bonzini wrote:
> > Il 26/11/2013 14:43, Amos Kong ha scritto:
> >> /* Set a default rate limit of 2^47 bytes per minute or roughly 2TB/s. If
> >> * y
together.
Signed-off-by: Amos Kong
---
V2: access local QemuOptsLists for drive (kevin)
V3: fix indent (fam)
Signed-off-by: Amos Kong
---
blockdev.c | 1 -
include/qemu/config-file.h | 1 +
include/sysemu/sysemu.h| 2 ++
util/qemu-config.c | 77
On Fri, Nov 08, 2013 at 05:18:02PM +0800, Fam Zheng wrote:
> Looks good to me. Two small comments below.
>
> On Wed, 11/06 13:16, Amos Kong wrote:
> > Currently we have three QemuOptsList (qemu_common_drive_opts,
> > qemu_legacy_drive_opts, and qemu_drive_opts), only qemu_dr
together.
Signed-off-by: Amos Kong
---
V2: access local QemuOptsLists for drive (kevin)
---
blockdev.c | 1 -
include/qemu/config-file.h | 1 +
include/sysemu/sysemu.h| 2 ++
util/qemu-config.c | 77 +-
vl.c
Hi Kevin,
On Mon, Nov 04, 2013 at 12:27:10PM +0100, Kevin Wolf wrote:
> Am 04.11.2013 um 08:01 hat Amos Kong geschrieben:
> > Currently we have three QemuOptsList (qemu_common_drive_opts,
> > qemu_legacy_drive_opts, and qemu_drive_opts), only qemu_drive_opts
> > is adde
> Laine Stump wrote:
> On 10/30/2013 07:18 AM, Amos Kong wrote:
> > On Tue, Oct 29, 2013 at 09:50:56AM -0400, Matthew Rosato wrote:
> >> Amos Kong provided QEMU support to facilitate macvtap rx-filter change
> >> notification here:
> >> http://lists.non
copied desc items of qemu_legacy_drive_opts and
qemu_common_drive_opts to qemu_drive_opts.
Signed-off-by: Amos Kong
---
blockdev.c | 168 +++--
1 file changed, 164 insertions(+), 4 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index
CC Kevin, Paolo
On Thu, Oct 31, 2013 at 04:35:43PM +0800, Amos Kong wrote:
> On Thu, Oct 31, 2013 at 04:07:15PM +0800, Osier Yang wrote:
> > CC to Amos.
> >
> > On 30/10/13 16:19, whitearchey wrote:
> > >
> > >In QEMU 1.6 parameters of 'drive&#
On Thu, Oct 31, 2013 at 04:07:15PM +0800, Osier Yang wrote:
> CC to Amos.
>
> On 30/10/13 16:19, whitearchey wrote:
> >
> >In QEMU 1.6 parameters of 'drive' option were removed:
> >
> >QemuOptsList qemu_drive_opts = {
> >.name = "drive",
> >.head = QTAILQ_HEAD_INITIALIZER(qemu_drive_opts.h
On Tue, Oct 29, 2013 at 09:50:56AM -0400, Matthew Rosato wrote:
> Amos Kong provided QEMU support to facilitate macvtap rx-filter change
> notification here:
> http://lists.nongnu.org/archive/html/qemu-devel/2013-07/msg02736.html
>
> Libvirt work was mentioned, but I haven't
CC: qemu-devel, kvm, libvirt-list
On Thu, Apr 11, 2013 at 4:43 AM, Lucas Meneghel Rodrigues
wrote:
> Hi guys,
>
> I'd like to propose yet another hipster-y initiative: A weekly hangout,
> where contributors from all affiliations that work on autotest/virt-tests
> or any project under the autotes
ly effects when boot priority is changed by
bootindex options, the old style(-boot order=..) will still
try to boot from un-selected devices.
v2: add HALT entry in get_boot_devices_list()
v3: rebase to latest qemu upstream
Signed-off-by: Amos Kong
---
As we discussed in the past, we need to i
On Mon, Jan 28, 2013 at 11:19:34AM +0800, Amos Kong wrote:
> On Wed, Jan 23, 2013 at 06:41:44PM +0800, Amos Kong wrote:
> > On Tue, Jan 22, 2013 at 12:26:03PM -0600, Anthony Liguori wrote:
> > > Eric Blake writes:
> > > > On 01/22/2013 08:52 AM, Amos Kong wrote:
>
On Wed, Jan 23, 2013 at 06:41:44PM +0800, Amos Kong wrote:
> On Tue, Jan 22, 2013 at 12:26:03PM -0600, Anthony Liguori wrote:
> > Eric Blake writes:
> > > On 01/22/2013 08:52 AM, Amos Kong wrote:
> > >>>>
> > >>>> Libvirt will
On Tue, Jan 22, 2013 at 12:26:03PM -0600, Anthony Liguori wrote:
> Eric Blake writes:
> > On 01/22/2013 08:52 AM, Amos Kong wrote:
> >>>>
> >>>> Libvirt will need to expose an attribute that lets the user control
> >>>> whether to us
On Tue, Jan 22, 2013 at 10:23:32AM -0500, Amos Kong wrote:
> - Original Message -
> > On 01/09/2013 01:39 AM, Amos Kong wrote:
> > > Current seabios will try to boot from selected devices first,
> > > if they are all failed, seabios will also try to boot fro
- Original Message -
> On 01/09/2013 01:39 AM, Amos Kong wrote:
> > Current seabios will try to boot from selected devices first,
> > if they are all failed, seabios will also try to boot from
> > un-selected devices.
> >
> > We need to make it configu
On Wed, Jan 09, 2013 at 08:14:07AM -0700, Eric Blake wrote:
> On 01/09/2013 01:39 AM, Amos Kong wrote:
> > Current seabios will try to boot from selected devices first,
> > if they are all failed, seabios will also try to boot from
> > un-selected devices.
> >
> >
76 matches
Mail list logo
