Re: [libvirt] RE: Libvirt - Xen Enterprise - Koan

2009-01-09 Thread Ben Guthro
One thing to know about the open source xend XenAPI - it does not come configured by default. you must enable it in the xend_config.sxp file If I recall my brief foray into the open source XenAPI - it uses the same transport mechanisms, but the open source one is not ver heavily tested, and just p

Re: [libvirt] RE: Libvirt - Xen Enterprise - Koan

2009-01-07 Thread Ben Guthro
FYI - The XenAPI has some similarities with XenEnterprise's API - but they forked away from the open source model a while ago. I agree with you that the XenAPI list is mostly dead. I haven't seem anyone contributing to it in a while... Daniel Veillard wrote on 01/07/2009 07:20 AM: > On Wed, Jan

Re: [libvirt] Deploying latest libvirt in rhel / centos 5.2

2008-12-09 Thread Ben Guthro
You shouldn't have any issues. There is a 'make rpm' target at the top level that I use to build updated packages in RHEL. Take a look at the top of the .spec.in file for build dependencies Marco Sinhoreli wrote on 12/09/2008 08:00 AM: > Hello all, > > I'm wanting to know if I will have some diff

Re: [libvirt] F10 rpm problems

2008-12-08 Thread Ben Guthro
cked up by virsh. Daniel P. Berrange wrote on 12/08/2008 08:00 AM: > On Mon, Dec 08, 2008 at 07:53:10AM -0500, Ben Guthro wrote: >> I do have older versions (for chroot purposes) mounted in non-standard >> paths... >> I don't know why it would pick it up in /data: >

RE: [libvirt] F10 rpm problems

2008-12-08 Thread Ben Guthro
iel Veillard [mailto:[EMAIL PROTECTED] Sent: Mon 12/8/2008 5:39 AM To: Ben Guthro Cc: libvir-list Subject: Re: [libvirt] F10 rpm problems On Fri, Dec 05, 2008 at 03:24:31PM -0500, Ben Guthro wrote: > So...I decided to make the leap, and upgraded to F10 (from F9) > > After my upgrade, I

[libvirt] F10 rpm problems

2008-12-05 Thread Ben Guthro
So...I decided to make the leap, and upgraded to F10 (from F9) After my upgrade, I decided to build the libvirt rpm from source, and install it. So far, so good...everything built, and installs nicely. However, when I run virsh, I get the following error: virsh: error while loading shared librar

RE: [libvirt] how to install updated python bindings

2008-12-05 Thread Ben Guthro
Visco - FYI - You should be able to build a custom rpm via 'make rpm' -Original Message- From: [EMAIL PROTECTED] on behalf of visco Sent: Fri 12/5/2008 1:05 AM To: Daniel P. Berrange; [EMAIL PROTECTED] Cc: libvir-list@redhat.com Subject: Re: [libvirt] how to install updated python bin

RE: [libvirt] [PATCH] post-release patch for symbols

2008-12-02 Thread Ben Guthro
If I understood the previous conversation correctly, these thread-safe changes are necessary for the Java bindings DomainEvent code. Do we really want those bindings to fall that far behind? -Original Message- From: [EMAIL PROTECTED] on behalf of Daniel Veillard Sent: Tue 12/2/2008 5:30

Re: [libvirt] PATCH: 0/28: Thread safety for libvirtd daemon and drivers

2008-12-01 Thread Ben Guthro
What git changeset does this queue apply against? I'm having a heck of a time getting it to apply cleanly with git-am. alternately: I know you work on occasion with mercurial. Is this an mq tree somewhere? Daniel P. Berrange wrote on 11/30/2008 06:14 PM: > The following huge series of patches a

Re: [libvirt] PATCH: 25/28: Thread safety for libvirtd event loop

2008-12-01 Thread Ben Guthro
please disregard this email...user error. Ben Guthro wrote on 12/01/2008 10:06 AM: > Is patch 24/25 missing? > > I tried > git branch thread-safe b726fa0fa5a91eee0af2f996c784d13593cd7616 > git checkout thread-safe > git am --interactive /home/bguthro/.thunderbird/tiloddj9.

Re: [libvirt] PATCH: 25/28: Thread safety for libvirtd event loop

2008-12-01 Thread Ben Guthro
Is patch 24/25 missing? I tried git branch thread-safe b726fa0fa5a91eee0af2f996c784d13593cd7616 git checkout thread-safe git am --interactive /home/bguthro/.thunderbird/tiloddj9.default/Mail/Local\ Folders/thread-safe and got through most of these, but it seemed to fail on patch 25: ... Applyin

Re: [libvirt] [PATCH] fix --without-xen build

2008-11-24 Thread Ben Guthro
This fixed it in our environment ACK Daniel P. Berrange wrote on 11/24/2008 10:50 AM: > On Fri, Nov 21, 2008 at 12:46:59PM -0500, David Lively wrote: >> Okay, *this* one seems to be a complete fix. > > Not quite. The ENABLE_XEN_TESTS conditional is only set when not > running on a live Xen kerne

Re: [libvirt] [PATCH] Xen Events Updated

2008-11-21 Thread Ben Guthro
11/21/2008 02:07 PM: > On Fri, Nov 21, 2008 at 01:56:16PM -0500, Ben Guthro wrote: >> I think I found the culprit of this: >> >> Daniel P. Berrange wrote on 11/21/2008 11:13 AM: >>> - Allocate capabilities info before initializing inotify driver >>>becau

Re: [libvirt] [PATCH] Xen Events Updated

2008-11-21 Thread Ben Guthro
I think I found the culprit of this: Daniel P. Berrange wrote on 11/21/2008 11:13 AM: > - Allocate capabilities info before initializing inotify driver >because loading XM config files /etc/xen requires this > ... > -if (!(priv->caps = xenHypervisorMakeCapabilities(conn))) { > -D

Re: [libvirt] [PATCH] Xen Events Updated

2008-11-21 Thread Ben Guthro
) I haven't chased this down fully yet, but something is interfering... Daniel P. Berrange wrote on 11/21/2008 11:13 AM: > On Thu, Nov 20, 2008 at 03:49:07PM -0500, Ben Guthro wrote: >> New xen events patch attached. This removes a couple unnecessary >> changes from my prio

Re: [libvirt] --with-xen=foo

2008-11-21 Thread Ben Guthro
et `../src/libvirt_driver_xen.la', needed by `xml2sexprtest'. Stop. ...it would appear that some dependency is incorrect... Ben Guthro wrote on 11/21/2008 06:52 AM: > > Oh - sorry for not getting back to you about this. > Yes - it does solve it for me. > > +1 > > --

RE: [libvirt] --with-xen=foo

2008-11-21 Thread Ben Guthro
Oh - sorry for not getting back to you about this. Yes - it does solve it for me. +1 -Original Message- From: Daniel P. Berrange [mailto:[EMAIL PROTECTED] Sent: Fri 11/21/2008 5:12 AM To: Ben Guthro Cc: libvir-list Subject: Re: [libvirt] --with-xen=foo On Thu, Nov 20, 2008 at 06:30

[libvirt] [PATCH] Allow rpm to build without uml

2008-11-20 Thread Ben Guthro
Allow to build minimal rpm without uml diff --git a/libvirt.spec.in b/libvirt.spec.in index cfd4a66..91af843 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -10,6 +10,7 @@ %define with_polkit0%{!?_without_polkit:0} %define with_python0%{!?_without_python:1} %define with_libvirtd 0

Re: [libvirt] [PATCH] Xen Events Updated

2008-11-20 Thread Ben Guthro
more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + * + * Author: Ben Guthro + */ +#include +#include

[libvirt] [PATCH] Fix UML syntax

2008-11-20 Thread Ben Guthro
various changes to fix make syntax-check succeed with new UML driver diff --git a/po/POTFILES.in b/po/POTFILES.in index 3f8fdd2..d9f3abe 100644 --- a/po/POTFILES.in +++ b/po/POTFILES.in @@ -28,6 +28,8 @@ src/storage_backend_logical.c src/storage_conf.c src/storage_driver.c src/test.c +src/uml_co

Re: [libvirt] --with-xen=foo

2008-11-20 Thread Ben Guthro
IBADD) $(srcdir)/libvirt_sym.version # Create an automake "convenience library" version of libvirt_la, Daniel P. Berrange wrote on 11/20/2008 10:50 AM: > On Thu, Nov 20, 2008 at 10:46:25AM -0500, Ben Guthro wrote: >> I did a git bisect, and as predicted,

Re: [libvirt] --with-xen=foo

2008-11-20 Thread Ben Guthro
+ Build drivers as libtool convenience libs Once again, I am faced with my ignorance of how automake magic works. It looks to me like XEN_CFLAGS is set properly...but clearly they are not being passed on while compiling stats_linux.c Ben Guthro wrote on 11/20/2008 09:48 AM

[libvirt] --with-xen=foo

2008-11-20 Thread Ben Guthro
So, when I merged my changes up yesterday to some of the developments going on, it would seem that one of the changesets I pulled in had a bit of a reduction in configure flexibility. I'm not yet sure what changeset caused it...but I used to be able to specify an external xen tree with the foll

Re: [libvirt] [PATCH] Xen Events Updated

2008-11-20 Thread Ben Guthro
I see a couple of issues with this patch that I am working out now Apologies for premature submission. (Thats what I get for submitting at the end of the day) New patch to follow shortly Ben Guthro wrote on 11/19/2008 05:47 PM: > I finally was able to get back to this patch. > > Atta

Re: [libvirt] PATCH: Change signature of virEventAddHandle to allow multiple calls per FD

2008-11-17 Thread Ben Guthro
well, that was a lot of fallout. All looks necessary though. +1 from me Daniel P. Berrange wrote on 11/17/2008 11:58 AM: > As discussed previously, this patch changes the semantics of the public > API for dealing with file handle watches. Previously we would track the > watch based on the file

Re: [libvirt] PATCH: Add domain event "detail" information

2008-11-14 Thread Ben Guthro
Looks pretty much exactly how I pictured it +1 Daniel P. Berrange wrote on 11/14/2008 12:44 PM: > As per our earlier discussion today, this patch expands the callback for > domain events so that it also gets a event type specific 'detail' field. > This is also kept as an int, and we define enumer

RE: [libvirt] [RFC] making (newly public) EventImpl interface moreconsistent

2008-11-14 Thread Ben Guthro
e don't have checkin permissions...so we'll go with whatever you guys decide. I'll let Dave follow up with any additional examples of where this would get us in trouble... -Original Message- From: Daniel P. Berrange [mailto:[EMAIL PROTECTED] Sent: Fri 11/14/2008 6:27 AM To:

RE: [libvirt] RFC: Add a 'reason' argument for domain events ?

2008-11-14 Thread Ben Guthro
To revisit the DEFINED, UNDEFINED topic - I have been giving this some thought, and it seems like it is redundant information to me. Doesn't the existence of a config file define the difference between a transient and a persistent domain? Therefore this could be tracked solely with the enum valu

[libvirt] [PATCH] Xen Events Updated

2008-11-11 Thread Ben Guthro
ul, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library

Re: [libvirt] make not invoking rpcgen remote_protocol.x

2008-11-10 Thread Ben Guthro
from the top level, you could do a make -C src remote_protocol.c This should re-generate both .c and .h files from the .x Kenneth Nagin wrote on 11/10/2008 10:52 AM: > I am attempting to add some new libvirt functions that I intend to submit > for your approval. > I have made changes to remote_p

Re: [libvirt] PATCH: Misc fixes to events code

2008-11-07 Thread Ben Guthro
Daniel P. Berrange wrote on 11/04/2008 05:05 PM: > Well lets just start with STARTED/STOPPED from xenstore, and possibly > try ADDED/REMOVED using inotify on /etc/xen or /var/lib/xend/domains. > These are what virt-manager cares about the most. The others are just > a nice-to-have. Perhaps I just

Re: [libvirt] RFC: Domain events add DEFINED and UNDEFINED events

2008-11-07 Thread Ben Guthro
I suppose I could make some sort of configure option to only compile it in optionally... I don't have access to a solaris box though...so don't really know what the appropriate API would be in that situation Daniel Veillard wrote on 11/07/2008 07:39 AM: > On Fri, Nov 07, 2008 at 12:26:23PM +000

RE: [libvirt] RFC: Domain events add DEFINED and UNDEFINED events

2008-11-07 Thread Ben Guthro
I think this sounds reasonable. Let me see if I understand the state machine for a newly created persistent domain: DEFINED->ADDED->STARTED->STOPPED Starting, then stopping a previously defined persistent domain would just emit STARTED->STOPPED and a transient domain would be: ADDED->STARTED->

Re: [libvirt] [PATCH] Xen events

2008-11-06 Thread Ben Guthro
New patch attached with changes recommended in prior email from Daniel V. Ben diff --git a/src/xen_unified.c b/src/xen_unified.c index 1ab204d..c5f84c8 100644 --- a/src/xen_unified.c +++ b/src/xen_unified.c @@ -222,6 +222,7 @@ xenUnifiedOpen (virConnectPtr conn, xmlURIPtr uri, virConnectAuthPtr au

[libvirt] [PATCH] Xen events

2008-11-06 Thread Ben Guthro
The following patch implements a framework for emitting events from the Xen driver, via monitoring xenstore. Currently, this only emits the STARTED, and STOPPED events, as this is all that seems to be available via monitoring xenstore. xen_unified.c | 162 +++ xen_unified

Re: [libvirt] PATCH: Misc fixes to events code

2008-11-04 Thread Ben Guthro
These look good to me +1 Daniel P. Berrange wrote on 11/04/2008 02:56 PM: > I'm trying out the new events code with virt-manager and stumbled on some > minor bugs > > - The python binding forgot to call LIBVIRT_BEGIN_ALLOW_THREADS, >LIBVIRT_END_ALLOW_THREADS, LIBVIRT_ENSURE_THREAD_STATE or >

Re: [libvirt] PATCH: Misc fixes to events code

2008-11-04 Thread Ben Guthro
Daniel P. Berrange wrote on 11/04/2008 04:42 PM: > Then there is XenAPI in Xen >= 3.1.0. We don't currently use XenAPI > at all, and I'm not up2date on its level of functionality, but in > the original scope it was intended to provide full event notification > capabilities for VMs. If the XenAPI

Re: [libvirt] PATCH: Misc fixes to events code

2008-11-04 Thread Ben Guthro
Daniel P. Berrange wrote on 11/04/2008 02:56 PM: > A couple more things I've not fixed but are on the todo list > > - THe QEMU driver doesn't emit the ADDED or REMOVED events for VMs >which virt-manager requires in order to fully avoid polling. Not to derail this topic from your patch...bu

Re: [libvirt] New Libvirt Implementation - OpenNebula

2008-11-04 Thread Ben Guthro
As part of the internal API (and not explicitly exported from src/libvirt_sym.version) The xml parsing would not be available to external apps. Stefan de Konink wrote on 11/04/2008 11:21 AM: > Daniel P. Berrange wrote: >> On Tue, Nov 04, 2008 at 05:04:50PM +0100, Stefan de Konink wrote: >>> Las

Re: [libvirt] [RFC] making (newly public) EventImpl interface more consistent

2008-11-04 Thread Ben Guthro
> I have no strong feeling w.r.t. the reregistration of an fd, I would > rather error and not state it's undefined though. > For the java bindings, yes please :-) that way I would be able to > push a new release too end of next week. I'd like to get the Xen driver domain events in that release

RE: [libvirt] [RFC] making (newly public) EventImpl interface moreconsistent

2008-11-04 Thread Ben Guthro
I'll respond now while I'm looking at this, as Dave may not be able to get to this until later today I was talking with Dave about this yesterday, and if I'm not mistaken, this idea comes from some of the implementations for either DevKit, DBus, or libHAL (I can't remember which one he was look

RE: [libvirt] Domain Events Python Bindings (Round 2)

2008-10-31 Thread Ben Guthro
cleanup coordination with the C code Ben -Original Message- From: Daniel Veillard [mailto:[EMAIL PROTECTED] Sent: Fri 10/31/2008 7:22 AM To: Ben Guthro Cc: libvir-list@redhat.com Subject: Re: [libvirt] Domain Events Python Bindings (Round 2) On Fri, Oct 31, 2008 at 07:04:09AM -0400, Ben

RE: [libvirt] Domain Events Python Bindings (Round 2)

2008-10-31 Thread Ben Guthro
Ben -Original Message- From: Daniel Veillard [mailto:[EMAIL PROTECTED] Sent: Fri 10/31/2008 6:16 AM To: Ben Guthro Cc: libvir-list@redhat.com Subject: Re: [libvirt] Domain Events Python Bindings (Round 2) On Thu, Oct 30, 2008 at 05:03:28PM -0400, Ben Guthro wrote: > Attached are th

[libvirt] Domain Events Python Bindings (Round 2)

2008-10-30 Thread Ben Guthro
Attached are the python bindings for domain events as previously submitted: https://www.redhat.com/archives/libvir-list/2008-October/msg00707.html https://www.redhat.com/archives/libvir-list/2008-October/msg00668.html I have resolved most of the issues Daniel V. commented on I also addressed a num

Re: [libvirt] [PATCH] Domain Events Python Bindings

2008-10-29 Thread Ben Guthro
Daniel Veillard wrote on 10/29/2008 01:09 PM: >> +/* Call the Callback Dispatcher */ >> +pyobj_ret = PyObject_CallMethod(pyobj_conn_inst, >> +(char*)"dispatchDomainEventCallbacks", >> +(char*)"Oi", >> +

Re: [libvirt] [PATCH] Domain Events Python Bindings

2008-10-29 Thread Ben Guthro
Comments inline below Daniel Veillard wrote on 10/29/2008 01:09 PM: ... >> +def myDomainEventCallback1 (conn, dom, event, opaque): >> +print "myDomainEventCallback1 EVENT: Domain %s(%s) %s" % (dom.name(), >> dom.ID(), eventToString(event)) >> + >> +def myDomainEventCallback2 (conn, dom, event

[libvirt] [PATCH] Domain Events Python Bindings

2008-10-29 Thread Ben Guthro
Attached are the python bindings for domain events I have moved much of the complicated code from my prior submission out of C and into python. This required a slight change to the generator. The new convention that we came up with is to append .py to the class as it is being generated, iff tha

Re: [libvirt] PATCH: Move domain event helpers out of internal.h/libvirt.c

2008-10-29 Thread Ben Guthro
he implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the

RE: [libvirt] [RFC] domain-events-python

2008-10-29 Thread Ben Guthro
2:50 AM To: Daniel P. Berrange Cc: Ben Guthro; libvir-list@redhat.com Subject: Re: [libvirt] [RFC] domain-events-python On Tue, Oct 28, 2008 at 06:23:20PM +, Daniel P. Berrange wrote: > On Tue, Oct 28, 2008 at 09:09:53AM -0400, Ben Guthro wrote: > > Attached is a preliminary patch imp

[libvirt] xen driver & events

2008-10-28 Thread Ben Guthro
I'm looking into implementing emitting events from the xen driver, and I've run into a bit of a snag that I would like to discuss I've attached an old version of my patch for reference. However - from past discussions, I know that there was a desire to keep the xen driver stateless. However, gi

[libvirt] [RFC] domain-events-python

2008-10-28 Thread Ben Guthro
Attached is a preliminary patch implementing the python bindings for domain events, and the EventImpl code. This implements a python test app equivalent to the code in the C event-test app. Contrary to what Daniel B originally suggested, I thought that the EventImpl would be useful to expose fo

Re: [libvirt] FYI: fixes to events code for mingw

2008-10-24 Thread Ben Guthro
Daniel Veillard wrote on 10/24/2008 09:26 AM: > since we don't use poll anywhere there i assume it's a leftover from > the early event work. Yes, this was mistakenly left in from prior versions of the patch -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/li

Re: [libvirt] [PATCH 00/12] Domain Events : DONE !

2008-10-23 Thread Ben Guthro
Also - Additional work is needed in the hypervisor drivers other than qemu to properly emit domain events. My initial patch submission included some code designed to add, and monitor xenstore watches. It would be nice to get this integrated, as well. Ben Guthro wrote on 10/23/2008 09:40 AM

Re: [libvirt] [PATCH 00/12] Domain Events : DONE !

2008-10-23 Thread Ben Guthro
> Again congratulations ! I think this also means the next release > will be a 0.5.0 since this is a major API addition. I still looking > at the other pending patches though, it would be better to have them > in the next release ... oh and I want your java bindings and we need > Python too (a

Re: [libvirt] errors building rpm

2008-10-22 Thread Ben Guthro
This looks like it fixed the problem for me, as well Thanks! +1 Cole Robinson wrote on 10/22/2008 09:31 AM: > Daniel P. Berrange wrote: >> On Tue, Oct 21, 2008 at 04:39:36PM -0400, Ben Guthro wrote: >>> I keep getting the following error when trying to build via a >>

Re: [libvirt] Re: [PATCH 01/12] Domain Events - Public API

2008-10-22 Thread Ben Guthro
Daniel Veillard wrote on 10/22/2008 05:14 AM: > thanks for the changes! I think the prototypes are good to go, maybe a couple > tiny changes but I can make them myself based on the 'make rebuild' > output in the doc directory > functions in src/libvirt.c still need arguments checkings however, bu

[libvirt] errors building rpm

2008-10-21 Thread Ben Guthro
that I did not need previously? Ben Guthro -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 00/12] Domain Events - Round 3

2008-10-21 Thread Ben Guthro
Apologies about the duplicate 00, 01, and 02 emails. My email seems to be acting up, and I didn't see those patches come through...so I resent those 3 Then they arrived in pairs. Please ignore the duplicates. Ben Guthro wrote on 10/21/2008 03:10 PM: > The following patch series im

[libvirt] Re: [PATCH 01/12] Domain Events - Public API

2008-10-21 Thread Ben Guthro
[PATCH 01/12] Domain Events - Public API This patch does the following: -implements the Event register/deregister code -Adds some callback lists, and queue functions used by drivers -Move EventImpl definitions into the public diff --git a/include/libvirt/libvirt.h b/include/libvirt/libvir

[libvirt] Re: [PATCH 01/12] Domain Events - Public API

2008-10-21 Thread Ben Guthro
[PATCH 01/12] Domain Events - Public API This patch does the following: -implements the Event register/deregister code -Adds some callback lists, and queue functions used by drivers -Move EventImpl definitions into the public diff --git a/include/libvirt/libvirt.h b/include/libvirt/libvi

[libvirt] Re: [PATCH 02/12] Domain Events - Internal API

2008-10-21 Thread Ben Guthro
[PATCH 02/12] Domain Events - Internal API This patch -Removes EventImpl from being a private function -Introduces the virDomainEventCallbackListPtr, and virDomainEventQueuePtr objects diff --git a/proxy/Makefile.am b/proxy/Makefile.am index 5902cab..75ba6b4 100644 --- a/proxy/Makefile.am +

[libvirt] Re: [PATCH 02/12] Domain Events - Internal API

2008-10-21 Thread Ben Guthro
[PATCH 02/12] Domain Events - Internal API This patch -Removes EventImpl from being a private function -Introduces the virDomainEventCallbackListPtr, and virDomainEventQueuePtr objects diff --git a/proxy/Makefile.am b/proxy/Makefile.am index 5902cab..75ba6b4 100644 --- a/proxy/Makefile.am ++

[libvirt] [PATCH 00/12] Domain Events - Round 3

2008-10-21 Thread Ben Guthro
if I missed something. Again, domain events are only emitted from qemu/kvm guests. Ben Guthro -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 00/12] Domain Events - Round 3

2008-10-21 Thread Ben Guthro
if I missed something. Again, domain events are only emitted from qemu/kvm guests. Ben Guthro -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] Re: [PATCH 12/12] Domain Events - python

2008-10-21 Thread Ben Guthro
[PATCH 12/12] Domain Events - python Add functions to be ignored, to prevent rpm build failures generator.py |3 +++ 1 file changed, 3 insertions(+) diff --git a/python/generator.py b/python/generator.py index c706b19..ca83eaf 100755 --- a/python/generator.py +++ b/python/generator.py @@ -33

[libvirt] Re: [PATCH 11/12] Domain Events - test harness

2008-10-21 Thread Ben Guthro
[PATCH 11/12] Domain Events - test harness Test app, and infrastructure changes for an example dir Makefile.am |2 configure.in |3 examples/domain-events/events-c/Makefile.am |5 examples/domain-events/events-c/event-t

[libvirt] Re: [PATCH 10/12] Domain Events - test driver

2008-10-21 Thread Ben Guthro
[PATCH 10/12] Domain Events - test driver Minor changes to test driver structure to prevent compile errors test.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/test.c b/src/test.c index aab74e4..34d35db 100644 --- a/src/test.c +++ b/src/test.c @@ -1552,6 +1552,8 @@ static virDriver

[libvirt] Re: [PATCH 09/12] Domain Events - openvz driver

2008-10-21 Thread Ben Guthro
[PATCH 09/12] Domain Events - openvz driver Minor changes to openvz driver structure to prevent compile errors openvz_driver.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/openvz_driver.c b/src/openvz_driver.c index b82d0df..2d0ddaa 100644 --- a/src/openvz_driver.c +++ b/src/openvz

[libvirt] Re: [PATCH 08/12] Domain Events - lxc driver

2008-10-21 Thread Ben Guthro
[PATCH 08/12] Domain Events - lxc driver Minor changes to LXC driver structure to prevent compile errors lxc_driver.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/lxc_driver.c b/src/lxc_driver.c index c598d1d..d1e4418 100644 --- a/src/lxc_driver.c +++ b/src/lxc_

[libvirt] Re: [PATCH 07/12] Domain Events - remote driver

2008-10-21 Thread Ben Guthro
[PATCH 07/12] Domain Events - remote driver Deliver local callbacks in response to remote events remote_internal.c | 276 +- 1 file changed, 271 insertions(+), 5 deletions(-) diff --git a/src/remote_internal.c b/src/remote_internal.c index 35b7

[libvirt] Re: [PATCH 06/12] Domain Events - qemu driver

2008-10-21 Thread Ben Guthro
[PATCH 06/12] Domain Events - qemu driver Register for, and dispatch domain event callbacks qemu_conf.h |3 + qemu_driver.c | 101 +- 2 files changed, 97 insertions(+), 7 deletions(-) diff --git a/src/qemu_conf.h b/src/qemu_conf.h ind

[libvirt] Re: [PATCH 05/12] Domain Events - Driver API

2008-10-21 Thread Ben Guthro
[PATCH 05/12] Domain Events - Driver API Additions to the driver API driver.h | 13 + 1 file changed, 13 insertions(+) diff --git a/src/driver.h b/src/driver.h index 0540f80..d1b541f 100644 --- a/src/driver.h +++ b/src/driver.h @@ -280,6 +280,17 @@ typedef unsigned long long (*

[libvirt] Re: [PATCH 04/12] Domain Events - rpc changes

2008-10-21 Thread Ben Guthro
[PATCH 04/12] Domain Events - rpc changes Changes to the RPC protocol remote_dispatch_localvars.h |3 +++ remote_dispatch_proc_switch.h | 18 ++ remote_dispatch_prototypes.h |3 +++ remote_protocol.c | 29 + remote_protocol.h

[libvirt] Re: [PATCH 03/12] Domain Events - daemon changes

2008-10-21 Thread Ben Guthro
[PATCH 03/12] Domain Events - daemon changes This code changes the daemaon to: use the pulic def of virEventRegisterImpl Add functionality to dispatch events to connected remote drivers event.c | 21 + event.h |5 +- mdns.c | 15 -- qemud.c | 72

Re: [libvirt] Re: [PATCH 04/12] Domain Events - rpc changes

2008-10-21 Thread Ben Guthro
id Lively wrote on 10/20/2008 04:05 PM: > On Sun, 2008-10-19 at 20:22 +0100, Daniel P. Berrange wrote: >> On Fri, Oct 17, 2008 at 11:58:15AM -0400, Ben Guthro wrote: >>> Changes to the RPC protocol >>> >>> +struct remote_domain_event_ret { >>> +remo

Re: [libvirt] Re: [PATCH 07/12] Domain Events - remote driver

2008-10-20 Thread Ben Guthro
iel P. Berrange wrote on 10/20/2008 10:59 AM: > On Mon, Oct 20, 2008 at 10:48:38AM -0400, Ben Guthro wrote: >>> Just discovered one tiny problem here - need to check 'event' to see >>> if the POLLHUP or POLLERR flags are set, and unregister the callback. >>> Othe

Re: [libvirt] Re: [PATCH 07/12] Domain Events - remote driver

2008-10-20 Thread Ben Guthro
> Just discovered one tiny problem here - need to check 'event' to see > if the POLLHUP or POLLERR flags are set, and unregister the callback. > Otherwise if you kill the server, the client will just spin on POLLHUP > or ERR forever. Something like this ought todo the trick > > if (event & (

RE: [libvirt] [PATCH 00/12] Domain Events - Round 2

2008-10-19 Thread Ben Guthro
xample, as suggested here: https://www.redhat.com/archives/libvir-list/2008-October/msg00258.html -Original Message- From: Jim Meyering [mailto:[EMAIL PROTECTED] Sent: Sun 10/19/2008 6:23 AM To: Ben Guthro Cc: libvir-list@redhat.com Subject: Re: [libvirt] [PATCH 00/12] Domain Events - Rou

[libvirt] Re: [PATCH 12/12] Domain Events - python

2008-10-17 Thread Ben Guthro
Add functions to be ignored, to prevent rpm build failures generator.py |3 +++ 1 file changed, 3 insertions(+) diff --git a/python/generator.py b/python/generator.py index c706b19..ca83eaf 100755 --- a/python/generator.py +++ b/python/generator.py @@ -332,6 +332,9 @@ skip_function = ( '

[libvirt] Re: [PATCH 11/12] Domain Events - test harness

2008-10-17 Thread Ben Guthro
Test app, and infrastructure changes for an example dir Makefile.am |2 configure.in |3 examples/domain-events/events-c/Makefile.am |5 examples/domain-events/events-c/event-test.c | 214 +++ l

[libvirt] Re: [PATCH 10/12] Domain Events - test driver

2008-10-17 Thread Ben Guthro
Minor changes to test driver structure to prevent compile errors test.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/src/test.c b/src/test.c index aab74e4..9f40576 100644 --- a/src/test.c +++ b/src/test.c @@ -1552,6 +1552,9 @@ static virDriver testDriver = { NULL, /* domainMemory

[libvirt] Re: [PATCH 09/12] Domain Events - openvz driver

2008-10-17 Thread Ben Guthro
Minor changes to openvz driver structure to prevent compile errors openvz_driver.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/src/openvz_driver.c b/src/openvz_driver.c index b82d0df..56dfea1 100644 --- a/src/openvz_driver.c +++ b/src/openvz_driver.c @@ -1012,6 +1012,9 @@ static vir

[libvirt] Re: [PATCH 08/12] Domain Events - lxc driver

2008-10-17 Thread Ben Guthro
Minor changes to LXC driver structure to prevent compile errors lxc_driver.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/src/lxc_driver.c b/src/lxc_driver.c index c598d1d..56e68fc 100644 --- a/src/lxc_driver.c +++ b/src/lxc_driver.c @@ -1278,6 +1278,9 @@ static virDriver lxcDriver =

[libvirt] Re: [PATCH 06/12] Domain Events - qemu driver

2008-10-17 Thread Ben Guthro
Register for, and dispatch domain event callbacks qemu_conf.h |3 ++ qemu_driver.c | 76 -- 2 files changed, 77 insertions(+), 2 deletions(-) diff --git a/src/qemu_conf.h b/src/qemu_conf.h index cfd7d35..d06c4d7 100644 --- a/src/q

[libvirt] Re: [PATCH 07/12] Domain Events - remote driver

2008-10-17 Thread Ben Guthro
Deliver local callbacks in response to remote events remote_internal.c | 255 -- 1 file changed, 248 insertions(+), 7 deletions(-) diff --git a/src/remote_internal.c b/src/remote_internal.c index 35b7b4b..13537f7 100644 --- a/src/remote_interna

[libvirt] Re: [PATCH 05/12] Domain Events - Driver API

2008-10-17 Thread Ben Guthro
Additions to the driver API driver.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/driver.h b/src/driver.h index 0540f80..c88dea8 100644 --- a/src/driver.h +++ b/src/driver.h @@ -280,6 +280,22 @@ typedef unsigned long long (*virDrvNodeGetFreeMemory)

[libvirt] Re: [PATCH 04/12] Domain Events - rpc changes

2008-10-17 Thread Ben Guthro
Changes to the RPC protocol remote_dispatch_localvars.h |3 +++ remote_dispatch_proc_switch.h | 18 ++ remote_dispatch_prototypes.h |3 +++ remote_protocol.c | 35 +++ remote_protocol.h | 28 +

[libvirt] Re: [PATCH 02/12] Domain Events - Internal API

2008-10-17 Thread Ben Guthro
This patch -Removes EventImpl from being a private function -Introduces the virDomainEventCallbackListPtr, and virDomainEventQueuePtr objects proxy/Makefile.am |1 src/event.c | 12 +- src/event.h | 37 --- src/internal.h| 63 ++

[libvirt] Re: [PATCH 03/12] Domain Events - daemon changes

2008-10-17 Thread Ben Guthro
This code changes the daemaon to: use the pulic def of virEventRegisterImpl Add functionality to dispatch events to connected remote drivers qemud.c | 28 --- qemud.h | 14 + remote.c | 158 +++ 3 files changed, 19

[libvirt] Re: [PATCH 01/12] Domain Events - Public API

2008-10-17 Thread Ben Guthro
This patch does the following: -implements the Event register/deregister code -Adds some callback lists, and queue functions used by drivers -Move EventImpl definitions into the public include/libvirt/libvirt.h| 59 + include/libvirt/libvirt.h.in | 59 + src/libv

[libvirt] [PATCH 00/12] Domain Events - Round 2

2008-10-17 Thread Ben Guthro
The following patch series implements the Events API discussed here previously in this thread: http://www.redhat.com/archives/libvir-list/2008-September/msg00321.html and http://www.redhat.com/archives/libvir-list/2008-October/msg00245.html By Daniel B's advice - I have broken this patch into the

Re: [libvirt] [PATCH 1/3] Domain events - primary implementation

2008-10-15 Thread Ben Guthro
I've been off implementing all of these changes, and I came across a point I would like to discuss, and get your opinion on. ... > In fat I think this scheme ought to let you do away with the mutex > locking completely. The contract for virConnectPtr dictates that > you are forbidden to use a sin

Re: [libvirt] [PATCH 3/3] Domain events - test harness

2008-10-09 Thread Ben Guthro
This test app prints domain events as they are emitted. I was not sure where it belonged in the tree - so this is not in the context of the rest of the libvirt tree Signed-off-by: Ben Guthro <[EMAIL PROTECTED]> Makefile |2 event-test.c

Re: [libvirt] [PATCH 2/3] Domain events - xen

2008-10-09 Thread Ben Guthro
Monitor xenstore for domain changes NOTE: this patch is currently untested Signed-off-by: Ben Guthro <[EMAIL PROTECTED]> proxy/Makefile.am |1 src/xen_unified.c |8 ++ src/xen_unified.h |3 src/xs_internal.c | 176 +

[libvirt] [PATCH 0/3] Domain events - overview

2008-10-09 Thread Ben Guthro
The following patch series implements the Events API discussed here previously in this thread: http://www.redhat.com/archives/libvir-list/2008-September/msg00321.html This is a rather large patch, and touches quite a few files, but in the end, accomplishes the goal of event delivery of notificat

RE: [libvirt] [PATCH] Don't remove devel files in spec

2008-09-18 Thread Ben Guthro
Hrm. My apologies for missing this piece. I thought I tested that prior to the second submission...but clearly I missed it. +1 for me. Ben -Original Message- From: [EMAIL PROTECTED] on behalf of Daniel P. Berrange Sent: Thu 9/18/2008 6:20 AM To: Cole Robinson Cc: libvir-list@redhat.com

Re: [libvirt] cpu flags

2008-09-17 Thread Ben Guthro
> I think the most likely place for exposing CPU flags would be in the > capabilities XML format. We do in fact already expose 3 flags there, > PAE, VMX and SVM. This looks like all of the info that I need - I guess I overlooked this part of the code prior to my message. The problem that I s

Re: [libvirt] [PATCH] spec file enhancements for minimal "client-only" build

2008-09-17 Thread Ben Guthro
1:30:23AM +0100, Richard W.M. Jones wrote: On Tue, Sep 16, 2008 at 10:20:54AM -0400, Ben Guthro wrote: New patch below, with changes discussed (removal of --without devel) +1 Ben, do you/VirtualIron have commit access now? Rich. diff --git a/libvirt.spec.in b/libvirt.spec.i

[libvirt] cpu flags

2008-09-16 Thread Ben Guthro
Hi, We're finding that we are going to be needing the cpu flags (as reported in /proc/cpuinfo) ...specifically to find out if we are a vmx enabled machine. So - off I went looking into this for a patch to submit upstream. Unfortunately, I ran into some questions which need answering before I

Re: [libvirt] [PATCH] spec file enhancements for minimal "client-only" build

2008-09-16 Thread Ben Guthro
--without avahi \ --without sasl \ --without python \ -ta --clean libvirt*.tar.gz Signed-off-by: Ben Guthro <[EMAIL PROTECTED]> libvirt.spec.in | 112 +++- 1 file changed, 102 insertions(+), 10 deletions(-) diff -

  1   2   >