Re: [libvirt] [PATCH] add support of iSER transport type in qemu with libiscsi

2018-01-17 Thread Charles Kelimod
Hello John, I have questions: >>This and the Parse makes no sense when compared to the 3 possible options. That is, it's possible to have "tcp", "rdma", and "iser", but you only care about "iser". This is because for other types are optional, there was no this line here, therefor I added this a

Re: [libvirt] [PATCH] add support of iSER transport type in qemu with libiscsi

2018-01-09 Thread Charles Kelimod
Hello, I have not got revert back since I sent last patch on 12/22/2017, just want to know how it is going on? Regards, Charles. On Fri, Dec 22, 2017 at 3:08 PM, Charles Kelimod wrote: > Hi Peter, > > I will remove the comment. > I did the test and noticed the issue, then I r

Re: [libvirt] [PATCH] add support of iSER transport type in qemu with libiscsi

2017-12-21 Thread Charles Kelimod
Hi Peter, I will remove the comment. I did the test and noticed the issue, then I reverted to a clean workspace which is cloned from the libvirt git datastore, however I meet the same issue when running the test: VIR_TEST_DEBUG=1 VIR_TEST_EXPENSIVE=1 make check Therefor I thought it was something

Re: [libvirt] [PATCH] add support of iSER transport type in qemu with libiscsi

2017-12-15 Thread Charles Kelimod
qemu can work for me, if need to use "iser://" and let disk-drive-network-iser.args to work, need to modify many place like qemuParseDriveURIString On Fri, Dec 15, 2017 at 11:47 AM, Charles Kelimod wrote: > Thank you for your patience, I regret for my first time submit here that &g

Re: [libvirt] [PATCH] add support of iSER transport type in qemu with libiscsi

2017-12-14 Thread Charles Kelimod
Thank you for your patience, I regret for my first time submit here that brings so may mistakes. I have done almost changes that you have mentioned. Now I have a question: I created drive-file-network-args.xml in test, and there is: -drive file=iser://example.org:6000/iqn.1992-01.com.example/1,for

Re: [libvirt] [PATCH 1/1] add support for iSER block type.

2017-12-13 Thread Charles Kelimod
"XXX_ISER", and driver will use the existing iscsi, that will be ok? Charles. On Wed, Dec 13, 2017 at 5:53 PM, Peter Krempa wrote: > On Wed, Dec 13, 2017 at 17:37:42 +0800, Charles Kelimod wrote: > > I can add protocol type. For driver name, I considered that before, for >

Re: [libvirt] [PATCH 1/1] add support for iSER block type.

2017-12-13 Thread Charles Kelimod
I can add protocol type. For driver name, I considered that before, for qemu, its actually use same driver for iSCSI and iSER, but there defined a driver called "iser": static BlockDriver bdrv_iser = { .format_name = "iser", .protocol_name = "iser", to use iser in qemu, we need to set driver as "is

Re: [libvirt] Add iSER support in libvirt

2017-12-12 Thread Charles Kelimod
:52:43PM +0800, Charles Kelimod wrote: > > I want to add iSER support in libvirt project, how can I submit (if > > possible) my modification to it? > > We welcome patches from anyone who is interested - there's some useful > info in: > > https://libvirt.org/

[libvirt] Add iSER support in libvirt

2017-12-07 Thread Charles Kelimod
I want to add iSER support in libvirt project, how can I submit (if possible) my modification to it? Best Regards, Charles. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list