Re: [libvirt PATCH v3] qemu: implement QEMU NBD source reconnect delay attribute

2023-03-08 Thread Christian Nautze
Hi, I know everyone is drowning in work but perhaps someone could review this patch? I think this is also a useful feature for others to configure the reconnect delay while attaching a NBD disk to a running VM. Thanks! Christian On Mon, 27 Feb 2023 at 12:15, Christian Nautze wrote

[libvirt PATCH v3] qemu: implement QEMU NBD source reconnect delay attribute

2023-02-27 Thread Christian Nautze
device.xml" e.g.: Signed-off-by: Christian Nautze --- Changes: schema reconnect element: drop mandatory 'enabled' attribute when using 'delay' reconnect element: use choice f

Re: [libvirt PATCH v2] qemu: implement QEMU NBD source reconnect delay attribute

2023-02-22 Thread Christian Nautze
no objections I will make the necessary change... On Tue, 21 Feb 2023 at 23:10, Jonathon Jongsma wrote: > On 2/17/23 10:50 AM, Christian Nautze wrote: > > Currently it's only possible to set this parameter during domain > > creation via QEMU commandline passthrough fe

[libvirt PATCH v2] qemu: implement QEMU NBD source reconnect delay attribute

2023-02-17 Thread Christian Nautze
device.xml" e.g.: Signed-off-by: Christian Nautze --- Change: reconnect element: drop mandatory 'enabled' attribute when using 'delay' --- docs/formatdomain.rst

Re: [PATCH] qemu: implement QEMU NBD source reconnect delay attribute

2023-01-30 Thread Christian Nautze
On Fri, 27 Jan 2023 at 23:42, Jonathon Jongsma wrote: > On 1/27/23 8:40 AM, Christian Nautze wrote: > > Hi! > > > > Is it possible to get a review on this patch I send before Christmas? :) > > Thank you! > > > > Christian > > > > __

Re: [PATCH] qemu: implement QEMU NBD source reconnect delay attribute

2023-01-27 Thread Christian Nautze
e new delay attribute it's also possible to set this parameter if you want to attach a new NBD disk using "virsh attach-device domain device.xml" e.g.: Signed-off-by: Christian Nautze https://listma

[PATCH] qemu: implement QEMU NBD source reconnect delay attribute

2022-12-23 Thread Christian Nautze
device.xml" e.g.: Signed-off-by: Christian Nautze --- docs/formatdomain.rst | 10 ++-- src/conf/domain_conf.c| 19 +++ src/conf/schemas/domaincommon.rng