On Thu, 2023-04-13 at 16:35 +0200, Michal Prívozník wrote:
> On 4/1/23 02:42, Eric Farman wrote:
> > Commit dbf1f68410 ("security: do not remember/recall labels for
> > VFIO")
> > rightly changed the DAC and SELinux labeling parameters to fix a
> > problem
>
On Sat, 2023-04-01 at 02:42 +0200, Eric Farman wrote:
> Commit dbf1f68410 ("security: do not remember/recall labels for
> VFIO")
> rightly changed the DAC and SELinux labeling parameters to fix a
> problem
> with "VFIO hostdevs" but really only addressed the P
ice guest ~/disk.xml
error: Failed to attach device from /home/test/disk.xml
error: Requested operation is not valid: Setting different SELinux label on
/dev/vfio/3 which is already in use
Make the same changes as reported in commit dbf1f68410, for the mdev paths.
Reported-by: Matthew Rosato
Signed
means the loadparm is
accepted, but not given to QEMU.
Correct this, and add some XML/argv tests.
Signed-off-by: Eric Farman
---
src/qemu/qemu_command.c | 24 ++
...machine-loadparm-hostdev.s390x-latest.args | 33 +++
.../machine-loadparm
3 ++-
> src/util/vircgroupv2devices.c | 14 --
> src/util/vircgroupv2devices.h | 2 +-
> 4 files changed, 8 insertions(+), 13 deletions(-)
>
Works well for me. Series:
Tested-by: Eric Farman
Reviewed-by: Eric Farman
On 4/9/21 10:14 AM, Pavel Hrdina wrote:
On Fri, Apr 09, 2021 at 09:13:32AM -0400, Eric Farman wrote:
I still fail to see how calling virCgroupRemove(group->nested) in
virCgroupRemove() would help at all. The original issue you mentioned in
the commit message is that we log this er
On 4/9/21 6:02 AM, Pavel Hrdina wrote:
On Thu, Apr 08, 2021 at 10:00:32PM -0400, Eric Farman wrote:
On 4/8/21 8:12 AM, Pavel Hrdina wrote:
On Wed, Apr 07, 2021 at 11:28:48PM -0400, Eric Farman wrote:
On 4/7/21 9:07 AM, Pavel Hrdina wrote:
On Fri, Mar 26, 2021 at 05:25:03PM +0100, Eric
On 4/8/21 8:12 AM, Pavel Hrdina wrote:
On Wed, Apr 07, 2021 at 11:28:48PM -0400, Eric Farman wrote:
On 4/7/21 9:07 AM, Pavel Hrdina wrote:
On Fri, Mar 26, 2021 at 05:25:03PM +0100, Eric Farman wrote:
The introduction of nested cgroups used a little macro
virCgroupGetNested() to retrieve
On 4/7/21 9:07 AM, Pavel Hrdina wrote:
On Fri, Mar 26, 2021 at 05:25:03PM +0100, Eric Farman wrote:
The introduction of nested cgroups used a little macro
virCgroupGetNested() to retrieve the nested cgroup
pointer, if one exists. But this macro isn't used when
removing cgroups, resulti
Polite ping, now that release freeze has finished.
On 3/26/21 12:25 PM, Eric Farman wrote:
Hi Pavel, et al,
Running Fedora 33 KVM/QEMU on s390x, I recently noticed a couple
of oddities when shutting down my guests, which I bisected between
7.0.0 and 7.1.0 to your commit:
commit
might well be way off track and would appreciate
your feedback in the matter.
Apologies for hitting this on the same day as freeze; I had not
noticed the messages previously, and started digging yesterday when
I noted the number of file descriptors left open by libvirt.
Thanks,
Eric
Eric Farm
ix this by using the same macro when removing cgroups,
so that it picks up the right structure and can remove the
associated resources properly.
Fixes: 184245f53b94 ("vircgroup: introduce nested cgroup to properly work with
systemd")
Signed-off-by: Eric Farman
---
src/util/vircgroup
On 8/13/20 11:33 AM, Cornelia Huck wrote:
> On Fri, 7 Aug 2020 13:59:42 +0200
> Cornelia Huck wrote:
>
>> On Wed, 05 Aug 2020 12:35:01 +0100
>> Sean Mooney wrote:
>>
>>> On Wed, 2020-08-05 at 12:53 +0200, Jiri Pirko wrote:
Wed, Aug 05, 2020 at 11:33:38AM CEST, yan.y.z...@intel.com wrot
o
these ideas after I get them sorted out.
Thanks for the reviews, and the suggestions!
- Eric
>
> Thanks,
>
>
> DHB
>
>
>
> On 9/3/19 5:09 PM, Eric Farman wrote:
>> The routine qemuDomainGetMemLockLimitBytes() has a couple tests
>> to determine what t
e attached successfully
$ grep locked /proc/83543/limits
Max locked memory 3221225472 3221225472 bytes
Eric Farman (3):
qemu: Refactor the max memlock routine
qemu: Reset the maximum locked memory on hotplug fail
qemu: Adjust max memlock on mdev hotplug
nvolved for the problem I was
trying to fix. Maybe another day.)
Signed-off-by: Eric Farman
---
src/qemu/qemu_hotplug.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 979e97b608..ae7c5395d2 100644
--- a/src/qemu/qemu_hotplug.c
back the way it was.
Signed-off-by: Eric Farman
---
src/qemu/qemu_hotplug.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 24e75e49be..979e97b608 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -1469,6 +1
Let's pull this hunk out into a function, so it can be reused
in another codepath that needs to do the same thing.
Signed-off-by: Eric Farman
---
src/qemu/qemu_domain.c | 30 ++
src/qemu/qemu_domain.h | 2 ++
src/qemu/qemu_hotplug.c | 11 +--
3
del != -1)
+newModel = model;
What's the harm if the last controller were undefined? Wouldn't it get
populated down the road anyway if one were not set at this point (we
send -1 today, after all). That could eliminate one of the two
virDomainControllerModelSCSI variable
On 12/06/2017 08:08 AM, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1519130
Commit id 'dc692438' reverted the automagic addition of a SCSI
controller attempt during virDomainHostdevAssignAddress; however,
the logic to determine where to place the next_unit depended upon
t
On 12/13/2017 02:39 PM, John Ferlan wrote:
On 12/13/2017 10:43 AM, Eric Farman wrote:
On 12/06/2017 08:08 AM, John Ferlan wrote:
When qemuDomainFindOrCreateSCSIDiskController adds a controller,
let's use the same model as a currently found controller under the
assumption that the r
On 12/06/2017 08:08 AM, John Ferlan wrote:
When qemuDomainFindOrCreateSCSIDiskController adds a controller,
let's use the same model as a currently found controller under the
assumption that the reason to add the controller in hotplug is
because virDomainHostdevAssignAddress determined that the
erlan
Reviewed-by: Eric Farman
---
src/qemu/qemu_hotplug.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 6ef28bf05..9317e134a 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.
On 12/13/2017 09:05 AM, John Ferlan wrote:
On 12/13/2017 08:28 AM, Eric Farman wrote:
On 12/12/2017 09:22 AM, John Ferlan wrote:
Commit id '70249927b' neglected to cover this case because the test
had taken the "shortcut" to already add the , so I altered
that too
On 12/12/2017 09:22 AM, John Ferlan wrote:
We cannot be sure someone initialized the passed *vhostfd and we
certainly don't want or need to be calling VIR_FORCE_CLOSE on what
probably is -1. So let's just return -1 immediately.
Signed-off-by: John Ferlan
Reviewed-by: E
00:09.0 should not have a PCI address
where the address is related to the guest PCI address provided.
Signed-off-by: John Ferlan
Reviewed-by: Eric Farman
---
src/qemu/qemu_domain_address.c | 3 +-
.../hostdev-scsi-vhost-scsi-ccw.xml| 1 -
.../hostde
t clear
why the failure occurred.
Signed-off-by: John Ferlan
Reviewed-by: Eric Farman
---
src/util/virscsivhost.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/util/virscsivhost.c b/src/util/virscsivhost.c
index d6fbf5ed5..5f176e177 100644
--- a/src/util/virsc
As with virtio-scsi, the "internal error" messages after
preparing a vhost-scsi hostdev overwrites more meaningful
error messages deeper in the callchain. Remove it too.
Signed-off-by: Eric Farman
---
src/qemu/qemu_hotplug.c | 7 +--
1 file changed, 1 insertion(+), 6 deletion
v1 was here:
https://www.redhat.com/archives/libvir-list/2017-April/msg01066.html
Per review, removed the "internal error" messages and split the
resulting patch into patches 2 (virtio-scsi) and 3 (vhost-scsi).
Patch 1 fixes a return code check that is a little off.
Eric Farman (
Signed-off-by: Eric Farman
---
src/qemu/qemu_hotplug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index eec99af..6d568d6 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -2468,7 +2468,7
issue better
messages deeper in the callchain so these "internal error"
messages overwrite any of them. Remove them, so that the
more detailed errors are seen.
Signed-off-by: Eric Farman
---
src/qemu/qemu_hotplug.c | 17 +
1 file changed, 1 insertion(+), 16 deletions(-)
di
On 04/26/2017 01:55 PM, John Ferlan wrote:
On 04/24/2017 02:02 PM, Eric Farman wrote:
I tried to attach a SCSI LUN to two different guests, and forgot
to specify "shareable" in the hostdev XML. Attaching the device
to the second guest failed, but the message was not helpful in
bably helpful.
Make this adjustment for both virtio-scsi and vhost-scsi
devices.
Signed-off-by: Eric Farman
Reviewed-by: Bjoern Walk
Reviewed-by: Boris Fiuczynski
---
src/qemu/qemu_hotplug.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_hotp
On 11/18/2016 09:26 AM, John Ferlan wrote:
Move the check for an already existing vHBA to the top of the function.
No sense in first decoding a provided parent if the next thing we're going
to do is fail if a provided wwnn/wwpn already exists.
Signed-off-by: John Ferlan
---
src/storage/stor
On 12/07/2016 08:16 PM, Jim Fehlig wrote:
On 11/22/2016 02:16 PM, John Ferlan wrote:
On 11/21/2016 10:58 PM, Eric Farman wrote:
Signed-off-by: Eric Farman
---
docs/formatdomain.html.in | 24
1 file changed, 24 insertions(+)
This will get squashed in with the
evice guest_01 scsicontroller.xml
Device detached successfully
Signed-off-by: Eric Farman
Reviewed-by: Bjoern Walk
Reviewed-by: Boris Fiuczynski
---
src/qemu/qemu_hotplug.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index b0
On 11/28/2016 04:14 PM, John Ferlan wrote:
On 11/28/2016 09:01 AM, Eric Farman wrote:
Consider a guest started with the following XML snippet:
That's an awfully large unit # isn't it? For the guest...
Large, yes. Unreasonable, no. T
I believe this is still the preferred method... Could I please have an
account "farman" for the libvirt wiki, in order to contribute some of
the cover-letter "howto" information from the recent vhost-scsi series?
Thanks,
- Eric
--
libvir-list mailing list
libvir-list@redhat.com
https://www.r
$ virsh detach-device guest_one_virtio_scsi scsicontroller.xml
Device detached successfully
Signed-off-by: Eric Farman
Reviewed-by: Bjoern Walk
Reviewed-by: Boris Fiuczynski
---
src/qemu/qemu_hotplug.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/qemu/qemu_hotplug.c b
On 11/22/2016 04:16 PM, John Ferlan wrote:
On 11/21/2016 10:58 PM, Eric Farman wrote:
Signed-off-by: Eric Farman
---
docs/formatdomain.html.in | 24
1 file changed, 24 insertions(+)
This will get squashed in with the conf patch. I'll also generat
On 11/22/2016 04:12 PM, John Ferlan wrote:
On 11/21/2016 10:58 PM, Eric Farman wrote:
With the QEMU components in place, provide the XML parsing to
invoke that code when given the following XML snippet:
An optional address element can be specified within the hostdev
On 11/22/2016 04:08 PM, John Ferlan wrote:
[...]
void
+qemuHostdevReAttachSCSIVHostDevices(virQEMUDriverPtr driver,
+const char *name,
+virDomainHostdevDefPtr *hostdevs,
+int nhost
code named "SCSIHost" to refer to
a hostdev type='scsi' protcol='none'.
Signed-off-by: Eric Farman
---
po/POTFILES.in | 1 +
src/Makefile.am | 1 +
src/libvirt_private.syms | 18 +++
src/util/virhostdev.c| 163 +++
Do all the stuff for the vhost-scsi capability in QEMU,
so it's in place for our checks later.
Signed-off-by: Eric Farman
Reviewed-by: Boris Fiuczynski
---
src/qemu/qemu_capabilities.c| 2 ++
src/qemu/qemu_capabilities.h| 1 +
chives/libvir-list/2016-September/msg00148.html
v2:https://www.redhat.com/archives/libvir-list/2016-August/msg01028.html
v1:https://www.redhat.com/archives/libvir-list/2016-July/msg01004.html
[1] http://www.redhat.com/archives/libvir-list/2014-July/msg01235.html
[2] http://www.r
a vhost-scsi-ccw device in the case of an s390 machine, or
vhost-scsi-pci for any others.
Signed-off-by: Eric Farman
---
src/qemu/qemu_cgroup.c | 32 +
src/qemu/qemu_command.c| 80 ++
src/qemu/qemu_command.h| 5
Ensure that the vhost-scsi wwpn information is passed to the
different security policies.
Signed-off-by: Eric Farman
---
src/security/security_apparmor.c | 20 -
src/security/security_dac.c | 46 ++--
src/security/security_selinux.c | 43
Signed-off-by: Eric Farman
---
docs/formatdomain.html.in | 24
1 file changed, 24 insertions(+)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 4e40aa1..6bd02cc 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -3694,6
These tests were cloned from hostdev-scsi-virtio-scsi in both
xml2argv and xml2xml
We add ones for both vhost-scsi-ccw and vhost-scsi-pci since
the syntaxes are slightly different between them.
Signed-off-by: Eric Farman
Reviewed-by: Boris Fiuczynski
---
.../qemuxml2argv-hostdev-scsi-vhost
With the QEMU components in place, provide the XML parsing to
invoke that code when given the following XML snippet:
An optional address element can be specified within the hostdev
(pick CCW or PCI as necessary):
Signed-off-by: Eric Farman
---
docs/schemas
ned-off-by: Eric Farman
---
src/conf/domain_conf.c | 11 ++-
src/conf/domain_conf.h | 18 ++
src/qemu/qemu_cgroup.c | 7 +++
src/qemu/qemu_hotplug.c | 2 ++
src/security/security_apparmor.c| 4
sr
r in this case, so that shutting down the
guest cleans up the host cgroup entries and allows future guests to use
vhost-scsi devices. (Otherwise the guest will silently end.)
Signed-off-by: Eric Farman
---
src/qemu/qemu_hotplug.c | 164
1 file
On 11/17/2016 06:18 PM, John Ferlan wrote:
[...]
I don't think the current code naming is incorrect, but it does
slightly paint us into a box with this work. I'll mull this over
overnight, and maybe cook up a cleanup patch separate from this
series. Or perhaps take your other suggestion and
On 11/14/2016 05:20 PM, Eric Farman wrote:
On 11/14/2016 04:59 PM, John Ferlan wrote:
On 11/14/2016 08:31 AM, Eric Farman wrote:
On 11/11/2016 04:41 PM, John Ferlan wrote:
s/$SUBJ/Introduce framework for hostdev SCSI_Host subsys type
On 11/08/2016 01:26 PM, Eric Farman wrote:
We
On 11/11/2016 04:53 PM, John Ferlan wrote:
need a commit message here.
On 11/08/2016 01:26 PM, Eric Farman wrote:
Signed-off-by: Eric Farman
---
docs/schemas/domaincommon.rng | 23
src/conf/domain_audit.c | 7
src/conf/domain_conf.c| 81
ot;" being used going forward.
[1] End of
https://www.redhat.com/archives/libvir-list/2016-November/msg00738.html
Signed-off-by: Eric Farman
---
src/conf/domain_audit.c | 2 +-
src/conf/domain_conf.c | 20 -
src/conf/domain_conf.h | 8 +
On 11/14/2016 04:59 PM, John Ferlan wrote:
On 11/14/2016 08:31 AM, Eric Farman wrote:
On 11/11/2016 04:41 PM, John Ferlan wrote:
s/$SUBJ/Introduce framework for hostdev SCSI_Host subsys type
On 11/08/2016 01:26 PM, Eric Farman wrote:
We already have a "scsi" hostdev type, which
On 11/14/2016 04:40 PM, John Ferlan wrote:
On 11/14/2016 03:38 PM, Eric Farman wrote:
On 11/11/2016 04:44 PM, John Ferlan wrote:
While perhaps mostly obvious - you need some sort of commit message here.
On 11/08/2016 01:26 PM, Eric Farman wrote:
Signed-off-by: Eric Farman
---
po
On 11/11/2016 04:44 PM, John Ferlan wrote:
While perhaps mostly obvious - you need some sort of commit message here.
On 11/08/2016 01:26 PM, Eric Farman wrote:
Signed-off-by: Eric Farman
---
po/POTFILES.in | 1 +
src/Makefile.am | 1 +
src/libvirt_private.syms
On 11/11/2016 04:47 PM, John Ferlan wrote:
On 11/08/2016 01:26 PM, Eric Farman wrote:
Adjust the device string that is built for vhost-scsi devices so that it
can be invoked from hotplug.
>From the QEMU command line, the file descriptors are expect to be numeric only.
s/>//
Looks
On 11/11/2016 04:41 PM, John Ferlan wrote:
s/$SUBJ/Introduce framework for hostdev SCSI_Host subsys type
On 11/08/2016 01:26 PM, Eric Farman wrote:
We already have a "scsi" hostdev type, which refers to a single LUN
that is passed through to a guest. But what of things where mul
On 11/11/2016 04:40 PM, John Ferlan wrote:
On 11/08/2016 01:26 PM, Eric Farman wrote:
Do all the stuff for the vhost-scsi capability in QEMU,
so it's in place for our checks later.
Signed-off-by: Eric Farman
Reviewed-by: Boris Fiuczynski
---
src/qemu/qemu_capabilit
Do all the stuff for the vhost-scsi capability in QEMU,
so it's in place for our checks later.
Signed-off-by: Eric Farman
Reviewed-by: Boris Fiuczynski
---
src/qemu/qemu_capabilities.c| 2 ++
src/qemu/qemu_capabilities.h| 1 +
Signed-off-by: Eric Farman
---
src/security/security_apparmor.c | 18 -
src/security/security_dac.c | 42 ++--
src/security/security_selinux.c | 39 +++--
3 files changed, 94 insertions(+), 5 deletions
r in this case, so that shutting down the
guest cleans up the host cgroup entries and allows future guests to use
vhost-scsi devices. (Otherwise the guest will silently end.)
Signed-off-by: Eric Farman
---
src/qemu/qemu_hotplug.c | 158
1 file
These tests were cloned from hostdev-scsi-virtio-scsi in both
xml2argv and xml2xml
Signed-off-by: Eric Farman
Reviewed-by: Boris Fiuczynski
---
.../qemuxml2argv-hostdev-scsi-vhost-scsi.args | 24 +
.../qemuxml2argv-hostdev-scsi-vhost-scsi.xml | 41
Signed-off-by: Eric Farman
---
po/POTFILES.in | 1 +
src/Makefile.am | 1 +
src/libvirt_private.syms | 19 +++
src/util/virhost.c | 299 +++
src/util/virhost.h | 72
src/util/virhostdev.c| 155
We already have a "scsi" hostdev type, which refers to a single LUN
that is passed through to a guest. But what of things where multiple
LUNs are passed through via a single SCSI HBA, such as with the
vhost-scsi target? Create a new hostdev type that will carry this.
Signed-off-by: E
Signed-off-by: Eric Farman
---
docs/formatdomain.html.in | 24
1 file changed, 24 insertions(+)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 11b3330..ed96ca4 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -3694,6
Signed-off-by: Eric Farman
---
docs/schemas/domaincommon.rng | 23
src/conf/domain_audit.c | 7
src/conf/domain_conf.c| 81 +--
3 files changed, 109 insertions(+), 2 deletions(-)
diff --git a/docs/schemas/domaincommon.rng
a vhost-scsi-ccw device in the case of an s390 machine, or
vhost-scsi-pci for any others.
Signed-off-by: Eric Farman
---
src/qemu/qemu_cgroup.c | 32 +
src/qemu/qemu_command.c| 79 ++
src/qemu/qemu_command.h| 5
As was suggested in an earlier review comment[1], we can
catch some additional code points by cleaning up how we use the
hostdev subsystem type in some switch statements.
[1] End of
https://www.redhat.com/archives/libvir-list/2016-September/msg00399.html
Signed-off-by: Eric Farman
---
src
tps://www.redhat.com/archives/libvir-list/2016-September/msg00148.html
v2:https://www.redhat.com/archives/libvir-list/2016-August/msg01028.html
v1:https://www.redhat.com/archives/libvir-list/2016-July/msg01004.html
[1] http://www.redhat.com/archives/libvir-list/2014-July/msg01235.html
[2] htt
As was suggested in an earlier review comment[1], we can
catch some additional code points by cleaning up how we use the
hostdev subsystem type in some switch statements.
[1] End of
https://www.redhat.com/archives/libvir-list/2016-September/msg00399.html
Signed-off-by: Eric Farman
---
src
ir-list/2016-September/msg00148.html
v2:https://www.redhat.com/archives/libvir-list/2016-August/msg01028.html
v1:https://www.redhat.com/archives/libvir-list/2016-July/msg01004.html
[1] http://www.redhat.com/archives/libvir-list/2014-July/msg01235.html
[2] http://www.redhat.com/archives/libvir-list
Signed-off-by: Eric Farman
---
docs/schemas/domaincommon.rng | 23
src/conf/domain_audit.c | 7
src/conf/domain_conf.c| 81 +--
3 files changed, 109 insertions(+), 2 deletions(-)
diff --git a/docs/schemas/domaincommon.rng
r in this case, so that shutting down the
guest cleans up the host cgroup entries and allows future guests to use
vhost-scsi devices. (Otherwise the guest will silently end.)
Signed-off-by: Eric Farman
---
src/qemu/qemu_hotplug.c | 158
1 file
These tests were cloned from hostdev-scsi-virtio-scsi in both
xml2argv and xml2xml
Signed-off-by: Eric Farman
Reviewed-by: Boris Fiuczynski
---
.../qemuxml2argv-hostdev-scsi-vhost-scsi.args | 24 +
.../qemuxml2argv-hostdev-scsi-vhost-scsi.xml | 41
Signed-off-by: Eric Farman
---
src/security/security_apparmor.c | 18 -
src/security/security_dac.c | 42 ++--
src/security/security_selinux.c | 39 +++--
3 files changed, 94 insertions(+), 5 deletions
Signed-off-by: Eric Farman
---
docs/formatdomain.html.in | 24
1 file changed, 24 insertions(+)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index c70377b..6ef864f 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -3694,6
Signed-off-by: Eric Farman
---
src/Makefile.am | 1 +
src/libvirt_private.syms | 19 +++
src/util/virhost.c | 301 +++
src/util/virhost.h | 72
src/util/virhostdev.c| 155
src/util
a vhost-scsi-ccw device in the case of an s390 machine, or
vhost-scsi-pci for any others.
Signed-off-by: Eric Farman
---
src/qemu/qemu_cgroup.c | 32 +
src/qemu/qemu_command.c| 79 ++
src/qemu/qemu_command.h| 5
Do all the stuff for the vhost-scsi capability in QEMU,
so it's in place for our checks later.
Signed-off-by: Eric Farman
Reviewed-by: Boris Fiuczynski
---
src/qemu/qemu_capabilities.c| 2 ++
src/qemu/qemu_capabilities.h| 1 +
We already have a "scsi" hostdev type, which refers to a single LUN
that is passed through to a guest. But what of things where multiple
LUNs are passed through via a single SCSI HBA, such as with the
vhost-scsi target? Create a new hostdev type that will carry this.
Signed-off-by: E
On 10/29/2016 08:33 AM, John Ferlan wrote:
On 10/26/2016 05:42 PM, Eric Farman wrote:
[Author note: Apologies for an extra release or two in between versions,
I was sidetracked by another project. This is probably too close to the
impending freeze for 2.4, so I just updated doc to 2.5 in
1] http://www.redhat.com/archives/libvir-list/2014-July/msg01235.html
[2] http://www.redhat.com/archives/libvir-list/2014-July/msg01390.html
Eric Farman (9):
qemu: Introduce vhost-scsi capability
Introduce a "scsi_host" hostdev type
util: Management routines for scsi_host devices
Signed-off-by: Eric Farman
---
src/security/security_apparmor.c | 18 -
src/security/security_dac.c | 42 ++--
src/security/security_selinux.c | 39 +++--
3 files changed, 94 insertions(+), 5 deletions
a vhost-scsi-ccw device in the case of an s390 machine, or
vhost-scsi-pci for any others.
Signed-off-by: Eric Farman
---
src/qemu/qemu_cgroup.c | 32 +
src/qemu/qemu_command.c| 79 ++
src/qemu/qemu_command.h| 5
r in this case, so that shutting down the
guest cleans up the host cgroup entries and allows future guests to use
vhost-scsi devices. (Otherwise the guest will silently end.)
Signed-off-by: Eric Farman
---
src/qemu/qemu_hotplug.c | 158
1 file
Signed-off-by: Eric Farman
---
docs/formatdomain.html.in | 24
1 file changed, 24 insertions(+)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index c70377b..6ef864f 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -3694,6
These tests were cloned from hostdev-scsi-virtio-scsi in both
xml2argv and xml2xml
Signed-off-by: Eric Farman
Reviewed-by: Boris Fiuczynski
---
.../qemuxml2argv-hostdev-scsi-vhost-scsi.args | 24 +
.../qemuxml2argv-hostdev-scsi-vhost-scsi.xml | 41
Do all the stuff for the vhost-scsi capability in QEMU,
so it's in place for our checks later.
Signed-off-by: Eric Farman
Reviewed-by: Boris Fiuczynski
---
src/qemu/qemu_capabilities.c| 2 ++
src/qemu/qemu_capabilities.h| 1 +
We already have a "scsi" hostdev type, which refers to a single LUN
that is passed through to a guest. But what of things where multiple
LUNs are passed through via a single SCSI HBA, such as with the
vhost-scsi target? Create a new hostdev type that will carry this.
Signed-off-by: E
Signed-off-by: Eric Farman
---
src/Makefile.am | 1 +
src/libvirt_private.syms | 19 +++
src/util/virhost.c | 301 +++
src/util/virhost.h | 72
src/util/virhostdev.c| 155
src/util
Signed-off-by: Eric Farman
---
docs/schemas/domaincommon.rng | 23
src/conf/domain_audit.c | 7
src/conf/domain_conf.c| 81 +--
3 files changed, 109 insertions(+), 2 deletions(-)
diff --git a/docs/schemas/domaincommon.rng
On 09/13/2016 05:48 PM, Eric Farman wrote:
On 09/13/2016 04:49 PM, John Ferlan wrote:
[...]
Thanks for the review. (Silent ACK on a lot of the above comments.)
I'll try to get these all in place for a v3 with a little runway before
the next freeze.
OK - hopefully I won't be
On 09/13/2016 04:55 PM, John Ferlan wrote:
[...]
diff --git a/src/util/virscsi.c b/src/util/virscsi.c
index 4843367..290b692 100644
--- a/src/util/virscsi.c
+++ b/src/util/virscsi.c
@@ -105,6 +105,32 @@ virSCSIDeviceGetAdapterId(const char *adapter,
return -1;
}
+int
+virSCSIOpen
On 09/13/2016 04:49 PM, John Ferlan wrote:
[...]
I took a peek at the v1, but suffice to say didn't follow it that
closely since there's a number of changes in v2 related to patch
ordering. You could get 3 different opinions on that matter too!
Hopefully a consensus before too long. :)
ye
On 09/12/2016 06:10 PM, John Ferlan wrote:
On 09/06/2016 08:58 AM, Eric Farman wrote:
Open /dev/vhost-scsi, and record the resulting file descriptor, so that
the guest has access to the host device outside of the libvirt daemon.
Pass this information, along with data parsed from the XML file
On 09/12/2016 05:34 PM, John Ferlan wrote:
On 09/06/2016 08:58 AM, Eric Farman wrote:
We already have a "scsi" hostdev type, which refers to a single LUN
that is passed through to a guest. But what of things where multiple
LUNs are passed through via a single SCSI HBA, such as with
1 - 100 of 171 matches
Mail list logo