[libvirt] [PATCH] xen_xs: Guard against set but empty kernel argument

On xen 4.1 I observied configurations that look like: (image (hvm (kernel '') (loader '/foo/bar') )) The kernel element is there but unset. This leads to an emtpy element in the XML and even worse makes us skip the boot order parsing and therefore not emit a element which br

Re: [libvirt] [PATCH] fix devhelp rebuild when in separate $(builddir) != $(srcdir)

Daniel Veillard schrieb: > On Thu, Dec 11, 2008 at 02:30:37PM +0100, Guido Günther wrote: >> Hi, >> look for devhelp.xsl in $(srcdir). >> Patch attached, > > Sure, +1 > > thanks ! Applied now. -- Guido -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listi

Re: [libvirt] [PATCH] qemu: fix virtual serial/parallel ports via unix/tcp

Daniel P. Berrange schrieb: > On Thu, Dec 11, 2008 at 12:30:50PM +0100, Guido G?nther wrote: >> Hi, >> as to my understanding we should pass 'server' instead of 'listen' to >> forward virtual serial ports via unix domain sockets or tcp. See: >> http://bellard.org/qemu/qemu-doc.html >> >> I also ad

[libvirt] [PATCH] make sure we call the freshly build libvirtd

...not the one in $PATH. I was wondering why this test kept failing... -- Guido --- tests/daemon-conf |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/daemon-conf b/tests/daemon-conf index db1f0d3..4a42d1e 100755 --- a/tests/daemon-conf +++ b/tests/daemon-conf

[Libvir] [PATCH] deep copy dom structure

--- src/virterror.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/src/virterror.c b/src/virterror.c index 1463129..49f3b89 100644 --- a/src/virterror.c +++ b/src/virterror.c @@ -115,6 +115,11 @@ virResetError(virErrorPtr err) free(err->str1); free

[Libvir] dumpxml define not idempotent due to tag

Hi, when using "virsh dumpxml > xmlfile" on a running paravirt xen domain that has no bootloader entry whatsoever I get: ... linux /boot/vmlinuz-vm /boot/initrd.img-vm root=/dev/sda1 ro ... reimporting this via "virsh define xmlfile" and then dumping again gives somethi

Re: [Libvir] Re: [PATCH] add missing qemudReportError

I just noticed that the patch got mangled, sorry: On Tue, Feb 05, 2008 at 01:09:15PM +0100, Guido Guenther wrote: > That said it might also be worthwhile to not let libvirtd segfault > because of a missing call to qemudReportError - this is debatable > though: diff --git a/src/qemu_con

[Libvir] Re: [PATCH] add missing qemudReportError

On Tue, Feb 05, 2008 at 01:06:14PM +0100, Guido Guenther wrote: > without this qemudParseVMDef might return NULL when the boot dev > configuration is invalid but virGetLastError returns NULL either since > no error has been set, this leads to a segfault in qemudLoadConfig when > try

[Libvir] [PATCH] add missing qemudReportError

Hi, without this qemudParseVMDef might return NULL when the boot dev configuration is invalid but virGetLastError returns NULL either since no error has been set, this leads to a segfault in qemudLoadConfig when trying to print the error message. Cheers, -- Guido diff --git a/src/qemu_conf.c b/sr

[Libvir] [PATCH] don't use xen functions when USE_XEN is undefined

diff --git a/tests/statstest.c b/tests/statstest.c index 4c19833..6213da8 100644 --- a/tests/statstest.c +++ b/tests/statstest.c @@ -12,7 +12,7 @@ static void testQuietError(void *userData ATTRIBUTE_UNUSED, virErrorPtr error AT /* nada */ } -#ifdef __linux__ +#if __linux__ && WITH_XEN st

Re: [Libvir] [PATCH] fix compilation with USE_XEN == 0

On Thu, Jan 31, 2008 at 04:14:09PM +0100, Jim Meyering wrote: > Guido Guenther <[EMAIL PROTECTED]> wrote: > > statstest.c needs to check if USE_XEN > 0, otherwise compilation breaks > > on --without-xen builds. Please apply if appropriate. Patch is against > > cu

[Libvir] [PATCH] fix compilation with USE_XEN == 0

Hi, statstest.c needs to check if USE_XEN > 0, otherwise compilation breaks on --without-xen builds. Please apply if appropriate. Patch is against current cvs. Cheers, -- Guido -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[Libvir] [PATCH] virtinst: don't expect non-root users to have block device access

Hi, attached patch drops the assumption that a non-root user has read access to the guest OSes partition - he doesn't need to since all interaction is handled via libvirt and giving the user read access for a simple MBR block read test seems like overkill. Please apply if appropriate, patch is agai

Re: [Libvir] [patch] qemu/kvm: use_system_powerdown instead of killing the vm hard

On Mon, Jan 14, 2008 at 12:28:09PM +, Richard W.M. Jones wrote: > Guido Guenther wrote: >> "sendkey ctrl-alt-delete" >> to the monitor which might be very fragile though. Both solutions depend >> on the os in the vm doing the right thing (acpi event handling in

Re: [Libvir] [patch] qemu/kvm: use_system_powerdown instead of killing the vm hard

On Wed, Jan 09, 2008 at 03:56:52PM +, Daniel P. Berrange wrote: > Well there's a 'system_reset' monitor command, but its unclear if > its actually working - when i run it, it stops the guest from responding > to any keyboard input and makes it take 100% CPU, but doesn't reboot :-( > If that's

Re: [Libvir] [patch] qemu/kvm: use_system_powerdown instead of killing the vm hard

On Tue, Jan 08, 2008 at 06:34:36PM +, Daniel P. Berrange wrote: > Fair enough. Any idea if the 'system_reboot' command is also wired up > in KVM yet ? We should probably just add code to call it anyway since > it'll be near identical code to that which you used for shutdown, and > its better t

Re: [Libvir] [patch] qemu/kvm: use_system_powerdown instead of killing the vm hard

On Tue, Jan 08, 2008 at 04:37:02PM +, Daniel P. Berrange wrote: > On Tue, Jan 08, 2008 at 12:15:56PM +0100, Guido Guenther wrote: > > Hi, > > currently domainShutdown kills qemu/kvm instances hard which is not very > > filesystem friendly. However recent kvm git acquire

[Libvir] [patch] qemu/kvm: use_system_powerdown instead of killing the vm hard

Hi, currently domainShutdown kills qemu/kvm instances hard which is not very filesystem friendly. However recent kvm git acquired system_powerdown to shutdown the system gracefully by simulating an acpi power button press. We can now use this in libvirt: diff --git a/src/qemu_driver.c b/src/qemu_