Commit 6b9964 enforces checking invalid use of VSH_OT_STRING with
VSH_OFLAG_REQ. This commit tries to do the same thing to stop using
VSH_OT_DATA without VSH_OFLAG_REQ and also fix existing misuse.
Signed-off-by: Hao Liu
---
V2:
Add missing fix of dommemstat --period option.
tools/virsh
Commit 6b9964 enforces checking invalid use of VSH_OT_STRING with
VSH_OFLAG_REQ. This commit tries to do the same thing to stop using
VSH_OT_DATA without VSH_OFLAG_REQ and also fix existing misuse.
Signed-off-by: Hao Liu
---
tools/virsh-domain-monitor.c | 2 +-
tools/virsh-domain.c
Signed-off-by: Hao Liu
---
docs/hacking.html.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/docs/hacking.html.in b/docs/hacking.html.in
index a73b1e0..53786b7 100644
--- a/docs/hacking.html.in
+++ b/docs/hacking.html.in
@@ -481,8 +481,9 @@
while (expr1
Signed-off-by: Hao Liu
---
HACKING | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/HACKING b/HACKING
index 884e78c..94d9d2c 100644
--- a/HACKING
+++ b/HACKING
@@ -383,8 +383,9 @@ single-'statement' loop: each has only one 'line' in its
body.
message.
This should fix bug:
https://bugzilla.redhat.com/show_bug.cgi?id=1172468
Signed-off-by: Hao Liu
---
V2: (Courtesy of Luyang Huang)
Fixed memory leak;
Fixed curly brace style;
src/storage/storage_backend_disk.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff
message.
This should fix bug:
https://bugzilla.redhat.com/show_bug.cgi?id=1172468
Signed-off-by: Hao Liu
---
src/storage/storage_backend_disk.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/storage/storage_backend_disk.c
b/src/storage/storage_backend_disk.c
index
The variable `nparams` didn't change accordingly when adding a new
parameter in commit b2cecf73.
This patch fixes https://bugzilla.redhat.com/show_bug.cgi?id=1171938
Signed-off-by: Hao Liu
---
Virt.xs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Virt.xs b/Virt.xs
ould use
VSH_OT_DATA instead of VSH_OT_STRING as an option type.
3) A typo.
Signed-off-by: Hao Liu
---
src/util/virutil.c | 4 ++--
tools/virsh-domain.c | 4 ++--
tools/virsh-host.c | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/util/virutil.c b/src/util/viru
Bandwidth options in blockcommit, blockcopy, blockjob and blockpull
are parsed by vshCommandOptULWrap() and should be shown as a number
type option.
And a typo is fixed.
Signed-off-by: Hao Liu
---
tools/virsh-domain.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git