Re: [libvirt] RFC: should we mandate use of VPATH builds ?

2018-02-22 Thread Jaroslav Suchanek
On Thu, Feb 22, 2018 at 01:29:35PM +, Daniel P. Berrangé wrote: > One of the things we (well I) constantly screw up is VPATH builds. I've > always tended to just build in the source tree, and as a result I'll > often miss changes which break VPATH builds. > > Now our Jenkins CI catches this be

Re: [libvirt] [PATCH] libvirt.spec.in: soft-static allocation of qemu and kvm groups

2016-07-11 Thread Jaroslav Suchanek
On Fri, Jul 08, 2016 at 07:08:05PM +0200, Andrea Bolognani wrote: > On Thu, 2016-07-07 at 17:41 +0200, Jaroslav Suchanek wrote: > > Follow the same logic for adding qemu user also for kvm and qemu groups. As > > is described in https://fedoraproject.org/wiki/Packaging:UsersAndGrou

[libvirt] [PATCH] libvirt.spec.in: soft-static allocation of qemu and kvm groups

2016-07-07 Thread Jaroslav Suchanek
Follow the same logic for adding qemu user also for kvm and qemu groups. As is described in https://fedoraproject.org/wiki/Packaging:UsersAndGroups document there should be preallocated UIDs and GIDs for libvirt. A check for required group id was added prior groupadd execution. Resolves: https://b

[libvirt] [PATCH v2] logging: fixing log level initialization from cmdline

2016-06-28 Thread Jaroslav Suchanek
Reorder code for setting default log level from cmdline prior initialization of log outputs. Thus the --verbose option is reflected. This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1325072 --- Notes: v2: moving up the cmdline override for default logging level also for the

Re: [libvirt] [PATCH] logging: fixing log level initialization from cmdline

2016-06-27 Thread Jaroslav Suchanek
On Fri, Jun 24, 2016 at 02:29:57PM +0100, Daniel P. Berrange wrote: > On Fri, Jun 24, 2016 at 02:25:27PM +0200, Jaroslav Suchanek wrote: > > Reorder code for setting default log level from cmdline prior > > initialization of log outputs. Thus the --verbose option is reflected

[libvirt] [PATCH] logging: fixing log level initialization from cmdline

2016-06-24 Thread Jaroslav Suchanek
Reorder code for setting default log level from cmdline prior initialization of log outputs. Thus the --verbose option is reflected. This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1325072 --- src/logging/log_daemon.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)