Re: [libvirt] udevadm settle can take too long

2012-04-26 Thread Jim Paris
Osier Yang wrote: > On 2012年04月24日 03:47, Guido Günther wrote: > >Hi, > >On Sun, Apr 22, 2012 at 02:41:54PM -0400, Jim Paris wrote: > >>Hi, > >> > >>http://bugs.debian.org/663931 is a bug I'm hitting, where virt-manager > >>times out on th

Re: [libvirt] udevadm settle can take too long

2012-04-23 Thread Jim Paris
Guido Günther wrote: > Hi, > On Sun, Apr 22, 2012 at 02:41:54PM -0400, Jim Paris wrote: > > Hi, > > > > http://bugs.debian.org/663931 is a bug I'm hitting, where virt-manager > > times out on the initial connection to libvirt. > > I reassigned the

[libvirt] udevadm settle can take too long

2012-04-22 Thread Jim Paris
he Debian bug report link above. -jim >From 17e5b9ebab76acb0d711e8bc308023372fbc4180 Mon Sep 17 00:00:00 2001 From: Jim Paris Date: Sun, 22 Apr 2012 14:35:47 -0400 Subject: [PATCH] shorten udevadmin settle timeout Otherwise, udevadmin settle can take so long that connections from e.g. virt-manager will get closed. ---

Re: [libvirt] heisenbug in command.c

2012-03-16 Thread Jim Paris
Serge Hallyn wrote: > On 03/16/2012 11:50 AM, Eric Blake wrote: > >On 03/16/2012 10:36 AM, Serge Hallyn wrote: > >>Hi, > >> > >>It seems I've run into quite the heisenbug, reported at > >>https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/922628 > >> > >>It manifests itself as virPidWait return

Re: [libvirt] [TCK PATCH] block devices: allow specification of size for safety

2010-05-05 Thread Jim Paris
Eric Blake wrote: > On 05/05/2010 01:31 PM, Jim Meyering wrote: > >> Can we provide the option to specify the device serial number so that > >> it's really impossible to trash the wrong device? > > > > Given that this is a good idea, next question is obviously > > how to get the serial number. On

Re: [libvirt] virtio network problems with kvm guests with 2.6.26 kernel

2009-09-29 Thread Jim Paris
Jim Paris wrote: > Daniel P. Berrange wrote: > > On Tue, Sep 29, 2009 at 02:39:59AM -0400, Jim Paris wrote: > > > Hi, > > > > > > After upgrading libvirt on one system, my kvm guests running a 2.6.26 > > > kernel with virtio networking could

Re: [libvirt] virtio network problems with kvm guests with 2.6.26 kernel

2009-09-29 Thread Jim Paris
Daniel P. Berrange wrote: > On Tue, Sep 29, 2009 at 02:39:59AM -0400, Jim Paris wrote: > > Hi, > > > > After upgrading libvirt on one system, my kvm guests running a 2.6.26 > > kernel with virtio networking could no longer communicate with the > > network. >

[libvirt] virtio network problems with kvm guests with 2.6.26 kernel

2009-09-28 Thread Jim Paris
Hi, After upgrading libvirt on one system, my kvm guests running a 2.6.26 kernel with virtio networking could no longer communicate with the network. It seems that the problem is caused by newer libvirt versions unconditionally enabling GSO support by setting IFF_VNET_HDR [1]. However, support f

Re: [libvirt] Passing -no-kvm-irqchip to KVM/QEMU guests

2009-09-13 Thread Jim Paris
Garry Dolley wrote: > Dear libvirt, > > Is there a way to tell a KVM/QEMU guest managed by libvirt to start > with the "-no-kvm-irqchip" argument? > > I have some FreeBSD 7 guests with timing issues, and if I try to > start the VMs manually with -no-kvm-irqchip, the timing issues go > away (the o

Re: [libvirt] [RFC] Support for CPUID masking

2009-09-02 Thread Jim Paris
Jiri Denemark wrote: > Hi, > > We need to provide support for CPU ID masking. Xen and VMware ESX are examples > of current hypervisors which support such masking. > > My proposal is to define new 'cpuid' feature advertised in guest > capabilities: ... > > ... > > > >

Re: [libvirt] [PATCH] remote_internal.c: don't dereference a NULL "conn"

2009-09-02 Thread Jim Paris
Daniel P. Berrange wrote: > On Wed, Sep 02, 2009 at 12:26:43PM +0200, Jim Meyering wrote: > > Daniel Veillard wrote: > > > On Wed, Sep 02, 2009 at 11:58:07AM +0200, Jim Meyering wrote: > > >> Here's the test just before the else-if in the patch below: > > >> > > >> if (conn && > > >> co

Re: [libvirt] How to get access to QEMU monitor?

2009-07-25 Thread Jim Paris
Jun Koi wrote: > Hi, > > I am running QEMU via libvirt (using virsh & virt-manager). Now I want > to get access to the monitor interface of QEMU, so I can issue some > commands to monitor. Is there anyway to do that? That isn't supported, because libvirt won't know what you've changed and can't d

Re: [libvirt] How to config my VM to use KVM with libvirt?

2009-07-21 Thread Jim Paris
Daniel P. Berrange wrote: > On Tue, Jul 21, 2009 at 09:46:17AM -0400, Jim Paris wrote: > > Speaking of this, I've noticed that > > > > > > > > hvm > > > > > > > > runs WITH kvm on an x86_64 system. Is that intended? &

Re: [libvirt] How to config my VM to use KVM with libvirt?

2009-07-21 Thread Jim Paris
Daniel P. Berrange wrote: > On Tue, Jul 21, 2009 at 05:47:15PM +0900, Jun Koi wrote: > > Hi, > > > > I have a VM running under libvirt, and it is currently run with > > -no-kvm option (I saw that in "ps" output). > > Now I want to run this VM with KVM. How can I reconfigure it for that? > > > > I

Re: [libvirt] [PATCH] qemu: Try multiple times to open unix monitor socket

2009-07-15 Thread Jim Paris
Daniel P. Berrange wrote: > On Wed, Jul 15, 2009 at 11:40:42AM +0200, Daniel Veillard wrote: > > On Tue, Jul 14, 2009 at 06:22:42PM -0400, Cole Robinson wrote: > > > Unlike the pty monitor (which we know exists since we scrape its path from > > > stdout), we have no way of knowing that the unix mon

Re: [libvirt] problems with remote authentication with policykit

2009-06-18 Thread Jim Paris
Daniel P. Berrange wrote: > On Thu, Jun 18, 2009 at 12:20:40PM -0400, Jim Paris wrote: > > I'm using Debian. I've already had to switch from the > > "netcat-traditional" package to the "netcat-openbsd" package. > > Debian does already include th

Re: [libvirt] problems with remote authentication with policykit

2009-06-18 Thread Jim Paris
Daniel P. Berrange wrote: > We close the socket to the 'nc' process here so in theory it should > be getting a HUP event from poll or EOF from read, etc and then > exiting. Ominously though I see several patches to Fedora's 'nc' > RPM at least one of which is related to nc hanging forever after >

Re: [libvirt] problems with remote authentication with policykit

2009-06-17 Thread Jim Paris
I wrote: > > Ok, this bit definitely sounds like a server side bug, unless > > perhaps there is some buffering taking place in ssh or nc > > causing the errore reply packet to not be send back promptly > > I'll try to get some better traces of what's going on here. The error is getting back to th

Re: [libvirt] problems with remote authentication with policykit

2009-06-17 Thread Jim Paris
Daniel P. Berrange wrote: > On Wed, Jun 17, 2009 at 05:51:27PM -0400, Jim Paris wrote: > > Daniel P. Berrange wrote: > > 17:34:59.360: debug : call:6947 : Doing call 70 (nil) > > 17:34:59.360: debug : call:7017 : We have the buck 70 0xbccef0 0xbccef0 > > 17:34:59.433:

Re: [libvirt] problems with remote authentication with policykit

2009-06-17 Thread Jim Paris
Daniel P. Berrange wrote: > > But when accessing remotely, I get no useful error, and a hang: > > > > $ virsh -c qemu+ssh://j...@server/system > > libvir: Remote error : authentication failed > > > > > > $ virsh --readonly -c qemu+ssh://j...@server/system > > libvir: Remote error : authenticatio

[libvirt] problems with remote authentication with policykit

2009-06-11 Thread Jim Paris
Hi, I have libvirt 0.6.4 running kvm instances on a headless server. I'm using virt-manager 0.7.0 to manage them. In the past, I would SSH in and run virt-manager as root. Since running GTK apps as root is no good, I've switched to policykit authentication. By default, the libvirt policy only

Re: [Libvirt] VNC auth per VM

2009-06-11 Thread Jim Paris
Daniel P. Berrange wrote: > > What about the VNC password? > > That's per-VM, isn't it? > > That is true by I don't really consider VNC password to be useful. It is > utterly insecure. ... Garry Dolley wrote: > With KVM/QEMU, you can set a VNC password per VM. > > But I think it is either/or tho

Re: [Libvirt] VNC auth per VM

2009-06-11 Thread Jim Paris
Daniel P. Berrange wrote: > On Mon, Jun 08, 2009 at 11:35:00AM +0200, Christian Weyermann wrote: > > Hello everybody, > > > > I encountered the following problem. I want my users to only be able to > > connect to their own virtual machines via VNC. Is there any way to do so? > > The VNC authentic

Re: [libvirt] Leaky virsh?

2009-02-05 Thread Jim Paris
ad averages: 0.36, 0.13, 0.07 > > Can you reproduce on Linux anyone? Yeah, it seems there is no limit on the size of the readline history, so it just grows forever. Try this? -jim >From a65339502c996dbeea9b6f3172a6cb8a2669f153 Mon Sep 17 00:00:00 2001 From: Jim Paris Date: Thu, 5 Feb

Re: [libvirt] [PATCH] add fullscreen support to qemu sdl xml (via fullscreen='true' attribute for the graphics element)

2008-12-10 Thread Jim Paris
Daniel P. Berrange wrote: > And in the struct > > int fullscreen : 1; unsigned int fullscreen : 1; would be better (so the possible values are 0 and 1). -jim -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] PATCH: Support initial boot time CPU affinity mask

2008-05-16 Thread Jim Paris
Daniel P. Berrange wrote: > Since we have CPU pinning support from my previous patch, adding in the > initial pinning is fairly easy. We first pass the '-S' arg to QEMU when > forking it. If -S is always added, this becomes unnecessary (qemu_conf.c:2823): if (vm->migrateFrom[0]) { if

Re: [Libvir] PATCH: Support network interface model in Xen and QEMU driver

2008-04-29 Thread Jim Paris
Daniel P. Berrange wrote: > This patch finishes off the work from Rich / Soren to support network > interface model in both Xen and QEMU drivers, and adds test cases for > the new syntax I still think our consensus from when I posted this patch last year () makes more sense ... but getting any for

Re: [Libvir] e1000 - Specifying model in XML Configs

2008-04-08 Thread Jim Paris
Henri Cook wrote: > Hi guys, > > I just tried to port a few customers over to this libvirt setup i'm > hoping to run and I couldn't get their machines started because there's > no mechanism to specify a model in the XML! > > I know redhat have changed KVM's default driver to e1000, which I think

Re: [Libvir] [PATCH] Rewrite openvzSetUUID.

2008-02-20 Thread Jim Paris
Jim Meyering wrote: > + /* Record failure if any of these fails, > +and be careful always to close the stream. */ > + if ((fseek(fp, 0, SEEK_END) < 0) > + + (fprintf(fp, "\n#UUID: %s\n", uuidstr) < 0); > + + (fclose(fp) == EOF)) > + ret = -1; I don't think

Re: [Libvir] take 2 [Re: write(2) may write less than the total requested

2008-02-20 Thread Jim Paris
Jim Meyering wrote: > It *could* perform that test, but I think it is slightly more > maintainable (no duplication of that potentially nontrivial expression) > and just as correct to check only "ret < 0". Not having the duplicated expression is certainly good, if it's correct to do so (and it seem

Re: [Libvir] take 2 [Re: write(2) may write less than the total requested

2008-02-20 Thread Jim Paris
Hi Jim, comments inline Jim Meyering wrote: > diff --git a/proxy/libvirt_proxy.c b/proxy/libvirt_proxy.c > index d96d3db..a22ba6c 100644 > --- a/proxy/libvirt_proxy.c > +++ b/proxy/libvirt_proxy.c > @@ -2,7 +2,7 @@ > * proxy_svr.c: root suid proxy server for Xen access to APIs with no > *

[Libvir] [PATCH] qemu_conf.h: Avoid dubious signed one-bit bitfield

2007-11-15 Thread Jim Paris
Signed one-bit bitfields are odd (values are 0 and -1?). The code doesn't test for == 1, so it's not currently broken, but it's fragile. (Noticed by Sparse). --- src/qemu_conf.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu_conf.h b/src/qemu_conf.h index 72e

[Libvir] [PATCH] stats_linux.c: Only include xs.h if WITH_XEN.

2007-11-15 Thread Jim Paris
Fixes compile error when building --without-xen on a host that has no Xen headers installed. --- src/stats_linux.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/stats_linux.c b/src/stats_linux.c index 5e6d06c..125af45 100644 --- a/src/stats_linux.c +++ b/src/stats_l

Re: [Libvir] Build error without Xen

2007-10-26 Thread Jim Paris
Daniel Veillard wrote: > > > Jim Paris wrote: > > > >Hi, > > > > > > > >The recent changes to src/xml.c breaks the build without xen: > > okay, fixed in CVS Yep, builds fine now, thanks. -jim -- Libvir-list mailing list Libvir-list@redhat

Re: [Libvir] read-only git mirror of libvirt CVS repository

2007-10-26 Thread Jim Paris
Jim Paris wrote: > Jim Meyering wrote: > > Thanks. I've added -k, since libvirt has at least 8 files with $Id[*], > > but don't seem to need the '-o master' -- at least not the way I'm pushing > > the result afterwards. Do you need it, with a recent

Re: [Libvir] read-only git mirror of libvirt CVS repository

2007-10-25 Thread Jim Paris
Jim Meyering wrote: > Thanks for letting me know. git's default hooks/update prohibits > pushing such unannotated tags by default, so although git-cvsimport > did create them, when I pushed the result to the public repo, they were > being denied. I've changed the corresponding config variable to

[Libvir] Build error without Xen

2007-10-25 Thread Jim Paris
Hi, The recent changes to src/xml.c breaks the build without xen: $ ./autogen.sh \ --prefix=/usr \ --mandir=\${prefix}/share/man \ --infodir=\${prefix}/share/info \ --sysconfdir=/etc \ --localstatedir=/var \ --without-xen $ make ... gcc -g -O2 -o .libs/virsh -W

Re: [Libvir] read-only git mirror of libvirt CVS repository

2007-10-25 Thread Jim Paris
"git pull" won't work if the pull would have > to merge changes to one of the modified files. FWIW, I've found this to do the right thing in that case: git fetch git rebase remotes/origin/HEAD Also, perhaps some .gitignore files could be added upstream now? Patch belo

Re: [Libvir] PATCH: Support NIC model selection for QEMU/KVM

2007-10-22 Thread Jim Paris
Daniel P. Berrange wrote: > On Mon, Oct 22, 2007 at 04:33:40PM -0400, Daniel Veillard wrote: > > On Mon, Oct 22, 2007 at 03:44:38PM -0400, Jim Paris wrote: > > > Hi, > > > > > > Sometime between kvm-36 and kvm-46 I ran into problems with the > > > def

[Libvir] [PATCH 2/5] qemu: specify nic model when invoking qemu

2007-10-22 Thread Jim Paris
Signed-off-by: Jim Paris <[EMAIL PROTECTED]> --- src/qemu_conf.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/qemu_conf.c b/src/qemu_conf.c index c463ffb..c1260ed 100644 --- a/src/qemu_conf.c +++ b/src/qemu_conf.c @@ -1738,7 +1738,8 @@ int qemudBuildComma

[Libvir] [PATCH 1/5] qemu: Add nic model to XML format.

2007-10-22 Thread Jim Paris
Signed-off-by: Jim Paris <[EMAIL PROTECTED]> --- src/qemu_conf.c | 21 + src/qemu_conf.h |2 ++ 2 files changed, 23 insertions(+), 0 deletions(-) diff --git a/src/qemu_conf.c b/src/qemu_conf.c index f3b8f4e..c463ffb 100644 --- a/src/qemu_conf.c +++ b/src/qemu_

[Libvir] [PATCH 3/5] docs: Fix typo in QEMU network examples

2007-10-22 Thread Jim Paris
Signed-off-by: Jim Paris <[EMAIL PROTECTED]> --- docs/format.html |8 docs/libvir.html |8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/format.html b/docs/format.html index efdbcde..8a519af 100644 --- a/docs/format.html +++ b/docs/forma

[Libvir] [PATCH 5/5] docs: Document nic model options for qemu

2007-10-22 Thread Jim Paris
Signed-off-by: Jim Paris <[EMAIL PROTECTED]> --- docs/format.html |9 +++-- docs/libvir.html | 13 +++-- 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/docs/format.html b/docs/format.html index 5553d10..d73adb1 100644 --- a/docs/format.html +++

[Libvir] [PATCH 4/5] docs: Remove duplicated qemu bridge example

2007-10-22 Thread Jim Paris
Signed-off-by: Jim Paris <[EMAIL PROTECTED]> --- docs/format.html |6 +- docs/libvir.html |6 +- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/docs/format.html b/docs/format.html index 8a519af..5553d10 100644 --- a/docs/format.html +++ b/docs/forma

[Libvir] PATCH: Support NIC model selection for QEMU/KVM

2007-10-22 Thread Jim Paris
Hi, Sometime between kvm-36 and kvm-46 I ran into problems with the default QEMU network card (ne2k-pci). Switching it fixed the problems, but libvirt doesn't support changing the NIC model. These patches add support for: which becomes qemu -net nic,model=rtl8139,mac=... By defau

Re: [Libvir] Problem to compile virt-manager in debian etch

2007-10-19 Thread Jim Paris
Marco Sinhoreli wrote: > Hello Jim, > On 10/19/07, Jim Paris <[EMAIL PROTECTED]> wrote: > > > Virt-manager is compiled from mercurial tree but it isn't working. I > > > don't know why. After run the virt-manager command, it was finished > > > witho

Re: [Libvir] Problem to compile virt-manager in debian etch

2007-10-18 Thread Jim Paris
> Virt-manager is compiled from mercurial tree but it isn't working. I > don't know why. After run the virt-manager command, it was finished > without output error and the window wasn't created. If you need more > informations about ask me what informations I should sent. I ran into that too -- ma

Re: [Libvir] PATCH: Implement CDROM media change for QEMU/KVM driver

2007-10-15 Thread Jim Paris
Jim Paris wrote: > Richard W.M. Jones wrote: > > Richard W.M. Jones wrote: > > >+strcat(cmd, newdisk->src); > > > > Also, is quoting/escaping required? In a naive libvirt-based app, it's > > plausible that the string is provided by the user

[Libvir] [PATCH] qemu: add qemudEscapeArg

2007-10-15 Thread Jim Paris
--- src/qemu_driver.c | 30 +++--- 1 files changed, 23 insertions(+), 7 deletions(-) diff --git a/src/qemu_driver.c b/src/qemu_driver.c index c9cecc0..671b334 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -1905,7 +1905,7 @@ static int qemudDomainGetInfo(virDo

Re: [Libvir] PATCH: Implement CDROM media change for QEMU/KVM driver

2007-10-15 Thread Jim Paris
Richard W.M. Jones wrote: > Richard W.M. Jones wrote: > >+strcat(cmd, newdisk->src); > > Also, is quoting/escaping required? In a naive libvirt-based app, it's > plausible that the string is provided by the user and could contain \n > to send arbitrary commands to the qemu console. Agreed.

Re: [Libvir] PATCH: Implement CDROM media change for QEMU/KVM driver

2007-10-15 Thread Jim Paris
Richard W.M. Jones wrote: > +char *cmd; > +char *reply; > +/* XXX QEMU only supports a single CDROM for now */ > +/*cmd = malloc(strlen("change ") + strlen(olddisk->dst) + 1 + > strlen(newdisk->src) + 2);*/ > +cmd = malloc(strlen("change ") + strlen("cdrom") + 1 + > strlen(new

Re: [Libvir] PATCH: Implement CDROM media change for QEMU/KVM driver

2007-10-13 Thread Jim Paris
Hi Dan, That's definitely be a useful feature. Some comments... > @@ -453,7 +454,7 @@ static int qemudOpenMonitor(virConnectPt > char buf[1024]; > int ret = -1; > > -if (!(monfd = open(monitor, O_RDWR))) { > +if (!(monfd = open(monitor, O_NOCTTY |O_RDWR))) { Is this just to

Re: [Libvir] how to setup usb/serial ports with libvirt & kvm (Fedora 7)

2007-10-11 Thread Jim Paris
John Davey wrote: > I am experimenting with the following Redhat 9 kvm on Fedora 7. > > How do I add a USB device with Libvirt? Specifically I'd like to add a > usb-serial converter for logging data. "Man qemu-kvm" shows -usbdevice > devname to add a USB device but I cannot find out how to do th

[Libvir] [PATCH] qemu: reset migration source if restore fails

2007-10-09 Thread Jim Paris
With the latest KVM I'm having some issues with save/restore, but I think it's a kvm issue and not libvirt. The problems did expose a libvirt bug, though; patch below. -jim --- A failed restore of a configured VM would leave the migration source set incorrectly, preventing the VM from being sta

Re: [Libvir] [PATCH 0/7] QEMU/KVM save/restore support, take 3

2007-08-13 Thread Jim Paris
Sorry, I'm still trying to learn these tools ... those subjects weren't numbered. The order should be: Subject: [PATCH 1/7] Fix issues with QEMU monitor interface. Subject: [PATCH 2/7] Add option to pass stdin fd to virExec Subject: [PATCH 3/7] Add migration support to QEMU startup. Subject: [PA

[Libvir] [PATCH] Add signal-safe read/write wrappers

2007-08-13 Thread Jim Paris
Adds saferead() and safewrite(), which are like read() and write() except that they retry in case of EINTR. Signed-off-by: Jim Paris <[EMAIL PROTECTED]> --- src/util.c | 37 + src/util.h |2 ++ 2 files changed, 39 insertions(+), 0 deletions(-)

[Libvir] [PATCH] Add migration support to QEMU startup.

2007-08-13 Thread Jim Paris
Adds new fields in qemu_vm structure. vm->migrateFrom specifies the argument to "-incoming". vm->stdin specifies the file descriptor to pass to virExec as stdin, which will be used for the "-incoming stdio" case. Signed-off-by: Jim Paris <[EMAIL PROTECTED]&g

[Libvir] [PATCH] Add KVM restore support using migration.

2007-08-13 Thread Jim Paris
Signed-off-by: Jim Paris <[EMAIL PROTECTED]> --- src/qemu_driver.c | 113 +++-- 1 files changed, 109 insertions(+), 4 deletions(-) diff --git a/src/qemu_driver.c b/src/qemu_driver.c index f2c4316..b0b6d62 100644 --- a/src/qemu_driver.c +++

[Libvir] [PATCH] Add KVM save support using migration.

2007-08-13 Thread Jim Paris
The save file format consists of a header, XML for the domain, and the raw QEMU/KVM migration data stream. Signed-off-by: Jim Paris <[EMAIL PROTECTED]> --- src/qemu_driver.c | 112 ++-- 1 files changed, 107 insertions(+), 5 deletions(-)

[Libvir] [PATCH 0/7] QEMU/KVM save/restore support, take 3

2007-08-13 Thread Jim Paris
Here's take 3 of the QEMU/KVM save/restore support. Thanks for your input. Changes since last time: - Remove escape sequence filtering, it's not necessary. - Clean up stdin handling in virExec, use -1 to signify unused - Add signal-safe read/write wrappers that handle EINTR and use them. - Ad

[Libvir] [PATCH] Add qemudEscapeShellArg for passing commandlines to qemu.

2007-08-13 Thread Jim Paris
itself. Signed-off-by: Jim Paris <[EMAIL PROTECTED]> --- src/qemu_driver.c | 66 + 1 files changed, 66 insertions(+), 0 deletions(-) diff --git a/src/qemu_driver.c b/src/qemu_driver.c index e649060..8125622 100644 --- a/src/qemu_dr

[Libvir] [PATCH] Add option to pass stdin fd to virExec

2007-08-13 Thread Jim Paris
If non-negative, uses the supplied fd instead of /dev/null. Update callers accordingly. Signed-off-by: Jim Paris <[EMAIL PROTECTED]> --- src/openvz_driver.c |4 ++-- src/qemu_driver.c |5 +++-- src/util.c | 12 ++-- src/util.h |4 ++-- 4 files c

[Libvir] [PATCH] Fix issues with QEMU monitor interface.

2007-08-13 Thread Jim Paris
mpt is printed twice. Switch all monitor commands to end with "\r" which avoids both issues. Signed-off-by: Jim Paris <[EMAIL PROTECTED]> --- src/qemu_driver.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu_driver.c b/src/qemu_driver.c index b05c

[Libvir] Re: [PATCH 3/7] Add option to pass stdin fd to virExec

2007-08-13 Thread Jim Paris
Daniel P. Berrange wrote: > > > If nonzero, uses the supplied fd instead of /dev/null. > > > Update callers accordingly. > > > > Looks fine to me, we already have stdout and stderr, it's sensible. +1 > > Looks OK, but shouldn't we use -1 as the magic value here, since 0 is also > a valid file d

[Libvir] Re: [PATCH 2/7] Fix issues with QEMU monitor interface.

2007-08-13 Thread Jim Paris
Daniel Veillard wrote: > > +/* Copy data, skipping 3-byte escape sequences */ > > +for (i = 0; i < got; i++) { > > +if (data[i] == '\033') > > +skip = 3; > > +if (skip) > > +skip--; > > +

[Libvir] [PATCH 7/7] Add KVM restore support using migration.

2007-08-12 Thread Jim Paris
Signed-off-by: Jim Paris <[EMAIL PROTECTED]> --- src/qemu_driver.c | 106 +++-- 1 files changed, 102 insertions(+), 4 deletions(-) diff --git a/src/qemu_driver.c b/src/qemu_driver.c index 50ab702..c6de8a0 100644 --- a/src/qemu_driver.c +++

[Libvir] [PATCH 6/7] Add KVM save support using migration.

2007-08-12 Thread Jim Paris
The save file format consists of a header, XML for the domain, and the raw QEMU/KVM migration data stream. Signed-off-by: Jim Paris <[EMAIL PROTECTED]> --- src/qemu_driver.c | 109 ++--- 1 files changed, 103 insertions(+), 6 deletions(-)

[Libvir] [PATCH 3/7] Add option to pass stdin fd to virExec

2007-08-12 Thread Jim Paris
If nonzero, uses the supplied fd instead of /dev/null. Update callers accordingly. Signed-off-by: Jim Paris <[EMAIL PROTECTED]> --- src/openvz_driver.c |4 ++-- src/qemu_driver.c |5 +++-- src/util.c | 12 ++-- src/util.h |4 ++-- 4 files chang

[Libvir] [PATCH 2/7] Fix issues with QEMU monitor interface.

2007-08-12 Thread Jim Paris
u) ". Fix the issue by filtering out these sequences when they are received. Signed-off-by: Jim Paris <[EMAIL PROTECTED]> --- src/qemu_driver.c | 21 - 1 files changed, 16 insertions(+), 5 deletions(-) diff --git a/src/qemu_driver.c b/src/qemu_driver.c index b0

[Libvir] [PATCH 4/7] Add migration support to QEMU startup.

2007-08-12 Thread Jim Paris
Adds new fields in qemu_vm structure. vm->migrateFrom specifies the argument to "-incoming". vm->stdinFd specifies the file descriptor to pass to virExec as stdin, which will be used for the "-incoming stdio" case. Signed-off-by: Jim Paris <[EMAIL PROTECTED]&g

[Libvir] [PATCH 5/7] Add qemudEscapeShellArg for passing commandlines to qemu.

2007-08-12 Thread Jim Paris
itself. Signed-off-by: Jim Paris <[EMAIL PROTECTED]> --- src/qemu_driver.c | 66 + 1 files changed, 66 insertions(+), 0 deletions(-) diff --git a/src/qemu_driver.c b/src/qemu_driver.c index e487640..5d310fe 100644 --- a/src/qemu_dr

[Libvir] [PATCH 1/7] Fix memory leak

2007-08-12 Thread Jim Paris
Signed-off-by: Jim Paris <[EMAIL PROTECTED]> --- src/qemu_driver.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/qemu_driver.c b/src/qemu_driver.c index 7c75d9c..b05c3f6 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -204,6 +204,7 @@ qemudStartu

Re: [Libvir] save/restore support for KVM

2007-08-12 Thread Jim Paris
Hi Daniel, Thanks for the quick reply. Things seem to be working well now, Main changes from last time: - Fixed issues with the QEMU monitor interface: - Due to the TTY layer, sending "\n" to the qemu monitor translates into "\r\n" when received. This triggers a bug in older versions

Re: [Libvir] save/restore support for KVM

2007-08-11 Thread Jim Paris
Daniel Veillard wrote: > On Fri, Aug 10, 2007 at 12:36:05PM -0400, Jim Paris wrote: > > I think appending unrelated data to the migration image is a bit of a > > hack anyway. A better plan would be a file containing > > > > Hum, beware you then need to make su

Re: [Libvir] save/restore support for KVM

2007-08-10 Thread Jim Paris
Daniel Veillard wrote: > On Thu, Aug 09, 2007 at 10:55:10PM +0100, Daniel P. Berrange wrote: > > Just been committed to KVM repos I see. Should be an easy patch to backport > > too. As long as we can detect failure if this is missing & report it back > > then I'm fine depending on this. > > Wou

Re: [Libvir] save/restore support for KVM

2007-08-10 Thread Jim Paris
Richard W.M. Jones wrote: > Jim Paris wrote: > >+if (strchr(path, '\'') || strchr(path, '\\') ) { > >+qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_FAILED, > >+ "invalid filename"); > >

[Libvir] save/restore support for KVM

2007-08-09 Thread Jim Paris
lso add put it in qemu_vm_def, or add parameters to qemudStartVMDaemon, etc.. Patch against current CVS is below. Signed-off-by: Jim Paris <[EMAIL PROTECTED]> -jim Index: src/qemu_conf.c === RCS file: /data/cvs/libvirt/s