Re: [PATCHv2 1/3] Share Dup Daemon Function *SetupLogging

On Mar 11, 2020 9:30 AM, Ján Tomko wrote: On a Sunday in 2020, Lan wrote: >One of the BiteSizedTasks > >Introduce src/util/virdaemon.c/h files > >Introduce a new function virDaemonSetupLogging (src/util/virdaemon.c) >for shared code in >virLockDaemonSetupLogging (src/

[PATCHv2 3/3] Passing virDaemonLogConfig to DaemonSetupLogging

Passing virDaemonLogConfig to the shared function DaemonSetupLogging instead of passing *DaemonConfig to *SetupLogging functions Signed-off-by: Lan Bai --- src/libvirt_private.syms | 2 ++ src/locking/lock_daemon.c | 12 ++-- src/logging/log_daemon.c | 14 -- src

[PATCHv2 1/3] Share Dup Daemon Function *SetupLogging

/remote_daemon.c) Introduce virDaemonLogConfig struct for config->log_* variables in virLockDaemonConfig/virLogDaemonConfig/daemonConfig struct Signed-off-by: Lan Bai --- src/libvirt_private.syms | 2 + src/locking/lock_daemon.c | 58 ++--- src/logging/log_daemon.c |

[PATCHv2 2/3] Alloc and Free virDaemonLogConfig

Introduce New functions virDaemonLogConfigNew/virDaemonLogConfigFree for alloc and free virDaemonLogConfig Signed-off-by: Lan Bai --- src/util/Makefile.inc.am | 2 +- src/util/virdaemon.c | 26 ++ src/util/virdaemon.h | 11 +++ 3 files changed, 38

[PATCHv2 0/3] Share duplicated daemon code in *SetupLogging functions

to alloc and free the new struct virDaemonLogConfig. Commit 3: Passing virDaemonLogConfig to DaemonSetupLogging Convert all the callers that now pass virDaemonLogConfig to the new function virDaemonSetupLogging. Lan (3): Share Dup Daemon Function *SetupLogging Alloc and Free

[PATCH] Share Dup Daemon Function *SetupLogging

Create a new function virDaemonSetupLogging (src/util/virdaemon.c) for shared code in virLockDaemonSetupLogging (src/locking/lock_daemon.c) virLogDaemonSetupLogging (src/logging/log_daemon.c) daemonSetupLogging (src/remote/remote_daemon.c) One of the BiteSizedTasks --- src/libvirt_private.syms