Re: [libvirt] boot time delay for domains?

2010-12-22 Thread Maximilian Wilhelm
Anno domini 2010 Paweł Krześniak scripsit: > # cat > /usr/bin/local/qemu-kvm-with-random-delay > #!/bin/bash > # delay running of virtual machine by 0-9 seconds > sleep $(( $RANDOM % 10 )) > exec /usr/bin/qemu-kvm $* > ^D When using $* you might lose quoting of parameters. exec /usr/bin/qemu-kv

Re: [libvirt] [PATCH] esx: Use MD5 sum of mount path as storage pool UUID

2010-08-11 Thread Maximilian Wilhelm
Anno domini 2010 Matthias Bolte scripsit: [...] > There is another "problem" with the approach of using the mount path > hash as UUID. In case of a Windows based GSX server you can use CIFS > shares as datastores addressed via UNC paths like \\nas\share. If you > have multiple GSX server sharing t

Re: [libvirt] Host IP Address

2010-06-24 Thread Maximilian Wilhelm
Anno domini 2010 Daniel P. Berrange scripsit: > Never use gethostbyname in any new code. It is long since obsolete, not > thread safe and is hardcoded to only work with IPv4. > There is a good exmaple of how to use the modern replacemenbt, getaddrinfo(), > to resolve hostnames here: > http://pe

Re: [libvirt] Host IP Address

2010-06-23 Thread Maximilian Wilhelm
Anno domini 2010 IKI-サガル バルウェ scripsit: Hi! > Thanks for such a quick reply. No problem :) >> Did I get you right, that you have a 'virDomainPtr' as basis and want a >> mapping >> from that to the IP? > Yes. Thats what I want to do. >> I guess one way could be to get the virConnectionPtr >> c

Re: [libvirt] Host IP Address

2010-06-22 Thread Maximilian Wilhelm
Anno domini 2010 IKI-サガル バルウェ scripsit: Hi! > I was trying to figure out a way to get the IP Address of the host, in which > a particular VM is running using the LibvirtAPI. For Eg.; If I have a VM > object, then I would like to fetch the IP Address of the host in which this > VM is running, prog

Re: [libvirt] Just to make sure I understand the API

2010-01-11 Thread Maximilian Wilhelm
Anno domini 2010 Daniel P. Berrange scripsit: Hi! [...] > > Yes, that's the correct behavior of these functions. > > virConnectListDefinedDomains list domains that are inactive but > > defined and virConnectListDomains lists domains that are active. > > If you combine the output of both function

Re: [libvirt] stat() vs. access()

2009-11-16 Thread Maximilian Wilhelm
Anno domini 2009 Daniel P. Berrange scripsit: > > While discussing some code with Matthias, we stumbled across many occurances > > of stat() calls within the libVirt code (virFileExists() for example) which > > could be implemented in a cheaper way when using access() instead of stat(), > > when t

[libvirt] stat() vs. access()

2009-11-07 Thread Maximilian Wilhelm
Hi! While discussing some code with Matthias, we stumbled across many occurances of stat() calls within the libVirt code (virFileExists() for example) which could be implemented in a cheaper way when using access() instead of stat(), when the only purpose is to check for the existance of a file.

Re: [libvirt] Re: [PATCH] Implement finer grained migration control for Xen

2009-10-17 Thread Maximilian Wilhelm
Anno domini 2009 Chris Lalancette scripsit: > > Attached you can find a patch implementing the same flags for Xen: > > * src/xen/xen_driver.c: Add support for VIR_MIGRATE_PERSIST_DEST flag > > * src/xen/xend_internal.c: Add support for VIR_MIGRATE_UNDEFINE_SOURCE flag > > I'm not totaly sure i

Re: [libvirt] Re: [PATCH] Implement finer grained migration control for Xen

2009-10-14 Thread Maximilian Wilhelm
Anno domini 2009 Chris Lalancette scripsit: [...] > > I'm not totaly sure if there are better ways to handle all the error > > cases. The current solution seemed to be a same one for me. > Well, I do think that we need to return a proper error in all cases except for > the one with the long comme

[PATCH] Implement finer grained migration control for Xen (was: Re: [libvirt] [PATCH] Finer grained migration control)

2009-10-13 Thread Maximilian Wilhelm
Anno domini 2009 Daniel Veillard scripsit: > On Mon, Oct 12, 2009 at 01:32:26PM +0200, Chris Lalancette wrote: > > Normally, when you migrate a domain from host A to host B, > > the domain on host A remains defined but shutoff and the domain > > on host B remains running but is a "transient". Add

Migration procedure (was: Re: [libvirt] Safe? /etc/libvirt/qemu on shared storage?)

2009-10-03 Thread Maximilian Wilhelm
Anno domini 2009 Chris Lalancette scripsit: Hi! [...] > Currently, the migration code assumes that you want to leave the migrated > guest > defined but not running on the "source" of the migration, and that you want to > leave it running but not defined (transient) on the "destination" of the >

Re: [libvirt] [PATCH] Automagically check if libssh2 is new enough for Phyp-support to be build

2009-09-09 Thread Maximilian Wilhelm
Anno domini 2009 Daniel Veillard scripsit: > On Fri, Sep 04, 2009 at 02:45:57PM +0200, Maximilian Wilhelm wrote: > > Hi! > > > > My buildbot spotted a problem with the latest changes to Phyp, as the > > function libssh2_session_block_directions() only is available w

Re: [libvirt] [PATCH] Automagically check if libssh2 is new enough for Phyp-support to be build

2009-09-08 Thread Maximilian Wilhelm
Anno domini 2009 Maximilian Wilhelm scripsit: Hi! > My buildbot spotted a problem with the latest changes to Phyp, as the > function libssh2_session_block_directions() only is available with > libssh2 version 1.0 and later. > At least on Debian Lenny there is an older one which prev

[libvirt] [PATCH] Automagically check if libssh2 is new enough for Phyp-support to be build

2009-09-04 Thread Maximilian Wilhelm
Hi! My buildbot spotted a problem with the latest changes to Phyp, as the function libssh2_session_block_directions() only is available with libssh2 version 1.0 and later. At least on Debian Lenny there is an older one which prevents libVirt from building, so I updated the configure.in script to

Re: [libvirt] [PATCH 11/20] Add volume encryption information handling.

2009-09-01 Thread Maximilian Wilhelm
Anno domini 2009 Miloslav Trmač scripsit: > diff --git a/src/storage_encryption.c b/src/storage_encryption.c > new file mode 100644 > index 000..ccb29ed > --- /dev/null > +++ b/src/storage_encryption.c > @@ -0,0 +1,241 @@ [...] > +#include "base64.h" [...] Is there any special need for this

Re: [libvirt] [PATCH] Workaround for broken GCC in Debian Etch

2009-08-02 Thread Maximilian Wilhelm
Anno domini 2009 Daniel P. Berrange scripsit: > > I missed one patch for working around a GCC bug in Debian Etch > > regarding limit definitions. > > Sorry for the unstripped git-format-patch outputs, I just realised > > this after pressing send :( > > (This seems to be not my day :)) > Since i

[libvirt] [PATCH] Workaround for broken GCC in Debian Etch

2009-07-30 Thread Maximilian Wilhelm
Hi again! I missed one patch for working around a GCC bug in Debian Etch regarding limit definitions. Sorry for the unstripped git-format-patch outputs, I just realised this after pressing send :( (This seems to be not my day :)) Ciao Max -- Gib Dein Bestes. Dann übertriff Dich selbst! * src/s

[libvirt] [PATCH] Add some automatic dependency checks for configure to enable/disable {ESX, UML, LXC, Xen-Inotify}

2009-07-30 Thread Maximilian Wilhelm
again :) Find four patches attached. Ciao Max -- Fortschritt bedeutet, einen Schritt so zu machen, daß man den nächsten auch noch machen kann. >From e198b3ed1fcfa68465a31d75192a901fc72b2c14 Mon Sep 17 00:00:00 2001 From: Maximilian Wilhelm Date: Thu, 30 Jul 2009 20:18:30 +0200 Subject

Re: [libvirt] Fix -Werror build error regarding to '#ifdef IFF_VNET_HDR'

2009-07-30 Thread Maximilian Wilhelm
Anno domini 2009 Daniel Veillard scripsit: Hi! > > Our build bot found a build error when building libVirt with -Werror > > introduced in > > b4f62abbf1191c8fbab3306b4bf2f2567e18067f > > kvm/virtio: Set IFF_VNET_HDR when setting up tap fds > > The attached patch kind of fixes the build error

[libvirt] Fix -Werror build error regarding to '#ifdef IFF_VNET_HDR'

2009-07-30 Thread Maximilian Wilhelm
Hi! Our build bot found a build error when building libVirt with -Werror introduced in b4f62abbf1191c8fbab3306b4bf2f2567e18067f kvm/virtio: Set IFF_VNET_HDR when setting up tap fds The attached patch kind of fixes the build error but I'm not sure, if this is the final solution for this proble

Anybondy interested in libVirt build daemon status mails? (was: Re: [libvirt] [PATCH] [v2] Support kvm-img or qemu-img dynamically)

2009-06-12 Thread Maximilian Wilhelm
Anno domini 2009 Matthias Bolte scripsit: > 2009/6/10 Doug Goldstein : > > This patch adds a new function virFindFileInPath() and uses it to find > > where a binary lives in the PATH environment variable. [...] > +char *virFindFileInPath(const char *file) > +{ [...] > +} > GCC (version 4.3.3 her

[libvirt] Checkpoint VMs

2009-06-08 Thread Maximilian Wilhelm
Hi! Some months ago there were some mails about ideas of adding new API functions for checkpointing of domains. For the project group Virtualized SuperComputer (the crazy guys with the ESX driver) we would like to have such a feature and would be willing to propose API patches and anything the li

Re: [libvirt] 802.1q vlan-tagging support for libvirt

2009-04-08 Thread Maximilian Wilhelm
Anno domini 2009 Daniel P. Berrange scripsit: > On Wed, Apr 08, 2009 at 01:06:48PM +0200, Maximilian Wilhelm wrote: > > Anno domini 2009 Daniel P. Berrange scripsit: That was a *really* _fast_ reply :) > > [...] > > > In the (nearish) future NICs will sta

Re: [libvirt] 802.1q vlan-tagging support for libvirt

2009-04-08 Thread Maximilian Wilhelm
Anno domini 2009 Daniel P. Berrange scripsit: [...] > In the (nearish) future NICs will start appearing with SR-IOV capabilities. > This gives you one physical PCI device, whcih exposes multiple functions. > So a single physical NIC appears as 8 NICs to the OS. You can thus directly > assign each

Re: [libvirt] Fix compile errors in 'safezero()' functions in util.c

2009-03-20 Thread Maximilian Wilhelm
Anno domini 2009 Daniel Veillard scripsit: Hi! > > Fix compile errors in 'safezero()' functions in util.c > > Commit 70e7672184ff639856d5f2f3bf7849464031dff9 introduced some > > compile errors because of the unsued 'flags' parameter in all three > > version of the 'safezero()' function. >

[libvirt] Fix compile errors in 'safezero()' functions in util.c

2009-03-20 Thread Maximilian Wilhelm
Hi! Fix compile errors in 'safezero()' functions in util.c Commit 70e7672184ff639856d5f2f3bf7849464031dff9 introduced some compile errors because of the unsued 'flags' parameter in all three version of the 'safezero()' function. Signed-Off-By: Maximilian

Re: [libvirt] [PATCH] Remove invalid ATTRIBUTE_UNUSED

2009-02-17 Thread Maximilian Wilhelm
it 4upstream Ciao Max -- Follow the white penguin. >From d6aba6d85d1d3812e4bb5a6c0cbbc9c162e0c2c9 Mon Sep 17 00:00:00 2001 From: Maximilian Wilhelm Date: Wed, 18 Feb 2009 01:53:12 +0100 Subject: [PATCH] Fix compile error in qemu_driver.c / qemudDomainCreate() The unused attribute fi

Re: [libvirt] [PATCH 1/4] fix problem with MKDIR_P vs mkdir_p

2009-02-14 Thread Maximilian Wilhelm
Anno domini 2009 Jim Meyering scripsit: > Maximilian Wilhelm wrote: > > configure defines mkdir_p but src/Makefile.am uses MKDIR_P > > --- > > src/Makefile.am |2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/src/Makefile

[libvirt] [PATCH 2/4] Build fix for 'bridge.c' if 'IFF_VNET_HDR' is disabled.

2009-02-13 Thread Maximilian Wilhelm
The function 'brProbeVnetHdr()' added in commit b14bf853b4b0c3479d13c4842cea6faa3414c834 does not use the 'tapfd' parameter. gcc does not like that. Make it happy. Signed-off-by: Maximilian Wilhelm --- src/bridge.c |2 +- 1 files changed, 1 insertions(+),

[libvirt] [PATCH 3/4] Build fix for 'driver.c' when building with loadable modules

2009-02-13 Thread Maximilian Wilhelm
The 'asprintf' -> 'virAsprintf' transition made in commit 9e5d9950a1c5069d3cc908a7316d86a2d501d8a9 introducted a build error for 'driver.c' as 'util.h' has to be included. Signed-off-by: Maximilian Wilhelm --- src/driver.c |1 + 1 files cha

[libvirt] [PATCH 1/4] fix problem with MKDIR_P vs mkdir_p

2009-02-13 Thread Maximilian Wilhelm
From: Matthias Bolte configure defines mkdir_p but src/Makefile.am uses MKDIR_P --- src/Makefile.am |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 9d934b4..eff9039 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -589,6 +589

[libvirt] [PATCH 4/4] Workarounded 'virGetVersion' build problem

2009-02-13 Thread Maximilian Wilhelm
The 'getVer' fix introducted in 02a72b420670718640d9abf0e07f2b1cca7b4d2b breaks compiling libvirt with loadable module support. Work around this to get it building again. Signed-off-by: Maximilian Wilhelm --- src/libvirt.c |7 +++ 1 files changed, 7 insertions(+), 0