ken out of virNetDevGetPhysicalFunction() and moved
> > to calling function virNetDevGetVirtualFunctionInfo()
> > - curly braces removed from single line
> > - net-> model check removed as STREQ_NULLABLE() follows
> >
> > [*]
> https://www.redhat.com/archives/libvir-list/
assigned to VNIC.
Signed-off-by: Radoslaw Biernacki
---
src/util/virnetdev.c | 22 ++--
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c
index 5867977df4..f1c2ba8c17 100644
--- a/src/util/virnetdev.c
+++ b/src/util
Removing redundant sections of the code
Signed-off-by: Radoslaw Biernacki
Reviewed-by: Michal Privoznik
---
src/util/virnetdev.c | 40 +++-
1 file changed, 5 insertions(+), 35 deletions(-)
diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c
index f1c2ba8c17..9318de406c
On Thu, 15 Nov 2018 at 12:23, Michal Privoznik wrote:
> On 11/10/2018 01:56 PM, Radoslaw Biernacki wrote:
> > The device xml parser code does not set "model" while parsing
> >
> >
> > function='0x2'/>
> >
> >
> > v
as STREQ_NULLABLE() follows
Radoslaw Biernacki (4):
util: fixing wrong assumption that PF has to have netdev assigned
util: Code simplification
util: Fix for NULL dereference
util: Fixing invalid error checking from virPCIGetNetname()
src/qemu/qemu_domain_address.c | 13 ++--
src/u
linkdev is In/Out function parameter as second order reference pointer
so requires first order dereference for checking NULLs which can be a
result from virPCIGetNetName()
Fixes: d6ee56d7237 (util: change virPCIGetNetName() to not return error if
device has no net name)
Signed-off-by: Radoslaw
On Thu, 15 Nov 2018 at 12:23, Michal Privoznik wrote:
> On 11/10/2018 01:56 PM, Radoslaw Biernacki wrote:
> > libvirt wrongly assumes that VF netdev has to have the
> > netdev assigned to PF. There is no such requirement in SRIOV standard.
> > This patch change the virN
d
"def->sounds[i]" with "sound")
Fixes: c7fc151eec7 (qemu: assign virtio devices to PCIe slot when appropriate)
Signed-off-by: Radoslaw Biernacki
Reviewed-by: Michal Privoznik
---
src/qemu/qemu_domain_address.c | 13 +
1 file changed, 5 insertions(+), 8 deleti
This patch breaks the error return value for:
virDomainControllerDefFormat()
virDomainSoundDefFormat()
virDomainMemballoonDefFormat()
Patch adds the "ret" variable but in error exit it use "return 0" statement.
Actually this breaks compilation.
Was this code compiled ?
conf/domain_conf.c: In func
linkdev is In/Out function parameter as second order reference pointer
so requires first order dereference for checking NULLs which can be a
result from virPCIGetNetName()
Fixes: d6ee56d7237 (util: change virPCIGetNetName() to not return error if
device has no net name)
Signed-off-by: Radoslaw
details about those issues can be found at:
https://bugs.linaro.org/show_bug.cgi?id=3778
https://bugs.launchpad.net/charm-nova-compute/+bug/1771662
Radoslaw Biernacki (4):
util: fixing wrong assumption that PF has to have netdev assigned
util: Code simplification
util: Fix for NULL dereference
Removing redundant sections of the code
Signed-off-by: Radoslaw Biernacki
---
src/util/virnetdev.c | 40 +++-
1 file changed, 5 insertions(+), 35 deletions(-)
diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c
index e55c538a29..117ec41869 100644
--- a/src/util/virnetdev.c
.
One example of such devices is ThunderX VNIC.
By applying this change, VF device is used for virNetlinkCommand() as
it is the only netdev assigned to VNIC.
Signed-off-by: Radoslaw Biernacki
---
src/util/virnetdev.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a
d
"def->sounds[i]" with "sound")
Fixes: c7fc151eec7 (qemu: assign virtio devices to PCIe slot when appropriate)
Signed-off-by: Radoslaw Biernacki
---
src/qemu/qemu_domain_address.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/src/qem
14 matches
Mail list logo