Re: [PULL 00/25] Migration 20230726 patches

2023-07-26 Thread Richard Henderson
On 7/26/23 05:14, Juan Quintela wrote: The following changes since commit 6cb2011fedf8c4e7b66b4a3abd6b42c1bae99ce6: Update version for v8.1.0-rc1 release (2023-07-25 20:09:05 +0100) are available in the Git repository at: https://gitlab.com/juan.quintela/qemu.git tags/migration-2023072

Re: [RFC PATCH-for-8.1] accel: Remove HAX accelerator

2023-06-26 Thread Richard Henderson
de 100644 target/i386/hax/hax-accel-ops.c delete mode 100644 target/i386/hax/hax-all.c delete mode 100644 target/i386/hax/hax-mem.c delete mode 100644 target/i386/hax/hax-posix.c delete mode 100644 target/i386/hax/hax-windows.c delete mode 100644 target/i386/hax/meson.build Reviewed-by: Richard Henderson r~

Re: [PATCH v4 10/10] accel/tcg: include cs_base in our hash calculations

2023-05-23 Thread Richard Henderson
On 5/23/23 05:50, Alex Bennée wrote: static inline uint32_t qemu_xxhash5(uint64_t ab, uint64_t cd, uint32_t e) { -return qemu_xxhash7(ab, cd, e, 0, 0); +return qemu_xxhash8(ab, cd, e, 0, 0); } static inline uint32_t qemu_xxhash6(uint64_t ab, uint64_t cd, uint32_t e,

Re: [PATCH v3 10/10] hmp: Deprecate 'singlestep' member of StatusInfo

2023-04-18 Thread Richard Henderson
date the iotests that use the command. (We will when we eventually drop the deprecated member.) --- docs/about/deprecated.rst | 14 ++ qapi/run-state.json | 14 +++--- 2 files changed, 25 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v3 07/10] accel/tcg: Report one-insn-per-tb in 'info jit', not 'info status'

2023-04-18 Thread Richard Henderson
utput currently only has one item, but it would be a place to put other stuff, eg if we wanted to mention whether split-wx is enabled. --- accel/tcg/monitor.c | 14 ++ softmmu/runstate-hmp-cmds.c | 5 ++--- 2 files changed, 16 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v3 03/10] accel/tcg: Use one_insn_per_tb global instead of old singlestep global

2023-04-18 Thread Richard Henderson
1 - linux-user/main.c | 1 - softmmu/globals.c | 1 - 7 files changed, 7 insertions(+), 8 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v3 03/10] accel/tcg: Use one_insn_per_tb global instead of old singlestep global

2023-04-18 Thread Richard Henderson
On 4/17/23 18:40, Peter Maydell wrote: @@ -219,8 +221,8 @@ static void tcg_set_one_insn_per_tb(Object *obj, bool value, Error **errp) { TCGState *s = TCG_STATE(obj); s->one_insn_per_tb = value; -/* For the moment, set the global also: this changes the behaviour */ -singlest

Re: [PATCH v2 03/10] tcg: Use one-insn-per-tb accelerator property in curr_cflags()

2023-04-13 Thread Richard Henderson
On 4/13/23 18:24, Peter Maydell wrote: On Mon, 3 Apr 2023 at 19:33, Richard Henderson wrote: On 4/3/23 07:46, Peter Maydell wrote: uint32_t curr_cflags(CPUState *cpu) { uint32_t cflags = cpu->tcg_cflags; +TCGState *tcgstate = TCG_STATE(current_accel()); As mentio

Re: [PATCH v2 09/10] qapi/run-state.json: Fix missing newline at end of file

2023-04-03 Thread Richard Henderson
insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v2 08/10] hmp: Report 'one-insn-per-tb', not 'single step mode', in 'info status' output

2023-04-03 Thread Richard Henderson
eprecation/transition plan for this, because we make no guarantees about stability of HMP output. Signed-off-by: Peter Maydell --- softmmu/runstate-hmp-cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v2 07/10] hmp: Add 'one-insn-per-tb' command equivalent to 'singlestep'

2023-04-03 Thread Richard Henderson
Peter Maydell --- docs/about/deprecated.rst | 9 + include/monitor/hmp.h | 2 +- softmmu/runstate-hmp-cmds.c | 2 +- tests/qtest/test-hmp.c | 1 + hmp-commands.hx | 25 + 5 files changed, 33 insertions(+), 6 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v2 06/10] Document that -singlestep command line option is deprecated

2023-04-03 Thread Richard Henderson
the only use of the deprecated syntax from a README. Signed-off-by: Peter Maydell --- docs/about/deprecated.rst | 16 qemu-options.hx | 5 +++-- tcg/tci/README| 2 +- 3 files changed, 20 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v2 05/10] bsd-user: Add '-one-insn-per-tb' option equivalent to '-singlestep'

2023-04-03 Thread Richard Henderson
d, 9 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v2 04/10] linux-user: Add '-one-insn-per-tb' option equivalent to '-singlestep'

2023-04-03 Thread Richard Henderson
+), 4 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v2 03/10] tcg: Use one-insn-per-tb accelerator property in curr_cflags()

2023-04-03 Thread Richard Henderson
On 4/3/23 07:46, Peter Maydell wrote: uint32_t curr_cflags(CPUState *cpu) { uint32_t cflags = cpu->tcg_cflags; +TCGState *tcgstate = TCG_STATE(current_accel()); As mentioned against the cover, this is a very hot path. We should try for something less expensive. Perhaps as simple

Re: [PATCH v2 02/10] softmmu: Don't use 'singlestep' global in QMP and HMP commands

2023-04-03 Thread Richard Henderson
+- 2 files changed, 25 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v2 01/10] make one-insn-per-tb an accel option

2023-04-03 Thread Richard Henderson
| 8 ++-- linux-user/main.c | 8 ++-- softmmu/vl.c| 17 +++-- qemu-options.hx | 7 +++ 5 files changed, 55 insertions(+), 6 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v2 00/10] Deprecate/rename singlestep command line option, monitor interfaces

2023-04-03 Thread Richard Henderson
On 4/3/23 07:46, Peter Maydell wrote: * I have written patch 3 on the assumption that curr_cflags() is not such a hot codepath that we can't afford to have a QOM cast macro in it; the alternative would be to keep it using a global variable but make the global be restricted to ac

Re: [PATCH v4 4/5] docs/about/deprecated: Deprecate 32-bit arm hosts for system emulation

2023-03-06 Thread Richard Henderson
On 3/6/23 00:46, Thomas Huth wrote: +continuous to be supported on 32-bit arm hosts, too) "continues" Acked-by: Richard Henderson r~

Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386

2023-02-28 Thread Richard Henderson
On 2/27/23 23:00, Michael S. Tsirkin wrote: On Mon, Feb 27, 2023 at 10:21:14AM -1000, Richard Henderson wrote: Removing support for building on 32 bit systems seems like a pity - it's one of a small number of ways to run 64 bit binaries on 32 bit systems, and the maintainance overhead is

Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386

2023-02-27 Thread Richard Henderson
On 2/27/23 01:50, Daniel P. Berrangé wrote: On Mon, Feb 27, 2023 at 12:10:49PM +0100, Thomas Huth wrote: Hardly anybody still uses 32-bit x86 hosts today, so we should start deprecating them to finally have less test efforts. With regards to 32-bit KVM support in the x86 Linux kernel, the develo

Re: [PATCH 1/2] docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386

2023-02-27 Thread Richard Henderson
On 2/27/23 10:12, Michael S. Tsirkin wrote: On Mon, Feb 27, 2023 at 11:50:07AM +, Daniel P. Berrangé wrote: I feel like we should have separate deprecation entries for the i686 host support, and for qemu-system-i386 emulator binary, as although they're related they are independant features w

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-02-17 Thread Richard Henderson
On 2/17/23 06:06, Reinoud Zandijk wrote: On Fri, Feb 17, 2023 at 11:36:41AM +0100, Markus Armbruster wrote: I feel the discussion petered out without a conclusion. I don't think letting the status quo win by inertia is a good outcome here. Which 32-bit hosts are still useful, and why? NetBSD

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-01-30 Thread Richard Henderson
On 1/30/23 13:14, Philippe Mathieu-Daudé wrote: On 30/1/23 20:19, Richard Henderson wrote: But I do question whether we need to support 64-bit guests on 32-bit hosts at all. Retaining 32-bit on 32-bit allows arm32 to emulate i686, which I suspect, but have no proof, is the limit of what

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-01-30 Thread Richard Henderson
On 1/30/23 02:01, Daniel P. Berrangé wrote: I vaguely recall someone mentioned problems with atomic ops in the past, or was it 128-bit ints, caused implications for the codebase ? TCG_OVERSIZED_GUEST, where 32-bit host running 64-bit guest cannot run the guest except in round-robin mode. It's

Re: [PATCH v2] MIPS: remove support for trap and emulate KVM

2022-12-21 Thread Richard Henderson
--- target/mips/cpu.c | 7 + target/mips/cpu.h | 3 --- target/mips/internal.h | 3 --- target/mips/kvm.c | 11 +--- target/mips/sysemu/addr.c | 17 target/mips/sysemu/physaddr.c | 13 -- 9

Re: [PULL 0/3] Misc next patches

2022-04-26 Thread Richard Henderson
On 4/26/22 08:13, Daniel P. Berrangé wrote: The following changes since commit a1755db71e34df016ffc10aa0727360aae2c6036: Merge tag 'pull-block-2022-04-25' of https://gitlab.com/hreitz/qemu into staging (2022-04-25 13:35:41 -0700) are available in the Git repository at: https://gitlab.co

Re: [PATCH v2 12/12] target/riscv: Support virtual time context synchronization

2021-12-13 Thread Richard Henderson
On 12/10/21 2:07 AM, Yifei Jiang via wrote: +static bool kvmtimer_needed(void *opaque) +{ +return kvm_enabled(); +} + + +static const VMStateDescription vmstate_kvmtimer = { +.name = "cpu/kvmtimer", +.version_id = 1, +.minimum_version_id = 1, +.needed = kvmtimer_needed, +.

Re: [PATCH v2 10/12] target/riscv: Add kvm_riscv_get/put_regs_timer

2021-12-13 Thread Richard Henderson
On 12/12/21 9:05 PM, Anup Patel wrote: +ret = kvm_get_one_reg(cs, RISCV_TIMER_REG(env, state), ®); +if (ret) { +abort(); +} +env->kvm_timer_state = reg; Please read the timer frequency here. Yep. + +env->kvm_timer_dirty = true; +} + +static void kvm_riscv_put_reg

Re: [PATCH v1 12/12] target/riscv: Support virtual time context synchronization

2021-11-20 Thread Richard Henderson
On 11/20/21 8:46 AM, Yifei Jiang wrote: const VMStateDescription vmstate_riscv_cpu = { .name = "cpu", .version_id = 3, .minimum_version_id = 3, +.post_load = cpu_post_load, .fields = (VMStateField[]) { VMSTATE_UINTTL_ARRAY(env.gpr, RISCVCPU, 32),

Re: [PATCH v1 03/12] target/riscv: Implement function kvm_arch_init_vcpu

2021-11-20 Thread Richard Henderson
On 11/20/21 8:46 AM, Yifei Jiang wrote: +id = kvm_riscv_reg_id(env, KVM_REG_RISCV_CONFIG, KVM_REG_RISCV_CONFIG_REG(isa)); +ret = kvm_get_one_reg(cs, id, &isa); +if (ret) { +return ret; +} +env->misa_mxl |= isa; This doesn't look right. I'm sure you meant env->m

Re: [PULL 00/10] Misc 20211102 patches

2021-11-03 Thread Richard Henderson
On 11/2/21 12:26 PM, Gerd Hoffmann wrote: The following changes since commit 8cb41fda78c7ebde0dd248c6afe1d336efb0de50: Merge remote-tracking branch 'remotes/philmd/tags/machine-20211101' into staging (2021-11-02 05:53:45 -0400) are available in the Git repository at: git://git.kraxel.or

Re: [PATCH v2 4/4] MAINTAINERS: Agree to maintain nanoMIPS TCG frontend

2021-10-27 Thread Richard Henderson
te nanoMIPS ISA"). [*] https://lore.kernel.org/qemu-devel/yvx7ygquenp83...@redhat.com/ Cc: Vince Del Vecchio Cc: Petar Jovanovic Reviewed-by: Jiaxun Yang Signed-off-by: Philippe Mathieu-Daudé --- Reviewed-by: Richard Henderson r~

Re: [PATCH v2 3/4] MAINTAINERS: Split MIPS TCG frontend vs MIPS machines/hardware

2021-10-27 Thread Richard Henderson
Mathieu-Daudé Message-Id:<20211004092515.3819836-4-f4...@amsat.org> --- MAINTAINERS | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v2 2/4] MAINTAINERS: Add entries to cover MIPS CPS / GIC hardware

2021-10-27 Thread Richard Henderson
- 1 file changed, 14 insertions(+), 6 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v2 1/4] MAINTAINERS: Add MIPS general architecture support entry

2021-10-27 Thread Richard Henderson
515.3819836-2-f4...@amsat.org> --- MAINTAINERS | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v3 3/4] fdc: Inline fdctrl_connect_drives() into fdctrl_realize_common()

2021-03-09 Thread Richard Henderson
On 3/9/21 8:12 AM, Markus Armbruster wrote: @@ -2565,6 +2551,7 @@ static void fdctrl_realize_common(DeviceState *dev, FDCtrl *fdctrl, Error **errp) { int i, j; +FDrive *drive; static int command_tables_inited = 0; if (fdctrl->fallbac

Re: [PULL 00/66] MIPS patches for 2021-01-07

2021-01-08 Thread Richard Henderson
On 1/8/21 5:22 AM, 罗勇刚(Yonggang Luo) wrote: >>> UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position >>> 80: ordinal not in range(128) > Can we always reading file in decodetree with utf8 encoding > And convert all decodetree to utf8 encoding, and the problem should resolved. > ```

Re: [PATCH-for-5.2] target/mips: Deprecate nanoMIPS ISA

2020-11-02 Thread Richard Henderson
tools/compilers/ > [2] https://www.mail-archive.com/qemu-devel@nongnu.org/msg756392.html > > Signed-off-by: Philippe Mathieu-Daudé > --- Acked-by: Richard Henderson r~

Re: [PATCH-for-5.2] hw/mips: Remove the 'r4k' machine

2020-11-02 Thread Richard Henderson
On 11/2/20 2:26 AM, Philippe Mathieu-Daudé wrote: > -mips ``r4k`` platform (since 5.0) > +mips ``r4k`` platform (removed in 5.2) > ''''''''''''''''''''''''''''''''' Header underline needs adjustment. Otherwise, Acked-by: Richard Henderson r~

Re: [RFC PATCH] docs/system/deprecated: mark ppc64abi32-linux-user for deprecation

2020-09-07 Thread Richard Henderson
On 9/7/20 2:05 AM, Alex Bennée wrote: > What about tweaking configure? Or should I just manually squash it in > all our CI configs? Squash in to CI, I would think. r~

Re: [RFC PATCH] docs/system/deprecated: mark ppc64abi32-linux-user for deprecation

2020-09-07 Thread Richard Henderson
", it's just that the code doesn't do that > (and never has?). It's like the mipsn32, mipsn32el, sparc32plus > ABIs which we also implement (hopefully correctly...) > > But "this has always been broken and nobody complained" is > a good reason to deprecate anyway. Indeed. With the last sentence changed to "For that reason the maintainers strongly suspect no one actually uses it." Reviewed-by: Richard Henderson r~