Eric,
> >> +dev->source.data.file.path = strdup("/dev/null");
> >> +
> >> +if (!(dev->source.data.file.path)) {
> >> +virReportOOMError();
> >> +return -1;
> >> +}
> >> +
> >
> > This can be reduced to:
> > if (VIR_STRDUP(dev->source.data.file.path,
Jan,
Thank you for reviewing.
I will fix the patch in accordance with your comments.
Seiji
> -Original Message-
> From: Ján Tomko [mailto:jto...@redhat.com]
> Sent: Thursday, August 15, 2013 5:36 AM
> To: Seiji Aguchi
> Cc: libvir-list@redhat.com
> Subject: Re: [libvi
Any comment?
> -Original Message-
> From: libvir-list-boun...@redhat.com [mailto:libvir-list-boun...@redhat.com]
> On Behalf Of Seiji Aguchi
> Sent: Wednesday, July 24, 2013 4:06 PM
> To: libvir-list@redhat.com
> Subject: [libvirt] [PATCH v3] xml: introduce startup
policy works as follows.
- If the value is "optional", guestOS boots up by dropping the chardev.
- If other values are specified, guestOS fails to boot up. (the default)
Description about original startupPolicy attribute:
http://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=e5a84d74a27
[libvirt] [PATCHv2] xml: introduce startupPolicy for chardev
> device
>
> On 05/24/2013 04:46 PM, Eric Blake wrote:
> > From: Seiji Aguchi
> >
> > [Problem]
> > Currently, guest OS's messages can be logged to a local disk of host OS
> > by creating chade
Any comments?
> -Original Message-
> From: Seiji Aguchi
> Sent: Thursday, May 02, 2013 1:26 PM
> To: libvir-list@redhat.com
> Cc: dle-deve...@lists.sourceforge.net; Tomoki Sekiyama
> (tomoki.sekiy...@hds.com)
> Subject: [PATCH] Introduce startupPolicy for cha
4a2789a917bf394f15de9989ec48fded0
Signed-off-by: Seiji Aguchi
---
docs/formatdomain.html.in |9 -
docs/schemas/domaincommon.rng |3 +++
src/conf/domain_conf.c|8
src/conf/domain_conf.h|1 +
src/qemu/qemu_process.c | 25 ++
> NACK this is putting inappropriate policy decisions into libvirt.
> This may be how you want this scenario to work, but it is certainly not what
> every user of libvirt will want.
How about adding some option to libvirt so that the users can choose policies?
> If the storage is fubar & the ma
destination to /dev/null in case a log file can't be
opened.
Signed-off-by: Seiji Aguchi
---
src/qemu/qemu_process.c | 20 +++-
1 files changed, 19 insertions(+), 1 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 8c4bfb7..fdf2
