[PATCH v2 06/11] virsh: Add option --title for nwfilter-list

Signed-off-by: K Shiva Kiran --- docs/manpages/virsh.rst | 5 - tools/virsh-nwfilter.c | 36 ++-- 2 files changed, 34 insertions(+), 7 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index e15f1832e7..5e03ce1e18 100644 --- a/docs

[PATCH v2 00/11] nwfilter: Add support for user defined metadata

patches as instructed K Shiva Kiran (11): nwfilter_conf: Add schema and parser logic for nwfilter metadata nwfilter_conf: Introduce public API to get/set user metadata nwfilter: Implement RPC virsh: Add new command `nwfilter-desc` virsh: Add new command `nwfilter-metadata` virsh: Add option

[PATCH v2 02/11] nwfilter_conf: Introduce public API to get/set user metadata

Two new APIs to work with user defined metadata: - virNWFilterSetMetadata() - virNWFilterGetMetadata() Signed-off-by: K Shiva Kiran --- include/libvirt/libvirt-nwfilter.h | 27 + include/libvirt/virterror.h| 1 + src/driver-nwfilter.h | 15 +++ src/libvirt

[PATCH v2 09/11] test_driver: Implement test driver for network filters

Signed-off-by: K Shiva Kiran --- src/conf/nwfilter_conf.c | 5 +- src/conf/nwfilter_conf.h | 3 + src/test/test_driver.c | 240 ++- 3 files changed, 246 insertions(+), 2 deletions(-) diff --git a/src/conf/nwfilter_conf.c b/src/conf/nwfilter_conf.c index

[PATCH v2 04/11] virsh: Add new command `nwfilter-desc`

This command can be used to view/modify the `` and `` fields of the Network filter object. Signed-off-by: K Shiva Kiran --- docs/manpages/virsh.rst | 40 tools/virsh-nwfilter.c | 209 tools/virsh-util.c | 25 + tools/virsh-util.h

[PATCH v2 01/11] nwfilter_conf: Add schema and parser logic for nwfilter metadata

Adds three new elements , and Signed-off-by: K Shiva Kiran --- docs/formatnwfilter.rst| 31 ++ src/conf/nwfilter_conf.c | 30 + src/conf/nwfilter_conf.h | 5 src/conf/schemas/nwfilter.rng

[PATCH v2 11/11] NEWS: Introduce user-defined metadata fields for NWFilter object

Signed-off-by: K Shiva Kiran --- NEWS.rst | 18 ++ 1 file changed, 18 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index d04090d43d..94e8c3f575 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,24 @@ v9.9.0 (unreleased) * **New features** + * nwfilter: Support for user

[PATCH v2 05/11] virsh: Add new command `nwfilter-metadata`

With the new command `nwfilter-metadata`, users will be able to view and modify the `` field of the Network Filter XML. Signed-off-by: K Shiva Kiran --- docs/manpages/virsh.rst | 48 ++ tools/virsh-nwfilter.c | 142 2 files changed, 190

[PATCH v2 10/11] test_driver: Implement test driver for metadata APIs

Signed-off-by: K Shiva Kiran --- src/test/test_driver.c | 49 +- tests/meson.build| 1 + tests/nwfiltermetadatatest.c | 297 +++ 3 files changed, 346 insertions(+), 1 deletion(-) create mode 100644 tests/nwfiltermetadatatest.c diff --git

[PATCH v2 08/11] nwfilter_driver: Add Driver implementation for metadata

Signed-off-by: K Shiva Kiran --- src/nwfilter/nwfilter_driver.c | 61 ++ 1 file changed, 61 insertions(+) diff --git a/src/nwfilter/nwfilter_driver.c b/src/nwfilter/nwfilter_driver.c index 09719edd75..00b2d89eb4 100644 --- a/src/nwfilter/nwfilter_driver.c +++ b

[PATCH v2 03/11] nwfilter: Implement RPC

Signed-off-by: K Shiva Kiran --- src/remote/remote_driver.c | 2 ++ src/remote/remote_protocol.x | 34 +- src/remote_protocol-structs | 19 +++ 3 files changed, 54 insertions(+), 1 deletion(-) diff --git a/src/remote/remote_driver.c b/src

[PATCH v2 07/11] virnwfilterobj: Add obj get and set methods for nwfilter metadata

Adds two new private methods for nwfilter metadata: - virNWFilterObjGetMetadata() - virNWFilterObjSetMetadata() Signed-off-by: K Shiva Kiran --- src/conf/virnwfilterobj.c | 148 ++ src/conf/virnwfilterobj.h | 13 src/libvirt_private.syms | 2 + 3

[PATCH] NEWS: Introduce new event for network metadata changes

Signed-off-by: K Shiva Kiran --- NEWS.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index a03ef20bc2..3381637fe5 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -15,6 +15,12 @@ v9.8.0 (unreleased) * **Removed features** + * New event for metadata changes in

[PATCH 16/16] NEWS: Introduce user-defined metadata fields for NWFilter object

Signed-off-by: K Shiva Kiran --- NEWS.rst | 18 ++ 1 file changed, 18 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index a03ef20bc2..bd38efb43c 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,24 @@ v9.8.0 (unreleased) * **New features** + * nwfilter: Support for user

[PATCH 15/16] nwfilter_driver: Add Driver implementation for metadata

Signed-off-by: K Shiva Kiran --- src/nwfilter/nwfilter_driver.c | 61 ++ 1 file changed, 61 insertions(+) diff --git a/src/nwfilter/nwfilter_driver.c b/src/nwfilter/nwfilter_driver.c index 09719edd75..3a28532ca2 100644 --- a/src/nwfilter/nwfilter_driver.c +++ b

[PATCH 13/16] virnwfilterobj: Add virNWFilterObjGetMetadata()

Signed-off-by: K Shiva Kiran --- src/conf/virnwfilterobj.c | 46 +++ src/conf/virnwfilterobj.h | 5 + src/libvirt_private.syms | 1 + 3 files changed, 52 insertions(+) diff --git a/src/conf/virnwfilterobj.c b/src/conf/virnwfilterobj.c index 6456add593

[PATCH 14/16] virnwfilterobj: Add virNWFilterObjSetMetadata()

Signed-off-by: K Shiva Kiran --- src/conf/virnwfilterobj.c | 102 ++ src/conf/virnwfilterobj.h | 8 +++ src/libvirt_private.syms | 1 + 3 files changed, 111 insertions(+) diff --git a/src/conf/virnwfilterobj.c b/src/conf/virnwfilterobj.c index eab864fe2e

[PATCH 11/16] virsh: Add option --title for nwfilter-list

Signed-off-by: K Shiva Kiran --- tools/virsh-nwfilter.c | 36 ++-- 1 file changed, 30 insertions(+), 6 deletions(-) diff --git a/tools/virsh-nwfilter.c b/tools/virsh-nwfilter.c index 801a52746e..ca803865bf 100644 --- a/tools/virsh-nwfilter.c +++ b/tools/virsh

[PATCH 12/16] docs: Document nwfilter metadata related commands

Documents the commands `nwfilter-desc`, `nwfilter-metadata` and the new `--title` option of `nwfilter-list`. Signed-off-by: K Shiva Kiran --- docs/manpages/virsh.rst | 98 - 1 file changed, 97 insertions(+), 1 deletion(-) diff --git a/docs/manpages

[PATCH 09/16] virsh: Add new command `nwfilter-desc`

This command can be used to view/modify the `` and `` fields of the NWFilter object. Signed-off-by: K Shiva Kiran --- tools/virsh-nwfilter.c | 209 + 1 file changed, 209 insertions(+) diff --git a/tools/virsh-nwfilter.c b/tools/virsh-nwfilter.c index

[PATCH 07/16] nwfilter: Implement RPC

Signed-off-by: K Shiva Kiran --- src/remote/remote_driver.c | 2 ++ src/remote/remote_protocol.x | 34 +- src/remote_protocol-structs | 19 +++ 3 files changed, 54 insertions(+), 1 deletion(-) diff --git a/src/remote/remote_driver.c b/src

[PATCH 10/16] virsh: Add new command `nwfilter-metadata`

With the new command `nwfilter-metadata`, users will be able to view and modify the `` field of the Network Filter XML. Signed-off-by: K Shiva Kiran --- tools/virsh-nwfilter.c | 142 + 1 file changed, 142 insertions(+) diff --git a/tools/virsh-nwfilter.c

[PATCH 08/16] virsh: Add helper method to retrieve xml from NWFilter def

Signed-off-by: K Shiva Kiran --- tools/virsh-util.c | 25 + tools/virsh-util.h | 9 + 2 files changed, 34 insertions(+) diff --git a/tools/virsh-util.c b/tools/virsh-util.c index fb6327613a..c3af770c29 100644 --- a/tools/virsh-util.c +++ b/tools/virsh-util.c

[PATCH 05/16] nwfilter: Introduce public API to modify user metadata

Introduces `virNWFilterSetMetadata()` to modify user defined metadata fields, i.e ``, `` and `` Signed-off-by: K Shiva Kiran --- include/libvirt/libvirt-nwfilter.h | 8 +++ src/driver-nwfilter.h | 9 src/libvirt-nwfilter.c | 87 ++ src

[PATCH 03/16] nwfilter: Add enum to operate on user defined metadata

Adds enum `virNWFilterMetadataType` to choose between ``, `` or ``. Signed-off-by: K Shiva Kiran --- include/libvirt/libvirt-nwfilter.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/include/libvirt/libvirt-nwfilter.h b/include/libvirt/libvirt-nwfilter.h index 33b842b464

[PATCH 06/16] nwfilter: Introduce public API to retrieve user-defined metadata

Introduces `virNWFilterGetMetadata()` to retrieve user defined metadata fields, i.e ``, `` and `` Signed-off-by: K Shiva Kiran --- include/libvirt/libvirt-nwfilter.h | 5 +++ src/driver-nwfilter.h | 6 +++ src/libvirt-nwfilter.c | 67

[PATCH 00/16] nwfilter: Add support for user defined metadata

This patchset adds support for the following user defined metadata fields for network filters. - title: A short description of the filter. - description: Any documentation that the user wants to store. - metadata: Other metadata in XML form. K Shiva Kiran (16): xml: Add , and to nwfilter xml

[PATCH 04/16] nwfilter: Add error code and message for missing metadata

Signed-off-by: K Shiva Kiran --- include/libvirt/virterror.h | 1 + src/util/virerror.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/include/libvirt/virterror.h b/include/libvirt/virterror.h index 224eddc9e4..ffb47a3242 100644 --- a/include/libvirt/virterror.h +++ b/include

[PATCH 02/16] conf: Add parser logic for nwfilter metadata fields

Signed-off-by: K Shiva Kiran --- src/conf/nwfilter_conf.c | 30 ++ src/conf/nwfilter_conf.h | 5 + 2 files changed, 35 insertions(+) diff --git a/src/conf/nwfilter_conf.c b/src/conf/nwfilter_conf.c index 35f6efbbe2..d03f78af4d 100644 --- a/src/conf

[PATCH 01/16] xml: Add , and to nwfilter xml schema

Signed-off-by: K Shiva Kiran --- docs/formatnwfilter.rst | 31 +++ src/conf/schemas/nwfilter.rng | 9 + 2 files changed, 40 insertions(+) diff --git a/docs/formatnwfilter.rst b/docs/formatnwfilter.rst index 434da5b1fd..766d7e85f5 100644 --- a/docs

[PATCH 5/8] Implement RPC Client for Network Metadata change callbacks

Signed-off-by: K Shiva Kiran --- src/remote/remote_driver.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index b81c9bc611..5d581dae48 100644 --- a/src/remote/remote_driver.c +++ b/src/remote

[PATCH 7/8] Add Bridge Driver implementation for Network metadata change callbacks

Signed-off-by: K Shiva Kiran --- src/network/bridge_driver.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index caad085192..34c88278cd 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -5149,6

[PATCH 8/8] examples: Add Testing for metadata change callbacks

Signed-off-by: K Shiva Kiran --- examples/c/misc/event-test.c | 85 1 file changed, 76 insertions(+), 9 deletions(-) diff --git a/examples/c/misc/event-test.c b/examples/c/misc/event-test.c index 64652b0153..813bca2699 100644 --- a/examples/c/misc/event

[PATCH 4/8] Add methods to create Metadata change events

Adds two new private methods to create metadata change events: - virNetworkEventMetadataChangeNewFromNet() - virNetworkEventMetadataChangeNewFromObj() Signed-off-by: K Shiva Kiran --- src/conf/network_event.c | 48 src/conf/network_event.h | 11

[PATCH 6/8] Test driver implementation for Network metadata change callbacks

Signed-off-by: K Shiva Kiran --- src/test/test_driver.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 0174b28bac..0144df164e 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -9989,6 +9989,7

[PATCH 1/8] Define Network Metadata change callback function

Signed-off-by: K Shiva Kiran --- include/libvirt/libvirt-network.h | 21 + 1 file changed, 21 insertions(+) diff --git a/include/libvirt/libvirt-network.h b/include/libvirt/libvirt-network.h index 0f7ad8300f..4b121ae0e7 100644 --- a/include/libvirt/libvirt-network.h +++ b

[PATCH 3/8] Add Event ID, Server side dispatcher and virsh print function

: K Shiva Kiran --- I was unable to split this patch due to static assertions (perfomed against VIR_NETWORK_EVENT_ID_LAST) in remote_daemon_dispatch.c and virsh-network.c Please let me know if there is a way to split patches in such cases. include/libvirt/libvirt-network.h | 1 + src/conf

[PATCH 2/8] Define Network event struct for Metadata change

Adds: - New struct virNetworkEventMetadataChange. - virNetworkEvent*Dispose() function for the same. Signed-off-by: K Shiva Kiran --- src/conf/network_event.c | 24 1 file changed, 24 insertions(+) diff --git a/src/conf/network_event.c b/src/conf/network_event.c index

[PATCH 0/8] network: Add callback for metadata changes

This patchset adds support to trigger an event upon changes in the content of ``, `` or `` in the network. K Shiva Kiran (8): Define Network Metadata change callback function Define Network event struct for Metadata change Add Event ID, Server side dispatcher and virsh print function Add

Re: Release of libvirt-9.7.0

This NEWS entry announcing the new metadata APIs for network object in version 9.7.0 seems to have been missed for the release. Link to patch: https://listman.redhat.com/archives/libvir-list/2023-August/241592.html - Shiva

[PATCH] virsh: Fix net-desc --config output

same (1 << 1), whereas they are not for network equivalent ones (1 << 0, 1 << 1). Signed-off-by: K Shiva Kiran --- tools/virsh-network.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tools/virsh-network.c b/tools/virsh-network.c index 49778d

[PATCH] virsh: Fix net-desc --config output

same (1 << 1), whereas they are not for network equivalent ones (1 << 0, 1 << 1). Signed-off-by: K Shiva Kiran --- tools/virsh-network.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tools/virsh-network.c b/tools/virsh-network.c index 49778d

[PATCH v2] NEWS: Announcing Network Metadata APIs

Ref to patchset implementing the above: https://listman.redhat.com/archives/libvir-list/2023-August/241250.html Signed-off-by: K Shiva Kiran --- This is a v2 of: https://listman.redhat.com/archives/libvir-list/2023-August/241469.html Diff to v1: - Shortened the text and put all text under one

Re: [libvirt PATCH v2 5/7] Add virNetworkObj Get and Set Methods for Metadata

for them. Please feel free to point out any more such things in the future. Shiva On 25 August 2023 4:09:09 pm IST, "Michal Prívozník" wrote: >Again, way too much changes, disperse in semantics for one patch. You've >introduced virNetworkObjUpdateModificationImpact(). Pe

[PATCH] NEWS: Announcing Network Metadata APIs

Ref to patchset implementing the above: https://listman.redhat.com/archives/libvir-list/2023-August/241250.html Signed-off-by: K Shiva Kiran --- NEWS.rst | 26 ++ 1 file changed, 26 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 73571f0019..01df22ef03 100644 --- a

[PATCH] REFACTOR: Eliminate newlines in messages and fixes a typo

Removes newlines of error message strings in metadata unit tests, libvirt-domain.c and libvirt-network.c Fixes a minor typo in libvirt-domain.c Signed-off-by: K Shiva Kiran --- include/libvirt/libvirt-domain.h | 2 +- src/libvirt-domain.c | 3 +-- src/libvirt-network.c

[PING] Patches Pending review

A gentle reminder, the following patch set has been pending review since 9 days. Link to Patch set: https://listman.redhat.com/archives/libvir-list/2023-August/241250.html Thanks

[libvirt PATCH v2 7/7] Added bridge driver implementation

Signed-off-by: K Shiva Kiran --- src/network/bridge_driver.c | 64 + 1 file changed, 64 insertions(+) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index e776d86c73..caad085192 100644 --- a/src/network/bridge_driver.c +++ b/src

[libvirt PATCH v2 4/7] virsh exposure of Network Metadata APIs

tation for all the above. - XML Fallback function `virshNetworkGetXMLFromNet` for title and description for compatibility with hosts running older versions of libvirtd. Signed-off-by: K Shiva Kiran --- docs/manpages/virsh.rst | 77 tools/virsh-network.c | 411

[libvirt PATCH v2 1/7] Add and for Network Objects

basictypes.rng for use by network and future objects. - Added Network XML parser logic for the above. Signed-off-by: K Shiva Kiran --- docs/formatnetwork.rst| 11 +++ src/conf/network_conf.c | 18 ++ src/conf/network_conf.h | 2 ++ src/conf/schemas

[libvirt PATCH v2 3/7] Implementing Remote Protocol for Network Metadata

- Defines wire protocol format. - Implements remote driver. Signed-off-by: K Shiva Kiran --- src/remote/remote_driver.c | 2 ++ src/remote/remote_protocol.x | 36 +++- src/remote_protocol-structs | 19 +++ 3 files changed, 56 insertions(+), 1

[libvirt PATCH v2 6/7] Add Test driver and testcase for Network Metadata change APIs

This commit implements the newly defined Network Metadata Get and Set APIs into the test driver. It also adds a new testcase "networkmetadatatest" to test the APIs. Signed-off-by: K Shiva Kiran --- src/conf/network_conf.c | 3 + src/test/test_driver.c | 67 +

[libvirt PATCH v2 0/7] Introduce new Metadata fields for Network object with corresponding APIs

networkUpdate(), substituted by call to newly introduced virNetworkObjUpdateModificationImpact(). - Added virsh exposure of the APIs. - Added bridge driver implementation. Signed-off-by: K Shiva Kiran K Shiva Kiran (7): Add and for Network Objects Adding Public Get and Set APIs for Network

[libvirt PATCH v2 5/7] Add virNetworkObj Get and Set Methods for Metadata

network before setting metadata. - Eliminates redundant call of virNetworkObjSetDefTransient() in virNetworkConfigChangeSetup() among others. - Substituted redundant logic in networkUpdate() with a call to virNetworkObjUpdateModificationImpact(). Signed-off-by: K Shiva Kiran --- src/conf

[libvirt PATCH v2 2/7] Adding Public Get and Set APIs for Network Metadata

support. Signed-off-by: K Shiva Kiran --- include/libvirt/libvirt-network.h | 29 ++ include/libvirt/virterror.h | 1 + src/driver-network.h | 16 +++ src/libvirt-network.c | 167 ++ src/libvirt_public.syms | 6 ++ src

Re: [libvirt PATCH 3/4] Add virNetworkObj Get and Set Methods for Metadata

On 19/07/23 14:48, Michal Prívozník wrote: On 7/11/23 08:47, K Shiva Kiran wrote: - Introduces virNetworkObjGetMetadata() and virNetworkObjSetMetadata(). - These functions implement common behaviour that can be reused by network drivers that use the virNetworkObj struct. - Also adds

Re: [libvirt PATCH v2 3/4] Add virNetworkObj Get and Set Methods for Metadata

On 19/07/23 21:47, K Shiva Kiran wrote: - Introduces virNetworkObjGetMetadata() and virNetworkObjSetMetadata(). - These functions implement common behaviour that can be reused by network drivers that use the virNetworkObj struct. - Introduces virNetworkObjUpdateModificationImpact() among

Re: [libvirt PATCH 2/4] Adding Public Get and Set APIs for Network Metadata

On 19/07/23 14:48, Michal Prívozník wrote: On 7/11/23 08:47, K Shiva Kiran wrote: This patch introduces public Get and Set APIs for modifying , and elements of the Network object. - Added enum to select one of the above elements to operate on. - Added error code and messages for missing

[libvirt PATCH v2 3/4] Add virNetworkObj Get and Set Methods for Metadata

live/persistent state of the network before setting metadata. - Replace redundant flag resolving code with the forementioned function in bridge_driver.c and test_driver.c - Eliminates redundant call of virNetworkObjSetDefTransient() in virNetworkConfigChangeSetup(). Signed-off-by: K Shiva

Re: [libvirt PATCH 0/4] Introduce new Metadata fields for Network object with corresponding APIs

On 19/07/23 14:48, Michal Prívozník wrote: On 7/11/23 08:47, K Shiva Kiran wrote: This commit introduces and fields to the XML schema of the Network object. It also adds public Get/Set APIs for modifying all metadata fields of the same, along with a test program. K Shiva Kiran (4): Add

[libvirt PATCH v2 2/4] Adding Public Get and Set APIs for Network Metadata

From 61d699de0603ca49a67cc898a219cce2613b82ba Mon Sep 17 00:00:00 2001 From: K Shiva Kiran Date: Tue, 27 Jun 2023 20:48:52 +0530 Subject: [libvirt PATCH v2 2/4] Adding Public Get and Set APIs for Network Metadata This patch introduces public Get and Set APIs for modifying , and elements of

[libvirt PATCH 2/4] Adding Public Get and Set APIs for Network Metadata

protocol format. Signed-off-by: K Shiva Kiran --- include/libvirt/libvirt-network.h | 29 ++ include/libvirt/virterror.h | 1 + src/driver-network.h | 16 +++ src/libvirt-network.c | 167 ++ src/libvirt_public.syms | 6

[libvirt PATCH 4/4] Add Test driver and testcase for Network Metadata change APIs

This commit implements the newly defined Network Metadata Get and Set APIs into the test driver. It also adds a new testcase "networkmetadatatest" to test the APIs. Signed-off-by: K Shiva Kiran --- src/conf/network_conf.c | 3 + src/test/test_driver.c | 67 +

[libvirt PATCH 1/4] Add and for Network Objects

From: K Shiva This patch adds new elements and to the Network XML. - The attribute holds a short title defined by the user and cannot contain newlines. - The attribute holds any documentation that the user wants to store. - Schema definitions of and have been moved from

[libvirt PATCH 0/4] Introduce new Metadata fields for Network object with corresponding APIs

This commit introduces and fields to the XML schema of the Network object. It also adds public Get/Set APIs for modifying all metadata fields of the same, along with a test program. K Shiva Kiran (4): Add and for Network Objects Adding Public Get and Set APIs for Network Metadata Add

[libvirt PATCH 3/4] Add virNetworkObj Get and Set Methods for Metadata

metadata. Signed-off-by: K Shiva Kiran --- src/conf/virnetworkobj.c | 325 +++ src/conf/virnetworkobj.h | 17 ++ 2 files changed, 342 insertions(+) diff --git a/src/conf/virnetworkobj.c b/src/conf/virnetworkobj.c index b8b86da06f..41d0a1d971 100644 --- a/src/conf

Re: [libvirt PATCH] Add and for Network Objects

Forgot to add the formatted strings to virBuffer. A v2 has been sent at: https://listman.redhat.com/archives/libvir-list/2023-June/240514.html

[libvirt PATCH v2] Add and for Network Objects

From: K Shiva This patch adds new elements and to the Network XML. - The attribute holds a short title defined by the user and cannot contain newlines. - The attribute holds any documentation that the user wants to store. - Schema definitions of and have been moved from

[libvirt PATCH] Add Public Get and Set APIs for Network Metadata

structs for RPC. Signed-off-by: K Shiva Kiran --- include/libvirt/libvirt-network.h | 29 ++ include/libvirt/virterror.h | 1 + src/driver-network.h | 16 +++ src/libvirt-network.c | 167 ++ src/libvirt_public.syms | 6

[libvirt PATCH] Add and for Network Objects

basictypes.rng for use by network and future objects. Get/Set Public APIs for modifying these elements as well as will be added in a subsequent patch. Signed-off-by: K Shiva Kiran --- docs/formatnetwork.rst| 11 +++ src/conf/network_conf.c | 13 + src/conf

[libvirt PATCH v3 7/8] Error code and message for NO_NETWORK_METADATA

Signed-off-by: K Shiva --- include/libvirt/virterror.h | 2 ++ src/util/virerror.c | 3 +++ 2 files changed, 5 insertions(+) diff --git a/include/libvirt/virterror.h b/include/libvirt/virterror.h index df13e4f11e..2910ff03da 100644 --- a/include/libvirt/virterror.h +++ b/include/libvirt

[libvirt PATCH v3 6/8] Test driver implementations

Adds: - Get and Set Metadata functions to the test driver. Signed-off-by: K Shiva --- src/driver-network.h | 16 + src/test/test_driver.c | 74 ++ 2 files changed, 90 insertions(+) diff --git a/src/driver-network.h b/src/driver-network.h index

[libvirt PATCH v3 5/8] Methods to relay metadata change callbacks

Added: - Methods for relaying metadata change callbacks. - Enums representing the same. Signed-off-by: K Shiva --- src/remote/remote_daemon_dispatch.c | 39 + src/remote/remote_driver.c | 32 +++ src/remote/remote_protocol.x| 15

[libvirt PATCH v3 4/8] virsh: Added Methods to print metadata changes

Signed-off-by: K Shiva --- tools/virsh-network.c | 78 ++- 1 file changed, 77 insertions(+), 1 deletion(-) diff --git a/tools/virsh-network.c b/tools/virsh-network.c index 42b7dba761..74712e29be 100644 --- a/tools/virsh-network.c +++ b/tools/virsh

[libvirt PATCH v3 8/8] Test program for network metadata

- Fixed a typo in libvirt-domain.h - Added test program networkmetadatatest.c Signed-off-by: K Shiva --- include/libvirt/libvirt-domain.h | 2 +- tests/meson.build| 1 + tests/networkmetadatatest.c | 297 +++ 3 files changed, 299 insertions

[libvirt PATCH v3 1/8] Parser and Schema definitions

- The definition of struct virNetworkObj has been moved from virnetworkobj.c to its header as it was needed by network_event.h. - Added functions to parse and save the XML along with helper functions that resolve the live/persistent state of the network. Signed-off-by: K Shiva --- src/conf

[libvirt PATCH v3 3/8] Added Metadata change events

Added: - Methods to handle metadata change events. Signed-off-by: K Shiva --- po/POTFILES | 1 + src/conf/network_event.c | 115 +++ src/conf/network_event.h | 11 3 files changed, 127 insertions(+) diff --git a/po/POTFILES b/po/POTFILES

[libvirt PATCH v3 2/8] Metadata change APIs and related enums

Added: - virNetworkGetMetadata() and virNetworkSetMetadata() APIs. - enums representing metadata type, i.e title, description or custom metadata. - enum representing metadata change callback event. Signed-off-by: K Shiva --- include/libvirt/libvirt-network.h | 51 + src/libvirt

[libvirt PATCH v3 0/8] Metadata support for Network Objects

/Google_Summer_of_Code_Ideas.html Signed-off-by: K Shiva K Shiva (8): Parser and Schema definitions Metadata change APIs and related enums Added Metadata change events virsh: Added Methods to print metadata changes Methods to relay metadata change callbacks Test driver implementations Error code and message for

Re: [libvirt PATCH] Metadata support for Network Objects

On 23/06/12 01:14AM, K Shiva wrote: > Adds support for the following to Network Object: > - , and added to Network obj Schema. > - Public Get and Set APIs, being virNetworkSetMetadata() & > virNetworkGetMetadata(). > - An async callback that notifies of changes

[libvirt PATCH v2] Metadata support for Network Objects

Adds the following to Network Object: - , and to the Network Schema. - Get and Set APIs to access or modify the above. - An async callback that notifies of metadata changes. Resolves (GSoC 2023): https://wiki.libvirt.org/Google_Summer_of_Code_Ideas.html Signed-off-by: K Shiva --- This is a v2

Ping

Awaiting review before proceeding attempts for metadata support on other objects. - Shiva

[libvirt PATCH v2 2/2] Corrected names in comments

Signed-off-by: K Shiva --- This patch applies to: https://listman.redhat.com/archives/libvir-list/2023-June/240299.html src/conf/virnetworkobj.c | 8 src/libvirt-network.c| 10 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/conf/virnetworkobj.c b/src

[libvirt PATCH] Metadata support for Network Objects

.org/Google_Summer_of_Code_Ideas.html Signed-off-by: K Shiva --- include/libvirt/libvirt-domain.h| 2 +- include/libvirt/libvirt-network.h | 51 include/libvirt/virterror.h | 2 + po/POTFILES | 1 + src/conf/network_conf.c | 3 + src/

Re: [libvirt PATCH] Move default Input bus logic to PostParse handling

derstood your corrections. Please proceed with the squash and the commit. Thank You K Shiva

[libvirt PATCH] Move default Input bus logic to PostParse handling

-off-by: K Shiva --- src/conf/domain_conf.c | 27 +++ src/conf/domain_conf.h | 1 + src/conf/domain_postparse.c| 30 ++ src/qemu/qemu_command.c| 1 + src/qemu/qemu_domain_address.c | 1 + src/qemu/qemu_hotplug.c

Re: [libvirt PATCH v3] Conf: Move validation of virDomainGraphicsListenDef out of Parser

On 4/6/23 20:43, Shiva wrote: Now, earlier in this loop (not visible in this limited context though) there's a check for VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK type. I don't think it is special so we have two options:    a) move it into virDomainGraphicsListenDefValidate(), or

Re: [libvirt PATCH v4] Conf: Move validation of virDomainGraphicsListenDef out of Parser

In an effort to separate the validation steps from the Parse stage, a few validation checks of virDomainGraphicsListenDef have been moved from virDomainGraphicsListenDefParseXML() in domain_conf.c to virDomainGraphicsDefListensValidate() in domain_validate.c Signed-off-by: Koninty Shiva Kiran

Re: [libvirt PATCH v3] Conf: Move validation of virDomainGraphicsListenDef out of Parser virDomainGraphicsListenDef out of Parser

In an effort to separate the validation steps from the Parse stage, a few validation checks of virDomainGraphicsListenDef have been moved from virDomainGraphicsListenDefParseXML() in domain_conf.c to virDomainGraphicsDefListensValidate() in domain_validate.c Signed-off-by: Koninty Shiva Kiran

[libvirt PATCH v4] Conf: Move validation of virDomainGraphicsListenDef out of Parser

From: K Shiva Kiran In an effort to separate the validation steps from the Parse stage, a few validation checks of virDomainGraphicsListenDef have been moved from virDomainGraphicsListenDefParseXML() in domain_conf.c to virDomainGraphicsDefListensValidate() in domain_validate.c Signed-off-by: K

Re: [libvirt PATCH v3] Conf: Move validation of virDomainGraphicsListenDef out of Parser

reover the function virDomainGraphicsListenDefValidate() has a pretty similar name to it's caller virDomainGraphicsDefListensValidate() and could be kindof annoying. Do I apply your suggestion and resend the patch? Thank You Shiva

[libvirt PATCH v3] Conf: Move validation of virDomainGraphicsListenDef out of Parser

In an effort to separate the validation steps from the Parse stage, a part of the validation of virDomainGraphicsListenDef has been moved to domain_validate.h. Signed-off-by: K Shiva --- This is a v3 of: https://listman.redhat.com/archives/libvir-list/2023-April/239265.html diff to v2

Re: [PATCH v2] Conf: Move validation of virDomainGraphicsListenDef out of Parser

lidate() from within domain_validate.c. Could you please provide a pointer on how it could be done? Thank you in advance. Shiva

[PATCH v2] Conf: Move validation of virDomainGraphicsListenDef out of Parser

From: skran In an effort to separate the validation steps from the Parse stage, a part of the validation of virDomainGraphicsListenDef has been moved to domain_validate.h. Signed-off-by: K Shiva --- This is a v2 of: https://listman.redhat.com/archives/libvir-list/2023-April/239205.html diff

Re: (GSoC) Contributor Application

On 4/3/23 19:40, Martin Kletzander wrote: On Mon, Apr 03, 2023 at 09:16:22AM +0200, Peter Krempa wrote: On Mon, Apr 03, 2023 at 12:24:09 +0530, Shiva wrote: Greetings libvirt developers! My name is Shiva and I am interested in contributing to the project titled *"Metadata support fo

(GSoC) Contributor Application

Greetings libvirt developers! My name is Shiva and I am interested in contributing to the project titled *"Metadata support for all object schemas". * My apologies for the delay in contact as this is my first time at GSoC and I have missed the dates. Is this the correct mailin