Re: [libvirt] [PATCH 0/3] Introduce new virtType enum item

2015-09-22 Thread Shivangi Dhir
Hi, On Tue, Sep 22, 2015 at 6:53 PM, Daniel P. Berrange wrote: > > On Tue, Sep 22, 2015 at 07:50:41AM -0400, John Ferlan wrote: > > > > > > On 09/17/2015 04:46 AM, Shivangi Dhir wrote: > > > These patches solve a BiteSizedTask - Introduce new virtType

[libvirt] [PATCH 1/3] conf: Add new VIR_DOMAIN_VIRT_NONE enum

2015-09-17 Thread Shivangi Dhir
Introduce VIR_DOMAIN_VIRT_NONE to give domaintype the default value of zero. This is specially helpful in constructing better error messages when we don't want to look up the default emulator by virtType. The test data in vircapstest.c is also modified to reflect this change. --- src/conf/capabil

[libvirt] [PATCH 2/3] qemu: Make virtType of type virDomainVirtType

2015-09-17 Thread Shivangi Dhir
Earlier virtType was of type int. After, introducing the enum VIR_DOMAIN_VIRT_NONE, the type of virtType is modified to virDomainVirtType. --- src/conf/domain_conf.h | 2 +- src/qemu/qemu_monitor.c | 2 +- src/qemu/qemu_monitor.h | 2 +- src/qemu/qemu_monitor_json.c | 2 +- src/qe

[libvirt] [PATCH 3/3] conf: Change the description of virCapabilitiesDomainDataLookup()

2015-09-17 Thread Shivangi Dhir
@domaintype: takes domain type to search for (of enum virDomainVirtType) since we no longer pass out-of-enum values. --- src/conf/capabilities.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/capabilities.c b/src/conf/capabilities.c index 533c925..b420f9f 100644 --- a

[libvirt] [PATCH 0/3] Introduce new virtType enum item

2015-09-17 Thread Shivangi Dhir
These patches solve a BiteSizedTask - Introduce new virtType enum item[0] [0] http://wiki.libvirt.org/page/BiteSizedTasks#Introduce_new_virtType_enum_item Shivangi Dhir (3): conf: Add new VIR_DOMAIN_VIRT_NONE enum qemu: Make virtType of type virDomainVirtType conf: Change the description