On 3/3/22 12:40 PM, Daniel P. Berrangé wrote:
> On Fri, Feb 25, 2022 at 04:11:27PM -0500, Tobin Feldman-Fitzthum wrote:
>> Some comments on the example protocol stuff
>>
>> On 2/23/22 1:38 PM, Dov Murik wrote:
>>> +cc Tobin, James
>>>
>>&g
On 3/3/22 12:20 PM, Daniel P. Berrangé wrote:
> On Fri, Feb 25, 2022 at 03:10:35PM -0500, Tobin Feldman-Fitzthum wrote:
>>
>>
>> On 2/24/22 7:26 AM, Daniel P. Berrangé wrote:
>>> On Wed, Feb 23, 2022 at 03:33:22PM -0500, Tobin Feldman-Fitzthum wrote:
>>>&g
Some comments on the example protocol stuff
On 2/23/22 1:38 PM, Dov Murik wrote:
> +cc Tobin, James
>
> On 23/02/2022 19:28, Daniel P. Berrangé wrote:
>>
>>
>> What could this look like from POV of an attestation server API, if
>> we assume HTTPS REST service with a simple JSON payload .>>
>>
>>
On 2/24/22 7:26 AM, Daniel P. Berrangé wrote:
> On Wed, Feb 23, 2022 at 03:33:22PM -0500, Tobin Feldman-Fitzthum wrote:
>>
>>
>> On 2/23/22 1:38 PM, Dov Murik wrote:
>>> +cc Tobin, James
>>>
>>> On 23/02/2022 19:28, Daniel P. Berrangé wrote:
On 2/23/22 1:38 PM, Dov Murik wrote:
> +cc Tobin, James
>
> On 23/02/2022 19:28, Daniel P. Berrangé wrote:
>> Extending management apps using libvirt to support measured launch of
>> QEMU guests with SEV/SEV-ES is unreasonably complicated today, both for
>> the guest owner and for the cloud man
Only probe QEMU binary with accel=tcg if TCG is not disabled.
Similarly, only add a VIR_DOMAIN_VIRT_QEMU guest if TCG
is available.
Signed-off-by: Tobin Feldman-Fitzthum
---
src/qemu/qemu_capabilities.c | 22 ++
src/qemu/qemu_capabilities.h | 1 +
2 files changed, 15
so that we can reuse the qom call.
Rename, virQEMUCapsProbeQMPDevices to virQEMUProbeQMPTypes.
All patches compile.
Tobin Feldman-Fitzthum (3):
add QEMU_CAPS_TCG_DISABLED and probe conditionally
add virQEMUCapsGetVirtType convenience function
add virQEMUCapsProbeQMPTCGState function to
Add virQEMUCapsProbeQMPTCGState to set TCG_DISABLED cap if version
is > 2.10, KVM is enabled, and tcg-accel is not present in
qom-list-types result.
Signed-off-by: Tobin Feldman-Fitzthum
---
src/qemu/qemu_capabilities.c | 34 --
1 file changed, 32 inserti
Signed-off-by: Tobin Feldman-Fitzthum
---
src/qemu/qemu_capabilities.c | 25 -
src/qemu/qemu_capabilities.h | 2 ++
2 files changed, 18 insertions(+), 9 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index c56b2d8f0e..e7179ea048
virQEMUCapsProbeQMPTCGState will set QEMU_CAPS_TCG_DISABLED if QEMU
version is at least 2.10, KVM is enabled, and qom-list-types does
not include tcg-accel.
Signed-off-by: Tobin Feldman-Fitzthum
---
src/qemu/qemu_capabilities.c | 32
1 file changed, 32
Probe for TCG with QMP right after probing for KVM.
Signed-off-by: Tobin Feldman-Fitzthum
---
src/qemu/qemu_capabilities.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 9abc6e80e7..fa3084484d
ave a QMP interface for determining
whether QEMU is available. Since QEMU_CAPS_TCG_DISABLED
is set only when TCG is disabled, we do not have to do any
extra work to infer an appropriate value in either of these
cases.
QEMU_CAPS_TCG_DISABLED is set via QMP command qom-list-types.
Tobin Feld
Signed-off-by: Tobin Feldman-Fitzthum
---
src/qemu/qemu_capabilities.c | 14 ++
src/qemu/qemu_capabilities.h | 2 ++
2 files changed, 16 insertions(+)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index c56b2d8f0e..8a17287076 100644
--- a/src/qemu
Only probe QEMU binary with accel=tcg if TCG is not disabled.
Similarly, only add a VIR_DOMAIN_VIRT_QEMU guest if TCG
is available.
Signed-off-by: Tobin Feldman-Fitzthum
---
src/qemu/qemu_capabilities.c | 22 ++
src/qemu/qemu_capabilities.h | 1 +
2 files changed, 15
Probe for TCG with QMP right after probing for KVM.
Signed-off-by: Tobin Feldman-Fitzthum
---
src/qemu/qemu_capabilities.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 528bf6e504..b3ba1cb079
QMP interface for determining
whether QEMU is available. Since QEMU_CAPS_TCG_DISABLED
is set only when TCG is disabled, we do not have to do any
extra work to infer an appropriate value in either of these
cases.
QEMU_CAPS_TCG_DISABLED is set via QMP command qom-list-types.
Tobin Feldman-Fitzthum
Only probe QEMU binary with accel=tcg if TCG is not disabled.
Similarly, only add a VIR_DOMAIN_VIRT_QEMU guest if TCG
is available.
Signed-off-by: Tobin Feldman-Fitzthum
---
src/qemu/qemu_capabilities.c | 22 ++
src/qemu/qemu_capabilities.h | 1 +
2 files changed, 15
Probe for TCG with QMP right after probing for KVM.
Signed-off-by: Tobin Feldman-Fitzthum
---
src/qemu/qemu_capabilities.c | 32
1 file changed, 32 insertions(+)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 0b44ee0745
Signed-off-by: Tobin Feldman-Fitzthum
---
src/qemu/qemu_capabilities.c | 14 ++
src/qemu/qemu_capabilities.h | 2 ++
2 files changed, 16 insertions(+)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 61123f0e63..0b44ee0745 100644
--- a/src/qemu
her QEMU is available. Since QEMU_CAPS_TCG_DISABLED
is set only when TCG is disabled, we do not have to do any
extra work to infer an appropriate value in either of these
cases.
QEMU_CAPS_TCG_DISABLED is set via QMP command qom-list-types.
Tobin Feldman-Fitzthum (5):
add QEMU_CAPS_TCG_DISABLED
Signed-off-by: Tobin Feldman-Fitzthum
---
src/qemu/qemu_capabilities.c | 14 ++
src/qemu/qemu_capabilities.h | 2 ++
2 files changed, 16 insertions(+)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 0371ca9b03..9c946339a3 100644
--- a/src/qemu
virQEMUCapsProbeQMPTCGState will set QEMU_CAPS_TCG_DISABLED if QEMU
version is at least 2.10, KVM is enabled, and qom-list-types does
not include tcg-accel.
Signed-off-by: Tobin Feldman-Fitzthum
---
src/qemu/qemu_capabilities.c | 32
1 file changed, 32
Probe for TCG with QMP right after probing for KVM.
Signed-off-by: Tobin Feldman-Fitzthum
---
src/qemu/qemu_capabilities.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index c84ad0e831..410b58bf47
Only probe QEMU binary with accel=tcg if TCG is not disabled.
Similarly, only add a VIR_DOMAIN_VIRT_QEMU guest if TCG
is available.
Signed-off-by: Tobin Feldman-Fitzthum
---
src/qemu/qemu_capabilities.c | 21 +
src/qemu/qemu_capabilities.h | 1 +
2 files changed, 14
error if the QEMU
binary was built without TCG. This patch allows execution to continue when the
second probe fails. Thus libvirt can be used with QEMU built without TCG. First
patch. Feedback appreciated. If better solution, please advise.
Signed-off-by: Tobin Feldman-Fitzthum
---
src/qemu
25 matches
Mail list logo