RE: [PATCH] qemu_conf: Fix double free problem for cfg->firmwares

2020-12-02 Thread Tuguoyi
> -Original Message- > From: Michal Privoznik [mailto:mpriv...@redhat.com] > Sent: Tuesday, December 01, 2020 9:28 PM > To: tuguoyi (Cloud) ; Ján Tomko > Cc: libvir-list@redhat.com > Subject: Re: [PATCH] qemu_conf: Fix double free problem for cfg->firmwares &g

RE: [PATCH] qemu_conf: Fix double free problem for cfg->firmwares

2020-11-30 Thread Tuguoyi
> -Original Message- > From: Ján Tomko [mailto:jto...@redhat.com] > Sent: Tuesday, November 24, 2020 6:57 PM > To: tuguoyi (Cloud) > Cc: libvir-list@redhat.com > Subject: Re: [PATCH] qemu_conf: Fix double free problem for cfg->firmwares > > On a Tuesday in

RE: [PATCH] qemu_conf: Fix double free problem for cfg->firmwares

2020-11-24 Thread Tuguoyi
On a Tuesday in 2020, Ján Tomko wrote: > On a Tuesday in 2020, Tuguoyi wrote: > >cfg->firmwares still points to the original memory address after being > >freed by virFirmwareFreeList(). As cfg get freed, it will be freed again > >even if cfg->nfirmwares=0 whi

[PATCH] qemu_conf: Fix double free problem for cfg->firmwares

2020-11-24 Thread Tuguoyi
eFreeList() returns Signed-off-by: Tuguoyi --- src/qemu/qemu_conf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 83de26a..98593b5 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -832,6 +832,7 @@ virQEMUDriverConfigLoadN