Re: [libvirt] [PATCH] tools: fix output of list with state-shutoff

On Mon, 2015-11-30 at 15:20 +0100, Martin Kletzander wrote: > On Mon, Nov 30, 2015 at 06:08:40PM +0800, Wei Jiangang wrote: > >Due to the default of flags is VIR_CONNECT_LIST_DOMAINS_ACTIVE, > >It doesn't show the domains that have been shutdown when we use > >

[libvirt] [PATCH] tools: fix output of list with state-shutoff

Due to the default of flags is VIR_CONNECT_LIST_DOMAINS_ACTIVE, It doesn't show the domains that have been shutdown when we use 'virsh list' with only --state-shutoff. Signed-off-by: Wei Jiangang --- tools/virsh-domain-monitor.c | 3 ++- 1 file changed, 2 insertions(+), 1 de

Re: [libvirt] [PATCH 1/3] libvirt-domain: Introduce macro to save duplicated codes

On Thu, 2015-10-15 at 11:31 +0200, Peter Krempa wrote: > On Thu, Oct 15, 2015 at 17:12:18 +0800, Wei Jiangang wrote: > > Signed-off-by: Wei Jiangang > > --- > > src/libvirt-domain.c | 55 > > ++-- > > 1 file change

[libvirt] [PATCH 3/3] Fix conficts with HACKING doc

Don't compare a bool variable against the literal, "true". Signed-off-by: Wei Jiangang --- src/conf/nwfilter_conf.c | 2 +- src/nwfilter/nwfilter_dhcpsnoop.c | 2 +- src/vz/vz_sdk.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff -

[libvirt] [PATCH 2/3] libvirt-secret: Fix typo

seclets ==> selects qualfied ==> qualified Signed-off-by: Wei Jiangang --- src/libvirt-secret.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libvirt-secret.c b/src/libvirt-secret.c index fa306e3..db42aec 100644 --- a/src/libvirt-secret.c +++ b/src/libvirt-se

[libvirt] [PATCH 1/3] libvirt-domain: Introduce macro to save duplicated codes

Signed-off-by: Wei Jiangang --- src/libvirt-domain.c | 55 ++-- 1 file changed, 15 insertions(+), 40 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 6e1aacd..ed07c9e 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt

Re: [libvirt] [PATCH] testscripts: make redirects happen in correct order

> Pushed. > > Congratulations for your first contribution to libvirt! :) > > Thanks for your prompt reply. I'm glad to join this community. Regards, wei On Wed, 2015-10-14 at 13:12 +0200, Andrea Bolognani wrote: > On Wed, 2015-10-14 at 18:39 +0800, Wei Jiangang wrote:

[libvirt] [PATCH] testscripts: make redirects happen in correct order

It should redirect stdout to /dev/null firstly, then redirect stderr to whatever stdout currently points at. Signed-off-by: Wei Jiangang --- tests/test-lib.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/test-lib.sh b/tests/test-lib.sh index e612f8f..d36a901