On Thu, Nov 3, 2016 at 4:31 PM, Christophe Fergeau wrote:
> On Thu, Nov 03, 2016 at 02:40:58PM +0100, Zeeshan Ali wrote:
>> ---
>> tests/test-gconfig.c| 24
>> tests/xml/gconfig-domain-device-unknown.xml | 5 +
&g
---
tests/test-gconfig.c| 24
tests/xml/gconfig-domain-device-unknown.xml | 5 +
2 files changed, 29 insertions(+)
create mode 100644 tests/xml/gconfig-domain-device-unknown.xml
diff --git a/tests/test-gconfig.c b/tests/test-gconfig.c
index 5
Currently we can and do get into serious trouble with this kind of code:
devices = gvir_config_domain_get_devices(domain);
gvir_config_domain_set_devices(domain, domain);
since the first call above won't return a complete list of objects present
in the domain but only the ones we have specific cl
We'll need to load XML from file in another function, that will be added
in a following patch.
---
tests/test-gconfig.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/tests/test-gconfig.c b/tests/test-gconfig.c
index a26bb5f..5389a26 100644
--- a/tests/test-gc
We'll need to instatiate DomainDevice baseclass itself for unknown (think
new devices added to libvirt XML) devices in a following patch. This
change makes that possible.
This doesn't break any API or ABI to the best of my knowledge and this
assumption was confirmed by Emmanuele Bassi and Tim-Phil
Changes in this version of series:
In the newly added test case, ensure:
* all device objects are freed
* devices XML tree remains the same.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Validation (if attempted) should just fail in this case instead of
crashing.
---
libvirt-gconfig/libvirt-gconfig-object.c | 8
1 file changed, 8 insertions(+)
diff --git a/libvirt-gconfig/libvirt-gconfig-object.c
b/libvirt-gconfig/libvirt-gconfig-object.c
index 6225de2..851e35c 100644
-
On Thu, Nov 3, 2016 at 2:17 PM, Christophe Fergeau wrote:
> On Thu, Nov 03, 2016 at 02:05:46PM +0100, Zeeshan Ali wrote:
>> On Thu, Nov 3, 2016 at 1:03 PM, Christophe Fergeau
>> wrote:
>> > On Thu, Nov 03, 2016 at 10:06:22AM +0100, Zeeshan Ali wrote:
>> >
On Thu, Nov 3, 2016 at 1:03 PM, Christophe Fergeau wrote:
> On Thu, Nov 03, 2016 at 10:06:22AM +0100, Zeeshan Ali wrote:
>> ---
>> tests/test-gconfig.c| 22 ++
>> tests/xml/gconfig-domain-device-unknown.xml | 5 +
>> 2 f
On Thu, Nov 3, 2016 at 12:34 PM, Christophe Fergeau wrote:
> On Thu, Nov 03, 2016 at 10:00:56AM +0100, Zeeshan Ali wrote:
>> Hi Christophe,
>>
>> On Wed, Nov 2, 2016 at 6:21 PM, Christophe Fergeau
>> wrote:
>> > Hey,
>> >
>> > On Tu
We'll need to load XML from file in another function, that will be added
in a following patch.
---
tests/test-gconfig.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/tests/test-gconfig.c b/tests/test-gconfig.c
index a26bb5f..5389a26 100644
--- a/tests/test-gc
---
tests/test-gconfig.c| 22 ++
tests/xml/gconfig-domain-device-unknown.xml | 5 +
2 files changed, 27 insertions(+)
create mode 100644 tests/xml/gconfig-domain-device-unknown.xml
diff --git a/tests/test-gconfig.c b/tests/test-gconfig.c
index 538
Validation (if attempted) should just fail in this case instead of
crashing.
---
libvirt-gconfig/libvirt-gconfig-object.c | 8
1 file changed, 8 insertions(+)
diff --git a/libvirt-gconfig/libvirt-gconfig-object.c
b/libvirt-gconfig/libvirt-gconfig-object.c
index 6225de2..851e35c 100644
-
We'll need to instatiate DomainDevice baseclass itself for unknown (think
new devices added to libvirt XML) devices in a following patch. This
change makes that possible.
This doesn't break any API or ABI to the best of my knowledge and this
assumption was confirmed by Emmanuele Bassi and Tim-Phil
Hi,
As usual I forgot to attach a summary. The changes in v2 are:
* Keeping a debug() log for unknown devices.
* Adding the test case XML file I forgot to add last time.
On Thu, Nov 3, 2016 at 10:06 AM, Zeeshan Ali wrote:
> Currently we can and do get into serious trouble with this kind
Currently we can and do get into serious trouble with this kind of code:
devices = gvir_config_domain_get_devices(domain);
gvir_config_domain_set_devices(domain, domain);
since the first call above won't return a complete list of objects present
in the domain but only the ones we have specific cl
Hi Christophe,
On Wed, Nov 2, 2016 at 6:21 PM, Christophe Fergeau wrote:
> Hey,
>
> On Tue, Nov 01, 2016 at 05:46:05PM +0100, Zeeshan Ali wrote:
>> Currently we can and do get into serious trouble with this kind of code:
>>
>> devices = gvir_confi
We'll need to instatiate DomainDevice baseclass itself for unknown (think
new devices added to libvirt XML) devices in a following patch. This
change makes that possible.
This doesn't break any API or ABI to the best of my knowledge and this
assumption was confirmed by Emmanuele Bassi and Tim-Phil
---
tests/test-gconfig.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/tests/test-gconfig.c b/tests/test-gconfig.c
index 5389a26..b91f5af 100644
--- a/tests/test-gconfig.c
+++ b/tests/test-gconfig.c
@@ -762,6 +762,26 @@ static void test_domain_device_pci_hostdev(void)
Currently we can and do get into serious trouble with this kind of code:
devices = gvir_config_domain_get_devices(domain);
gvir_config_domain_set_devices(domain, domain);
since the first call above won't return a complete list of objects present
in the domain but only the ones we have specific cl
We'll need to load XML from file in another function, that will be added
in a following patch.
---
tests/test-gconfig.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/tests/test-gconfig.c b/tests/test-gconfig.c
index a26bb5f..5389a26 100644
--- a/tests/test-gc
Validation (if attempted) should just fail in this case instead of
crashing.
---
libvirt-gconfig/libvirt-gconfig-object.c | 8
1 file changed, 8 insertions(+)
diff --git a/libvirt-gconfig/libvirt-gconfig-object.c
b/libvirt-gconfig/libvirt-gconfig-object.c
index 6225de2..851e35c 100644
-
, Zeeshan Ali (Khattak)
wrote:
> ---
> tests/test-gconfig.c| 43
> +
> tests/xml/gconfig-domain-device-pci-hostdev.xml | 11 +++
> 2 files changed, 54 insertions(+)
> create mode 100644 tests/xml/gconfig-domain-devi
---
tests/test-gconfig.c| 43 +
tests/xml/gconfig-domain-device-pci-hostdev.xml | 11 +++
2 files changed, 54 insertions(+)
create mode 100644 tests/xml/gconfig-domain-device-pci-hostdev.xml
diff --git a/tests/test-gconfig.c b/tests/test-gc
received a copy of the GNU Lesser General Public
+ * License along with this library. If not, see
+ * <http://www.gnu.org/licenses/>.
+ *
+ * Authors: Zeeshan Ali (Khattak)
+ * Christophe Fergeau
+ */
+
+#include
+
+#include "libvirt-gconfig/libvirt-gconfig.h"
+#include
From: Christophe Fergeau
They will be useful to do more checks in the GVirDomainDeviceHostdev
unit test.
---
.../libvirt-gconfig-domain-address-pci.c | 45 ++
.../libvirt-gconfig-domain-address-pci.h | 5 +++
libvirt-gconfig/libvirt-gconfig.sym
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library. If not, see
+ * <http://www.gnu.org/licenses/>.
+ *
+ * Authors: Zeeshan Ali (Khattak)
+ * Christophe Fergeau
+ */
+
+#include
+
+#include "libvirt-gconfig/libvirt-gconfig
From: Christophe Fergeau
---
libvirt-gconfig/libvirt-gconfig-object-private.h | 2 ++
libvirt-gconfig/libvirt-gconfig-object.c | 13 +
2 files changed, 15 insertions(+)
diff --git a/libvirt-gconfig/libvirt-gconfig-object-private.h
b/libvirt-gconfig/libvirt-gconfig-object-p
On Mon, Jul 25, 2016 at 10:08 AM, Christophe Fergeau
wrote:
> On Fri, Jul 22, 2016 at 01:43:35PM +0100, Zeeshan Ali (Khattak) wrote:
>> +gboolean
>> gvir_config_domain_hostdev_pci_get_rom_bar(GVirConfigDomainHostdevPci
>> *hostdev)
>> +{
>> +xmlNodePtr
From: Christophe Fergeau
They will be useful to do more checks in the GVirDomainDeviceHostdev
unit test.
---
.../libvirt-gconfig-domain-address-pci.c | 45 ++
.../libvirt-gconfig-domain-address-pci.h | 5 +++
libvirt-gconfig/libvirt-gconfig.sym
received a copy of the GNU Lesser General Public
+ * License along with this library. If not, see
+ * <http://www.gnu.org/licenses/>.
+ *
+ * Authors: Zeeshan Ali (Khattak)
+ * Christophe Fergeau
+ */
+
+#include
+
+#include "libvirt-gconfig/libvirt-gconfig.h"
+#include
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library. If not, see
+ * <http://www.gnu.org/licenses/>.
+ *
+ * Authors: Zeeshan Ali (Khattak)
+ * Christophe Fergeau
+ */
+
+#include
+
+#include "libvirt-gconfig/libvirt-gconfig
From: Christophe Fergeau
---
libvirt-gconfig/libvirt-gconfig-object-private.h | 2 ++
libvirt-gconfig/libvirt-gconfig-object.c | 13 +
2 files changed, 15 insertions(+)
diff --git a/libvirt-gconfig/libvirt-gconfig-object-private.h
b/libvirt-gconfig/libvirt-gconfig-object-p
---
tests/test-gconfig.c| 43 +
tests/xml/gconfig-domain-device-pci-hostdev.xml | 11 +++
2 files changed, 54 insertions(+)
create mode 100644 tests/xml/gconfig-domain-device-pci-hostdev.xml
diff --git a/tests/test-gconfig.c b/tests/test-gc
Hi,
On Fri, Jul 22, 2016 at 10:27 AM, Christophe Fergeau
wrote:
> On Thu, Jul 21, 2016 at 06:11:36PM +0100, Zeeshan Ali (Khattak) wrote:
>> Hi,
>>
>> On Mon, Jul 18, 2016 at 3:54 PM, Christophe Fergeau
>> wrote:
>> > Please add a gconfig: prefix to the sub
From: Christophe Fergeau
They will be useful to do more checks in the GVirDomainDeviceHostdev
unit test.
---
.../libvirt-gconfig-domain-address-pci.c | 45 ++
.../libvirt-gconfig-domain-address-pci.h | 5 +++
libvirt-gconfig/libvirt-gconfig.sym
---
tests/test-gconfig.c| 43 +
tests/xml/gconfig-domain-device-pci-hostdev.xml | 11 +++
2 files changed, 54 insertions(+)
create mode 100644 tests/xml/gconfig-domain-device-pci-hostdev.xml
diff --git a/tests/test-gconfig.c b/tests/test-gc
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library. If not, see
+ * <http://www.gnu.org/licenses/>.
+ *
+ * Authors: Zeeshan Ali (Khattak)
+ * Christophe Fergeau
+ */
+
+#include
+
+#include "libvirt-gconfig/libvirt-gconfig
From: Christophe Fergeau
---
libvirt-gconfig/libvirt-gconfig-object-private.h | 2 ++
libvirt-gconfig/libvirt-gconfig-object.c | 13 +
2 files changed, 15 insertions(+)
diff --git a/libvirt-gconfig/libvirt-gconfig-object-private.h
b/libvirt-gconfig/libvirt-gconfig-object-p
received a copy of the GNU Lesser General Public
+ * License along with this library. If not, see
+ * <http://www.gnu.org/licenses/>.
+ *
+ * Authors: Zeeshan Ali (Khattak)
+ * Christophe Fergeau
+ */
+
+#include
+
+#include "libvirt-gconfig/libvirt-gconfig.h"
+#include
fy for adding patch series version.
> Acked-by: Christophe Fergeau
>
> Christophe
>
> On Wed, Jul 06, 2016 at 10:45:52PM +0100, Zeeshan Ali (Khattak) wrote:
>> Add API to read and write domain/devices/hostdev nodes. This patch only
>> adds the baseclass and hence is
; } LIBVIRT_GCONFIG_0.2.2;
>>
>> +LIBVIRT_GCONFIG_0.2.5 {
>> + gvir_config_domain_graphics_spice_set_listen;
>> +} LIBVIRT_GCONFIG_0.2.4;
>> +
>> # define new API here using predicted next version number
>> --
>> 2.5.5
>>
>
>
>
> --
> Visarion-Mingopol Alexandru-Viorel
> Telefon : 0729614060
> Best Bucuresti
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
--
Regards,
Zeeshan Ali (Khattak)
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Add a getter for model of domain video device.
---
libvirt-gconfig/libvirt-gconfig-domain-video.c | 12
libvirt-gconfig/libvirt-gconfig-domain-video.h | 1 +
libvirt-gconfig/libvirt-gconfig.sym| 1 +
3 files changed, 14 insertions(+)
diff --git a/libvirt-gconfig/libvirt
Hi,
On Wed, Jul 13, 2016 at 4:27 PM, Daniel P. Berrange wrote:
> On Wed, Jul 13, 2016 at 04:16:01PM +0100, Zeeshan Ali (Khattak) wrote:
>> Rename GVIR_CONFIG_DOMAIN_VIDEO_MODEL_VIRTIO to
>> GVIR_CONFIG_DOMAIN_VIDEO_MODEL_VIRTIO_GPU to get the naming the same as
>> used by l
Rename GVIR_CONFIG_DOMAIN_VIDEO_MODEL_VIRTIO to
GVIR_CONFIG_DOMAIN_VIDEO_MODEL_VIRTIO_GPU to get the naming the same as
used by libosinfo. Consistency is good anyway in general but this would
also mean that Boxes can start using virgl without any changes.
---
examples/config-demo.py
From: Christophe Fergeau
They will be useful to do more checks in the GVirDomainDeviceHostdev
unit test.
---
.../libvirt-gconfig-domain-address-pci.c | 45 ++
.../libvirt-gconfig-domain-address-pci.h | 5 +++
libvirt-gconfig/libvirt-gconfig.sym
received a copy of the GNU Lesser General Public
+ * License along with this library. If not, see
+ * <http://www.gnu.org/licenses/>.
+ *
+ * Authors: Zeeshan Ali (Khattak)
+ * Christophe Fergeau
+ */
+
+#include
+
+#include "libvirt-gconfig/libvirt-gconfig.h"
+#include
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library. If not, see
+ * <http://www.gnu.org/licenses/>.
+ *
+ * Authors: Zeeshan Ali (Khattak)
+ * Christophe Fergeau
+ */
+
+#include
+
+#include "libvirt-gconfig/libvirt-gconfig
It's back! :) Really intend to actually get it finished and merged this time
around.
Basically I mostly fixed all the minor issues in patch 3/5 (Add
GVirConfigDomainHostdevPci) pointed out in last review, including treatment of
on/off attributes (which is why the patch "libvirt-gconfig: Accept
From: Christophe Fergeau
---
libvirt-gconfig/libvirt-gconfig-object-private.h | 2 ++
libvirt-gconfig/libvirt-gconfig-object.c | 13 +
2 files changed, 15 insertions(+)
diff --git a/libvirt-gconfig/libvirt-gconfig-object-private.h
b/libvirt-gconfig/libvirt-gconfig-object-p
---
tests/test-gconfig.c| 43 +
tests/xml/gconfig-domain-device-pci-hostdev.xml | 11 +++
2 files changed, 54 insertions(+)
create mode 100644 tests/xml/gconfig-domain-device-pci-hostdev.xml
diff --git a/tests/test-gconfig.c b/tests/test-gc
On Thu, May 12, 2016 at 1:28 PM, Christophe Fergeau wrote:
> Looks I never answered this one.
>
> On Tue, Apr 26, 2016 at 05:04:30PM +0100, Zeeshan Ali (Khattak) wrote:
>> >> +const gchar
>> >> *gvir_config_domain_hostdev_pci_get_rom_file(GVirConfi
On Thu, Apr 21, 2016 at 3:12 PM, Christophe Fergeau wrote:
> On Fri, Apr 15, 2016 at 02:38:22PM +0100, Zeeshan Ali (Khattak) wrote:
>> Add API to read and write PCI hostdev nodes.
>> ---
>> libvirt-gconfig/Makefile.am| 2 +
>> .../libvirt-g
On Thu, Apr 21, 2016 at 2:55 PM, Christophe Fergeau wrote:
> On Fri, Apr 15, 2016 at 02:38:19PM +0100, Zeeshan Ali (Khattak) wrote:
>> From: Christophe Fergeau
>
> This patch is mine, hopefully someone else will review it ;)
Sure, ACK. :)
> Christophe
--
Regards,
Ze
On Thu, Apr 21, 2016 at 3:14 PM, Christophe Fergeau wrote:
> And one more.
Yours? AFAIK it's mine.
> On Fri, Apr 15, 2016 at 02:38:24PM +0100, Zeeshan Ali (Khattak) wrote:
>> ---
>> tests/test-gconfig.c| 43
>> +
On Thu, Apr 21, 2016 at 3:14 PM, Christophe Fergeau wrote:
> Another patch that I wrote...
ACK.
> Christophe
>
> On Fri, Apr 15, 2016 at 02:38:23PM +0100, Zeeshan Ali (Khattak) wrote:
>> From: Christophe Fergeau
>>
>> They will be useful to do more checks in the G
---
tests/test-gconfig.c| 43 +
tests/xml/gconfig-domain-device-pci-hostdev.xml | 11 +++
2 files changed, 54 insertions(+)
create mode 100644 tests/xml/gconfig-domain-device-pci-hostdev.xml
diff --git a/tests/test-gconfig.c b/tests/test-gc
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library. If not, see
+ * <http://www.gnu.org/licenses/>.
+ *
+ * Authors: Zeeshan Ali (Khattak)
+ * Christophe Fergeau
+ */
+
+#include
+
+#include "libvirt-gconfig/libvirt-gconfig
have received a copy of the GNU Lesser General Public
+ * License along with this library. If not, see
+ * <http://www.gnu.org/licenses/>.
+ *
+ * Authors: Zeeshan Ali (Khattak)
+ * Christophe Fergeau
+ */
+
+#include
+
+#include "libvirt-gconfig/libvirt-gconfig.h"
+#
gvir_config_object_get_attribute_boolean() currently only accepts yes/no
as boolean attribute values. Let's also accept on/off as valid values
too.
This will come handy in a following patch that adds 'hostdev' handling
API.
---
libvirt-gconfig/libvirt-gconfig-object.c | 4 ++--
1 file changed, 2
Finally I got the time to clean-up and fix the patches. It's been a while last
i looked into them already and I got a bit confused at some point so I
appologize if I didn't address some of the review comments.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/list
From: Christophe Fergeau
---
libvirt-gconfig/libvirt-gconfig-object-private.h | 2 ++
libvirt-gconfig/libvirt-gconfig-object.c | 13 +
2 files changed, 15 insertions(+)
diff --git a/libvirt-gconfig/libvirt-gconfig-object-private.h
b/libvirt-gconfig/libvirt-gconfig-object-p
From: Christophe Fergeau
They will be useful to do more checks in the GVirDomainDeviceHostdev
unit test.
---
.../libvirt-gconfig-domain-address-pci.c | 45 ++
.../libvirt-gconfig-domain-address-pci.h | 5 +++
libvirt-gconfig/libvirt-gconfig.sym
On Fri, Mar 11, 2016 at 3:15 PM, Christophe Fergeau wrote:
> On Fri, Mar 11, 2016 at 03:03:03PM +0000, Zeeshan Ali (Khattak) wrote:
>> On Fri, Mar 11, 2016 at 9:21 AM, Christophe Fergeau
>> wrote:
>> > On Thu, Mar 10, 2016 at 05:08:33PM +, Zeeshan Ali (
On Fri, Mar 11, 2016 at 9:21 AM, Christophe Fergeau wrote:
> On Thu, Mar 10, 2016 at 05:08:33PM +0000, Zeeshan Ali (Khattak) wrote:
>> Hi,
>>
>> I'm a bit confused, this patch doesn't seem to add anything to mine.
>> Did you forget to commit?
>
> As indi
Hi,
I'm a bit confused, this patch doesn't seem to add anything to mine.
Did you forget to commit?
On Fri, Jan 29, 2016 at 6:21 PM, Christophe Fergeau wrote:
> From: "Zeeshan Ali (Khattak)"
>
> ---
> tests/test-gconfig.c| 30
>
quot;on"))
>> +*bar = TRUE;
>> +else
>> +*bar = FALSE;
>> +
>> +return (const char *) rom_node->children->content;
>
> The filename is in the file attribute, it's not in the node content
> (addressed in a patch I'm goin
Hi,
On Fri, Jan 29, 2016 at 5:18 PM, Christophe Fergeau wrote:
> Hey,
>
> A gconfig: prefix in the commit shortlog would be nice
Hmm.. maybe for consistency, yes but I'll remove "GVirConfig" then
from class name.
> On Thu, Jan 28, 2016 at 04:32:12PM +0100, Zeeshan A
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library. If not, see
+ * <http://www.gnu.org/licenses/>.
+ *
+ * Authors: Zeeshan Ali (Khattak)
+ * Christophe Fergeau
+ */
+
+#include
+
+#include "libvirt-gconfig/libvirt-gconfig
received a copy of the GNU Lesser General Public
+ * License along with this library. If not, see
+ * <http://www.gnu.org/licenses/>.
+ *
+ * Authors: Zeeshan Ali (Khattak)
+ * Christophe Fergeau
+ */
+
+#include
+
+#include "libvirt-gconfig/libvirt-gconfig.h"
+#include
---
tests/test-gconfig.c| 30 +
tests/xml/gconfig-domain-device-pci-hostdev.xml | 11 +
2 files changed, 41 insertions(+)
create mode 100644 tests/xml/gconfig-domain-device-pci-hostdev.xml
diff --git a/tests/test-gconfig.c b/tests/test-
Justification from IRC chat:
danpb: i'm not sure it's good to have a g_debug() for every
libvirt-gobject/gconfig object creation/destruction
danpb: the debug output becomes so big that at least I never
think about enabling it at runtime and sometimes end up missing
imp
On Thu, Nov 26, 2015 at 10:20 AM, Christophe Fergeau
wrote:
> Hey,
>
> Still a couple of comments :(
Fixed and pushed. Thanks for reviews.
--
Regards,
Zeeshan Ali (Khattak)
Befriend GNOME: http://www.gnome.org/friends/
--
libvir-list mai
Drop usage of deprecated GSimpleAsyncResult API.
---
v5:
* Plug some GError leaks.
* Drop StoragePoolBuildData in favour of GUINT_TO_POINTER/GPOINTER_TO_UINT.
* Don't unref GTask before using it later in idle callback.
libvirt-gobject/libvirt-gobject-domain.c| 290 +-
On Tue, Nov 24, 2015 at 4:23 PM, Zeeshan Ali (Khattak)
wrote:
> Drop usage of deprecated GSimpleAsyncResult API.
> ---
This version ensures that async result is returned from the main
thread in gvir_stream_close_async().
> libvirt-gobject/libvirt-gobject-domain.c
Drop usage of deprecated GSimpleAsyncResult API.
---
libvirt-gobject/libvirt-gobject-domain.c| 290 +---
libvirt-gobject/libvirt-gobject-input-stream.c | 77 +++
libvirt-gobject/libvirt-gobject-output-stream.c | 75 +++---
libvirt-gobject/libvirt-gobject-storage-
On Mon, Nov 23, 2015 at 10:45 PM, Zeeshan Ali (Khattak)
wrote:
> Drop usage of deprecated GSimpleAsyncResult API.
> ---
Sorry, forgot to pass --annotate option to git-send-email.
v3 just drops some of the private context structures in favour of
GPOINTER_TO_UINT/GUINT_TO_POINTER
Drop usage of deprecated GSimpleAsyncResult API.
---
libvirt-gobject/libvirt-gobject-domain.c| 290 +---
libvirt-gobject/libvirt-gobject-input-stream.c | 77 +++
libvirt-gobject/libvirt-gobject-output-stream.c | 75 +++---
libvirt-gobject/libvirt-gobject-storage-
On Mon, Nov 23, 2015 at 4:08 PM, Christophe Fergeau wrote:
> On Fri, Nov 20, 2015 at 09:06:30PM +0000, Zeeshan Ali (Khattak) wrote:
>> Drop usage of deprecated GSimpleAsyncResult API.
>> ---
>
> A Changes since v1 section would be nice as this patch is a bit big.
&g
Drop usage of deprecated GSimpleAsyncResult API.
---
libvirt-gobject/libvirt-gobject-domain.c| 273 +++
libvirt-gobject/libvirt-gobject-input-stream.c | 77 +++
libvirt-gobject/libvirt-gobject-output-stream.c | 75 +++
libvirt-gobject/libvirt-gobject-storage-
We already require and use glib >= 2.36 so there is no reason to keep
around code to ensure compatibility with glib older than that.
---
libvirt-gobject/libvirt-gobject-compat.c | 87
libvirt-gobject/libvirt-gobject-compat.h | 73 ---
2 file
We already require and use glib >= 2.36 so there is no reason to keep
around code to ensure compatibility with glib older than that.
---
libvirt-gconfig/libvirt-gconfig-compat.h | 20
1 file changed, 20 deletions(-)
diff --git a/libvirt-gconfig/libvirt-gconfig-compat.h
b/lib
We already require and use glib >= 2.36 so there is no reason to keep
around code to ensure compatibility with glib older than that.
---
libvirt-gconfig/libvirt-gconfig-compat.h | 20
1 file changed, 20 deletions(-)
diff --git a/libvirt-gconfig/libvirt-gconfig-compat.h
b/lib
and returning immediately
> without doing anything?
I doubt so. AFAICT, it was scheduling the result to be returned in the
idle using 'g_simple_async_result_complete_in_idle'.
> The helper does not seem to be doing anything more, in which case I'd
> suggest not creating
---
libvirt-gobject/libvirt-gobject-domain.c | 134 +++
libvirt-gobject/libvirt-gobject-domain.h | 15 +++-
libvirt-gobject/libvirt-gobject.sym | 9 +++
3 files changed, 157 insertions(+), 1 deletion(-)
diff --git a/libvirt-gobject/libvirt-gobject-domain.c
b/l
eclaration wrong then? I think
it's more important to optimize it out rather than ensuring programmer
doesn't pass wrong value by mistake, here.
--
Regards,
Zeeshan Ali (Khattak)
Befriend GNOME: http://www.gnome.org/friends/
--
lib
---
This version:
* Replaces the seconds and nseconds arguments by a GDateTime.
* Drops the use of flags argument, since caller can specify the only flag
currently possible (VIR_DOMAIN_TIME_SYNC) by simply passing a NULL as the
GDateTime argument.
* Add some needed articles to doc comment.
li
Drop usage of deprecated GSimpleAsyncResult API.
---
libvirt-gobject/libvirt-gobject-domain.c| 270 ++-
libvirt-gobject/libvirt-gobject-input-stream.c | 76 +++
libvirt-gobject/libvirt-gobject-output-stream.c | 75 +++
libvirt-gobject/libvirt-gobject-storage-
We already require and use glib >= 2.36 so there is no reason to keep
around code to ensure compatibility with glib oler than that.
---
libvirt-gobject/libvirt-gobject-compat.c | 87
libvirt-gobject/libvirt-gobject-compat.h | 73 ---
2 files
We already require and use glib >= 2.36 so there is no reason to keep
around code to ensure compatibility with glib oler than that.
---
libvirt-gconfig/libvirt-gconfig-compat.h | 20
1 file changed, 20 deletions(-)
diff --git a/libvirt-gconfig/libvirt-gconfig-compat.h
b/libv
Couldn't come up with a better summary here, sorry but these patches simply
* Drop usage of deprecated GSimpleAsyncResult API.
* Drop redundant compatibility API.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Hi Christophe,
On Wed, Oct 28, 2015 at 10:15 AM, Christophe Fergeau
wrote:
> Hey,
>
> On Tue, Oct 27, 2015 at 06:17:58PM +, Zeeshan Ali (Khattak) wrote:
>> ---
>> libvirt-gobject/libvirt-gobject-domain.c | 126
>> +++
>> libvirt
---
libvirt-gobject/libvirt-gobject-domain.c | 126 +++
libvirt-gobject/libvirt-gobject-domain.h | 25 ++
libvirt-gobject/libvirt-gobject.sym | 9 +++
3 files changed, 160 insertions(+)
diff --git a/libvirt-gobject/libvirt-gobject-domain.c
b/libvirt-gobjec
On Wed, Sep 23, 2015 at 3:00 PM, Daniel P. Berrange wrote:
> On Wed, Sep 23, 2015 at 02:54:51PM +0100, Zeeshan Ali (Khattak) wrote:
>> On Wed, Sep 23, 2015 at 2:18 PM, Daniel P. Berrange
>> wrote:
>> > On Wed, Sep 23, 2015 at 01:44:28PM +0100, Zeeshan Ali (Khattak) w
On Wed, Sep 23, 2015 at 2:18 PM, Daniel P. Berrange wrote:
> On Wed, Sep 23, 2015 at 01:44:28PM +0100, Zeeshan Ali (Khattak) wrote:
>> The returned GVirStoragePoolInfo pointer is not a GObject so it must not
>> be unrefed using g_object_unref(). Since gvir_storage_pool_info_free(
The returned GVirStoragePoolInfo pointer is not a GObject so it must not
be unrefed using g_object_unref(). Since gvir_storage_pool_info_free()
is private function, callers must either use g_slice_free() or
g_boxed_free().
---
Perhaps we should just make gvir_storage_pool_info_free() public instea
> + - glib-2.0
> + - gobject-2.0
> + - libxml-2.0
> + - libvirt
> +
> +Functionality is optionally enhanced by the following packages:
> +
> + - gobject-introspection
> + - Vala (build-time only)
>
> Patches sumissions
> ==
> --
> 2.4.3
kes tests/test-gconfig valgrind-clean, and refactors
>> > two
>> > setters in GVirConfigDomainVideo to make them use the helpers provided by
>> > GVirConfigObject.
>>
>> Ping?
>
> These missed the libvirt-glib release, it would be nice to get them
>
On Tue, Jul 21, 2015 at 4:09 PM, Daniel P. Berrange wrote:
> On Tue, Jul 21, 2015 at 03:56:54PM +0100, Zeeshan Ali (Khattak) wrote:
>> On Tue, Jul 21, 2015 at 3:20 PM, Daniel P. Berrange
>> wrote:
>> > Previously the use of virDomainOpenGraphicsFD API from libvirt
&
guint flags,
> GError **err)
> {
> +#ifdef HAVE_VIR_NETWORK_GET_DHCP_LEASES
> virNetworkDHCPLeasePtr *leases;
> GList *ret = NULL;
> int num_leases, i;
> +#endif /* HAVE_VIR_NETWORK_GET_DHCP_LEASES */
>
>
1 - 100 of 551 matches
Mail list logo
