[PATCH] Re: storage: Cleaning up pools is not always ideal

2020-01-17 Thread ebenner
From: Eric Benner Didn't have a sign off and was formatted by a mail client. This is a functional copy of this patch with the requirements. Signed-off-by: Eric Benner --- src/remote/libvirtd.conf.in | 7 +++ src/storage/storage_driver.c | 38 2 files

[libvirt] [PATCH] Cleaning up pools is not always ideal

2020-01-06 Thread ebenner
Libvirt cleans up pools that error out by deactivating them. When using LVM this is not very useful. We rather would have our own system handle any real failures and to many situations where errors are meaningless and unimportant cause Libvirt to disable our pools continuously causing lots of g

[libvirt] [PATCH] Don't check if the path exists for LVM

2020-01-06 Thread ebenner
I'm not entirely sure why Libvirt is checking to see if the target file exists for LVM but it is a problem. Empty volume groups do not appear in /dev. When libvirt starts these pools then fail to autostart because their path does not exist. This is not useful, this is the patch we are running t