Re: [libvirt] [PATCH] Omitting braces with a single-line body

2013-04-22 Thread harryxiyou
On Mon, Apr 22, 2013 at 10:33 PM, Eric Blake wrote: [...] > It's capital 'I', not lower case 'l'. That's shorthand using sed syntax > for an in-place replacement you should perform on your text. It means > you should have written: > After I read libvirt/HACKING file, I find we should > for that

Re: [libvirt] [PATCH] Omitting braces with a single-line body

2013-04-22 Thread harryxiyou
On Mon, Apr 22, 2013 at 9:13 PM, Osier Yang wrote: > On 22/04/13 20:33, harryxi...@gmail.com wrote: >> >> From: Harry Wei >> >> After i read libvirt/HACKING file, i find we should > > > s/i/I/, Actually, i wonder what 's/i/l/' means? > > >> Omit braces with a single-line body. So this patch >>

[libvirt] [PATCH] Omitting braces with a single-line body

2013-04-22 Thread harryxiyou
From: Harry Wei After i read libvirt/HACKING file, i find we should Omit braces with a single-line body. So this patch fix this coding style problem for Sheepdog storage backend driver. Signed-off-by: Harry Wei --- src/storage/storage_backend_sheepdog.c | 11 --- 1 file changed, 4 in

Re: [libvirt] [PATCH] Virsh command vol-rename

2013-04-19 Thread harryxiyou
On Fri, Apr 19, 2013 at 1:42 PM, Osier Yang wrote: [...] > > There is no new things in the wiki. Sorry, i have not put my new design plan for 'Rename volume name'. > > Before writing the code, I'd suggest going through the HACKING > and the document for how to implement a new API for libvirt [1]

Re: [libvirt] [PATCH] Virsh command vol-rename

2013-04-18 Thread harryxiyou
On Thu, Apr 18, 2013 at 11:03 PM, Eric Blake wrote: [...] > Exactly - we need to add a new libvirt API that can support renames at > the backend driver level, with instant effect (a directory pool > forwarding to rename(2), other pools using pool-specific renaming commands). > > It might be worth

Re: [libvirt] [PATCH] Virsh command vol-rename

2013-04-18 Thread harryxiyou
On Thu, Apr 18, 2013 at 5:30 PM, Daniel P. Berrange wrote: > On Thu, Apr 18, 2013 at 04:29:45PM +0800, harryxi...@gmail.com wrote: >> From: Harry Wei >> >> Vol-rename is a convenience function, requiring when >> one wanna rename a volume name. >> >> Signed-off-by: Harry Wei >> --- >> tools/virs

Re: [libvirt] [PATCH] Virsh command vol-rename

2013-04-18 Thread harryxiyou
On Thu, Apr 18, 2013 at 5:27 PM, Osier Yang wrote: > On 18/04/13 16:29, harryxi...@gmail.com wrote: >> >> From: Harry Wei >> >> Vol-rename is a convenience function, requiring when >> one wanna rename a volume name. > > > NACK. It should use the upcoming rename APIs for the *-rename virsh > comma

[libvirt] [PATCH] Virsh command vol-rename

2013-04-18 Thread harryxiyou
From: Harry Wei Vol-rename is a convenience function, requiring when one wanna rename a volume name. Signed-off-by: Harry Wei --- tools/virsh-volume.c | 103 ++ 1 file changed, 103 insertions(+) diff --git a/tools/virsh-volume.c b/tools/virsh-v

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-16 Thread harryxiyou
On Tue, Apr 16, 2013 at 10:39 PM, harryxiyou wrote: > On Tue, Apr 16, 2013 at 12:22 AM, Eric Blake wrote: >> On 04/15/2013 09:16 AM, harryxiyou wrote: >>>> I could be if you want, but the question is which project you are focusing >>>> on? This one or the renami

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-16 Thread harryxiyou
On Tue, Apr 16, 2013 at 12:22 AM, Eric Blake wrote: > On 04/15/2013 09:16 AM, harryxiyou wrote: >>> I could be if you want, but the question is which project you are focusing >>> on? This one or the renaming APIs? And as far as I got from the wiki page, >>> we ge

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-15 Thread harryxiyou
On Mon, Apr 15, 2013 at 11:28 PM, Stefan Hajnoczi wrote: [...] > I asked because it seems like a very mechanical and relatively short > thing to work on. > > If you still think the scope is good, then please add the project idea > to the GSoC wiki using this template: > http://qemu-project.org/Goo

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-15 Thread harryxiyou
On Tue, Apr 16, 2013 at 12:22 AM, Eric Blake wrote: [...] > This indeed feels like a reasonable project, where there is enough work > to do to fill up 12 weeks of good effort while still having something > measurable to commit, and where the design is known enough in advance > that it won't be sta

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-15 Thread harryxiyou
On Mon, Apr 15, 2013 at 10:55 PM, Daniel P. Berrange wrote: [...] > Enthusiasm of the students to learn libvirt isn't the only consideration. > The project mentors have to put non-trivial effort into GSoC and want to > have some level of confidence that the project will result in a positive > out

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-15 Thread harryxiyou
On Mon, Apr 15, 2013 at 10:56 PM, Stefan Hajnoczi wrote: [...] > A project must be a 12-week effort. Are you saying you'd like to > focus on just capability support for 12 weeks? > Yup, after i read the comments from Danpb and Osier, i find Renaming all APIs is more comfortable for GSOC. I have

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-15 Thread harryxiyou
On Mon, Apr 15, 2013 at 11:00 PM, Osier Yang wrote: > On 15/04/13 22:41, harryxiyou wrote: >> >> On Mon, Apr 15, 2013 at 9:43 PM, harryxiyou wrote: >>> >>> On Mon, Apr 15, 2013 at 5:13 PM, Daniel P. Berrange >>> wrote: >>> [...] >>>&g

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-15 Thread harryxiyou
On Mon, Apr 15, 2013 at 9:43 PM, harryxiyou wrote: > On Mon, Apr 15, 2013 at 5:13 PM, Daniel P. Berrange > wrote: > [...] >> I'm not hugely comfortable with the idea of "capability support" being >> done by a student. IMHO to do a good job on that design-

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-15 Thread harryxiyou
On Mon, Apr 15, 2013 at 5:13 PM, Daniel P. Berrange wrote: [...] > I'm not hugely comfortable with the idea of "capability support" being > done by a student. IMHO to do a good job on that design-wise requires > someone with a very good understanding of libvirt architecture & application > needs.

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-14 Thread harryxiyou
On Fri, Apr 12, 2013 at 11:29 PM, Stefan Hajnoczi wrote: > On Fri, Apr 12, 2013 at 10:58 AM, Daniel P. Berrange > wrote: >> On Fri, Apr 12, 2013 at 08:34:18AM +0200, Michal Privoznik wrote: >>> On 10.04.2013 15:13, harryxiyou wrote: >>> > >>> > Hi a

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-12 Thread harryxiyou
On Sat, Apr 13, 2013 at 1:35 PM, Osier Yang wrote: > On 13/04/13 00:05, harryxiyou wrote: >> >> On Fri, Apr 12, 2013 at 11:57 PM, Stefan Hajnoczi >> wrote: >> [...] >>> >>> Right, I'm trying to check with danpb, mprivozn, eblake, and osier >&

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-12 Thread harryxiyou
On Fri, Apr 12, 2013 at 11:57 PM, Stefan Hajnoczi wrote: [...] > Right, I'm trying to check with danpb, mprivozn, eblake, and osier > whether these tasks are worthy of a 12-week project. > > There needs to be agreement here before we can add this as a project > idea to the GSoC wiki page. > Okay,

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-12 Thread harryxiyou
On Fri, Apr 12, 2013 at 11:47 PM, harryxiyou wrote: > On Fri, Apr 12, 2013 at 11:29 PM, Stefan Hajnoczi wrote: > [...] >> Michal said earlier that virsh vol-move seemed too small a task. >> >> Do you think that these 4 tasks together merit a 12-week project? >> >

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-12 Thread harryxiyou
On Fri, Apr 12, 2013 at 11:47 PM, harryxiyou wrote: > On Fri, Apr 12, 2013 at 11:29 PM, Stefan Hajnoczi wrote: > [...] >> Michal said earlier that virsh vol-move seemed too small a task. >> >> Do you think that these 4 tasks together merit a 12-week project? >> >

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-12 Thread harryxiyou
On Fri, Apr 12, 2013 at 11:29 PM, Stefan Hajnoczi wrote: [...] > Michal said earlier that virsh vol-move seemed too small a task. > > Do you think that these 4 tasks together merit a 12-week project? > Yes, these 4 tasks should be a whole project which may merit almost a 12-week project. Like dan

Re: [libvirt] [RFC] Fix https://bugzilla.redhat.com/show_bug.cgi?id=461931

2013-04-12 Thread harryxiyou
On Fri, Apr 12, 2013 at 5:20 PM, Osier Yang wrote: > On 12/04/13 16:02, harryxiyou wrote: >> >> Hi Osier, >> >> From the actual bug messages like fowllowing >> >> Actual results: >> Traceback (most recent call last): >>File "/usr/share

[libvirt] [RFC] Fix https://bugzilla.redhat.com/show_bug.cgi?id=461931

2013-04-12 Thread harryxiyou
Hi Osier, >From the actual bug messages like fowllowing Actual results: Traceback (most recent call last): File "/usr/share/virt-manager/virtManager/createvol.py", line 191, in _async_vol_create poolobj = self.vol.install(meter=meter) File "/usr/lib/python2.5/site-packages/virtinst/Storag

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-11 Thread harryxiyou
On Fri, Apr 12, 2013 at 2:34 PM, Michal Privoznik wrote: Hi Michal, > I am not sure we want *rename virsh commands. Not only for storage, but > in general. And even if we do want these, they don't require a new API. > They can be implemented with simple vir*GetXML(); vir*Define(); > vir*Undefine

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-11 Thread harryxiyou
On Fri, Apr 12, 2013 at 2:34 PM, Michal Privoznik wrote: Hi Michal, > I am not sure we want *rename virsh commands. Not only for storage, but > in general. And even if we do want these, they don't require a new API. > They can be implemented with simple vir*GetXML(); vir*Define(); > vir*Undefine

Re: [libvirt] [RFC] Usage about 'virsh vol-wipe vol_name'

2013-04-11 Thread harryxiyou
On Fri, Apr 12, 2013 at 12:39 PM, Osier Yang wrote: [...] > The command is there, and the docs is there too. So you already had the > guide, why not to try it? > Thanks, i will. > >> >> Could anyone please give me some suggestions? Thanks in advance. >> >>> However, if users just want to wipe p

Re: [libvirt] [RFC] Usage about 'virsh vol-wipe vol_name'

2013-04-11 Thread harryxiyou
On Fri, Apr 12, 2013 at 12:42 PM, Osier Yang wrote: Hi Osier, >> >> On Fri, Apr 12, 2013 at 10:22 AM, harryxiyou wrote: >>> >>> Hi all, >>> >>> I am not very clear about the usage of ‘virsh vol-wipe vol_name’. I think >>> if 'virsh

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-11 Thread harryxiyou
On Fri, Apr 12, 2013 at 1:07 PM, Osier Yang wrote: [...] > > Not sure if you planned to request separate projects for these, but I don't > think it's deserved for separate projects. They can be just one project, > as the work need to do for them is similar. Sure, they are a whole project for GSOC

Re: [libvirt] [RFC] Usage about 'virsh vol-wipe vol_name'

2013-04-11 Thread harryxiyou
On Fri, Apr 12, 2013 at 10:22 AM, harryxiyou wrote: > Hi all, > > I am not very clear about the usage of ‘virsh vol-wipe vol_name’. I think > if 'virsh vol-wipe vol_name' can just wipe all the datas in this volume and > it is similar as we format a volume which the da

Re: [libvirt] [RFC] Usage about 'virsh vol-wipe vol_name'

2013-04-11 Thread harryxiyou
On Fri, Apr 12, 2013 at 10:22 AM, harryxiyou wrote: > Hi all, > > I am not very clear about the usage of ‘virsh vol-wipe vol_name’. I think > if 'virsh vol-wipe vol_name' can just wipe all the datas in this volume and > it is similar as we format a volume which the da

[libvirt] [RFC] Usage about 'virsh vol-wipe vol_name'

2013-04-11 Thread harryxiyou
Hi all, I am not very clear about the usage of ‘virsh vol-wipe vol_name’. I think if 'virsh vol-wipe vol_name' can just wipe all the datas in this volume and it is similar as we format a volume which the datas would be wiped, right? After this wipe, we can use this volume like a new one. However,

Re: [libvirt] [RFC] virCommandRun return error number

2013-04-11 Thread harryxiyou
On Thu, Apr 11, 2013 at 10:59 PM, Daniel P. Berrange wrote: [...] > The question of efficiency is irrelevant in this context. We are > explicitly choosing to prioritize reliability and readability of > the code here. > ACK. -- Thanks Harry Wei -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [RFC] virCommandRun return error number

2013-04-11 Thread harryxiyou
On Thu, Apr 11, 2013 at 11:03 PM, Eric Blake wrote: [...] > No need. You are talking about the error path, the one that only hits > on the RARE case of OOM. If we are OOM, we are already hosed - what > does it matter if we take a few extra calls to a few more virCommand*() > functions before fin

Re: [libvirt] [RFC] virCommandRun return error number

2013-04-11 Thread harryxiyou
On Thu, Apr 11, 2013 at 10:26 PM, Eric Blake wrote: Hi Eric, [...] > Not necessary. virCommand is DESIGNED for streamlined usage, so that it > is much easier to read how the command is constructed without being > distracted by error checking in the caller every step of the way. As a > virComma

[libvirt] [PATCH] Fix error return value for VirCommandNewArgList

2013-04-11 Thread harryxiyou
From: Harry Wei virCommandNewArgList may return NULL so we need not do following stuffs and just return '-1'. Signed-off-by: Harry Wei CC: Osier Yang CC: Michal Privoznik --- src/storage/storage_backend_sheepdog.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/storage/

Re: [libvirt] [RFC] virCommandRun return error number

2013-04-11 Thread harryxiyou
On Thu, Apr 11, 2013 at 9:38 PM, Michal Privoznik wrote: [...] > Maybe you've pasted wrong code snippet, but the one you've pasted is > correct. If virCommandRun() fails and returns -1; we return that value > to the caller. And if the command doesn't fail, we call > virStorageBackendSheepdogParseN

[libvirt] [RFC] virCommandRun return error number

2013-04-11 Thread harryxiyou
Hi all, I copy portions of libvirt/src/storage/storage_backend_sheepdog.c [...] 125 ret = virCommandRun(cmd, NULL); 126 if (ret == 0) 127 ret = virStorageBackendSheepdogParseNodeInfo(pool->def, output); [...] I found virCommandRun may return '-1', which hinds something error happe

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-04-10 Thread harryxiyou
On Fri, Feb 8, 2013 at 4:07 PM, Michal Privoznik wrote: > On 07.02.2013 16:19, Stefan Hajnoczi wrote: >> I have created the Google Summer of Code 2013 wiki page where you can >> add project ideas: >> >> http://wiki.qemu.org/Google_Summer_of_Code_2013 >> >> Please add project ideas you are willing

Re: [libvirt] Cannot download gnulib

2013-03-06 Thread harryxiyou
On Wed, Mar 6, 2013 at 11:35 PM, Guannan Ren wrote: [...] >I am not quite sure it was fixed by a patch. >It probably caused by gnulib git server problem(I guess) >I just tried just now, it worked well. Ok, thanks very much ;-) -- Thanks Harry Wei -- libvir-list mailing list libvir

Re: [libvirt] Cannot download gnulib

2013-03-06 Thread harryxiyou
On Tue, Mar 5, 2013 at 11:15 PM, Guannan Ren wrote: Hi Guannan, > > I met this problem yesterday too, but now, it is fixed. > you can try again. > We have to reset libvirt git tree to libvirt v1.0.1 so that our patches work well. Therefore, could you please tell us the patches location,

Re: [libvirt] Compile libvirt V1.0.1 error

2013-02-27 Thread harryxiyou
On Thu, Feb 28, 2013 at 12:47 AM, Eric Blake wrote: [...] > What a waste of resources - that forks a shell to do an echo every time > that you use ${JVM_DIR}. Much simpler to write as: > > JVM_DIR=${JAVA_HOME} > I am not familiar with automake so i just use shell to finish this job. I will test

Re: [libvirt] Compile libvirt V1.0.1 error

2013-02-26 Thread harryxiyou
On Wed, Feb 27, 2013 at 11:04 AM, Eric Blake wrote: [...] > You trimmed too much of your make line to tell us what was happening. > It might also help to run 'make V=1' to get the full command line being > attempted. I have to wonder if you have an unexpanded '$JAVA_HOME' > injected somewhere int

[libvirt] Compile libvirt V1.0.1 error

2013-02-26 Thread harryxiyou
Hi all, When i compiled libvirt like following 1. git clone git://libvirt.org/libvirt.git;cd libvirt 2. git reset --hard v1.0.1 3. wget http://cloudxy.googlecode.com/svn/branches/hlfs/person/harry/hlfs/patches/hlfs_driver_for_libvirt_network_disk.patch 4. wget http://cloudxy.googlecode.

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-02-14 Thread harryxiyou
On Thu, Feb 14, 2013 at 11:15 PM, Stefan Hajnoczi wrote: [...] > Hi Harry, Hi Stefan, > Thanks for your interest. You can begin thinking about ideas but > please keep in mind that we are still in the very early stages of GSoC > preparation. > > Google will publish the list of accepted organizati

Re: [libvirt] Google Summer of Code 2013 ideas wiki open

2013-02-14 Thread harryxiyou
On Tue, Feb 12, 2013 at 5:21 AM, Stefan Hajnoczi wrote: > On Thu, Feb 7, 2013 at 4:19 PM, Stefan Hajnoczi wrote: >> I believe Google will announce GSoC again this year (there is >> no guarantee though) and I have created the wiki page so we can begin >> organizing project ideas that students can

Re: [libvirt] Boot VM with HLFS driver for Libvirt network disk (Online storage management)

2013-02-14 Thread harryxiyou
On Thu, Feb 14, 2013 at 12:18 PM, harryxiyou wrote: [...] > I have some questions about up stuffs. > > 1, I wonder why first way (Only execute "virsh create hlfs_hdfs.xml") > do not call > qemuBuildCommandLine func, which may lead to fail to start VM with HLFS > volume

[libvirt] How to catch libvirtd logs

2013-02-14 Thread harryxiyou
Hi all, I start a VM with command "virsh create hlfs.xml", which fork a child process. But i am not sure how to catch this child process's logs? Could anyone give me some suggestions? Thanks in advance. -- Thanks Harry Wei -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.co

Re: [libvirt] [PATCH] fix a bug of sheepdog storage driver

2013-02-08 Thread harryxiyou
On Sat, Feb 9, 2013 at 5:40 AM, Eric Blake wrote: > On 02/08/2013 12:26 AM, Osier Yang wrote: >> On 2013年02月08日 14:48, harryxi...@gmail.com wrote: > > Your 'From:' line didn't match your 'Signed-off-by:' line. That makes > our generated AUTHORS file look strange. I would suggest doing: > > git c

[libvirt] Why not add snapshot operations for Sheepdog storage driver in Libvirt

2013-02-08 Thread harryxiyou
Hi all, Virsh has following operations about snapshot. Snapshot (help keyword 'snapshot') snapshot-createCreate a snapshot from XML snapshot-create-as Create a snapshot from a set of args snapshot-current Get or set the current snapshot s

Re: [libvirt] [PATCH] fix some bugs of sheepdog storage driver

2013-02-08 Thread harryxiyou
On Fri, Feb 8, 2013 at 7:11 PM, Daniel P. Berrange wrote: > On Fri, Feb 08, 2013 at 06:49:47PM +0800, harryxi...@gmail.com wrote: >> Don't try to do other jobs if get cmd NULL. >> >> Signed-off-by: Harry Wei >> >> --- >> src/storage/storage_backend_sheepdog.c | 10 ++ >> 1 files change

[libvirt] [PATCH] fix some bugs of sheepdog storage driver

2013-02-08 Thread harryxiyou
Don't try to do other jobs if get cmd NULL. Signed-off-by: Harry Wei --- src/storage/storage_backend_sheepdog.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/src/storage/storage_backend_sheepdog.c b/src/storage/storage_backend_sheepdog.c index 218284d..1ce5

[libvirt] [PATCH] fix some bugs of sheepdog storage driver

2013-02-08 Thread harryxiyou
Signed-off-by: Harry Wei --- src/storage/storage_backend_sheepdog.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/src/storage/storage_backend_sheepdog.c b/src/storage/storage_backend_sheepdog.c index 218284d..1ce5aa4 100644 --- a/src/storage/storage_backend_

Re: [libvirt] [Patch]Fix bugs of Sheepdog storage driver

2013-02-08 Thread harryxiyou
On Fri, Feb 8, 2013 at 2:00 PM, Osier Yang wrote: [...] > > Btw, if you look further more on virStorageBackendSheepdogRefreshVol, > you will see it has bugs too. It can be another patch though. > Thanks, i will fix some other bugs ;-) -- Thanks Harry Wei -- libvir-list mailing list libvir-list

[libvirt] [PATCH] fix a bug of sheepdog storage driver

2013-02-07 Thread harryxiyou
Don't try to refresh Sheepdog volume if creating volume fails. Signed-off-by: Harry Wei --- src/storage/storage_backend_sheepdog.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/storage/storage_backend_sheepdog.c b/src/storage/storage_backend_sheepdog.c i

Re: [libvirt] [Patch]Fix bugs of Sheepdog storage driver

2013-02-07 Thread harryxiyou
On Fri, Feb 8, 2013 at 1:57 PM, Osier Yang wrote: [...] > That's why I said in previous replyment "initialize ret", I mean > this (see the top of the function): > > int ret = -1; > > And with setting "ret" to 0 before cleanup: > > ret = 0; > cleanup: > virCommandFree(cmd); > return

Re: [libvirt] [Patch]Fix bugs of Sheepdog storage driver

2013-02-07 Thread harryxiyou
On Fri, Feb 8, 2013 at 1:06 PM, Osier Yang wrote: [...] > Google Groups小组敬上 > > That's bad if one could get one notice like this each time after > reviewing your patch. :-) Not sure how to get rid of this, but > I think it's caused by the permission, so please either change > the google group to p

[libvirt] [Patch]Fix bugs of Sheepdog storage driver

2013-02-07 Thread harryxiyou
diff --git a/src/storage/storage_backend_sheepdog.c b/src/storage/storage_backend_sheepdog.c index cd18f33..f987604 100644 --- a/src/storage/storage_backend_sheepdog.c +++ b/src/storage/storage_backend_sheepdog.c @@ -168,9 +168,12 @@ virStorageBackendSheepdogCreateVol(virConnectPtr conn ATTRIBUTE

[libvirt] (no subject)

2013-02-07 Thread harryxiyou
diff --git a/src/storage/storage_backend_sheepdog.c b/src/storage/storage_backend_sheepdog.c index cd18f33..f987604 100644 --- a/src/storage/storage_backend_sheepdog.c +++ b/src/storage/storage_backend_sheepdog.c @@ -168,9 +168,12 @@ virStorageBackendSheepdogCreateVol(virConnectPtr conn ATTRIBUTE

[libvirt] [Patch]Fix bugs of Sheepdog storage driver

2013-02-07 Thread harryxiyou
virStorageBackendSheepdogCreateVol calls virCommandRun whihout checking the return value, which this return value determines us whether we should call virStorageBackendSheepdogRefreshVol func. And we should also give a return value to virStorageBackendSheepdogRefreshVol func because it may cause e

[libvirt] [Patch]Fix a bug of Sheepdog storage driver

2013-02-07 Thread harryxiyou
Signed-off-by: Harry Wei --- src/storage/storage_backend_sheepdog.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/src/storage/storage_backend_sheepdog.c b/src/storage/storage_backend_sheepdog.c index cd18f33..f987604 100644 --- a/src/storage/storage_backend_sheepd

Re: [libvirt] Fix bugs of Sheepdog storage driver

2013-02-07 Thread harryxiyou
On Thu, Feb 7, 2013 at 12:54 AM, Daniel P. Berrange wrote: > On Thu, Feb 07, 2013 at 12:52:36AM +0800, harryxi...@gmail.com wrote: >> --- >> src/storage/storage_backend_sheepdog.c |5 - >> 1 files changed, 4 insertions(+), 1 deletions(-) >> >> diff --git a/src/storage/storage_backend_shee

[libvirt] [Patch]Fix bugs of Sheepdog storage driver

2013-02-06 Thread harryxiyou
Signed-off-by: Harry Wei --- src/storage/storage_backend_sheepdog.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/src/storage/storage_backend_sheepdog.c b/src/storage/storage_backend_sheepdog.c index cd18f33..2cbfe01 100644 --- a/src/storage/storage_backend_sheep

[libvirt] Fix bugs of Sheepdog storage driver

2013-02-06 Thread harryxiyou
--- src/storage/storage_backend_sheepdog.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/src/storage/storage_backend_sheepdog.c b/src/storage/storage_backend_sheepdog.c index cd18f33..2cbfe01 100644 --- a/src/storage/storage_backend_sheepdog.c +++ b/src/storage/stor

Re: [libvirt] [Patch]Sheepdog storage driver ignore refreshVol func's return value

2013-02-06 Thread harryxiyou
On Wed, Feb 6, 2013 at 11:19 PM, Eric Blake wrote: [...] > Thanks for attempting a patch. However, the commit message is > unconventionally formatted; did you use 'git send-email' to send your > patch, as suggested in HACKING? We would have to amend the message to > get rid of the 'Hi all,' line

[libvirt] [Patch]Sheepdog storage driver ignore refreshVol func's return value

2013-02-05 Thread harryxiyou
Hi all, In libvirt/src/storage/storage_backend_sheepdog.c file, func virStorageBackendSheepdogCreateVol calls func virStorageBackendSheepdogRefreshVol to refresh Sheepdog volume infos. But we do not check func virStorageBackendSheepdogRefreshVol's return value. Following patch can fix this bug. S

Re: [libvirt] A question about booting from the snapshot image by specifying snapshot id in Libvirt

2013-02-04 Thread harryxiyou
On Tue, Feb 5, 2013 at 4:31 AM, Eric Blake wrote: [...] > I'm not that familiar with sheepdog, but I'll give it a shot: > id 1 is a static point in time. But you booted your guest, which means > you have made modifications since that point in time. Those > modifications have to be stored somewhe

Re: [libvirt] How to start a snapshot of Sheepdog volume in Libvirt

2013-02-04 Thread harryxiyou
On Tue, Feb 5, 2013 at 4:49 AM, Eric Blake wrote: [...] > For an offline guest, libvirt does not yet drive 'collie' to create any > sheepdog snapshots; I don't know if 'qemu-img' has that capability > either. In other words, you are treading on frontier territory, where > you may find that a lot

[libvirt] A question about booting from the snapshot image by specifying snapshot id in Libvirt

2013-02-03 Thread harryxiyou
Hi all, I test libvirt boots QEMU VM from Sheepdog snapshot image by specify snapshot id like following. 1, $ collie vdi list NameIdSizeUsed SharedCreation time VDI id Copies Tag Alice1 10 GB 1.3 GB 0.0 MB 2013-02-01 18:59 15d167 2 s testvdi 1 20

[libvirt] How to start a snapshot of Sheepdog volume in Libvirt

2013-02-02 Thread harryxiyou
Hi all, I wanna test start a snapshot of Sheepdog volume in Libvirt. However, i cannot find a test description from https://github.com/collie/sheepdog/wiki/Libvirt. >From http://libvirt.org/formatsnapshot.html, i can find some snapshot >operations in Libvirt, which may be different from Sheepdog

Re: [libvirt] [Libvirt]How to get libvirt version after git clone?

2013-02-02 Thread harryxiyou
On Sat, Feb 2, 2013 at 9:49 PM, Matthias Bolte wrote: [...] > You can look at the AC_INIT line in configure.ac > > AC_INIT([libvirt], [1.0.2], [libvir-list@redhat.com], [], > [http://libvirt.org]) > > the second argument is the latest released version. This is just the *latest released version*

[libvirt] [Libvirt]Snapshot operations in Libvirt

2013-02-02 Thread harryxiyou
Hi all, I see our libvirt snapshot XML form like following, which this XML is to create a disk snapshot of just vda on a qemu domain with two disks. Snapshot of OS install and updates My understanding about up XML is like this: it creates a snapshot for '/path/to/

[libvirt] [Libvirt]How to get libvirt version after git clone?

2013-02-02 Thread harryxiyou
Hi all, After i clone libvirt git repo, how i could get this libvirt version exactly? $ git clone git://libvirt.org/libvirt.git $ git branch -a * master remotes/origin/HEAD -> origin/master remotes/origin/master remotes/origin/v0.10.2-maint remotes/origin/v0.9.11-maint remotes/origin/v0

Re: [libvirt] [sheepdog-users] [Sheepdog][Libvirt]Test boot VMs from sheepdog volumes in Libvirt

2013-02-02 Thread harryxiyou
On Sat, Feb 2, 2013 at 1:33 AM, Gao Yongwei wrote: [...] > soga,you may not understand my english,^^,if you can speak Chinese I think I > can help you more comfortable. > I will try my best to share my experience. > to get a bootable disk with os installed, you could try this command: > wget http:

Re: [libvirt] [Sheepdog][Libvirt]Boot VMs from sheepdog volumes error

2013-02-01 Thread harryxiyou
On Sat, Feb 2, 2013 at 12:49 AM, Eric Blake wrote: > On 02/01/2013 04:08 AM, harryxiyou wrote: >> Hi all, >> >> I wanna boot VMs from sheepdog volumes so i do according to >> https://github.com/collie/sheepdog/wiki/Libvirt >> However, some errors happened to m

Re: [libvirt] [sheepdog-users] [Sheepdog][Libvirt]Test boot VMs from sheepdog volumes in Libvirt

2013-02-01 Thread harryxiyou
On Fri, Feb 1, 2013 at 6:14 PM, Gao Yongwei wrote: [...] >> We can get "Boot VMs from sheepdog volumes in Libvirt" way >> from https://github.com/collie/sheepdog/wiki/Libvirt like following. >> >> a, prepare a file containing an XML domain description >> >> $ cat > sheepdog.xml >> >>

[libvirt] [Sheepdog][Libvirt]Boot VMs from sheepdog volumes error

2013-02-01 Thread harryxiyou
Hi all, I wanna boot VMs from sheepdog volumes so i do according to https://github.com/collie/sheepdog/wiki/Libvirt However, some errors happened to me like following. $ ./virsh create os.xml error:create domain from os.xml failure error:(domain_definition):14: Premature end of data in tag domain

Re: [libvirt] [Libvirt][Sheepdog]Sheepdog pool/volume storage driver for libvirt problem

2013-01-31 Thread harryxiyou
On Fri, Feb 1, 2013 at 12:06 PM, MORITA Kazutaka wrote: [...] > 1. prepare a file containing an XML domain description > > $ cat > sheepdog.xml > > testvm > 1048576 > > hvm > > > > > > > > > > 2. boot from testvdi with virsh

[libvirt] [Sheepdog][Libvirt]Test boot VMs from sheepdog volumes in Libvirt

2013-01-31 Thread harryxiyou
Hi all, We can get "Boot VMs from sheepdog volumes in Libvirt" way from https://github.com/collie/sheepdog/wiki/Libvirt like following. a, prepare a file containing an XML domain description $ cat > sheepdog.xml testvm 1048576 hvm

Re: [libvirt] [Libvirt][Sheepdog]Sheepdog pool/volume storage driver for libvirt problem

2013-01-31 Thread harryxiyou
On Fri, Feb 1, 2013 at 1:18 AM, Eric Blake wrote: [...] > Libvirt exists to manage existing hypervisor capabilities. It makes no > sense for libvirt to be able to create storage volumes for a new > protocol if there are no hypervisors that are also able to support that > storage format. So until

Re: [libvirt] [Libvirt]Install Libvirt errors

2013-01-31 Thread harryxiyou
On Thu, Jan 31, 2013 at 2:52 AM, Eric Blake wrote: [...] > >> [...] >> /usr/bin//xsltproc: /usr/local/lib/libxml2.so.2: no version information >> available (required by /usr/lib/libxslt.so.1) >> /usr/bin//xsltproc: /usr/local/lib/libxml2.so.2: no version information >> available (required by /us

[libvirt] [Libvirt][Sheepdog]How to test network disk support for sheepdog in Libvirt

2013-01-31 Thread harryxiyou
Hi all, Morita added network disk support for Libvirt, which supported nbd, rbd, sheepdog, and other protocols. Now, i wanna test network disk support for sheepdog solely. I have following questions. Could anyone please give me some suggestions? Thanks in advance. 1, Before this test, whether sho

Re: [libvirt] [Libvirt][Sheepdog]Sheepdog pool/volume storage driver for libvirt problem

2013-01-31 Thread harryxiyou
On Thu, Jan 31, 2013 at 3:05 AM, Eric Blake wrote: [...] > There's two aspects to storage management in libvirt. Eric, very thanks for your perfectly answers ;-) [...] >But without at least one online user (qemu), it > doesn't make sense to worry about offline management in libvirt (what > good

Re: [libvirt] [Libvirt]Install Libvirt errors

2013-01-31 Thread harryxiyou
On Thu, Jan 31, 2013 at 4:19 PM, Claudio Bley wrote: [...] > AFAIK, the DTD files are not required, they are just used to validate > the generated HTML files. > > Apparently, xsltproc is broken since there's a mismatch with its > libraries. Why is xsltproc installed in /usr but the libraries in >

Re: [libvirt] [Libvirt]Install Libvirt errors

2013-01-31 Thread harryxiyou
On Thu, Jan 31, 2013 at 2:52 AM, Eric Blake wrote: [...] > Pastebin links expire, making it harder to follow the conversation when > revisiting the list archives in the future. It is okay to paste the > actual error into the message rather than making people chase through a > link. > You are rig

Re: [libvirt] [Libvirt][Sheepdog]Sheepdog pool/volume storage driver for libvirt problem

2013-01-30 Thread harryxiyou
On Wed, Jan 30, 2013 at 2:49 AM, Eric Blake wrote: > On 01/29/2013 10:42 AM, harryxiyou wrote: >> Hi Sebastian, Morita and other developers, > > Answering what I can... Eric, thanks for your answers, you are awesome ;-) And i have some questions about your answers like following.

[libvirt] [Libvirt][Sheepdog]Sheepdog pool/volume storage driver for libvirt problem

2013-01-29 Thread harryxiyou
Hi Sebastian, Morita and other developers, I have studied Sheepdog pool/volume storage driver for libvirt and i have following questions. Please give me some suggestions. Thanks in advance ;-) 1, In libvirt/src/storage/storage_backend_sheepdog.c, i just find we realized create/delete/resize volum

Re: [libvirt] [Libvirt][QEMU][HLFS]How to test HLFS driver for Libvirt

2013-01-29 Thread harryxiyou
On Tue, Jan 29, 2013 at 8:55 PM, harryxiyou wrote: > On Tue, Jan 29, 2013 at 12:05 AM, MORITA Kazutaka > wrote: >> At Mon, 28 Jan 2013 23:43:04 +0800, >> harryxiyou wrote: >>> >>> Following test is Libvirt v0.8.6, which you just add Sheepdog volume >>>

Re: [libvirt] [Libvirt][QEMU][HLFS]How to test HLFS driver for Libvirt

2013-01-29 Thread harryxiyou
On Tue, Jan 29, 2013 at 12:05 AM, MORITA Kazutaka wrote: > At Mon, 28 Jan 2013 23:43:04 +0800, > harryxiyou wrote: >> >> Following test is Libvirt v0.8.6, which you just add Sheepdog volume >> patch to Libvirt. > > The version doesn't support Sheepdog storage p

Re: [libvirt] [Libvirt][QEMU][HLFS]How to test HLFS driver for Libvirt

2013-01-28 Thread harryxiyou
On Tue, Jan 29, 2013 at 8:18 AM, MORITA Kazutaka wrote: [...] > > I've looked at the upstream tree, but it certainly contains sheepdog > codes. > > http://libvirt.org/git/?p=libvirt.git;a=tree;f=src/storage > Sorry, my libvirt git tree was not the latest one, which may not patch Sheepdog pool/vol

Re: [libvirt] [Libvirt][QEMU][HLFS]How to test HLFS driver for Libvirt

2013-01-28 Thread harryxiyou
On Tue, Jan 29, 2013 at 12:05 AM, MORITA Kazutaka wrote: > At Mon, 28 Jan 2013 23:43:04 +0800, > harryxiyou wrote: >> >> Following test is Libvirt v0.8.6, which you just add Sheepdog volume >> patch to Libvirt. > > The version doesn't support Sheepdog storage p

Re: [libvirt] [Libvirt][QEMU][HLFS]How to test HLFS driver for Libvirt

2013-01-28 Thread harryxiyou
On Mon, Jan 28, 2013 at 11:23 PM, harryxiyou wrote: > On Mon, Jan 28, 2013 at 11:06 PM, harryxiyou wrote: >> On Mon, Jan 28, 2013 at 10:44 PM, MORITA Kazutaka >> wrote: >> [...] >>> I'm not familiar with HLFS at all. Sheepdog examples I explained to >>

Re: [libvirt] [Libvirt][QEMU][HLFS]How to test HLFS driver for Libvirt

2013-01-28 Thread harryxiyou
On Mon, Jan 28, 2013 at 11:06 PM, harryxiyou wrote: > On Mon, Jan 28, 2013 at 10:44 PM, MORITA Kazutaka > wrote: > [...] >> I'm not familiar with HLFS at all. Sheepdog examples I explained to >> you in another mail may help you, but I cannot give you any other

Re: [libvirt] [Libvirt][QEMU][HLFS]How to test HLFS driver for Libvirt

2013-01-28 Thread harryxiyou
On Mon, Jan 28, 2013 at 10:44 PM, MORITA Kazutaka wrote: [...] > I'm not familiar with HLFS at all. Sheepdog examples I explained to > you in another mail may help you, but I cannot give you any other > suggestions about HLFS. > Thanks for your reminder, i have found this email. Therefore, could

Re: [libvirt] [Libvirt][Test]How to test storage solely in Libvirt?

2013-01-28 Thread harryxiyou
On Mon, Jan 28, 2013 at 9:36 PM, Daniel P. Berrange wrote: [...] > I agree with that. I don't see this being a part of libvirt until > the QEMU community accepts it into the mainline QEMU GIT tree. So > I'd focus on the latter first. > After HLFS has a good performance, we will submmit patches to

Re: [libvirt] [Libvirt][Test]How to test storage solely in Libvirt?

2013-01-28 Thread harryxiyou
On Mon, Jan 28, 2013 at 9:32 PM, MORITA Kazutaka wrote: >> >> 3, Morita said if QEMU does not support Sheepdog then Libvirt will not >> support Sheepdog but i am not clear about their communicating details. >> Could you please tell me their communicating details? > > If QEMU doesn't officially sup

Re: [libvirt] [Libvirt][Test]How to test storage solely in Libvirt?

2013-01-28 Thread harryxiyou
On Mon, Jan 28, 2013 at 9:32 PM, MORITA Kazutaka wrote: >> >> 3, Morita said if QEMU does not support Sheepdog then Libvirt will not >> support Sheepdog but i am not clear about their communicating details. >> Could you please tell me their communicating details? > > If QEMU doesn't officially sup

Re: [libvirt] [Libvirt][Test]How to test storage solely in Libvirt?

2013-01-28 Thread harryxiyou
On Mon, Jan 28, 2013 at 11:28 AM, Osier Yang wrote: [...] > > It's bad that we don't have sheepdog pool documented in [1] > when doing the patches. But the good thing is there are some > documents for it in [2]. If you see the document is not > enough. You can check the RNG schema to figure out th

Re: [libvirt] [Libvirt][Sheepdog]How to test Sheepdog patch

2013-01-27 Thread harryxiyou
On Mon, Jan 28, 2013 at 11:04 AM, harryxiyou wrote: > Hi Morita and other developers, > > I have done following jobs. > > 1, git clone git://libvirt.org/libvirt.git > 2, cd libvirt > 3, git reset --hard 036ad50 > 4, ./autogen.sh > 5, make > > NOTE: step 3 calls b

  1   2   >