z/vz_driver.c | 36 +++-
> src/vz/vz_sdk.c| 24 +++-
> 2 files changed, 18 insertions(+), 42 deletions(-)
ACK. Thanks.
Maxim Nestratov
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
17-Oct-17 20:40, Jiri Denemark пишет:
On Tue, Oct 17, 2017 at 16:55:13 +0300, Nikolay Shirokovskiy wrote:
Nikolay Shirokovskiy (2):
vz: missing pieces for fd885a06 for vz driver
vz: fix typo for 0d3d020b
src/vz/vz_driver.c | 4 ++--
src/vz/vz_sdk.c| 2 +-
2 files changed, 3 inser
29-Jun-17 13:17, Mikhail Feoktistov пишет:
Mikhail Feoktistov (2):
vz: add argument xmlopt for virDomainDefCheckABIStability call
vz: nseclabels member is moved to virDomainChrSourceDef struct
src/vz/vz_driver.c | 2 +-
src/vz/vz_sdk.c| 2 +-
2 files changed, 2 insertions(+), 2 de
11-May-17 12:15, Daniel P. Berrange пишет:
On Thu, May 11, 2017 at 12:01:27PM +0300, Nikolay Shirokovskiy wrote:
---
docs/Makefile.am | 22 --
1 file changed, 20 insertions(+), 2 deletions(-)
ACK
Regards,
Daniel
Pushed.
Thanks,
Maxim
--
libvir-list mailing list
lib
14-Apr-17 17:53, Konstantin Neumoin пишет:
Acked-by: Nikolay Shirokovskiy
Signed-off-by: Konstantin Neumoin
---
src/vz/vz_driver.c | 43 +++
src/vz/vz_sdk.c| 23 +++
src/vz/vz_sdk.h| 1 +
3 files changed, 67 insertions(+
22-Feb-17 17:35, Dmitry Derbyshev пишет:
Ping.
Also, noticed that I renamed patch series, old name was "Substitute poll by epoll in
virEventPollRunOnce". My bad.
A few issues required to be fixed to make 'make syntax-check' pass. Otherwise
looks good to me.
Maxim
/14/2017 9:04 PM, Derbys
09-Feb-17 15:57, Jiri Denemark пишет:
On Tue, Jan 31, 2017 at 17:12:13 +0300, Maxim Nestratov wrote:
Strings associated with virDomainHyperv values in domain_conf.c are used to
construct HyperV CPU features names to be compared with names defined in
cpu_x86_data.h and the names for HyperV
08-Feb-17 21:19, Andrea Bolognani пишет:
On Wed, 2017-02-08 at 18:26 +0300, Maxim Nestratov wrote:
PARALLELS_STATISTICS_DROP_COUNT isn't used anymore
Signed-off-by: Maxim Nestratov
ACK
Pushed.
Thanks,
Maxim
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redha
08-Feb-17 19:07, Daniel P. Berrange пишет:
On Wed, Feb 08, 2017 at 06:28:34PM +0300, Maxim Nestratov wrote:
When we happen to lose a domain but still get a performance event
for it, we should also free the event handle.
Signed-off-by: Maxim Nestratov
---
src/vz/vz_sdk.c | 4 +++-
1 file
When we happen to lose a domain but still get a performance event
for it, we should also free the event handle.
Signed-off-by: Maxim Nestratov
---
src/vz/vz_sdk.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c
index ec954dd..614dca1
PARALLELS_STATISTICS_DROP_COUNT isn't used anymore
Signed-off-by: Maxim Nestratov
---
src/vz/vz_sdk.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c
index 614dca1..30eb743 100644
--- a/src/vz/vz_sdk.c
+++ b/src/vz/vz_sdk.c
@@ -2187,8 +2
Every successful call of PrlEvent_GetParamByName allocates a handle,
which has to be freed.
Signed-off-by: Maxim Nestratov
---
src/vz/vz_sdk.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c
index 727b572..ec954dd 100644
--- a/src/vz/vz_sdk.c
+++ b/src/vz
Maxim Nestratov (2):
vz: fix handle leak in prlsdkHandleVmStateEvent
vz: fix event handle leak in prlsdkHandlePerfEvent
src/vz/vz_sdk.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
--
2.4.11
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman
08-Feb-17 17:52, Martin Kletzander пишет:
On Wed, Jan 18, 2017 at 01:21:48PM +0300, Nikolay Shirokovskiy wrote:
By the way we came to agreement to create distinct API to support backup
operations in [1]
and there is a discussion of pull backup series in [2]. The latter is blocked
as some neces
31-Jan-17 15:24, Nikolay Shirokovskiy пишет:
On 31.01.2017 14:01, Maxim Nestratov wrote:
This is necessary to be able to get statistics for venet0 or
"host-routed" adapter, which has -1 index and thus, its statistics
is shown as "net.nic4294967295".
Signed-off-by: Maxim
support hyperv 'spinlocks' feature" even when it's supported.
Let's fix it and rename along with it VIR_CPU_x86_KVM_HV_SPINLOCK to
VIR_CPU_x86_KVM_HV_SPINLOCKS.
Signed-off-by: Maxim Nestratov
---
src/cpu/cpu_x86.c | 4 ++--
src/cpu/cpu_x86_data.h | 8 +++-
2 fi
31-Jan-17 10:44, Nikolay Shirokovskiy пишет:
Nikolay Shirokovskiy (2):
vz: support virDomainAbortJob
vz: support virDomainReset
src/vz/vz_driver.c | 53 +
src/vz/vz_sdk.c| 48
src/
31-Jan-17 14:54, Jiri Denemark пишет:
On Tue, Jan 31, 2017 at 13:59:37 +0300, Maxim Nestratov wrote:
Corresponding hv cpu feature name is 'spinlocks' thus, we should have similar
name with __kvm_hv_ prefix. Otherwise we have misleading warning:
"host doesn't support hyperv
This is necessary to be able to get statistics for venet0 or
"host-routed" adapter, which has -1 index and thus, its statistics
is shown as "net.nic4294967295".
Signed-off-by: Maxim Nestratov
---
src/vz/vz_sdk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --g
Corresponding hv cpu feature name is 'spinlocks' thus, we should have similar
name with __kvm_hv_ prefix. Otherwise we have misleading warning:
"host doesn't support hyperv 'spinlocks' feature" even when it's supported.
Signed-off-by: Maxim Nestratov
--
30-Jan-17 18:35, Maxim Nestratov пишет:
29-Dec-16 12:58, Nikolay Shirokovskiy пишет:
Because this is invalid xml for containers. This patch almost
reverts 7eda8369, but still skips converting vz sdk bootorder
for containers to libvirt bootorder because we use boot order
in containers for
12-Dec-16 10:56, Nikolay Shirokovskiy пишет:
Nikolay Shirokovskiy (5):
vz: provide block stats for all domain stats
vz: add net group to all domain stats
vz: add vcpu group to all domain stats
vz: add balloon group to all domain stats
vz: add state group to all domain stats
src
12-Dec-16 10:56, Nikolay Shirokovskiy пишет:
---
src/vz/vz_driver.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c
index 01c1a96..d9bd2cd 100644
--- a/src/vz/vz_driver.c
+++ b/src/vz/vz_driver.c
@@ -3729,6 +3729,28 @@ vzD
12-Dec-16 10:56, Nikolay Shirokovskiy пишет:
---
src/vz/vz_driver.c | 189 +
src/vz/vz_sdk.c| 8 +++
2 files changed, 197 insertions(+)
diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c
index 08f7961..6d173ef 100644
--- a/src/vz/v
29-Dec-16 12:58, Nikolay Shirokovskiy пишет:
Because this is invalid xml for containers. This patch almost
reverts 7eda8369, but still skips converting vz sdk bootorder
for containers to libvirt bootorder because we use boot order
in containers for quite different purpurse.
---
I know I review
Add bug fix description of appying correct pit timer policy.
---
docs/news.xml | 11 +++
1 file changed, 11 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index e341ba2..d616ebd 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -184,6 +184,17 @@
libvirt can recognize.
05-Jan-17 19:53, John Ferlan пишет:
On 12/09/2016 09:28 AM, Maxim Nestratov wrote:
As specifying both QEMU_CAPS_NO_KVM_PIT and QEMU_CAPS_KVM_PIT_TICK_POLICY
capabilities has no practical sense in tests, and we already have tests
for QEMU_CAPS_KVM_PIT_TICK_POLICY, it's better to add a sep
05-Jan-17 19:52, John Ferlan пишет:
On 12/09/2016 09:28 AM, Maxim Nestratov wrote:
Reuse "kvm-pit-device" test case for testing it.
Signed-off-by: Maxim Nestratov
---
src/qemu/qemu_command.c| 8 +++-
tests/qemuxml2argvdata/qemuxml2ar
05-Jan-17 19:52, John Ferlan пишет:
Since this has been sitting unreviewed for a while...
On 12/09/2016 09:28 AM, Maxim Nestratov wrote:
By a mistake, 'delay' libvirt xml parameter was converted to 'discard' QEMU
command line string one.
Test "kvm-pit-delay"
22-Dec-16 12:13, Daniel P. Berrange пишет:
On Wed, Dec 21, 2016 at 10:38:52PM +0300, Maxim Nestratov wrote:
A CT disk statistics is reported with prefix "hdd" and we should use
it to extract data.
Signed-off-by: Maxim Nestratov
---
src/vz/vz_driver.c | 10 --
src/v
This is necessary to show CTs created out of libvirt correctly.
Signed-off-by: Maxim Nestratov
---
src/vz/vz_sdk.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c
index 64748fa..2c8ce03 100644
--- a/src/vz/vz_sdk.c
+++ b/src/vz/vz_sdk.c
@@ -563,6 +563,7
Before, boot devices information for CTs was always empty and we
didn't indicate that containers can boot from disk.
Signed-off-by: Maxim Nestratov
---
src/vz/vz_sdk.c | 25 ++---
1 file changed, 22 insertions(+), 3 deletions(-)
diff --git a/src/vz/vz_sdk.c b/s
on to show
corresponding libvirt xml.
Signed-off-by: Maxim Nestratov
---
src/vz/vz_sdk.c | 96 ++---
1 file changed, 85 insertions(+), 11 deletions(-)
diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c
index 8d75399..54a21a3 100644
--- a/src/vz/vz_sdk.c
v1-v2 changes - comments addressed
Maxim Nestratov (5):
vz: report "scsi" bus for disks when nothing was set explixitly
vz: don't add implicit devices for CTs
vz: report disks either as disks or filesystems depending on original
xml
vz: set boot from disk for CT only w
A CT disk statistics is reported with prefix "hdd" and we should use
it to extract data.
Signed-off-by: Maxim Nestratov
---
src/vz/vz_driver.c | 10 --
src/vz/vz_sdk.c| 5 +++--
src/vz/vz_sdk.h| 2 +-
3 files changed, 12 insertions(+), 5 deletions(-)
diff --gi
Implicit devices like controllers are confusing for CTs and
function virDomainDefAddImplicitDevices never intended to be called
for CTs.
Signed-off-by: Maxim Nestratov
---
src/vz/vz_sdk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c
index
21-Dec-16 10:25, Nikolay Shirokovskiy пишет:
On 09.12.2016 17:36, Maxim Nestratov wrote:
Virtuozzo SDK interface doesn't differ filesystems from disks and sees them as
disks.
Before, we always mistakenly presented disks based on files as filesystems,
which is
not completely correct. N
20-Dec-16 17:44, Nikolay Shirokovskiy пишет:
On 09.12.2016 17:36, Maxim Nestratov wrote:
Implicit devices like controllers are confusing for CTs as they are faked.
Other devices like video we require to be specified explicitly.
I would drop last sentence. prlsdkApplyVideoParams shows that
we
20-Dec-16 13:50, Nikolay Shirokovskiy пишет:
On 09.12.2016 17:36, Maxim Nestratov wrote:
Before, boot devices information for CTs was always empty and we
didn't indicate that containers always boot from disk.
Signed-off-by: Maxim Nestratov
---
src/vz/vz_sdk.c | 13 +
1
20-Dec-16 13:20, Nikolay Shirokovskiy пишет:
On 09.12.2016 17:36, Maxim Nestratov wrote:
This is necessary for to show CTs created out of libvirt correctly.
Signed-off-by: Maxim Nestratov
---
src/vz/vz_sdk.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a
LICY simultaneusly in tests as they are mutually
exclusive and "kvm-pit-device" becomes just the same as "kvm-pit-delay".
Signed-off-by: Maxim Nestratov
---
src/qemu/qemu_command.c| 2 +-
tests/qemuxml2argvdata/qemuxml2argv-k
As specifying both QEMU_CAPS_NO_KVM_PIT and QEMU_CAPS_KVM_PIT_TICK_POLICY
capabilities has no practical sense in tests, and we already have tests
for QEMU_CAPS_KVM_PIT_TICK_POLICY, it's better to add a separate one with
QEMU_CAPS_NO_KVM_PIT set.
Signed-off-by: Maxim Nest
Reuse "kvm-pit-device" test case for testing it.
Signed-off-by: Maxim Nestratov
---
src/qemu/qemu_command.c| 8 +++-
tests/qemuxml2argvdata/qemuxml2argv-kvm-pit-device.xml | 2 +-
tests/qemuxml2argvtest.c | 1 +
3 fil
Maxim Nestratov (3):
qemu: fix pit timer tick policy=delay
qemu: allow to specify pit timer tick policy=discard
qemu: tests: add "no-kvm-pit-device" testcase
src/qemu/qemu_command.c| 10 ++--
.../qemuxml2argv-kvm-pit-delay.args
Implicit devices like controllers are confusing for CTs as they are faked.
Other devices like video we require to be specified explicitly.
Signed-off-by: Maxim Nestratov
---
src/vz/vz_sdk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c
A CT disk statistics is reported with prefix "hdd" and we should use
it to extract data.
Signed-off-by: Maxim Nestratov
---
src/vz/vz_driver.c | 10 --
src/vz/vz_sdk.c| 5 +++--
src/vz/vz_sdk.h| 2 +-
3 files changed, 12 insertions(+), 5 deletions(-)
diff --gi
This is necessary for to show CTs created out of libvirt correctly.
Signed-off-by: Maxim Nestratov
---
src/vz/vz_sdk.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c
index d5688e1..9976e4c 100644
--- a/src/vz/vz_sdk.c
+++ b/src
on to show
corresponding libvirt xml.
Signed-off-by: Maxim Nestratov
---
src/vz/vz_sdk.c | 96 +++--
1 file changed, 86 insertions(+), 10 deletions(-)
diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c
index 1030a1b..9b8b48e 100644
--- a/src/vz/vz_sdk.c
Maxim Nestratov (5):
vz: report "scsi" bus for disks when nothing was set explixitly
vz: don't query boot devices information for VZ, set boot from disk
always
vz: don't add implicit devices for CTs
vz: report disks either as disks or filesystems depending on origin
Before, boot devices information for CTs was always empty and we
didn't indicate that containers always boot from disk.
Signed-off-by: Maxim Nestratov
---
src/vz/vz_sdk.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c
08-Dec-16 11:49, Pavel Glushchak пишет:
This flag tells backend not to create instance
disks making behavior the same as in qemu driver.
Disk files have to be created beforehand on target
host manually or by upper management layer i.e.
OpenStack Nova.
Signed-off-by: Pavel Glushchak
---
src/v
08-Dec-16 15:17, John Ferlan пишет:
On 12/08/2016 04:19 AM, Maxim Nestratov wrote:
08-Dec-16 02:22, John Ferlan пишет:
[...]
I see what you mean; however, IMO vstorage should be separate. Maybe
there's another opinion out there, but since you're requiring
"something"
08-Dec-16 02:22, John Ferlan пишет:
[...]
I see what you mean; however, IMO vstorage should be separate. Maybe
there's another opinion out there, but since you're requiring
"something" else to be installed in order to get the WITH_VSTORAGE to be
set to 1, then a separate file is in order.
Not
22-Nov-16 15:05, Nikolay Shirokovskiy пишет:
ACK
Pushed now. Thanx.
Maxim
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
23-Nov-16 11:00, Nikolay Shirokovskiy пишет:
On 23.11.2016 10:50, Michal Privoznik wrote:
On 23.11.2016 08:08, Nikolay Shirokovskiy wrote:
On 22.11.2016 17:49, Michal Privoznik wrote:
On 14.11.2016 15:24, Nikolay Shirokovskiy wrote:
qemuDomainObjExitAgent is unsafe.
First it accesses doma
22-Nov-16 18:17, Michal Privoznik пишет:
On 16.11.2016 14:43, Nikolay Shirokovskiy wrote:
Patches 1 and 2 are refactorings to help review patch 3.
diff from v1:
=
1. error flag cleanup logic clarified
2. patches that touch io loop are dropped
Nikolay Shirokovskiy (3):
qemu: age
21-Nov-16 15:22, Martin Kletzander пишет:
On Fri, Oct 14, 2016 at 10:13:48AM +0300, Nikolay Shirokovskiy wrote:
It is already discussed in "[RFC] daemon: remove hardcode dep on
libvirt-guests" [1].
Mgmt can use means to save/restore domains on system shutdown/boot other then
libvirt-guests.se
This reverts commit 3a6cf6fc16.
Mistakenly this commit was pushed because I thought I missed the
corret one b880ff42ddb while in fact I didn't.
Signed-off-by: Maxim Nestratov
---
src/vz/vz_sdk.c | 12
1 file changed, 12 deletions(-)
diff --git a/src/vz/vz_sdk.c b/src/vz/vz_
15-Nov-16 17:33, Peter Krempa пишет:
On Tue, Nov 15, 2016 at 17:09:33 +0300, Maxim Nestratov wrote:
It was introduced by commit 7a51d9ebb, which started to use
monitor commands without job acquiring, which is unsafe and leads
to simultaneous access to vm->mon structure by different thre
15-Nov-16 16:44, Maxim Nestratov пишет:
It was introduced by commit 7a51d9ebb, which started to use
monitor commands without job acquiring, which is unsafe and leads
to simultaneous access to vm->mon structure by different threads.
Crash backtrace is the following (shortened):
Prog
:11546
10 0x7f6934470c40 in remoteDispatchConnectGetAllDomainStats at remote.c:6267
(gdb) p mon->msg
$1 = (qemuMonitorMessagePtr) 0x0
This change fixes it by calling qemuDomainRefreshVcpuHalted only when job is
acquired.
Signed-off-by: Maxim Nestratov
---
v1-v2: don't output halted cpu info if i
:11546
10 0x7f6934470c40 in remoteDispatchConnectGetAllDomainStats at remote.c:6267
(gdb) p mon->msg
$1 = (qemuMonitorMessagePtr) 0x0
This change fixes it by calling qemuDomainRefreshVcpuHalted only when job is
acquired.
Signed-off-by: Maxim Nestratov
---
src/qemu/qemu_driver.c | 17 +++--
15-Nov-16 15:38, Viktor Mihajlovski пишет:
On 15.11.2016 13:19, Peter Krempa wrote:
On Wed, Nov 02, 2016 at 18:56:49 +0300, Maxim Nestratov wrote:
It was introduced by commit 7a51d9ebb, which started to use
monitor commands without job acquiring, which is unsafe and
leads to simultaneous
15-Nov-16 14:26, Viktor Mihajlovski пишет:
On 02.11.2016 17:29, Viktor Mihajlovski wrote:
On 02.11.2016 16:56, Maxim Nestratov wrote:
It was introduced by commit 7a51d9ebb, which started to use
monitor commands without job acquiring, which is unsafe and leads
to simultaneous access to vm->
14-Nov-16 18:20, Pavel Glushchak пишет:
dom xml generated on begin step should be passed
to perform step in VIR_MIGRATE_PARAM_DEST_XML parameter.
Otherwise 'XML error: failed to parse xml document' is
raised on destination host as dom xml is NULL.
Signed-off-by: Pavel Glushchak
---
src/vz/vz
07-Nov-16 20:15, Michal Privoznik пишет:
On 07.11.2016 17:19, Michal Privoznik wrote:
On 03.11.2016 19:11, Maxim Nestratov wrote:
Both qemuDomainReboot and qemuDomainShutdownFlags do the following if
they were called to reboot:
1. use agent and call qemuAgentShutdown
2. then if the above
e set for it. The lack of
monitor event
reaction leads to incorrect logic and guest doesn't restart or reboot correctly.
The patch simply sets domainPowerdown monitor callback to
qemuProcessHandleShutdown as
powerdown event processing is actually equal to shutdown.
Signed-off-by: Maxim
:11546
10 0x7f6934470c40 in remoteDispatchConnectGetAllDomainStats at remote.c:6267
(gdb) p mon->msg
$1 = (qemuMonitorMessagePtr) 0x0
This change fixes it by calling qemuDomainRefreshVcpuHalted only when job is
acquired.
Signed-off-by: Maxim Nestratov
---
src/qemu/qemu_driver.c | 20 +---
27-Oct-16 16:58, Maxim Nestratov пишет:
24-Oct-16 09:46, Nikolay Shirokovskiy пишет:
On 21.10.2016 18:20, Maxim Nestratov wrote:
07-Sep-16 14:00, Nikolay Shirokovskiy пишет:
On 05.09.2016 19:39, Maxim Nestratov wrote:
Recently, libprlsdk got a separate flag PNA_BRIDGE corresponding to
24-Oct-16 09:46, Nikolay Shirokovskiy пишет:
On 21.10.2016 18:20, Maxim Nestratov wrote:
07-Sep-16 14:00, Nikolay Shirokovskiy пишет:
On 05.09.2016 19:39, Maxim Nestratov wrote:
Recently, libprlsdk got a separate flag PNA_BRIDGE corresponding to
type=bridge libvirt network interfaces
07-Sep-16 14:00, Nikolay Shirokovskiy пишет:
On 05.09.2016 19:39, Maxim Nestratov wrote:
Recently, libprlsdk got a separate flag PNA_BRIDGE corresponding to
type=bridge libvirt network interfaces. Let's use it and get rid of
all workarounds previously added to support it.
Signed-o
22-Sep-16 17:55, Nikolay Shirokovskiy пишет:
Only the first patch is really on the subject. The second one is
bugfix that is included mainly because it touches the same place
(and nice to have to test first patch too...)
Nikolay Shirokovskiy (2):
vz: add serial number to disk devices
vz:
21-Oct-16 12:50, Maxim Nestratov пишет:
Actually this is a combination of the two previous series
https://www.redhat.com/archives/libvir-list/2016-October/msg00890.html
and
https://www.redhat.com/archives/libvir-list/2016-September/msg01024.html
Maxim Nestratov (1):
util: qemu: make
th an info note just as before.
We need usual conversion from "" to NULL in direction
vz sdk -> libvirt, because "" is not valid for libvirt
and "" means unspecifiend in vz sdk which is NULL for libvirt.
Signed-off-by: Nikolay Shirokovskiy
Signed-off-by: Maxim
From: Nikolay Shirokovskiy
Absent driver name attribute is invalid xml. Which in turn makes
unusable 'virsh edit' for example. The value does not make
much sense and ignored on input so nobody will hurt.
---
src/vz/vz_sdk.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/vz/vz_sdk.c b
Actually this is a combination of the two previous series
https://www.redhat.com/archives/libvir-list/2016-October/msg00890.html
and
https://www.redhat.com/archives/libvir-list/2016-September/msg01024.html
Maxim Nestratov (1):
util: qemu: make qemuSafeSerialParamValue function usable by other
Rename qemuSafeSerialParamValue to virSafeSerialParamValue and move it to utils
Signed-off-by: Maxim Nestratov
---
src/libvirt_private.syms | 1 +
src/qemu/qemu_command.c | 19 +--
src/util/virutil.c | 16
src/util/virutil.h | 2 ++
4 files
19-Oct-16 12:40, Nikolay Shirokovskiy пишет:
On 18.10.2016 19:19, Mikhail Feoktistov wrote:
We should set localhost as vnc address in case of empty string.
Because Virtuozzo sets 0.0.0.0 as default vnc address.
---
src/vz/vz_sdk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
22-Sep-16 17:55, Nikolay Shirokovskiy пишет:
vz sdk supports setting serial number only for disk devices.
Getting serial upon cdrom(for example) is error however
setting is just ignored. Let's check for disk device
explicitly for clarity in both cases.
Setting serial number for other devices is
22-Sep-16 17:55, Nikolay Shirokovskiy пишет:
Absent driver name attribute is invalid xml. Which in turn makes
unusable 'virsh edit' for example. The value does not make
much sense and ignored on input so nobody will hurt.
---
src/vz/vz_sdk.c | 3 +++
1 file changed, 3 insertions(+)
diff --gi
The first patch is a preparation moving qemuSafeSerialParamValue to util,
the second implements disk serial number setting in vz driver.
Maxim Nestratov (2):
util: qemu: make qemuSafeSerialParamValue function usable by other
drivers
vz: support setting disk serial number
src
Signed-off-by: Maxim Nestratov
---
src/vz/vz_sdk.c | 19 +++
src/vz/vz_utils.c | 5 -
2 files changed, 19 insertions(+), 5 deletions(-)
diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c
index b5b0197..f27441d 100644
--- a/src/vz/vz_sdk.c
+++ b/src/vz/vz_sdk.c
@@ -590,6
Rename qemuSafeSerialParamValue to virSafeSerialParamValue and move it to utils
Signed-off-by: Maxim Nestratov
---
src/libvirt_private.syms | 1 +
src/qemu/qemu_command.c | 19 +--
src/util/virutil.c | 16
src/util/virutil.h | 2 ++
4 files
07-Oct-16 20:09, Olga Krishtal пишет:
On 24/09/16 00:12, John Ferlan wrote:
On 09/23/2016 11:56 AM, Olga Krishtal wrote:
On 21/09/16 19:17, Maxim Nestratov wrote:
20 сент. 2016 г., в 23:52, John Ferlan написал(а):
On 09/15/2016 03:32 AM, Olga Krishtal wrote:
Hi everyone, we would like
23-Sep-16 23:51, John Ferlan пишет:
[snip]
I think rather than just copy what the storage pool does, I would think
the new driver could "build up" what it needs based on some consensus
based on what makes sense for the usage model.
Having a guest mount a host file system would seem to be poss
> 20 сент. 2016 г., в 23:52, John Ferlan написал(а):
>
>
>
>> On 09/15/2016 03:32 AM, Olga Krishtal wrote:
>> Hi everyone, we would like to propose the first implementation of fspool
>> with directory backend.
>>
>> Filesystem pools is a facility to manage filesystems resources similar
>> to
27-May-16 11:05, Nikolay Shirokovskiy пишет:
There is already a patch [1] on this topic with a different approach - keep
nvram file by default. There is also some discussion there. To sum up keeping
nvram on undefine could be useful in some usecases so there should be an option
to do it. On t
07-Sep-16 12:45, Michal Privoznik пишет:
On 07.09.2016 11:41, Maxim Nestratov wrote:
06-Sep-16 17:42, Michal Privoznik пишет:
On 05.09.2016 18:42, Maxim Nestratov wrote:
There is a possibility that qemu driver frees by unreferencing its
closeCallbacks pointer as it has the only reference to
06-Sep-16 18:03, Michal Privoznik пишет:
On 05.09.2016 18:42, Maxim Nestratov wrote:
From: Yuri Pudgorodskiy
A separate error code will help recognize real failures from
necessity to try again
Signed-off-by: Maxim Nestratov
---
include/libvirt/virterror.h | 2 ++
src/qemu/qemu_agent.c
06-Sep-16 17:42, Michal Privoznik пишет:
On 05.09.2016 18:42, Maxim Nestratov wrote:
There is a possibility that qemu driver frees by unreferencing its
closeCallbacks pointer as it has the only reference to the object,
while in fact not all users of CloseCallbacks called thier
06-Sep-16 18:03, Michal Privoznik пишет:
On 05.09.2016 18:42, Maxim Nestratov wrote:
From: Yuri Pudgorodskiy
A separate error code will help recognize real failures from
necessity to try again
Signed-off-by: Maxim Nestratov
---
include/libvirt/virterror.h | 2 ++
src/qemu/qemu_agent.c
backs object in virCloseCallbacksSet and
unreference in virCloseCallbacksUnset.
Signed-off-by: Maxim Nestratov
---
src/util/virclosecallbacks.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/util/virclosecallbacks.c b/src/util/virclosecallbacks.c
index 82d4071..891a92b 100644
--- a/src
Maxim Nestratov (3):
vz: support type=bridge network interface type correctly
vz: remove Bridged network name and rename Routed
vz: add MIGRATION_V3 capability
src/vz/vz_driver.c | 1 +
src/vz/vz_sdk.c| 100 -
src/vz/vz_utils.h
It's funny, but Routed network name was incorrect. We should use
host-routed instead.
---
src/vz/vz_utils.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/vz/vz_utils.h b/src/vz/vz_utils.h
index 4b407ec..9e02fe0 100644
--- a/src/vz/vz_utils.h
+++ b/src/vz/vz_utils.h
@@ -
Recently, libprlsdk got a separate flag PNA_BRIDGE corresponding to
type=bridge libvirt network interfaces. Let's use it and get rid of
all workarounds previously added to support it.
Signed-off-by: Maxim Nestratov
---
src/vz/vz_sdk.c
From: Yuri Pudgorodskiy
A separate error code will help recognize real failures from
necessity to try again
Signed-off-by: Maxim Nestratov
---
include/libvirt/virterror.h | 2 ++
src/qemu/qemu_agent.c | 6 +++---
src/util/virerror.c | 6 ++
3 files changed, 11 insertions
Signed-off-by: Maxim Nestratov
---
src/vz/vz_driver.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c
index 819dad7..b971add 100644
--- a/src/vz/vz_driver.c
+++ b/src/vz/vz_driver.c
@@ -3071,6 +3071,7 @@ vzConnectSupportsFeature(virConnectPtr conn
25-Aug-16 12:25, Mikhail Feoktistov пишет:
On 25.08.2016 11:33, Nikolay Shirokovskiy wrote:
---
src/vz/vz_driver.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c
index b34fe33..f223794 100644
--- a/src/vz/vz_driver.c
+++ b/src/vz/vz_driver.c
@
18-Aug-16 14:57, Olga Krishtal пишет:
While dettaching/attaching device in OpenStack, nova
calls vzDomainDettachDevice twice, because the update of the internal
configuration of the ct comes a bit latter than the update event.
As the result, we suffer from the second call to dettach the same dev
25-Aug-16 11:13, Nikolay Shirokovskiy пишет:
On 15.08.2016 19:02, Mikhail Feoktistov wrote:
We should query bus type for containers too, like for VM.
In openstack we add volume disk like SCSI, so we can't
hardcode SATA bus.
---
src/vz/vz_sdk.c | 32 +---
1 file c
1 - 100 of 614 matches
Mail list logo
