Currently devAliases in virDomainFSInfo struct are iterated as a
NULL-terminated list, but that is not guaranteed. It should use
ndevAliases which stores the number of the items in devAliases.
Signed-off-by: Tomoki Sekiyama
---
libvirt-override.c |7 ---
1 file changed, 4 insertions
On 11/24/14, 11:30 , "Pavel Hrdina" wrote:
>On 11/22/2014 02:28 AM, Tomoki Sekiyama wrote:
>> Implement the function which returns a list of tuples, that contains
>>members
>> of virDomainFSInfo struct.
>>
>> Signed-off-by: Tomoki Sekiyama
sda1 ext4 hdc
/opt dm-2 vfat vda,vdb
/mnt/testsdb1 xfs sda
Signed-off-by: Tomoki Sekiyama
---
tools/virsh-domain.c | 70 ++
tools/virsh.pod |9 +
Add daemon and driver code to (de-)serialize virDomainFSInfo.
Signed-off-by: Tomoki Sekiyama
---
daemon/remote.c | 113 ++
src/remote/remote_driver.c | 93 +++
src/remote/remote_protocol.x | 32
Get mounted filesystems list, which contains hardware info of disks and its
controllers, from QEMU guest agent 2.2+. Then, convert the hardware info
to corresponding device aliases for the disks.
Signed-off-by: Tomoki Sekiyama
---
src/conf/domain_conf.c | 71 +++
src/conf
Add test cases for qemuAgentGetFSInfo, with a sample agent response for
the qemu-get-fsinfo command and a configuration xml.
Signed-off-by: Tomoki Sekiyama
---
tests/Makefile.am|1
tests/qemuagentdata/qemuagent-fsinfo.xml | 39
tests/qemuagenttest.c
-off-by: Tomoki Sekiyama
---
include/libvirt/libvirt-domain.h | 22
src/driver-hypervisor.h |6 +++
src/libvirt.c| 68 ++
src/libvirt_public.syms |6 +++
4 files changed, 102 insertions(+)
diff --git
Implement the function which returns a list of tuples, that contains members
of virDomainFSInfo struct.
Signed-off-by: Tomoki Sekiyama
---
generator.py |5 +++
libvirt-override-api.xml |6
libvirt-override.c | 70
mounted filesystems information in the guest, collected via the guest agent.
The returned info contains mountpoints and disk device alias named in
libvirt, so we can know which mountpoints should be frozen by
virDomainFSFreeze to take snapshots of a part of disks.
---
Tomoki Sekiy
On 11/20/14, 18:54 , "John Ferlan" wrote:
>On 11/20/2014 01:19 PM, Eric Blake wrote:
>> On 11/20/2014 11:11 AM, John Ferlan wrote:
>>
However, for some reason I see this build error after 2/5:
make[3]: Entering directory
'/home/zippy/work/libvirt/libvirt.git/tools/wireshark/s
On 11/20/14, 7:24 , "Pavel Hrdina" wrote:
>On 11/20/2014 01:22 PM, Pavel Hrdina wrote:
>> On 11/18/2014 12:29 AM, Tomoki Sekiyama wrote:
>>> Implement the function which returns a list of tuples, that contains
>>> members
>>> of virDomainFSInfo
On 11/19/14, 17:58 , "John Ferlan" wrote:
>On 11/17/2014 06:26 PM, Tomoki Sekiyama wrote:
>> Hi,
>>
>> This is v2 of patchset to add virDomainGetFSInfo API.
>>
>> * changes in v1->v2:
>> -[all] removed redundant NULL element at the last of
On 11/20/14, 14:12 , "Eric Blake" wrote:
>On 11/17/2014 04:26 PM, Tomoki Sekiyama wrote:
>> Add daemon and driver code to (de-)serialize virDomainFSInfo.
>>
>> Signed-off-by: Tomoki Sekiyama
>> ---
>> daemon/remote.c | 117
>>+
On 11/20/14, 14:09 , "Eric Blake" wrote:
>On 11/17/2014 04:26 PM, Tomoki Sekiyama wrote:
>> virDomainGetFSInfo returns a list of filesystems information mounted in
>>the
>> guest, which contains mountpoints, device names, filesystem types, and
>> device a
ll related freeze APIs or none of them.
OK, I¹ll change this to '@acl domain:fs_freeze¹ and
use QEMU_JOB_QUERY because this interact with qemu-guest-agent.
--
Tomoki Sekiyama
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Implement the function which returns a list of tuples, that contains members
of virDomainFSInfo struct.
Signed-off-by: Tomoki Sekiyama
---
generator.py |5 +++
libvirt-override-api.xml |6
libvirt-override.c | 70
Get mounted filesystems list, which contains hardware info of disks and its
controllers, from QEMU guest agent 2.2+. Then, convert the hardware info
to corresponding device aliases for the disks.
Signed-off-by: Tomoki Sekiyama
---
src/conf/domain_conf.c | 71 ++
src/conf
Add daemon and driver code to (de-)serialize virDomainFSInfo.
Signed-off-by: Tomoki Sekiyama
---
daemon/remote.c | 117 ++
src/remote/remote_driver.c | 92 +
src/remote/remote_protocol.x | 32
sda1 ext4 hdc
/opt dm-2 vfat vda,vdb
/mnt/testsdb1 xfs sda
Signed-off-by: Tomoki Sekiyama
---
tools/virsh-domain.c | 74 ++
tools/virsh.pod |9 +
Add test cases for qemuAgentGetFSInfo, with a sample agent response for
the qemu-get-fsinfo command and a configuration xml.
Signed-off-by: Tomoki Sekiyama
---
tests/Makefile.am|1
tests/qemuagentdata/qemuagent-fsinfo.xml | 39
tests/qemuagenttest.c
-off-by: Tomoki Sekiyama
---
include/libvirt/libvirt-domain.h | 21
src/driver-hypervisor.h |6 +++
src/libvirt.c| 66 ++
src/libvirt_public.syms |6 +++
4 files changed, 99 insertions(+)
diff --git
The returned info contains mountpoints and disk device alias named in
libvirt, so we can know which mountpoints should be frozen by
virDomainFSFreeze to take snapshots of a part of disks.
---
Tomoki Sekiyama (5):
Implement public API for virDomainGetFSInfo
remote: Implement the
Hi John, thanks for your review.
On 10/23/14, 9:16 , "John Ferlan" wrote:
>On 09/30/2014 08:20 PM, Tomoki Sekiyama wrote:
>> virDomainGetFSInfo returns a list of filesystems information mounted in
>>the
>> guest, which contains mountpoints, device names, filesyst
Could someone review this patchset please? Any comment is appreciated!
Regards,
Tomoki Sekiyama
On 9/30/14, 20:19 , "Tomoki Sekiyama" wrote:
>Hi,
>
>This series implements a new virDomainGetFSInfo API, that returns a list
>of
>mounted filesystems information in the
Add a "domfsinfo" command that shows a list of filesystems info mounted in
the guest.
Signed-off-by: Tomoki Sekiyama
---
tools/virsh-domain.c | 70 ++
1 file changed, 70 insertions(+)
diff --git a/tools/virsh-domain.c b/tools/virs
Add test cases for qemuAgentGetFSInfo, with a sample agent response for
the qemu-get-fsinfo command and a configuration xml.
Signed-off-by: Tomoki Sekiyama
---
tests/Makefile.am|1
tests/qemuagentdata/qemuagent-fsinfo.xml | 27 +++
tests/qemuagenttest.c
Add daemon and driver code to (de-)serialize virDomainFSInfo.
Signed-off-by: Tomoki Sekiyama
---
daemon/remote.c | 117 ++
src/remote/remote_driver.c | 87 +++
src/remote/remote_protocol.x | 32
-off-by: Tomoki Sekiyama
---
include/libvirt/libvirt.h.in | 21 +
src/driver.h |6
src/libvirt.c| 68 ++
src/libvirt_public.syms |6
4 files changed, 101 insertions(+)
diff --git a
virDomainFSFreeze to take snapshots of a part of disks.
---
Tomoki Sekiyama (5):
Implement public API for virDomainGetFSInfo
remote: Implement the remote protocol for virDomainGetFSInfo
qemu: Implement the qemu driver for virDomainGetFSInfo
qemu: add test for qemuAgentGetFSInfo
Get mounted filesystems list, which contains hardware info of disks and its
controllers, from QEMU guest agent 2.2+. Then, convert the hardware info
to corresponding device aliases for the disks.
Signed-off-by: Tomoki Sekiyama
---
src/conf/domain_conf.c | 71
src/conf
Fix info in the command definition of allocpages, which is currently
pointing info for 'capabilities'.
Signed-off-by: Tomoki Sekiyama
---
tools/virsh-host.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/virsh-host.c b/tools/virsh-host.c
index a857a3
Fix comments about the version in which '.nodeAllocPages' are added.
Signed-off-by: Tomoki Sekiyama
---
src/lxc/lxc_driver.c |2 +-
src/qemu/qemu_driver.c |2 +-
src/uml/uml_driver.c |2 +-
src/vbox/vbox_common.c |2 +-
4 files changed, 4 insertions(+), 4 deletion
Hi Michal,
On 8/14/14, 2:58 , "Michal Privoznik" wrote:
>On 13.08.2014 17:42, Tomoki Sekiyama wrote:
>> This patch gives users a nicer error message when the QEMU guest agent
>>is
>> not new enough to support 'guest-fsfreeze-freeze-list' command, wh
domain --mountpoint /mnt/point
error: Unable to freeze filesystems
error: argument unsupported: this version of guest agent doesn't support
specifying mountpoints
Signed-off-by: Tomoki Sekiyama
---
src/qemu/qemu_agent.c | 79 -
1 file cha
On 8/11/14 16:36 , "Eric Blake" wrote:
>On 08/08/2014 02:03 PM, Tomoki Sekiyama wrote:
>> A command to freeze a part of mounted file systems is implemented in
>> upstream QEMU-guest-agent with a name of 'guest-fsfreeze-freeze-list'.
>> This fixes the nam
API.
Signed-off-by: Tomoki Sekiyama
---
src/qemu/qemu_agent.c |2 +-
tests/qemuagenttest.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c
index 0421733..a10954a 100644
--- a/src/qemu/qemu_agent.c
+++ b/src/qemu/qemu_agent.
From: Tomoki Sekiyama
Hello Michael,
Thank you for posting v2.
May be we should add following diff to avoid sanitytest.pl's
mapping error.
---
diff --git a/sanitytest.py b/sanitytest.py
index cff30d5..62fe42b 100644
--- a/sanitytest.py
+++ b/sanitytest.py
@@ -207,6 +207,8 @@ for na
Thanks for your review, and a lot of fixes :) .
Just a comment...
>On 10.05.2014 01:21, Tomoki Sekiyama wrote:
>diff --git a/libvirt-override.c b/libvirt-override.c
>index d0557c2..d08b271 100644
>--- a/libvirt-override.c
>+++ b/libvirt-override.c
>@@ -7564,7 +7564,7 @@ libvirt
Add binding for the new virDomainFSFreeze and virDomainFSThaw functions
added in libvirt 1.2.5. These require override since these take a list
of mountpoints path string. The methods are named 'fSFreeze' and 'fSThaw',
like a existing 'fSTrim' method.
ments":{"mountpoints":["/mnt/vol1","/mnt/vol2"]}}
Signed-off-by: Tomoki Sekiyama
Acked-by: Daniel P. Berrange
---
src/qemu/qemu_agent.c | 47 +++
src/qemu/qemu_agent.h |3 ++-
src/qemu/qemu_driver.c |
Use qemuDomainSnapshotFSFreeze() and qemuDomainSnapshotFSFThaw() which are
already implemented for snapshot quiescing.
Signed-off-by: Tomoki Sekiyama
---
src/qemu/qemu_driver.c | 98
1 file changed, 98 insertions(+)
diff --git a/src/qemu
These are exposed under domfsfreeze command and domfsthaw command.
Signed-off-by: Tomoki Sekiyama
---
tools/virsh-domain.c | 126 ++
tools/virsh.pod | 23 +
2 files changed, 149 insertions(+)
diff --git a/tools/virsh-domain.c b
New rules are added in fixup_name in gendispatch.pl to keep the name
FSFreeze and FSThaw. This adds a new ACL permission 'fs_freeze',
which is also applied to VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE flag.
Signed-off-by: Tomoki Sekiyama
Acked-by: Daniel P. Berrange
---
src/access/virac
is caused before sending a
freeze command, a counterpart thaw command shouldn't be sent either, not to
confuse fsfreeze status tracking.
Signed-off-by: Tomoki Sekiyama
---
src/qemu/qemu_domain.c |5 +++
src/qemu/qemu_domain.h |2 +
src/qemu/qemu_
These will freeze and thaw filesystems within guest specified by
@mountpoints parameters. The parameters can be NULL and 0, then the all
mounted filesystems are frozen or thawed. @flags parameter, which are
currently not used, is for future extensions.
Signed-off-by: Tomoki Sekiyama
---
include
ion is not provided, every
mounted filesystem is frozen/thawed.
The APIs have flags option currently unsupported for future extension.
---
Tomoki Sekiyama (6):
Introduce virDomainFSFreeze() and virDomainFSThaw() public API
remote: Implement virDomainFSFreeze and virDoma
On 4/30/14 15:44 , "Eric Blake" wrote:
>On 04/30/2014 10:52 AM, Tomoki Sekiyama wrote:
>
>>
>>> I'd think it'd be better to just allow multiple instances of
>>> the arg eg
>>>
>>> virsh fsfreeze --mount --mount
>&
On 4/30/14 11:30 , "Daniel P. Berrange" wrote:
>On Tue, Apr 29, 2014 at 08:04:24PM -0400, Tomoki Sekiyama wrote:
>> These are exposed under domfsfreeze command and domfsthaw command.
>>
>> Signed-off-by: Tomoki Sekiyama
>>
Hi, thank you for the review.
On 4/30/14 11:26 , "Daniel P. Berrange" wrote:
>On Tue, Apr 29, 2014 at 08:03:57PM -0400, Tomoki Sekiyama wrote:
>> These will freeze and thaw filesystems within guest specified by
>> @mountpoints parameters. The parameters can be
These are exposed under domfsfreeze command and domfsthaw command.
Signed-off-by: Tomoki Sekiyama
---
tools/virsh-domain.c | 130 ++
tools/virsh.pod | 23 +
2 files changed, 153 insertions(+)
diff --git a/tools/virsh-domain.c b
Use qemuDomainSnapshotFSFreeze() and qemuDomainSnapshotFSFThaw() which are
already implemented for snapshot quiescing.
Signed-off-by: Tomoki Sekiyama
---
src/qemu/qemu_driver.c | 89
1 file changed, 89 insertions(+)
diff --git a/src/qemu
ents":{"mountpoints": ["/mnt/vol1","/mnt/vol2"]}}
Signed-off-by: Tomoki Sekiyama
---
src/qemu/qemu_agent.c | 47 +++
src/qemu/qemu_agent.h |3 ++-
src/qemu/qemu_driver.c | 13 ++---
tests/qemuagentt
is caused before sending a
freeze command, a counterpart thaw command shouldn't be sent either, not to
confuse fsfreeze status tracking.
Signed-off-by: Tomoki Sekiyama
---
src/qemu/qemu_domain.c |5 +++
src/qemu/qemu_domain.h |2 +
src/qemu/qemu_
New rules are added in fixup_name in gendispatch.pl to keep the name
FSFreeze and FSThaw. This adds a new ACL permission 'fs_freeze',
which is also applied to VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE flag.
Signed-off-by: Tomoki Sekiyama
---
src/access/viraccessperm.c |2 +-
These will freeze and thaw filesystems within guest specified by
@mountpoints parameters. The parameters can be NULL and 0, then the all
mounted filesystes are frozen or thawed. @flags parameter, which are
currently not used, is for future extensions.
Signed-off-by: Tomoki Sekiyama
---
include
n/thawed.
The APIs have flags option currently unsupported for future extension.
---
Tomoki Sekiyama (6):
Introduce virDomainFSFreeze() and virDomainFSThaw() public API
remote: Implement virDomainFSFreeze and virDomainFSThaw
qemu: track quiesced status in qemuDomainSnapshotFS
On 4/25/14 5:44 , "Daniel P. Berrange" wrote:
>On Thu, Apr 24, 2014 at 09:29:04PM +, Tomoki Sekiyama wrote:
>> On 4/24/14 4:58 , "Daniel P. Berrange" wrote:
>>
>> >On Thu, Apr 24, 2014 at 12:16:00AM +, Tomoki Sekiyama wrote:
>>
On 4/24/14 4:58 , "Daniel P. Berrange" wrote:
>On Thu, Apr 24, 2014 at 12:16:00AM +, Tomoki Sekiyama wrote:
>> Hi Daniel,
>>
>>
>> On 4/23/14 5:55 , "Daniel P. Berrange" wrote:
>> >On Tue, Apr 22, 2014 at 06:22:18PM +, Tomok
Hi Daniel,
On 4/23/14 5:55 , "Daniel P. Berrange" wrote:
>On Tue, Apr 22, 2014 at 06:22:18PM +, Tomoki Sekiyama wrote:
>> Hi Daniel,
>> thanks for your comment.
>>
>> On 4/22/14 11:39 , "Daniel P. Berrange" wrote:
>> >On Thu,
Hi Daniel,
thanks for your comment.
On 4/22/14 11:39 , "Daniel P. Berrange" wrote:
>On Thu, Apr 03, 2014 at 11:39:29AM -0400, Tomoki Sekiyama wrote:
>> +
>> +/**
>> + * virDomainFSFreeze:
>> + * @dom: a domain object
>> + * @disks: list of disk names
Any comments for this patchset?
On 4/3/14 11:39 , "Tomoki Sekiyama" wrote:
>Hello,
>
>This is patchset v5 to add FSFreeze/FSThaw API for custom disk
>snapshotting.
>
>Changes to v4:
> * add disks and ndisks parameter to specify disks to be frozen/thawed
>
On 4/4/14 8:15 , "Eric Blake" wrote:
>On 04/04/2014 02:51 AM, Daniel P. Berrange wrote:
>> On Thu, Apr 03, 2014 at 11:39:29AM -0400, Tomoki Sekiyama wrote:
>>> These will freeze and thaw filesystems within guest. The APIs take
>>>@disks
>>> and @ndis
These are exposed under domfsfreeze command and domfsthaw command.
Signed-off-by: Tomoki Sekiyama
---
tools/virsh-domain.c | 128 ++
tools/virsh.pod | 23 +
2 files changed, 151 insertions(+)
diff --git a/tools/virsh-domain.c b
command, a counterpart thaw command shouldn't be sent either.
Signed-off-by: Tomoki Sekiyama
---
src/qemu/qemu_domain.c |6
src/qemu/qemu_domain.h |2 +
src/qemu/qemu_driver.c | 65 ++--
3 files changed, 59 insertions(+), 14 deletions(-)
d
requested to be thawed as many times as freeze request.
@flags parameter, which are currently not used, is for future extensions.
Signed-off-by: Tomoki Sekiyama
---
include/libvirt/libvirt.h.in | 10 +
src/driver.h | 14 ++
src/libvirt.c| 92
New rules are added in fixup_name in gendispatch.pl to keep the name
FSFreeze and FSThaw. This adds a new ACL permission 'fs_freeze',
which is also applied to VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE flag.
Signed-off-by: Tomoki Sekiyama
---
src/access/viraccessperm.c |2 +-
e requests.
Currently, qemu driver doesn't support disks parameter because the guest
agent doesn't have means to specify disks to be frozen/thawed. Hence, it
just counts depth of fsfreeze per domain, not per disk, so far.
The APIs have flags option currently unsupported for future extension.
Use qemuDomainSnapshotFSFreeze() and qemuDomainSnapshotFSFThaw() which are
already implemented for snapshot quiescing. So far, disks and ndisks
parameters are unsupported, because the guest agent doesn't have means to
specify disks to be frozen or thawed.
Signed-off-by: Tomoki Sekiyama
---
On 3/28/14 12:08 , "Tomoki Sekiyama" wrote:
>On 3/27/14 20:32 , "Eric Blake" wrote:
>>On 03/27/2014 05:54 PM, Tomoki Sekiyama wrote:
>>> This sounds reasonable for me to add disks parameters.
>>> I will try adding them in next version. Then the api
On 3/27/14 20:32 , "Eric Blake" wrote:
>On 03/27/2014 05:54 PM, Tomoki Sekiyama wrote:
>> This sounds reasonable for me to add disks parameters.
>> I will try adding them in next version. Then the api will look like:
>>
>> int virDomainFSFreeze(virDo
On 3/27/14 18:27 , "Eric Blake" wrote:
>On 03/27/2014 04:21 PM, Jon Bernard wrote:
>> * Tomoki Sekiyama wrote:
>>> Hello,
>>>
>>> This is patchset v4 to add FSFreeze/FSThaw API for custom disk
>>>snapshotting.
>>
>> This patc
These are exposed under domfsfreeze command and domfsthaw command.
Signed-off-by: Tomoki Sekiyama
---
tools/virsh-domain.c | 92 ++
tools/virsh.pod | 15
2 files changed, 107 insertions(+)
diff --git a/tools/virsh-domain.c b
These will freeze and thaw filesystems within guest. The APIs take @flags
arguments which are currently not used, for future extensions.
Signed-off-by: Tomoki Sekiyama
---
include/libvirt/libvirt.h.in |6
src/driver.h | 10 ++
src/libvirt.c| 70
chset adds virDomainFSFreeze()/virDomainFSThaw() APIs and virsh
domfsfreeze/domfsthaw commands to enable the users to freeze and thaw
domain's filesystems cleanly.
The APIs have flags option currently unsupported for future extension.
---
Tomoki Sekiyama (5):
Introduce virDomainFSFr
Use qemuDomainSnapshotFSFreeze() and qemuDomainSnapshotFSFreeze() which are
already implemented for snapshot quiescing.
Signed-off-by: Tomoki Sekiyama
---
src/qemu/qemu_driver.c | 78
1 file changed, 78 insertions(+)
diff --git a/src/qemu
error is caused before sending a
freeze command, a counterpart thaw command shouldn't be sent either, not to
thaw the guest unexpectedly by error handling code.
Signed-off-by: Tomoki Sekiyama
---
src/qemu/qemu_domain.c |5
src/qemu/qemu_domain.h |2 +
src/qemu/qemu_driver.c |
New rules are added in fixup_name in gendispatch.pl to keep the name
FSFreeze and FSThaw. This adds a new ACL permission 'fs_freeze',
which is also applied to VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE flag.
Signed-off-by: Tomoki Sekiyama
---
src/access/viraccessperm.c |2 +-
qemuDomainSetSchedulerParametersFlags() calls virQEMUDriverGetConfig() twice
and makes the reference counter leak. This removes redundant call.
---
src/qemu/qemu_driver.c |1 -
1 file changed, 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 76f789e..ca971f3 10
error is caused before sending a
freeze command, a counterpart thaw command shouldn't be sent either, not to
thaw the guest unexpectedly by error handling code.
Signed-off-by: Tomoki Sekiyama
---
src/qemu/qemu_domain.c |5
src/qemu/qemu_domain.h |2 +
src/qemu/qemu_driver.c |
These are exposed under domfsfreeze command and domfsthaw command.
Signed-off-by: Tomoki Sekiyama
---
tools/virsh-domain.c | 92 ++
tools/virsh.pod | 15
2 files changed, 107 insertions(+)
diff --git a/tools/virsh-domain.c b
New rules are added in fixup_name in gendispatch.pl to keep the name
FSFreeze and FSThaw. This adds a new ACL permission 'fs_freeze',
which is also applied to VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE flag.
Signed-off-by: Tomoki Sekiyama
---
src/access/viraccessperm.c |2 +-
Use qemuDomainSnapshotFSFreeze() and qemuDomainSnapshotFSFreeze() which are
already implemented for snapshot quiescing.
Signed-off-by: Tomoki Sekiyama
---
src/qemu/qemu_driver.c | 78
1 file changed, 78 insertions(+)
diff --git a/src/qemu
enable the users to freeze and thaw
domain's filesystems cleanly.
The APIs have flags option currently unsupported for future extension.
---
Tomoki Sekiyama (5):
Introduce virDomainFSFreeze() and virDomainFSThaw() public API
remote: Implement virDomainFSFreeze and virDomainFSTha
These will freeze and thaw filesystems within guest. The APIs take @flags
arguments which are currently not used, for future extensions.
Signed-off-by: Tomoki Sekiyama
---
include/libvirt/libvirt.h.in |6
src/driver.h | 10 ++
src/libvirt.c| 70
>On Wed, Mar 05, 2014 at 02:53:10PM -0500, Tomoki Sekiyama wrote:
>> Adds an quiesced flag into qemuDomainObjPrivate that tracks whether guest
>> filesystems of the domain is quiesced of not.
>> It also modify error code from qemuDomainSnapshotFSFreeze and
>> qemuDoma
_SNAPSHOT_CREATE_QUIESCE flag for snapshot APIs
> uses this new permission.
I see. I will add the new acl for this and for
VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE flag.
Thanks,
Tomoki Sekiyama
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On 3/6/14 4:32 , "Daniel P. Berrange" wrote:
>On Wed, Mar 05, 2014 at 02:52:49PM -0500, Tomoki Sekiyama wrote:
>> Hello,
>>
>> This is patchset v2 to add FSFreeze/FSThaw API for custom disk
>>snapshotting.
>
>Patch 1 in your series hasn't arr
These will freeze and thaw filesystems within guest. The APIs take flags
arguments which are currently not used, for future extensions.
Signed-off-by: Tomoki Sekiyama
---
include/libvirt/libvirt.h.in |6
src/driver.h | 10 ++
src/libvirt.c| 70
These will freeze and thaw filesystems within guest. The APIs take flags
arguments which are currently not used, for future extensions.
Signed-off-by: Tomoki Sekiyama
---
include/libvirt/libvirt.h.in |6
src/driver.h | 10 ++
src/libvirt.c| 70
These are exposed under domfsfreeze command and domfsthaw command.
Signed-off-by: Tomoki Sekiyama
---
tools/virsh-domain.c | 92 ++
tools/virsh.pod | 15
2 files changed, 107 insertions(+)
diff --git a/tools/virsh-domain.c b
Use qemuDomainSnapshotFSFreeze() and qemuDomainSnapshotFSFreeze() which are
already implemented for snapshot quiescing.
Signed-off-by: Tomoki Sekiyama
---
src/qemu/qemu_driver.c | 78
1 file changed, 78 insertions(+)
diff --git a/src/qemu
New rules are added in fixup_name in gendispatch.pl to keep the name
FSFreeze and FSThaw.
Signed-off-by: Tomoki Sekiyama
---
src/remote/remote_driver.c |2 ++
src/remote/remote_protocol.x | 23 ++-
src/remote_protocol-structs |9 +
src/rpc/gendispatch.pl
Adds an quiesced flag into qemuDomainObjPrivate that tracks whether guest
filesystems of the domain is quiesced of not.
It also modify error code from qemuDomainSnapshotFSFreeze and
qemuDomainSnapshotFSThaw, so that a caller can know whether the command is
actually sent to the guest agent. If the e
ystems cleanly.
The APIs have flags option currently unsupported for future extension.
---
Tomoki Sekiyama (5):
Introduce virDomainFSFreeze() and virDomainFSThaw() public API
remote: Implement virDomainFSFreeze and virDomainFSThaw
qemu: Track domain quiesced status
qemu: I
On 3/4/14 12:13 , "Daniel P. Berrange" wrote:
>On Tue, Mar 04, 2014 at 10:11:39AM -0700, Eric Blake wrote:
>> On 03/04/2014 08:39 AM, Tomoki Sekiyama wrote:
>>
>> >>>
>> >>> This patchset adds virDomainFSFreeze()/virDomainFSThaw() APIs and
On 3/3/14 17:14 , "Eric Blake" wrote:
>On 11/18/2013 09:38 AM, Tomoki Sekiyama wrote:
>> Currently FSFreeze and FSThaw are supported by qemu guest agent and
>>they are
>> used internally in snapshot-create command with --quiesce option.
>> However, when user
Any comments?
On 11/18/13 11:38 , "Tomoki Sekiyama" wrote:
>Currently FSFreeze and FSThaw are supported by qemu guest agent and they
>are
>used internally in snapshot-create command with --quiesce option.
>However, when users want to utilize the native snapshot featu
Use qemuAgentFSFreeze() and qemuAgentFSThaw() already implemented for
snapshot quiescing. @mountPoint must be NULL and @flags zero, because
qemu guest agent doesn't support these arguments so far.
Signed-off-by: Tomoki Sekiyama
---
src/qemu/qemu_driver.c |
These are exposed under domfsfreeze command and domfsthaw command.
Although the API doesn't support specifying mount point yet, expose it
anyway.
Signed-off-by: Tomoki Sekiyama
---
tools/virsh-domain.c | 108 ++
tools/virsh.pod |
This will freeze filesystems within guest. The API takes @mountPoint
arguments which are currently not used, for future extensions of guest
agent.
Signed-off-by: Tomoki Sekiyama
---
include/libvirt/libvirt.h.in |8
src/driver.h | 12 +
src/libvirt.c
1 - 100 of 106 matches
Mail list logo
