On Wed, May 07, 2008 at 09:38:26AM +0200, Soren Hansen wrote:
> Yes and no. In the latest patch I provided I only set use_extboot if
> there's only one boot device defined, and it's a virtio device, so PXE
> booting would use the old-style "-boot n" syntax. I literallly woke up
> this morning and i
On Tue, May 06, 2008 at 10:02:21PM +0100, Daniel P. Berrange wrote:
> > sorry for the delay. Here's the newest version of the patch which
> > should address all the issues that have been raised so far.
> Yes & no. It didn't address the redundant re-ordering of -drive
> parameters when using boot=on
On Tue, May 06, 2008 at 08:11:11PM +0200, Soren Hansen wrote:
> sorry for the delay. Here's the newest version of the patch which should
> address all the issues that have been raised so far.
Yes & no. It didn't address the redundant re-ordering of -drive parameters
when using boot=on, nor re-add
Hi,
sorry for the delay. Here's the newest version of the patch which should
address all the issues that have been raised so far.
=== modified file 'src/qemu_conf.c'
--- old/src/qemu_conf.c 2008-04-30 12:30:55 +
+++ new/src/qemu_conf.c 2008-05-06 17:58:44 +
@@ -491,6 +491,8 @@
On Tue, Apr 29, 2008 at 04:42:54PM +0200, Soren Hansen wrote:
> On Tue, Apr 29, 2008 at 03:17:14PM +0100, Daniel P. Berrange wrote:
> +if (!bus)
> +disk->bus = QEMUD_DISK_BUS_IDE;
> +else if (!strcmp((const char *)bus, "ide"))
> +disk->bus = QEMUD_DISK_BU
On Tue, 2008-04-29 at 15:17 +0100, Daniel P. Berrange wrote:
> > > Even if the -drive parameter is supported, it should still pass the
> > > -boot a/c/d/n parameter in.
> >
> > Why? And how would you boot from a virtio device this way?
>
> It is needed for PXE boot at least, and IMHO, QEMU shou
On Tue, Apr 29, 2008 at 03:17:14PM +0100, Daniel P. Berrange wrote:
+if (!bus)
+disk->bus = QEMUD_DISK_BUS_IDE;
+else if (!strcmp((const char *)bus, "ide"))
+disk->bus = QEMUD_DISK_BUS_IDE;
+else if (!strcmp((const char *)bus, "scsi"))
+
Jim Meyering <[EMAIL PROTECTED]> wrote:
> "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote:
>
>> On Tue, Apr 29, 2008 at 04:10:40PM +0200, Soren Hansen wrote:
>>> On Tue, Apr 29, 2008 at 02:27:00PM +0100, Daniel P. Berrange wrote:
>>> >> +if (!bus)
>>> >> +disk->bus = QEMUD_DISK_BUS_IDE;
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote:
> On Tue, Apr 29, 2008 at 04:10:40PM +0200, Soren Hansen wrote:
>> On Tue, Apr 29, 2008 at 02:27:00PM +0100, Daniel P. Berrange wrote:
>> >> +if (!bus)
>> >> +disk->bus = QEMUD_DISK_BUS_IDE;
>> >> +else if (!strcmp((const char *)bus,
On Tue, Apr 29, 2008 at 04:10:40PM +0200, Soren Hansen wrote:
> On Tue, Apr 29, 2008 at 02:27:00PM +0100, Daniel P. Berrange wrote:
> >> +if (!bus)
> >> +disk->bus = QEMUD_DISK_BUS_IDE;
> >> +else if (!strcmp((const char *)bus, "ide"))
> >> +disk->bus = QEMUD_DISK_BUS_IDE;
>
On Tue, Apr 29, 2008 at 02:27:00PM +0100, Daniel P. Berrange wrote:
> > +strcmp((const char *)target, "hdd") &&
> > +strcmp((const char *)target, "hdd") &&
>
> These two lines test the same thing !
Quite so. My bad.
> > +strncmp((const char *)target, "vd", 2)) {
>
> Its
On Tue, Apr 29, 2008 at 09:56:13AM +0200, Soren Hansen wrote:
> Hi!
>
> I'd like to propose that the following patch gets applied against
> libvirt. It adds the option of putting a bus attribute on a disk target.
> To acommodate this, it also changes the way drives are defined for kvm
> from the o
Hi!
I'd like to propose that the following patch gets applied against
libvirt. It adds the option of putting a bus attribute on a disk target.
To acommodate this, it also changes the way drives are defined for kvm
from the old "-hda /path/to/file -boot c" style to the new "-drive
file=/path/to/fil
13 matches
Mail list logo
