On Tue, Apr 08, 2008 at 02:57:15PM +0100, Daniel P. Berrange wrote:
> This patch seems incomplete - there's no code to include the
> tag when dumping the XML.
FWIW, The patch I applied in Ubuntu to do this, looks like this. It
obviously still lack the test case updates and such, though.
Index:
On Tue, Apr 08, 2008 at 03:16:08PM +0100, Richard W.M. Jones wrote:
> On Tue, Apr 08, 2008 at 02:57:15PM +0100, Daniel P. Berrange wrote:
> > This patch seems incomplete - there's no code to include the tag
> > when dumping the XML.
>
> Yeah, agreed - forgot about that :-(
Oh, you may also find
Quoting "Richard W.M. Jones" <[EMAIL PROTECTED]>:
This patch allows selection of the NIC model for QEMU/KVM domains.
The selection is done by adding a element to the XML, as in
this example:
The model type string is only checked to make sure it's a short
alpha-numeric
On Tue, Apr 08, 2008 at 02:57:15PM +0100, Daniel P. Berrange wrote:
> This patch seems incomplete - there's no code to include the tag
> when dumping the XML.
Yeah, agreed - forgot about that :-(
> We should also implement the same for Xen driver really, since that has the
> choice of ne2k/rtl81
I'm sorry , didn't read the patch properly first!
Richard W.M. Jones wrote:
> This patch allows selection of the NIC model for QEMU/KVM domains.
> The selection is done by adding a element to the XML, as in
> this example:
>
>
>
>
>
>
> The model type string is only ch
What about when the model name doesn't include an underscore? like e1000
H
Richard W.M. Jones wrote:
> This patch allows selection of the NIC model for QEMU/KVM domains.
> The selection is done by adding a element to the XML, as in
> this example:
>
>
>
>
>
>
> The model
On Tue, Apr 08, 2008 at 02:17:56PM +0100, Richard W.M. Jones wrote:
> This patch allows selection of the NIC model for QEMU/KVM domains.
> The selection is done by adding a element to the XML, as in
> this example:
>
>
>
>
>
>
> The model type string is only checked to ma
On Tue, Apr 08, 2008 at 02:17:56PM +0100, Richard W.M. Jones wrote:
> This patch allows selection of the NIC model for QEMU/KVM domains.
> The selection is done by adding a element to the XML, as in
> this example:
>
>
>
>
>
>
> The model type string is only checked to ma
This patch allows selection of the NIC model for QEMU/KVM domains.
The selection is done by adding a element to the XML, as in
this example:
The model type string is only checked to make sure it's a short
alpha-numeric + underscore, since it seems impractical to extract t
