Re: [Libvir] [PATCH] Block device and network stats (version 2)

2007-08-29 Thread Richard W.M. Jones
Daniel P. Berrange wrote: [about requests vs sectors] Yes, we need both. If we can't find actual request sizes for Xen, we should make a note and see if its possible add this to future Xen kernel backend drivers. I notice that in the version of Xen in Fedora 7, we now have the following stati

Re: [Libvir] [PATCH] Block device and network stats (version 2)

2007-08-21 Thread Daniel P. Berrange
On Tue, Aug 21, 2007 at 09:02:45AM +0100, Richard W.M. Jones wrote: > Daniel P. Berrange wrote: > >On Mon, Aug 20, 2007 at 04:31:26PM +0100, Richard W.M. Jones wrote: > >>This patch adds block device and network stats. The main changes over > >>the previous version are: > >> > >>* Remote support.

Re: [Libvir] [PATCH] Block device and network stats (version 2)

2007-08-21 Thread Daniel P. Berrange
On Tue, Aug 21, 2007 at 02:37:13PM +0100, John Levon wrote: > On Tue, Aug 21, 2007 at 02:34:57PM +0100, Daniel P. Berrange wrote: > > > > Ah :-) Well that's LGPL so we can probably reuse pieces of it. But > > > I don't feel too confident relying on an installed Xen library at this > > > point. >

Re: [Libvir] [PATCH] Block device and network stats (version 2)

2007-08-21 Thread John Levon
On Tue, Aug 21, 2007 at 02:34:57PM +0100, Daniel P. Berrange wrote: > > Ah :-) Well that's LGPL so we can probably reuse pieces of it. But > > I don't feel too confident relying on an installed Xen library at this > > point. > > FYI, in case people didn't realize we can /use/ code from libxenst

Re: [Libvir] [PATCH] Block device and network stats (version 2)

2007-08-21 Thread Daniel P. Berrange
On Tue, Aug 21, 2007 at 09:06:08AM -0400, Daniel Veillard wrote: > On Tue, Aug 21, 2007 at 01:26:14PM +0100, John Levon wrote: > > On Tue, Aug 21, 2007 at 08:10:33AM -0400, Daniel Veillard wrote: > > > > > > > The Xen impl as coded only works for disks named xvdN, because the > > > > > code for >

Re: [Libvir] [PATCH] Block device and network stats (version 2)

2007-08-21 Thread Daniel P. Berrange
On Tue, Aug 21, 2007 at 12:55:19PM +0100, John Levon wrote: > On Tue, Aug 21, 2007 at 03:37:41AM +0100, Daniel P. Berrange wrote: > > > The Xen impl as coded only works for disks named xvdN, because the code for > > calculating device ID assumes xvdN device numbering scheme: > > > > device =

Re: [Libvir] [PATCH] Block device and network stats (version 2)

2007-08-21 Thread John Levon
On Tue, Aug 21, 2007 at 09:06:08AM -0400, Daniel Veillard wrote: > > apologies, > > No need, express yourself :-) What I want to make sure is that 0.3.2 > is not broken on a serious basis. If you think you can provide a solaris > patch for that new code I can wait for a day before actually roll

Re: [Libvir] [PATCH] Block device and network stats (version 2)

2007-08-21 Thread Richard W.M. Jones
John Levon wrote: BTW I am a little concerned that we're re-implementing all this code when libxenstat can do it. I already wrote this code once :) I based this code on libxenstat. Because libxenstat itself depends on libxc, and removing the libxc dependency was not going to be easy, I reimp

Re: [Libvir] [PATCH] Block device and network stats (version 2)

2007-08-21 Thread Daniel Veillard
On Tue, Aug 21, 2007 at 01:26:14PM +0100, John Levon wrote: > On Tue, Aug 21, 2007 at 08:10:33AM -0400, Daniel Veillard wrote: > > > > > The Xen impl as coded only works for disks named xvdN, because the code > > > > for > > > > calculating device ID assumes xvdN device numbering scheme: > > > >

Re: [Libvir] [PATCH] Block device and network stats (version 2)

2007-08-21 Thread John Levon
On Tue, Aug 21, 2007 at 08:10:33AM -0400, Daniel Veillard wrote: > > > The Xen impl as coded only works for disks named xvdN, because the code > > > for > > > calculating device ID assumes xvdN device numbering scheme: > > > > > > device = 202 * 256 + minor; > > > > What's with device numbe

Re: [Libvir] [PATCH] Block device and network stats (version 2)

2007-08-21 Thread Daniel Veillard
On Tue, Aug 21, 2007 at 12:55:19PM +0100, John Levon wrote: > On Tue, Aug 21, 2007 at 03:37:41AM +0100, Daniel P. Berrange wrote: > > > The Xen impl as coded only works for disks named xvdN, because the code for > > calculating device ID assumes xvdN device numbering scheme: > > > > device =

Re: [Libvir] [PATCH] Block device and network stats (version 2)

2007-08-21 Thread John Levon
On Tue, Aug 21, 2007 at 03:37:41AM +0100, Daniel P. Berrange wrote: > The Xen impl as coded only works for disks named xvdN, because the code for > calculating device ID assumes xvdN device numbering scheme: > > device = 202 * 256 + minor; What's with device numbering at all? Must we really

Re: [Libvir] [PATCH] Block device and network stats (version 2)

2007-08-21 Thread Richard W.M. Jones
Mindaugas Kiznis wrote: - Aren't "xdr_remote_domain_interface_stats_ret" and "xdr_remote_domain_interface_stats_args" functions missing in the patch? As I understand, those should be in qemud/remote_protocol.c. Repesctively, qemud/remote_protocol.h changes are missing too. I usually omit chan

Re: [Libvir] [PATCH] Block device and network stats (version 2)

2007-08-21 Thread Mindaugas Kiznis
Hello, - Aren't "xdr_remote_domain_interface_stats_ret" and "xdr_remote_domain_interface_stats_args" functions missing in the patch? As I understand, those should be in qemud/remote_protocol.c. Repesctively, qemud/remote_protocol.h changes are missing too. Best regards, Mindaugas Kiznis Ric

Re: [Libvir] [PATCH] Block device and network stats (version 2)

2007-08-21 Thread Richard W.M. Jones
Daniel P. Berrange wrote: On Mon, Aug 20, 2007 at 04:31:26PM +0100, Richard W.M. Jones wrote: This patch adds block device and network stats. The main changes over the previous version are: * Remote support. * Change Xen network interface names to have the form "vif."[1]. Discussions about t

Re: [Libvir] [PATCH] Block device and network stats (version 2)

2007-08-21 Thread Daniel Veillard
On Tue, Aug 21, 2007 at 03:37:41AM +0100, Daniel P. Berrange wrote: > On Mon, Aug 20, 2007 at 04:31:26PM +0100, Richard W.M. Jones wrote: > > This patch adds block device and network stats. The main changes over > > the previous version are: > > > > * Remote support. > > * Change Xen network int

Re: [Libvir] [PATCH] Block device and network stats (version 2)

2007-08-20 Thread Daniel P. Berrange
On Mon, Aug 20, 2007 at 04:31:26PM +0100, Richard W.M. Jones wrote: > This patch adds block device and network stats. The main changes over > the previous version are: > > * Remote support. > * Change Xen network interface names to have the form "vif."[1]. > > Discussions about the previous ver

[Libvir] [PATCH] Block device and network stats (version 2)

2007-08-20 Thread Richard W.M. Jones
This patch adds block device and network stats. The main changes over the previous version are: * Remote support. * Change Xen network interface names to have the form "vif."[1]. Discussions about the previous version may be found starting here: https://www.redhat.com/archives/libvir-list/2007

Re: [Libvir] [PATCH] Block device and network stats

2007-08-13 Thread Daniel Veillard
On Mon, Aug 13, 2007 at 12:45:39PM +0100, Daniel P. Berrange wrote: > On Mon, Aug 13, 2007 at 05:45:27AM -0400, Daniel Veillard wrote: > > On Fri, Aug 10, 2007 at 03:35:08PM +0100, Richard W.M. Jones wrote: > > > This is the implementation (currently Xen, local only). > > > > Thanks ! > > > > >

Re: [Libvir] [PATCH] Block device and network stats

2007-08-13 Thread Daniel P. Berrange
On Mon, Aug 13, 2007 at 05:45:27AM -0400, Daniel Veillard wrote: > On Fri, Aug 10, 2007 at 03:35:08PM +0100, Richard W.M. Jones wrote: > > This is the implementation (currently Xen, local only). > > Thanks ! > > > +++ include/libvirt/libvirt.h.in10 Aug 2007 14:30:21 - > > @@ -14,6 +14,9

Re: [Libvir] [PATCH] Block device and network stats

2007-08-13 Thread Daniel Veillard
On Fri, Aug 10, 2007 at 03:35:08PM +0100, Richard W.M. Jones wrote: > This is the implementation (currently Xen, local only). Thanks ! > +++ include/libvirt/libvirt.h.in 10 Aug 2007 14:30:21 - > @@ -14,6 +14,9 @@ > #ifndef __VIR_VIRLIB_H__ > #define __VIR_VIRLIB_H__ > > +#include

Re: [Libvir] [PATCH] Block device and network stats

2007-08-10 Thread Richard W.M. Jones
Daniel P. Berrange wrote: The virbrN / xenbrN devices are bridges so see all traffic from any guest attached. We need to look at ths individual vifN.N or vnetN devices which are per-guest. This info isn't included in the XML though. If we can figure out a efficient way to export vif name in t

Re: [Libvir] [PATCH] Block device and network stats

2007-08-10 Thread Richard W.M. Jones
Daniel P. Berrange wrote: On Fri, Aug 10, 2007 at 03:35:08PM +0100, Richard W.M. Jones wrote: This is the implementation (currently Xen, local only). It includes a couple of virsh commands if you want to play with looking at the stats. The network interface stuff isn't quiet correct +/* Pat

Re: [Libvir] [PATCH] Block device and network stats

2007-08-10 Thread Daniel P. Berrange
On Fri, Aug 10, 2007 at 03:35:08PM +0100, Richard W.M. Jones wrote: > This is the implementation (currently Xen, local only). > > It includes a couple of virsh commands if you want to play with looking > at the stats. The network interface stuff isn't quiet correct +/* Paths have the form "virb

[Libvir] [PATCH] Block device and network stats

2007-08-10 Thread Richard W.M. Jones
This is the implementation (currently Xen, local only). It includes a couple of virsh commands if you want to play with looking at the stats. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Win