Re: [Libvir] [PATCH] Delete a harmful variable in xend_parse_sexp_desc()

On Mon, Aug 27, 2007 at 05:37:29PM +0900, Masayuki Sunou wrote: > Hi > > Xend_parse_sexp_desc() of xend_internal.c declares a variable named > "ret" to buffer SXP. > However, it actually uses "buf.content" not "ret" and allocates memory > to "buf" when size of "ret" became insufficient. > --> vi

[Libvir] [PATCH] Delete a harmful variable in xend_parse_sexp_desc()

Hi Xend_parse_sexp_desc() of xend_internal.c declares a variable named "ret" to buffer SXP. However, it actually uses "buf.content" not "ret" and allocates memory to "buf" when size of "ret" became insufficient. --> virBufferAdd(&buf, ...);, virBufferVSprintf(&buf, ...) So freeing "ret" fails, b