Re: [Libvir] [PATCH] Fix cdrom connect/disconnect for qemu

2008-03-13 Thread Daniel Veillard
On Wed, Mar 12, 2008 at 12:57:59PM -0400, Cole Robinson wrote: > The attached patch fixes cdrom changing for a live qemu guest. There > were a few issues preventing it from working: > > 1) It didn't anticipate no block in the xml. > 2) No support for ejecting the media > 3) Small bug which preven

[Libvir] [PATCH] Fix cdrom connect/disconnect for qemu

2008-03-12 Thread Cole Robinson
The attached patch fixes cdrom changing for a live qemu guest. There were a few issues preventing it from working: 1) It didn't anticipate no block in the xml. 2) No support for ejecting the media 3) Small bug which prevented the running guest xml from being updated. I've tested this via virt-ma