Re: [Libvir] [PATCH] Fix the cpus parameter setting of xenXMParseXMLToConfig

2007-12-14 Thread Daniel Veillard
On Fri, Dec 14, 2007 at 10:31:58AM -0500, Daniel Veillard wrote: > On Fri, Dec 14, 2007 at 02:34:34PM +, Daniel P. Berrange wrote: > > On Fri, Dec 14, 2007 at 05:57:37PM +0900, Saori Fukuta wrote: > > > I think there is a unnecessary code for setting cpus parameter at > > > xenXMParseXMLToConfi

Re: [Libvir] [PATCH] Fix the cpus parameter setting of xenXMParseXMLToConfig

2007-12-14 Thread Daniel Veillard
On Fri, Dec 14, 2007 at 02:34:34PM +, Daniel P. Berrange wrote: > On Fri, Dec 14, 2007 at 05:57:37PM +0900, Saori Fukuta wrote: > > I think there is a unnecessary code for setting cpus parameter at > > xenXMParseXMLToConfig, since the cpus parameter is already set on > > the upper code. Because

Re: [Libvir] [PATCH] Fix the cpus parameter setting of xenXMParseXMLToConfig

2007-12-14 Thread Daniel P. Berrange
On Fri, Dec 14, 2007 at 05:57:37PM +0900, Saori Fukuta wrote: > I think there is a unnecessary code for setting cpus parameter at > xenXMParseXMLToConfig, since the cpus parameter is already set on > the upper code. Because of this, converted cpus string will not be > used. So, can I remove it ?

Re: [Libvir] [PATCH] Fix the cpus parameter setting of xenXMParseXMLToConfig

2007-12-14 Thread Richard W.M. Jones
Saori Fukuta wrote: I think there is a unnecessary code for setting cpus parameter at xenXMParseXMLToConfig, since the cpus parameter is already set on the upper code. Because of this, converted cpus string will not be used. So, can I remove it ? Yes I agree, this code does seem to duplicate s

[Libvir] [PATCH] Fix the cpus parameter setting of xenXMParseXMLToConfig

2007-12-14 Thread Saori Fukuta
I think there is a unnecessary code for setting cpus parameter at xenXMParseXMLToConfig, since the cpus parameter is already set on the upper code. Because of this, converted cpus string will not be used. So, can I remove it ? Regards, Saori Fukuta numa-fix.patch Description: Binary data -- Libv