Re: [Libvir] [PATCH] check the maximum of virtual CPU

2007-03-08 Thread Daniel Veillard
On Thu, Mar 08, 2007 at 10:03:25AM +0900, Masayuki Sunou wrote: > Hi Daniel > > I forgot the spelling check of comment. > I contribute the patch that corrects the comment again. > > Moreever, because some return values were illegal, I corrected it. Excellent, applied and commited, thanks

Re: [Libvir] [PATCH] check the maximum of virtual CPU

2007-03-07 Thread Masayuki Sunou
: [Libvir] [PATCH] check the maximum of virtual CPU" "Daniel Veillard <[EMAIL PROTECTED]>" wrote: > On Tue, Mar 06, 2007 at 08:08:57PM +0900, Masayuki Sunou wrote: > > Hi, Dan > > > > > > 1. When initially creating a VM > > > > 2. When ch

Re: [Libvir] [PATCH] check the maximum of virtual CPU

2007-03-07 Thread Daniel Veillard
On Tue, Mar 06, 2007 at 08:08:57PM +0900, Masayuki Sunou wrote: > Hi, Dan > > > > 1. When initially creating a VM > > > 2. When changing the config of an inactive VM > > > 3. When changing the config of a running VM > > > > Certainly, I had not considered concerning 1 and 2. > So, I corrected

Re: [Libvir] [PATCH] check the maximum of virtual CPU

2007-03-06 Thread Masayuki Sunou
age of it. Is it added as a command of virsh? Or, is it used from virsh create and virsh start? Signed-off-by: Masayuki Sunou <[EMAIL PROTECTED]> Thanks -- In message <[EMAIL PROTECTED]> "Re: [Libvir]

Re: [Libvir] [PATCH] check the maximum of virtual CPU

2007-03-05 Thread Daniel P. Berrange
On Mon, Mar 05, 2007 at 03:42:35PM +0900, Masayuki Sunou wrote: > I removed a needless part from the former patch. > > Add check the maxmum of virtual CPU. I was thinking about how to make use of this new API in virt-manager when I came up with a further complication :-) There are three scenario

Re: [Libvir] [PATCH] check the maximum of virtual CPU

2007-03-04 Thread Masayuki Sunou
mainGetMaxVcpus */ NULL, /* domainDumpXML */ NULL, /* listDefinedDomains */ NULL, /* numOfDefinedDomains */ ------- In message <[EMAIL PROTECTED]> "Re: [Libvir] [PATCH] check the maximum of virtual CPU"

Re: [Libvir] [PATCH] check the maximum of virtual CPU

2007-03-02 Thread Daniel P. Berrange
On Fri, Mar 02, 2007 at 09:26:03PM +0900, Atsushi SAKAI wrote: > Hi, Dan > > Please omit follwoing code from Masayuki's patch. > It reverses Mizushima's Yes, no problem - noticed that already. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Pe

Re: [Libvir] [PATCH] check the maximum of virtual CPU

2007-03-02 Thread Atsushi SAKAI
Hi, Dan Please omit follwoing code from Masayuki's patch. It reverses Mizushima's @@ -511,10 +512,10 @@ xend_post(virConnectPtr xend, const char } else if ((ret == 202) && (strstr(content, "failed") != NULL)) { virXendError(xend, VIR_ERR_POST_FAILED, content); ret = -1; -

Re: [Libvir] [PATCH] check the maximum of virtual CPU

2007-03-02 Thread Daniel P. Berrange
On Fri, Mar 02, 2007 at 08:42:59PM +0900, Masayuki Sunou wrote: > Hi Dan > > > This looks like a bug in XenD that should be reported upstrem. If the > > hypercall > > is given an invalid value it should reject it and not screw up the whole > > host. > > > I agree. > I will consider it as a back

Re: [Libvir] [PATCH] check the maximum of virtual CPU

2007-03-02 Thread Atsushi SAKAI
00000000 +0900 > @@ -98,6 +98,7 @@ static virDriver xenXMDriver = { > xenXMDomainSetVcpus, /* domainSetVcpus */ > NULL, /* domainPinVcpu */ > NULL, /* domainGetVcpus */ > +NULL, /* domainGetMaxVcpus */ > xenXMDomainDumpXML, /* domainDumpXML */ >

Re: [Libvir] [PATCH] check the maximum of virtual CPU

2007-03-02 Thread Masayuki Sunou
xVcpus */ NULL, /* domainDumpXML */ NULL, /* listDefinedDomains */ NULL, /* numOfDefinedDomains */ -- In message <[EMAIL PROTECTED]> "Re: [Libvir] [PATCH] check the maximum of virtual CPU" "

Re: [Libvir] [PATCH] check the maximum of virtual CPU

2007-03-01 Thread Daniel P. Berrange
On Thu, Mar 01, 2007 at 10:02:03AM +0900, Masayuki Sunou wrote: > Hi > > The maximum of virtual CPU is not guarded in virsh setvcpus now. > Then, when 32767 was set to virtual CPU of virsh setvcpus, the problem > that Xend became abnormal was detected. > > example: > -

Re: [Libvir] [PATCH] check the maximum of virtual CPU

2007-03-01 Thread Masayuki Sunou
needed in the future. Thanks, Masayuki Sunou. In message <[EMAIL PROTECTED]> "Re: [Libvir] [PATCH] check the maximum of virtual CPU" ""Richard W.M. Jones" <[EMAIL PROTECTED]>" wrote: > Masayuki Sunou wrote: > > Hi > > > > T

Re: [Libvir] [PATCH] check the maximum of virtual CPU

2007-03-01 Thread Richard W.M. Jones
Masayuki Sunou wrote: Hi The maximum of virtual CPU is not guarded in virsh setvcpus now. Then, when 32767 was set to virtual CPU of virsh setvcpus, the problem that Xend became abnormal was detected. example: -- # virsh setv

[Libvir] [PATCH] check the maximum of virtual CPU

2007-02-28 Thread Masayuki Sunou
Hi The maximum of virtual CPU is not guarded in virsh setvcpus now. Then, when 32767 was set to virtual CPU of virsh setvcpus, the problem that Xend became abnormal was detected. example: -- # virsh setvcpus 0 32767 libvir: X