[libvirt] Re: [Libvir] [PATCH] sound support for qemu and xen

2008-05-09 Thread Daniel P. Berrange
On Fri, May 09, 2008 at 06:33:19PM +0900, Atsushi SAKAI wrote: > Hi, Cole and Dan > > I have a question about the reason why it does not support in xen_proxy. > Would you explain why it does not support in xen_proxy? That changeset was just disabling a couple of functions there were not needed in

[libvirt] Re: [Libvir] [PATCH] sound support for qemu and xen

2008-05-09 Thread Atsushi SAKAI
Hi, Cole and Dan I have a question about the reason why it does not support in xen_proxy. Would you explain why it does not support in xen_proxy? This policy comes from security issue or other? If it does already commented on this please show me a pointer. P.S. I raise this question when I see

Re: [libvirt] Re: [Libvir] [PATCH] sound support for qemu and xen

2008-05-07 Thread Daniel Veillard
On Tue, May 06, 2008 at 10:25:37PM +0100, Daniel P. Berrange wrote: > On Tue, May 06, 2008 at 10:39:53AM -0400, Cole Robinson wrote: > > Cole Robinson wrote: > > > The patch below adds xml support for the soundhw option to qemu > > > and xen. > > > > Third iteration. Changes include: > > > > - R

[libvirt] Re: [Libvir] [PATCH] sound support for qemu and xen

2008-05-06 Thread Daniel P. Berrange
On Tue, May 06, 2008 at 10:39:53AM -0400, Cole Robinson wrote: > Cole Robinson wrote: > > The patch below adds xml support for the soundhw option to qemu > > and xen. > > Third iteration. Changes include: > > - Rediffd against current code > - Reading 'all' from a xend sexpr or xm config does th

Re: [Libvir] [PATCH] sound support for qemu and xen

2008-05-06 Thread Cole Robinson
Cole Robinson wrote: > The patch below adds xml support for the soundhw option to qemu > and xen. Third iteration. Changes include: - Rediffd against current code - Reading 'all' from a xend sexpr or xm config does the right thing. - Added test files. - Addressed most of Jim's feedback. Unfortun

Re: [Libvir] [PATCH] sound support for qemu and xen

2008-04-29 Thread Jim Meyering
Cole Robinson <[EMAIL PROTECTED]> wrote: > Cole Robinson wrote: >> The patch below adds xml support for the soundhw option to qemu >> and xen. The new xml element takes the form: ... > Again, this needs to be rediff'd around recent commits (virBuffer > changes, probably others), which I will do nex

Re: [Libvir] [PATCH] sound support for qemu and xen

2008-04-28 Thread Daniel P. Berrange
On Mon, Apr 28, 2008 at 01:44:32PM -0400, Cole Robinson wrote: > Cole Robinson wrote: > > The patch below adds xml support for the soundhw option to qemu > > and xen. The new xml element takes the form: > > > > Here is the updated patch. Took a bit more work to take into account > the multiple mo

Re: [Libvir] [PATCH] sound support for qemu and xen

2008-04-28 Thread Cole Robinson
Cole Robinson wrote: > The patch below adds xml support for the soundhw option to qemu > and xen. The new xml element takes the form: > Here is the updated patch. Took a bit more work to take into account the multiple models, building and parsing the xen soundhw string, checking for duplicates, e

Re: [Libvir] [PATCH] sound support for qemu and xen

2008-04-22 Thread Cole Robinson
Jerone Young wrote: > I was actually thinking about doing this very patch :-) . Are you going > to also enable virt-manager to make use of it ? Since it's just good old > qemu it will be great for local KVM use. > Yeah, I'll probably start adding support for this in virt-install and virt-manager o

Re: [Libvir] [PATCH] sound support for qemu and xen

2008-04-22 Thread Jerone Young
I was actually thinking about doing this very patch :-) . Are you going to also enable virt-manager to make use of it ? Since it's just good old qemu it will be great for local KVM use. Though it would be really nice if pulse audio support to where added to qemu. Then someway expose options also t

Re: [Libvir] [PATCH] sound support for qemu and xen

2008-04-21 Thread Daniel P. Berrange
On Mon, Apr 21, 2008 at 02:20:29PM -0400, Cole Robinson wrote: > Daniel P. Berrange wrote: > > On Mon, Apr 21, 2008 at 01:02:35PM -0400, Cole Robinson wrote: > >> The patch below adds xml support for the soundhw option to qemu > >> and xen. The new xml element takes the form: > >> > >> > >> > >> W

Re: [Libvir] [PATCH] sound support for qemu and xen

2008-04-21 Thread Cole Robinson
Daniel P. Berrange wrote: > On Mon, Apr 21, 2008 at 01:02:35PM -0400, Cole Robinson wrote: >> The patch below adds xml support for the soundhw option to qemu >> and xen. The new xml element takes the form: >> >> >> >> Where driver name can be pcspk, sb16, es1370, or all. > > I'd like to use 'mode

Re: [Libvir] [PATCH] sound support for qemu and xen

2008-04-21 Thread Daniel P. Berrange
On Mon, Apr 21, 2008 at 01:02:35PM -0400, Cole Robinson wrote: > The patch below adds xml support for the soundhw option to qemu > and xen. The new xml element takes the form: > > > > Where driver name can be pcspk, sb16, es1370, or all. I'd like to use 'model' instead of 'driver', since we use

[Libvir] [PATCH] sound support for qemu and xen

2008-04-21 Thread Cole Robinson
The patch below adds xml support for the soundhw option to qemu and xen. The new xml element takes the form: Where driver name can be pcspk, sb16, es1370, or all. Everything seems to be in working order but I have a few implementation questions: 1) Should multiple drivers be able to be specif