Re: [Libvir] [PATCH] virsh Range check in Credit Scheduler

2007-07-30 Thread Daniel Veillard
On Mon, Jul 30, 2007 at 11:52:16AM +0900, Atsushi SAKAI wrote: > Hi, Dan > > Thank you for your suggestion. > My concern is if patch for sysctl v4 is applied or not. > Since previously Daniel commented, libvirt does not include the patch for > Xen-unstable only includes for versioned like Xen-3.x

Re: [Libvir] [PATCH] virsh Range check in Credit Scheduler

2007-07-29 Thread Atsushi SAKAI
Hi, Dan Thank you for your suggestion. My concern is if patch for sysctl v4 is applied or not. Since previously Daniel commented, libvirt does not include the patch for Xen-unstable only includes for versioned like Xen-3.x. Thanks Atsushi SAKAI "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote:

Re: [Libvir] [PATCH] virsh Range check in Credit Scheduler

2007-07-27 Thread Daniel P. Berrange
On Wed, Jul 18, 2007 at 10:40:06PM +0900, Atsushi SAKAI wrote: > Hi, Daniel > > ?$B!!I checked it and it works fine! > > 2 point of question (not related to this point) > > 1)I sometimes rewiriting xen_internal.c in my test environment. > from > xen/linux/privcmd.h > to > xen/sys/privcmd.h > Is

Re: [Libvir] [PATCH] virsh Range check in Credit Scheduler

2007-07-20 Thread Daniel Veillard
On Fri, Jul 20, 2007 at 07:10:12PM +0900, Saori Fukuta wrote: > > That would be nicer, we have the information and don't pass it to the > > user. > > It may not be a big gain when used purely from virsh but for future > > automatic > > tuning tools it may be interesting to get the value reporte

Re: [Libvir] [PATCH] virsh Range check in Credit Scheduler

2007-07-20 Thread Saori Fukuta
On Fri, 20 Jul 2007 05:00:41 -0400 Daniel Veillard wrote: > On Fri, Jul 20, 2007 at 05:17:34PM +0900, Saori Fukuta wrote: > > The schedinfo command said strange message. > > # virsh schedinfo 25 --weight 0 > > libvir: Xen error : invalid argument in > > xenHypervisorSetSchedulerParameters: > > Cr

Re: [Libvir] [PATCH] virsh Range check in Credit Scheduler

2007-07-20 Thread Daniel Veillard
On Fri, Jul 20, 2007 at 05:17:34PM +0900, Saori Fukuta wrote: > The schedinfo command said strange message. > # virsh schedinfo 25 --weight 0 > libvir: Xen error : invalid argument in xenHypervisorSetSchedulerParameters: > Credit scheduler weight parameter (%d) is out of range (1-65535) >

Re: [Libvir] [PATCH] virsh Range check in Credit Scheduler

2007-07-20 Thread Saori Fukuta
On Wed, 18 Jul 2007 04:16:36 -0400 Daniel Veillard wrote: > On Wed, Jul 18, 2007 at 09:11:42AM +0900, Atsushi SAKAI wrote: > > Hi, Daniel > > > > uint16(weight and cap) is copyied in src/virsh.c > > so It cannot rewrite on src/xen_internal.c. > >xenHypervisorSetSchedulerParameters() do get t

Re: [Libvir] [PATCH] virsh Range check in Credit Scheduler

2007-07-19 Thread Daniel Veillard
On Wed, Jul 18, 2007 at 10:40:06PM +0900, Atsushi SAKAI wrote: > Hi, Daniel > > 　I checked it and it works fine! Okay, commited. W.r.t. your question of compatibility with xen-unstable, I didn't looked at it. Seems someone need to check the compatibility again once they produce a new release

Re: [PATCH] xen/?/privcmd.h (was: Re: [Libvir] [PATCH] virsh Range check in Credit Scheduler)

2007-07-18 Thread John Levon
On Wed, Jul 18, 2007 at 03:17:20PM +0100, Richard W.M. Jones wrote: > Can you test the attached patch to see if it fixes this problem for you? It's much preferred to test xen/sys/privcmd.h first. This is what is used with current Xen onwards, i.e. xen/linux/privcmd.h should only be a fallback, no

[PATCH] xen/?/privcmd.h (was: Re: [Libvir] [PATCH] virsh Range check in Credit Scheduler)

2007-07-18 Thread Richard W.M. Jones
Atsushi SAKAI wrote: 1)I sometimes rewiriting xen_internal.c in my test environment. from xen/linux/privcmd.h to xen/sys/privcmd.h Is there any possibility to change the path? Atsushi, Can you test the attached patch to see if it fixes this problem for you? Thanks, Rich. -- Emerging Techno

Re: [Libvir] [PATCH] virsh Range check in Credit Scheduler

2007-07-18 Thread Atsushi SAKAI
Hi, Daniel 　I checked it and it works fine! 2 point of question (not related to this point) 1)I sometimes rewiriting xen_internal.c in my test environment. from xen/linux/privcmd.h to xen/sys/privcmd.h Is there any possibility to change the path? 2)xen-unstable 15482 changes sysctl version(fro

Re: [Libvir] [PATCH] virsh Range check in Credit Scheduler

2007-07-18 Thread Daniel Veillard
On Wed, Jul 18, 2007 at 09:11:42AM +0900, Atsushi SAKAI wrote: > Hi, Daniel > > uint16(weight and cap) is copyied in src/virsh.c > so It cannot rewrite on src/xen_internal.c. xenHypervisorSetSchedulerParameters() do get the int values in the case XEN_SCHEDULER_CREDIT : op_dom.u.getschedinfo

Re: [Libvir] [PATCH] virsh Range check in Credit Scheduler

2007-07-17 Thread Atsushi SAKAI
Hi, Daniel uint16(weight and cap) is copyied in src/virsh.c so It cannot rewrite on src/xen_internal.c. Thanks Atsushi SAKAI Daniel Veillard <[EMAIL PROTECTED]> wrote: > On Tue, Jul 17, 2007 at 11:16:24AM +0100, Richard W.M. Jones wrote: > > Atsushi SAKAI wrote: > > >Hi, > > > > > >Add Range

Re: [Libvir] [PATCH] virsh Range check in Credit Scheduler

2007-07-17 Thread Daniel Veillard
On Tue, Jul 17, 2007 at 11:16:24AM +0100, Richard W.M. Jones wrote: > Atsushi SAKAI wrote: > >Hi, > > > >Add Range check in Credit Scheduler. Hum, it's true that this code is really specific to Xen at this point in virsh.c But I think the long term way is to add that check where it can really

Re: [Libvir] [PATCH] virsh Range check in Credit Scheduler

2007-07-17 Thread Richard W.M. Jones
Atsushi SAKAI wrote: Hi, Add Range check in Credit Scheduler. +1 Rich. -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[Libvir] [PATCH] virsh Range check in Credit Scheduler

2007-07-17 Thread Atsushi SAKAI
Hi, Add Range check in Credit Scheduler. Signed-off-by: Atsushi SAKAI <[EMAIL PROTECTED]> Thanks Atsushi SAKAI credit_range_check.patch Description: Binary data -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list