Re: [Libvir] [RFC] 1/3 Base linux container support

2008-02-21 Thread Dave Leskovec
Daniel P. Berrange wrote: On Wed, Feb 20, 2008 at 10:24:49PM -0800, Dave Leskovec wrote: This patch contains the base linux container support * new switch --with-lxc to enable support (off by default) Any reason this can't be on-by-default ? I know OpenVZ is off by default but I'd li

Re: [Libvir] [RFC] 1/3 Base linux container support

2008-02-21 Thread Daniel P. Berrange
On Thu, Feb 21, 2008 at 02:40:07PM +, Daniel P. Berrange wrote: > On Wed, Feb 20, 2008 at 10:24:49PM -0800, Dave Leskovec wrote: > > This patch contains the base linux container support > > > > * new switch --with-lxc to enable support (off by default) > > Any reason this can't be on-by-defau

Re: [Libvir] [RFC] 1/3 Base linux container support

2008-02-21 Thread Daniel P. Berrange
On Wed, Feb 20, 2008 at 10:24:49PM -0800, Dave Leskovec wrote: > This patch contains the base linux container support > > * new switch --with-lxc to enable support (off by default) Any reason this can't be on-by-default ? I know OpenVZ is off by default but I'd like to see that on by default too

Re: [Libvir] [RFC] 1/3 Base linux container support

2008-02-21 Thread Daniel Veillard
On Wed, Feb 20, 2008 at 10:24:49PM -0800, Dave Leskovec wrote: > This patch contains the base linux container support Looks fine to me, Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ [EMAIL PROTECTED]

Re: [Libvir] [RFC] 1/3 Base linux container support

2008-02-21 Thread Richard W.M. Jones
This patch all looks sensible. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 0379890

[Libvir] [RFC] 1/3 Base linux container support

2008-02-20 Thread Dave Leskovec
This patch contains the base linux container support * new switch --with-lxc to enable support (off by default) * Add new source files to Makefile.am * Add define for lxc in driver.h * Add call to lxcRegister() in libvirt.c * Add define for errors from lxc in virterror.h * Add case for errors fro