Re: [Libvir] [RFC] 2/3 Config functions for managing linux containers

2008-02-21 Thread Daniel P. Berrange
On Wed, Feb 20, 2008 at 10:25:11PM -0800, Dave Leskovec wrote: > This patch contains the new files lxc_conf.c and lxc_conf.h This looks pretty good to me - you follow all our coding conventions and use all the appropriate utility / helper functions. Only thing I ca nfind to comment on so far is:

Re: [Libvir] [RFC] 2/3 Config functions for managing linux containers

2008-02-21 Thread Richard W.M. Jones
The code looks sensible, and its self-contained so +1. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company

[Libvir] [RFC] 2/3 Config functions for managing linux containers

2008-02-20 Thread Dave Leskovec
This patch contains the new files lxc_conf.c and lxc_conf.h Index: src/lxc_conf.c === RCS file: src/lxc_conf.c diff -N src/lxc_conf.c --- /dev/null1 Jan 1970 00:00:00 - +++ src/lxc_conf.c20 Feb 2008 23:02:14 - @@ -0,0