Re: [Libvir] [RFC] 2 of 4 Linux Container support - lxc_conf files

2008-03-21 Thread Jim Meyering
Dave Leskovec <[EMAIL PROTECTED]> wrote: > This patch adds the lxc_conf source files. Looks good. Please add lxcError to the err_func_re list in Makefile.maint, so that "make syntax-check" checks all uses for translatable string mark-up. > +#define LXC_MAX_TTY_NAME 32 LXC_MAX_TTY_NAME_LENGTH wo

Re: [Libvir] [RFC] 2 of 4 Linux Container support - lxc_conf files

2008-03-20 Thread Daniel Veillard
On Wed, Mar 19, 2008 at 11:14:31PM -0700, Dave Leskovec wrote: > This patch adds the lxc_conf source files. [...] > +#define LXC_MAX_XML_LENGTH 4096 maybe up that a bit, or even better try to avoid a fixed size buffer but that can be done separately > +#define LXC_MAX_ERROR_LEN 1024 > +#define

[Libvir] [RFC] 2 of 4 Linux Container support - lxc_conf files

2008-03-19 Thread Dave Leskovec
This patch adds the lxc_conf source files. -- Best Regards, Dave Leskovec IBM Linux Technology Center Open Virtualization --- src/lxc_conf.c | 942 + src/lxc_conf.h | 142 2 files changed, 1084 insertions(+) Index: b/src/lxc_