Re: [Libvir] PATCH: 0/7 Implementation of storage APIs

2007-10-31 Thread Daniel P. Berrange
On Wed, Oct 31, 2007 at 02:16:26PM +0100, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > > - For the local directory backend, I've got the ability to choose > >between file formats on a per-volume basis. eg, /var/lib/xen/images can > >contain a mix of raw, qcow, vm

Re: [Libvir] PATCH: 0/7 Implementation of storage APIs

2007-10-31 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > Since the previous discussions didn't really end up anywhere conclusive > I decided it would be better to have a crack at getting some working code > to illustrate my ideas. Thus, the following series of 7 patches provide Hi Dan, Impressive work!

Re: [Libvir] PATCH: 0/7 Implementation of storage APIs

2007-10-29 Thread Daniel P. Berrange
On Mon, Oct 29, 2007 at 02:49:16PM +, Richard W.M. Jones wrote: > Daniel P. Berrange wrote: > >As we did with virsh attach-disk/attach-interface, vs attach-device > >I think it would be helpful to provide a 'virsh vol-create' variant > >which took a handful of explicit args as an alternative to

Re: [Libvir] PATCH: 0/7 Implementation of storage APIs

2007-10-29 Thread Daniel P. Berrange
On Mon, Oct 29, 2007 at 02:50:43PM +, Richard W.M. Jones wrote: > Daniel P. Berrange wrote: > >On Mon, Oct 29, 2007 at 01:52:04PM +, Daniel P. Berrange wrote: > >>On Mon, Oct 29, 2007 at 12:03:34PM +, Richard W.M. Jones wrote: > >>>I was envisaging a much more straightforward config fil

Re: [Libvir] PATCH: 0/7 Implementation of storage APIs

2007-10-29 Thread Richard W.M. Jones
Daniel P. Berrange wrote: On Mon, Oct 29, 2007 at 01:52:04PM +, Daniel P. Berrange wrote: On Mon, Oct 29, 2007 at 12:03:34PM +, Richard W.M. Jones wrote: I was envisaging a much more straightforward config file: /etc/libvirt.conf --- disk_storage_pools: [ "/var/lib

Re: [Libvir] PATCH: 0/7 Implementation of storage APIs

2007-10-29 Thread Richard W.M. Jones
Daniel P. Berrange wrote: As we did with virsh attach-disk/attach-interface, vs attach-device I think it would be helpful to provide a 'virsh vol-create' variant which took a handful of explicit args as an alternative to the XML, eg virsh pool-create --type fs xenimages /var/lib/xen/images Y

Re: [Libvir] PATCH: 0/7 Implementation of storage APIs

2007-10-29 Thread Daniel P. Berrange
On Mon, Oct 29, 2007 at 01:52:04PM +, Daniel P. Berrange wrote: > On Mon, Oct 29, 2007 at 12:03:34PM +, Richard W.M. Jones wrote: > > I was envisaging a much more straightforward config file: > > > > /etc/libvirt.conf --- > > > > disk_storage_pools: [ "/var/lib/xen/ima

Re: [Libvir] PATCH: 0/7 Implementation of storage APIs

2007-10-29 Thread Daniel P. Berrange
On Mon, Oct 29, 2007 at 12:03:34PM +, Richard W.M. Jones wrote: > General comments. (I haven't yet read the patches line by line, but > there are some things that I noticed that we can get back to later.) > > I patched up my libvirt with all the patches (the remote patches turned > out to b

Re: [Libvir] PATCH: 0/7 Implementation of storage APIs

2007-10-29 Thread Richard W.M. Jones
General comments. (I haven't yet read the patches line by line, but there are some things that I noticed that we can get back to later.) I patched up my libvirt with all the patches (the remote patches turned out to be necessary after all for reasons I now understand -- see below). Out of th

[Libvir] PATCH: 0/7 Implementation of storage APIs

2007-10-28 Thread Daniel P. Berrange
Since the previous discussions didn't really end up anywhere conclusive I decided it would be better to have a crack at getting some working code to illustrate my ideas. Thus, the following series of 7 patches provide an implementation of storage APIs which follow the scheme outlined in the pre