Re: [Libvir] PATCH: 12/16: logical volume backend

2008-02-19 Thread Daniel P. Berrange
On Tue, Feb 12, 2008 at 04:38:39AM +, Daniel P. Berrange wrote: > This patch implements a storage pool based on logical volume > management. The underlying implementation calls out to LVM > on Linux. A future implementation for Solaris would use the > ZFS pool support to achieve the same functi

Re: [Libvir] PATCH: 12/16: logical volume backend

2008-02-19 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: ... >> > +for (i = 0 ; i < pool->def->source.ndevice ; i++) { >> > +int fd; >> > +char zeros[512]; >> > +memset(zeros, 0, sizeof(zeros)); ... >> is it really 512 or the block size on the device used ? But 512 is >> probab

Re: [Libvir] PATCH: 12/16: logical volume backend

2008-02-19 Thread Daniel Veillard
On Tue, Feb 19, 2008 at 12:46:28PM +, Daniel P. Berrange wrote: > On Tue, Feb 19, 2008 at 03:43:11AM -0500, Daniel Veillard wrote: > > > + > > > +/* > > > + * LVM requires that the first 512 bytes are blanked if using > > > + * a whole disk as a PV. So we just blank them

Re: [Libvir] PATCH: 12/16: logical volume backend

2008-02-19 Thread Daniel P. Berrange
On Tue, Feb 19, 2008 at 03:43:11AM -0500, Daniel Veillard wrote: > > diff -r 31abfd8687b3 qemud/qemud.c > > --- a/qemud/qemud.c Thu Feb 07 13:44:25 2008 -0500 > > +++ b/qemud/qemud.c Thu Feb 07 14:17:16 2008 -0500 > > @@ -2089,7 +2089,9 @@ int main(int argc, char **argv) { > > > > if (pipe(s

Re: [Libvir] PATCH: 12/16: logical volume backend

2008-02-19 Thread Daniel Veillard
On Tue, Feb 12, 2008 at 04:38:39AM +, Daniel P. Berrange wrote: > This patch implements a storage pool based on logical volume > management. The underlying implementation calls out to LVM > on Linux. A future implementation for Solaris would use the > ZFS pool support to achieve the same functi

Re: [Libvir] PATCH: 12/16: logical volume backend

2008-02-11 Thread Daniel P. Berrange
This patch implements a storage pool based on logical volume management. The underlying implementation calls out to LVM on Linux. A future implementation for Solaris would use the ZFS pool support to achieve the same functionality. The LVM impl uses the LVM command line tools, in particular lvs, an