Re: [Libvir] PATCH: 13/16: iSCSI backend

2008-02-19 Thread Daniel P. Berrange
On Tue, Feb 12, 2008 at 04:39:25AM +, Daniel P. Berrange wrote: > This provides a storage pool using the iSCSI protocol. Since there > is no API for iSCSI it is implemented by simply shelling out to the > iscsiadm command line tool. A pool corresponds to a single target > on the iSCSI server. S

Re: [Libvir] PATCH: 13/16: iSCSI backend

2008-02-19 Thread Daniel P. Berrange
On Tue, Feb 19, 2008 at 08:45:03AM +, Mark McLoughlin wrote: > > On Tue, 2008-02-19 at 03:24 -0500, Daniel Veillard wrote: > > > +# For ISCSI driver > > > +Requires: iscsi-initiator-utils > > > > Apparently iscsi-initiator-utils exists in RHEL 4 (and 3 but > > we are not tergetting that old

Re: [Libvir] PATCH: 13/16: iSCSI backend

2008-02-19 Thread Mark McLoughlin
On Tue, 2008-02-19 at 03:24 -0500, Daniel Veillard wrote: > > +# For ISCSI driver > > +Requires: iscsi-initiator-utils > > Apparently iscsi-initiator-utils exists in RHEL 4 (and 3 but > we are not tergetting that old) it would be great if that worked > there too. I can't remember when

Re: [Libvir] PATCH: 13/16: iSCSI backend

2008-02-19 Thread Daniel Veillard
On Tue, Feb 12, 2008 at 04:39:25AM +, Daniel P. Berrange wrote: > This provides a storage pool using the iSCSI protocol. Since there > is no API for iSCSI it is implemented by simply shelling out to the > iscsiadm command line tool. A pool corresponds to a single target > on the iSCSI server. S

Re: [Libvir] PATCH: 13/16: iSCSI backend

2008-02-12 Thread Daniel P. Berrange
On Tue, Feb 12, 2008 at 08:37:02AM -0500, Chris Lalancette wrote: > > +static char *virStorageBackendISCSIPortal(virConnectPtr conn, > > + virStoragePoolObjPtr pool) > > +{ > > +char ipaddr[NI_MAXHOST]; > > +char *portal; > > + > > +if (virStorag

Re: [Libvir] PATCH: 13/16: iSCSI backend

2008-02-12 Thread Chris Lalancette
A couple of comments about this, inline. > +static int virStorageBackendISCSIConnection(virConnectPtr conn, > +virStoragePoolObjPtr pool, > +const char *portal, > +c

Re: [Libvir] PATCH: 13/16: iSCSI backend

2008-02-11 Thread Daniel P. Berrange
This provides a storage pool using the iSCSI protocol. Since there is no API for iSCSI it is implemented by simply shelling out to the iscsiadm command line tool. A pool corresponds to a single target on the iSCSI server. Starting a pool logs into the server and maps the target's LUNs into the loca