Re: [Libvir] PATCH: 14/16: disk partition backend

2008-02-19 Thread Daniel P. Berrange
On Tue, Feb 12, 2008 at 04:40:26AM +, Daniel P. Berrange wrote: > This implements a storage pool for partitioning local disks. > It uses parted as the tool for reading & writing disk partitions. > Since parted is GPLv3, we cannot link against the code directly. > So, this driver calls out to th

Re: [Libvir] PATCH: 14/16: disk partition backend

2008-02-15 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > On Fri, Feb 15, 2008 at 07:52:37PM +0100, Jim Meyering wrote: >> "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: ... >> Shouldn't size be 1 larger? i.e., >> >> unsigned long long size = >> dev->freeExtents[i].end - >>

Re: [Libvir] PATCH: 14/16: disk partition backend

2008-02-15 Thread Daniel P. Berrange
On Fri, Feb 15, 2008 at 07:52:37PM +0100, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > > +static int virStorageBackendDiskCreateVol(virConnectPtr conn, > > + virStoragePoolObjPtr pool, > > +

Re: [Libvir] PATCH: 14/16: disk partition backend

2008-02-15 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > +static int virStorageBackendDiskCreateVol(virConnectPtr conn, > + virStoragePoolObjPtr pool, > + virStorageVolDefPtr vol) > +{ > +int i; > +char start[100], e

Re: [Libvir] PATCH: 14/16: disk partition backend

2008-02-15 Thread Daniel P. Berrange
On Fri, Feb 15, 2008 at 05:11:03PM +0100, Jim Meyering wrote: > > +static const char *virStorageBackendDiskVolFormatToString(virConnectPtr > > conn, > > + int format) { > > +switch (format) { > > +case VIR_STORAGE_VOL_DISK_NONE: > >

Re: [Libvir] PATCH: 14/16: disk partition backend

2008-02-15 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: ... > diff -r 4c283aac5fd6 src/storage_backend_disk.c > --- /dev/null Thu Jan 01 00:00:00 1970 + > +++ b/src/storage_backend_disk.c Thu Feb 07 16:51:32 2008 -0500 ... > +static int virStorageBackendDiskVolFormatFromString(virConnectPtr conn,

Re: [Libvir] PATCH: 14/16: disk partition backend

2008-02-11 Thread Daniel P. Berrange
This implements a storage pool for partitioning local disks. It uses parted as the tool for reading & writing disk partitions. Since parted is GPLv3, we cannot link against the code directly. So, this driver calls out to the regular 'parted' command line tool for creationg/deletion. For listing of