Re: [Libvir] PATCH: 9/16: main internal storage driver

2008-02-19 Thread Daniel Veillard
On Tue, Feb 19, 2008 at 10:09:20AM +0100, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > > On Mon, Feb 18, 2008 at 09:51:28AM -0500, Daniel Veillard wrote: > >> On Tue, Feb 12, 2008 at 04:36:04AM +, Daniel P. Berrange wrote: > ... > >> > +if (xml) > >> > +xm

Re: [Libvir] PATCH: 9/16: main internal storage driver

2008-02-19 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > On Mon, Feb 18, 2008 at 09:51:28AM -0500, Daniel Veillard wrote: >> On Tue, Feb 12, 2008 at 04:36:04AM +, Daniel P. Berrange wrote: ... >> > +if (xml) >> > +xmlFreeDoc(xml); >> > +return NULL; >> > +} >> >> since we try to remo

Re: [Libvir] PATCH: 9/16: main internal storage driver

2008-02-18 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: ... > +int virStoragePoolObjSaveDef(virConnectPtr conn, > + virStorageDriverStatePtr driver, > + virStoragePoolObjPtr pool, > + virStoragePoolDefPtr def) { > +char

Re: [Libvir] PATCH: 9/16: main internal storage driver

2008-02-18 Thread Daniel P. Berrange
On Mon, Feb 18, 2008 at 09:51:28AM -0500, Daniel Veillard wrote: > On Tue, Feb 12, 2008 at 04:36:04AM +, Daniel P. Berrange wrote: > > This patch provides the general purpose code for the storage driver. > > The storage_driver.{c,h} file implements the libvirt internal storage > > driver API. T

Re: [Libvir] PATCH: 9/16: main internal storage driver

2008-02-18 Thread Daniel P. Berrange
On Mon, Feb 18, 2008 at 03:20:37PM +0100, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > > +static int virStorageSize(virConnectPtr conn, > > + const char *unit, > > + const char *val, > > + unsigned

Re: [Libvir] PATCH: 9/16: main internal storage driver

2008-02-18 Thread Daniel P. Berrange
On Mon, Feb 18, 2008 at 02:41:09PM +0100, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > ... > > diff -r 77cf7f42edd4 src/storage_conf.c > > --- /dev/null Thu Jan 01 00:00:00 1970 + > > +++ b/src/storage_conf.cThu Feb 07 12:59:40 2008 -0500 > ... > > +static i

Re: [Libvir] PATCH: 9/16: main internal storage driver

2008-02-18 Thread Daniel P. Berrange
On Mon, Feb 18, 2008 at 10:25:04AM +0100, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > ... > > diff -r 77cf7f42edd4 src/storage_conf.c > > --- /dev/null Thu Jan 01 00:00:00 1970 + > > +++ b/src/storage_conf.cThu Feb 07 12:59:40 2008 -0500 > ... > > +if (

Re: [Libvir] PATCH: 9/16: main internal storage driver

2008-02-18 Thread Daniel Veillard
On Tue, Feb 12, 2008 at 04:36:04AM +, Daniel P. Berrange wrote: > This patch provides the general purpose code for the storage driver. > The storage_driver.{c,h} file implements the libvirt internal storage > driver API. The storage_conf.{c,h} file takes care of parsing and > formatting the XML

Re: [Libvir] PATCH: 9/16: main internal storage driver

2008-02-18 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > +static int virStorageSize(virConnectPtr conn, > + const char *unit, > + const char *val, > + unsigned long long *ret) { > +unsigned long long mult; > +char *end; > +

Re: [Libvir] PATCH: 9/16: main internal storage driver

2008-02-18 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: ... > diff -r 77cf7f42edd4 src/storage_conf.c > --- /dev/null Thu Jan 01 00:00:00 1970 + > +++ b/src/storage_conf.c Thu Feb 07 12:59:40 2008 -0500 ... > +static int virStoragePoolDefParsePerms(virConnectPtr conn, > xmlXPathContextPtr ctxt, v

Re: [Libvir] PATCH: 9/16: main internal storage driver

2008-02-18 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: ... > diff -r 77cf7f42edd4 src/storage_conf.c > --- /dev/null Thu Jan 01 00:00:00 1970 + > +++ b/src/storage_conf.c Thu Feb 07 12:59:40 2008 -0500 ... > +if (options->flags & VIR_STORAGE_BACKEND_POOL_SOURCE_DEVICE) { > +xmlNodePtr