Re: [Libvir] PATCH 2/4: Xen driver support for serial/paralle

2008-04-28 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > On Thu, Apr 24, 2008 at 10:42:34PM +0200, Jim Meyering wrote: >> "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: ... >> It'd be nice to avoid the riskily redundant length, >> by using a STR* macro that requires a literal string S >> as argument #2,

Re: [Libvir] PATCH 2/4: Xen driver support for serial/paralle

2008-04-27 Thread Daniel P. Berrange
On Thu, Apr 24, 2008 at 10:42:34PM +0200, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > > +if (value[0] == '/') { > > +type = "dev"; > > +} else if (STREQLEN(value, "null", 4)) { > > +type = "null"; > > +value = NULL; > > +} else if (STR

Re: [Libvir] PATCH 2/4: Xen driver support for serial/paralle

2008-04-25 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > On Fri, Apr 25, 2008 at 03:11:44AM -0400, Daniel Veillard wrote: >> On Thu, Apr 24, 2008 at 10:14:49PM +0100, Daniel P. Berrange wrote: >> > On Thu, Apr 24, 2008 at 10:42:34PM +0200, Jim Meyering wrote: >> > > All of the virBufferAddLit and virBuff

Re: [Libvir] PATCH 2/4: Xen driver support for serial/paralle

2008-04-25 Thread Daniel P. Berrange
On Fri, Apr 25, 2008 at 03:11:44AM -0400, Daniel Veillard wrote: > On Thu, Apr 24, 2008 at 10:14:49PM +0100, Daniel P. Berrange wrote: > > On Thu, Apr 24, 2008 at 10:42:34PM +0200, Jim Meyering wrote: > > > All of the virBufferAddLit and virBufferVSprintf calls > > > above can fail with ENOMEM. I

Re: [Libvir] PATCH 2/4: Xen driver support for serial/paralle

2008-04-25 Thread Daniel Veillard
On Thu, Apr 24, 2008 at 10:14:49PM +0100, Daniel P. Berrange wrote: > On Thu, Apr 24, 2008 at 10:42:34PM +0200, Jim Meyering wrote: > > All of the virBufferAddLit and virBufferVSprintf calls > > above can fail with ENOMEM. I see that there are *many* more > > virBufferAddLit and virBufferVSprintf

Re: [Libvir] PATCH 2/4: Xen driver support for serial/paralle

2008-04-24 Thread Daniel P. Berrange
On Thu, Apr 24, 2008 at 10:42:34PM +0200, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > > On Fri, Apr 18, 2008 at 09:27:05PM +0100, Daniel P. Berrange wrote: > >> This patch updates Xen HVM to allow use of serial ¶llel ports, though > >> XenD limits you to single one of e

Re: [Libvir] PATCH 2/4: Xen driver support for serial/paralle

2008-04-24 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > On Fri, Apr 18, 2008 at 09:27:05PM +0100, Daniel P. Berrange wrote: >> This patch updates Xen HVM to allow use of serial ¶llel ports, though >> XenD limits you to single one of each even though QEMU supports many. >> It also updates the tag to sup

Re: [Libvir] PATCH 2/4: Xen driver support for serial/paralle

2008-04-24 Thread Daniel P. Berrange
On Fri, Apr 18, 2008 at 09:27:05PM +0100, Daniel P. Berrange wrote: > This patch updates Xen HVM to allow use of serial ¶llel ports, though > XenD limits you to single one of each even though QEMU supports many. > It also updates the tag to support new syntax extensions. This version fixes a few

Re: [Libvir] PATCH 2/4: Xen driver support for serial/paralle

2008-04-18 Thread Daniel P. Berrange
This patch updates Xen HVM to allow use of serial ¶llel ports, though XenD limits you to single one of each even though QEMU supports many. It also updates the tag to support new syntax extensions. xend_internal.c | 256 +++- xend_internal.h