Re: [Libvir] Patch: Fix documentation and code of virGetDomain function

2007-03-07 Thread Daniel P. Berrange
On Wed, Mar 07, 2007 at 04:29:16AM -0500, Daniel Veillard wrote: > On Tue, Mar 06, 2007 at 10:06:32PM +, Daniel P. Berrange wrote: > > On Thu, Mar 01, 2007 at 09:46:11AM +, Mark McLoughlin wrote: > > > On Wed, 2007-02-28 at 16:24 +, Richard W.M. Jones wrote: > > > > virGetDomain(virCon

Re: [Libvir] Patch: Fix documentation and code of virGetDomain function

2007-03-07 Thread Daniel Veillard
On Tue, Mar 06, 2007 at 10:06:32PM +, Daniel P. Berrange wrote: > On Thu, Mar 01, 2007 at 09:46:11AM +, Mark McLoughlin wrote: > > On Wed, 2007-02-28 at 16:24 +, Richard W.M. Jones wrote: > > > virGetDomain(virConnectPtr conn, const char *name, const unsigned char > > > *uuid) { > > >

Re: [Libvir] Patch: Fix documentation and code of virGetDomain function

2007-03-07 Thread Daniel Veillard
On Wed, Feb 28, 2007 at 04:24:10PM +, Richard W.M. Jones wrote: > > It turns out that you _can't_ pass name=NULL to virGetDomain, despite > what the docs say. > The goal was to allow searching by name or uuid (or both), that was the principle of the API, unfortunately UUID search was not

Re: [Libvir] Patch: Fix documentation and code of virGetDomain function

2007-03-06 Thread Daniel P. Berrange
On Thu, Mar 01, 2007 at 09:46:11AM +, Mark McLoughlin wrote: > On Wed, 2007-02-28 at 16:24 +, Richard W.M. Jones wrote: > > virGetDomain(virConnectPtr conn, const char *name, const unsigned char > > *uuid) { > > virDomainPtr ret = NULL; > > > > -if ((!VIR_IS_CONNECT(conn)) || (

Re: [Libvir] Patch: Fix documentation and code of virGetDomain function

2007-03-01 Thread Jim Meyering
Mark McLoughlin <[EMAIL PROTECTED]> wrote: > On Wed, 2007-02-28 at 16:24 +, Richard W.M. Jones wrote: >> virGetDomain(virConnectPtr conn, const char *name, const unsigned char >> *uuid) { >> virDomainPtr ret = NULL; >> >> -if ((!VIR_IS_CONNECT(conn)) || ((name == NULL) && (uuid == NU

Re: [Libvir] Patch: Fix documentation and code of virGetDomain function

2007-03-01 Thread Mark McLoughlin
On Wed, 2007-02-28 at 16:24 +, Richard W.M. Jones wrote: > virGetDomain(virConnectPtr conn, const char *name, const unsigned char > *uuid) { > virDomainPtr ret = NULL; > > -if ((!VIR_IS_CONNECT(conn)) || ((name == NULL) && (uuid == NULL)) || > +if ((!VIR_IS_CONNECT(conn)) || (n

[Libvir] Patch: Fix documentation and code of virGetDomain function

2007-02-28 Thread Richard W.M. Jones
It turns out that you _can't_ pass name=NULL to virGetDomain, despite what the docs say. Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations