Re: [PATCH] for MinGW Re: [Libvir] Pthreads error in windows compilation

2008-02-07 Thread Atsushi SAKAI
Hi, I tested and build virsh.exe successfully on MinGW. Only src/internal.h is the place which requires to add pthread.h. c.f Anyway libintl is need to write on configure.in. for MinGW Is there any option to write configure script? c.f.2 Pthread-win32 is seems general one. http://www.straightrun

Re: [PATCH] for MinGW Re: [Libvir] Pthreads error in windows compilation

2008-02-06 Thread Atsushi SAKAI
Hi, Rich I just took pthread.h from pthread-win32. http://sourceware.org/pthreads-win32/ I think it is correct way. Or any other way exists? Thanks Atsushi SAKAI "Richard W.M. Jones" <[EMAIL PROTECTED]> wrote: > Atsushi SAKAI wrote: > > Hi, > > > >  Today I recognized. > > It would be better

Re: [PATCH] for MinGW Re: [Libvir] Pthreads error in windows compilation

2008-02-06 Thread Daniel P. Berrange
On Wed, Feb 06, 2008 at 06:26:04PM +, Richard W.M. Jones wrote: > Atsushi SAKAI wrote: > >Hi, > > > >???Today I recognized. > >It would be better to write #include in hash.h than hash.c. > >And compilation works if configure.in changes in MINGW? > >Would you apply this patch? > > I think actu

Re: [PATCH] for MinGW Re: [Libvir] Pthreads error in windows compilation

2008-02-06 Thread Richard W.M. Jones
Atsushi SAKAI wrote: Hi,  Today I recognized. It would be better to write #include in hash.h than hash.c. And compilation works if configure.in changes in MINGW? Would you apply this patch? I think actually it's better to push the '#include ' all the way up into src/internal.h. It's require

[PATCH] for MinGW Re: [Libvir] Pthreads error in windows compilation

2008-02-06 Thread Atsushi SAKAI
Hi,  Today I recognized. It would be better to write #include in hash.h than hash.c. And compilation works if configure.in changes in MINGW? Would you apply this patch? Anyway virsh.exe works fine, but cannot compile testutils.c. Thanks Atsushi SAKAI "Richard W.M. Jones" <[EMAIL PROTECTED]> w

Re: [Libvir] Pthreads error in windows compilation

2008-01-29 Thread Richard W.M. Jones
Gabriel Kaufmann wrote: In order to fix this problem, I installed the ‘pthreads’ package on my MinGW. Then added include pthread.h in src/internal.h Is this the right action? Yes, I think so. This sounds like a regression. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjo

[Libvir] Pthreads error in windows compilation

2008-01-29 Thread Gabriel Kaufmann
Hi, I received the error In file included from libvirt.c:32: internal.h: At top level: internal.h:177: error: expected specifier-qualifier-list before 'pthread_mutex_t' In order to fix this problem, I installed the 'pthreads' package on my MinGW. Then added include pthread.h in src/internal.h