Re: [Libvir] brSetForwardDelay / brSetEnableSTP

2007-11-21 Thread Daniel P. Berrange
On Wed, Nov 21, 2007 at 11:34:27AM +, Richard W.M. Jones wrote: > Proposed patch. I'm going to apply this one unless anyone objects, > because it seems simple / obvious enough. Go for it. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Pe

Re: [Libvir] brSetForwardDelay / brSetEnableSTP

2007-11-21 Thread Richard W.M. Jones
Proposed patch. I'm going to apply this one unless anyone objects, because it seems simple / obvious enough. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United K

Re: [Libvir] brSetForwardDelay / brSetEnableSTP

2007-11-20 Thread Daniel P. Berrange
On Tue, Nov 20, 2007 at 03:19:42PM +, Richard W.M. Jones wrote: > This code in qemu_driver.c doesn't look right to me. I think the second > should be a call to brSetEnableSTP? > > Rich. > > if (network->def->forwardDelay && > (err = brSetForwardDelay(driver->brctl, network->brid

[Libvir] brSetForwardDelay / brSetEnableSTP

2007-11-20 Thread Richard W.M. Jones
This code in qemu_driver.c doesn't look right to me. I think the second should be a call to brSetEnableSTP? Rich. if (network->def->forwardDelay && (err = brSetForwardDelay(driver->brctl, network->bridge, network->def->forwardDelay))) { qemudReportError(conn, NULL, NULL,