Re: [PATCH] Conf: Move validation of Graphics Transport and StorageNetwork Socket out of parser

2023-04-05 Thread Michal Prívozník
On 4/4/23 20:10, skran wrote: > Thank you for the corrections. I understand it now. > [1] I have made the Graphics Transport validation function static and moved > its call out of the parser, to virDomainGraphicsDefListensValidate() in > domain_validate.h. Is this a correct implementation?, it do

[PATCH] Conf: Move validation of Graphics Transport and StorageNetwork Socket out of parser

2023-04-04 Thread skran
Thank you for the corrections. I understand it now. [1] I have made the Graphics Transport validation function static and moved its call out of the parser, to virDomainGraphicsDefListensValidate() in domain_validate.h. Is this a correct implementation?, it does pass the tests. I have removed the

Re: [PATCH] Conf: Move validation of Graphics Transport and StorageNetwork Socket out of parser

2023-04-04 Thread skran
Thank you for the corrections. I understand it now. [1] I have made the Graphics Transport validation function static and moved its call out of the parser, to virDomainGraphicsDefListensValidate() in domain_validate.h. Is this a correct implementation?, it does pass the tests. I have removed the

Re: [PATCH] Conf: Move validation of Graphics Transport and StorageNetwork Socket out of parser

2023-04-04 Thread Michal Prívozník
On 4/3/23 19:08, skran wrote: > I have implemented your corrections successfully. Thank you. This is not a commit message that describes what the patch does. If you look at git log you'll see plenty of good examples. The idea is that anybody reading through git log would understand what the commit

[PATCH] Conf: Move validation of Graphics Transport and StorageNetwork Socket out of parser

2023-04-03 Thread skran
I have implemented your corrections successfully. Thank you. Signed-off-by: K Shiva --- src/conf/domain_conf.c | 42 +++- src/conf/domain_validate.c | 56 ++ src/conf/domain_validate.h | 7 + 3 files changed, 67 insertions(+), 3