Re: [PATCH] Modify virCPUarmCompare to perform compare actions

2020-09-18 Thread Zhenyu Zheng
Thanks, I've updated the codes, please have a look :), the topic of the mail is [PATCH V3] Modify virCPUarmCompare to perform compare actions BR, Zhenyu On Fri, Sep 18, 2020 at 8:01 PM Jiri Denemark wrote: > On Mon, Sep 07, 2020 at 20:15:59 +0800, Zhenyu Zheng wrote: > > So the suitable way of

Re: [PATCH] Modify virCPUarmCompare to perform compare actions

2020-09-18 Thread Jiri Denemark
On Mon, Sep 07, 2020 at 20:15:59 +0800, Zhenyu Zheng wrote: > So the suitable way of doing this will be checking for `VIR_CPU_TYPE_HOST` > and perform a comparison in this case and still return IDENTICAL for all > other cases right? Yes. > Then the upper layer caller(like OpenStack Nova) will hav

Re: [PATCH] Modify virCPUarmCompare to perform compare actions

2020-09-07 Thread Zhenyu Zheng
So the suitable way of doing this will be checking for `VIR_CPU_TYPE_HOST` and perform a comparison in this case and still return IDENTICAL for all other cases right? Then the upper layer caller(like OpenStack Nova) will have to pass source host cpu info as a parameter. BR, Zhenyu On Mon, Sep 7

Re: [PATCH] Modify virCPUarmCompare to perform compare actions

2020-09-07 Thread Jiri Denemark
On Mon, Sep 07, 2020 at 09:21:02 +0800, Zhenyu Zheng wrote: > Thanks alot for the reply, > > This sounds like a valid use case (not sure it is that useful), but we > > need to be careful. But we should make sure implementing this does not > > break anything. This means, we need to do different thi

Re: [PATCH] Modify virCPUarmCompare to perform compare actions

2020-09-06 Thread Zhenyu Zheng
Thanks alot for the reply, This sounds like a valid use case (not sure it is that useful), but we > need to be careful. But we should make sure implementing this does not > break anything. This means, we need to do different things depending on > the type of the CPU definition we are asked to comp

Re: [PATCH] Modify virCPUarmCompare to perform compare actions

2020-09-04 Thread Jiri Denemark
On Thu, Sep 03, 2020 at 19:50:13 +0800, Zhenyu Zheng wrote: > Hi, > > Thanks alot for the review and feedback. As for host-passthrough cases, I > have some other understandings, > if I understand correctly, what you mean is that if a vm uses > host-passthrough, it can migrate to any other > host,

Re: [PATCH] Modify virCPUarmCompare to perform compare actions

2020-09-03 Thread Zhenyu Zheng
Hi, Thanks alot for the review and feedback. As for host-passthrough cases, I have some other understandings, if I understand correctly, what you mean is that if a vm uses host-passthrough, it can migrate to any other host, since it asks for host-passthrough. In my point of view, I think in real c

Re: [PATCH] Modify virCPUarmCompare to perform compare actions

2020-09-01 Thread Jiri Denemark
On Fri, Aug 21, 2020 at 10:20:15 +0800, Zhenyu Zheng wrote: > Modify virCPUarmCompare in cpu_arm.c to perform > actual compare actions. Compare host cpu vendor > and model info with guest cpu as initial implementation, > as most ARM clouds uses host-passthrogh mode. In addition to the low-level co

Re: [PATCH] Modify virCPUarmCompare to perform compare actions

2020-08-31 Thread Daniel Henrique Barboza
On 8/20/20 11:20 PM, Zhenyu Zheng wrote: Modify virCPUarmCompare in cpu_arm.c to perform actual compare actions. Compare host cpu vendor and model info with guest cpu as initial implementation, as most ARM clouds uses host-passthrogh mode. Typo: host-passthrogh -> host-passthrough Signed-

[PATCH] Modify virCPUarmCompare to perform compare actions

2020-08-20 Thread Zhenyu Zheng
Modify virCPUarmCompare in cpu_arm.c to perform actual compare actions. Compare host cpu vendor and model info with guest cpu as initial implementation, as most ARM clouds uses host-passthrogh mode. Signed-off-by: Zhenyu Zheng --- src/cpu/cpu_arm.c | 188 +